Skip to contentSkip to conversation

ethdev: add security flow item

PATCH In review Tejasree Kondoj 5 participants 15 messages Sep 10, 2020 – Apr 20, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ethdev: add security flow item

Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to distinguish plain packets from IPsec decrypted plain packets.

---
 doc/guides/prog_guide/rte_flow.rst | 25 +++++++++++++++++++++++++
 lib/librte_ethdev/rte_flow.h       |  9 +++++++++
 2 files changed, 34 insertions(+)
doc/guides/prog_guide/rte_flow.rst +25 -0
index 3e5cd1e0d..a51a3e5d6 100644
@@ -712,6 +712,31 @@ action sets metadata for a packet and the metadata will be reported via
    | ``mask`` | ``data`` | bit-mask applies to "spec" and "last" |
    +----------+----------+---------------------------------------+
 
+Item: ``SECURITY``
+^^^^^^^^^^^^^^^^^^
+
+Matches packets that were security processed. It can be used to identify
+packets after inline security processing. For example, in case of inline IPsec,
+the packet headers would change after IPsec decapsulation and this item would
+allow application to differentiate non-IPsec packets from packets after
+inline IPsec processing.
+
+- ``spec``, ``last`` and ``mask`` are ignored.
+
+.. _table_rte_flow_item_security:
+
+.. table:: SECURITY
+
+   +----------+---------+
+   | Field    | Value   |
+   +==========+=========+
+   | ``spec`` | ignored |
+   +----------+---------+
+   | ``last`` | ignored |
+   +----------+---------+
+   | ``mask`` | ignored |
+   +----------+---------+
+
 Data matching item types
 ~~~~~~~~~~~~~~~~~~~~~~~~
 
lib/librte_ethdev/rte_flow.h +9 -0
index da8bfa548..65499b758 100644
@@ -537,6 +537,15 @@ enum rte_flow_item_type {
 	 */
 	RTE_FLOW_ITEM_TYPE_ECPRI,
 
+	/**
+	 * [META]
+	 *
+	 * Matches security processed packets.
+	 *
+	 * No associated specification structure.
+	 */
+	RTE_FLOW_ITEM_TYPE_SECURITY,
+
 };
 
 /**
Signature · 1 line
2.27.0
#1 lore raw
Quoted 4 lines · On Thu, 10 Sep 2020 22:14:41 +0530 Tejasree Kondoj <[email protected]>…

Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to distinguish plain packets from IPsec decrypted plain packets.

Please provide an implementation, API's without any driver support should not be accepted.

Also, we need a test for this.

#2 lore raw
Quoted 19 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen Hemminger
Sent: Thursday, September 10, 2020 7:46 PM
To: Tejasree Kondoj <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob <[email protected]>; Narayana Prasad <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 3 lines · On Thu, 10 Sep 2020 22:14:41 +0530 Tejasree Kondoj <[email protected]>…

Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to distinguish plain packets from IPsec decrypted plain packets.

Quoted 6 lines
Quoted 1 line

Please provide an implementation, API's without any driver support should not be accepted.

Also, we need a test for this.

+1
Also, I think the word SECURITY is too high-level, and if specifically you mention here an item for IPSec, perhaps you can consider renaming.

#3 lore raw

Please see inline.

Thanks
Tejasree

Quoted 31 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Thursday, September 17, 2020 3:09 PM
To: Stephen Hemminger <[email protected]>; Tejasree Kondoj <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

----------------------------------------------------------------------

Quoted 13 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen Hemminger
Sent: Thursday, September 10, 2020 7:46 PM
To: Tejasree Kondoj <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob <[email protected]>; Narayana Prasad <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 13 lines
Quoted 4 lines
Quoted 1 line · On Thu, 10 Sep 2020 22:14:41 +0530 Tejasree Kondoj <[email protected]>…

Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to

distinguish

Quoted 8 lines
Quoted 3 lines

plain packets from IPsec decrypted plain packets.

Please provide an implementation, API's without any driver support should not be accepted.

Also, we need a test for this.

[Tejasree] We would like to defer the patch and add implementation, test case in next cycle.

Quoted 4 lines

+1
Also, I think the word SECURITY is too high-level, and if specifically you mention here an item for IPSec, perhaps you can consider renaming.

[Tejasree] This item matches security processed packets and not specific to IPsec. Will change commit description as follows:
" Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to
match packets that were security processed. For example, in case of inline IPsec, it can be used to distinguish plain packets from IPsec decrypted plain packets"
Would that be fine?

#4 lore raw

Regards,
Asaf Penso

Quoted 74 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Monday, September 21, 2020 11:59 AM
To: Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 4 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Thursday, September 17, 2020 3:09 PM
To: Stephen Hemminger <[email protected]>; Tejasree

Kondoj

Quoted 27 lines

<[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

----------------------------------------------------------------------

Quoted 13 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen Hemminger
Sent: Thursday, September 10, 2020 7:46 PM
To: Tejasree Kondoj <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob <[email protected]>; Narayana Prasad <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 13 lines
Quoted 4 lines
Quoted 1 line · On Thu, 10 Sep 2020 22:14:41 +0530 Tejasree Kondoj <[email protected]>…

Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to

distinguish

Quoted 8 lines
Quoted 3 lines

plain packets from IPsec decrypted plain packets.

Please provide an implementation, API's without any driver support should not be accepted.

Also, we need a test for this.

[Tejasree] We would like to defer the patch and add implementation, test case in next cycle.

Quoted 4 lines

+1
Also, I think the word SECURITY is too high-level, and if specifically you mention here an item for IPSec, perhaps you can consider renaming.

Quoted 7 lines

[Tejasree] This item matches security processed packets and not specific to IPsec.
Will change commit description as follows:
" Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to match packets that were security processed. For example, in case of inline IPsec, it can be used to distinguish plain packets from IPsec decrypted plain packets" Would that be fine?

It would be more clear, yes, thank you, but in this case I suggest to have a field in the spec that you can match on it.
For example, is it viable to know if the packet was processed by IPSec and not AES? Maybe you want to have 2 flow with this new item, but still differentiate between the types.

#5 lore raw

Hi

Quoted 92 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Monday, September 21, 2020 7:09 PM
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Regards,
Asaf Penso

Quoted 74 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Monday, September 21, 2020 11:59 AM
To: Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 4 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Thursday, September 17, 2020 3:09 PM
To: Stephen Hemminger <[email protected]>; Tejasree

Kondoj

Quoted 27 lines

<[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

----------------------------------------------------------------------

Quoted 13 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen Hemminger
Sent: Thursday, September 10, 2020 7:46 PM
To: Tejasree Kondoj <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob <[email protected]>; Narayana Prasad <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 13 lines
Quoted 4 lines
Quoted 1 line · On Thu, 10 Sep 2020 22:14:41 +0530 Tejasree Kondoj <[email protected]>…

Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to

distinguish

Quoted 8 lines
Quoted 3 lines

plain packets from IPsec decrypted plain packets.

Please provide an implementation, API's without any driver support should not be accepted.

Also, we need a test for this.

[Tejasree] We would like to defer the patch and add implementation, test case in next cycle.

Quoted 4 lines

+1
Also, I think the word SECURITY is too high-level, and if specifically you mention here an item for IPSec, perhaps you can consider renaming.

Quoted 7 lines

[Tejasree] This item matches security processed packets and not specific to IPsec.
Will change commit description as follows:
" Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to match packets that were security processed. For example, in case of inline IPsec, it can be used to distinguish plain packets from IPsec decrypted plain packets" Would that be fine?

Quoted 5 lines

It would be more clear, yes, thank you, but in this case I suggest to have a field in the spec that you can match on it.
For example, is it viable to know if the packet was processed by IPSec and not AES? Maybe you want to have 2 flow with this new item, but still differentiate between the types.

Why not use mark/tag/meta to set this value?
The application will insert a flow that sends to security and mark the flow with some ID then the application can check this ID.

Best,
Ori

#6 lore raw

Please see inline.

Thanks
Tejasree

Quoted 125 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Tuesday, September 22, 2020 1:22 PM
To: Asaf Penso <[email protected]>; Tejasree Kondoj <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

----------------------------------------------------------------------
Hi

Quoted 7 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Monday, September 21, 2020 7:09 PM
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 47 lines

Regards,
Asaf Penso

Quoted 44 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Monday, September 21, 2020 11:59 AM
To: Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 4 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Thursday, September 17, 2020 3:09 PM
To: Stephen Hemminger <[email protected]>; Tejasree

Kondoj

Quoted 19 lines

<[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

-------------------------------------------------------------------
---

Quoted 2 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen

Hemminger

Quoted 26 lines
Quoted 26 lines
Quoted 25 lines
Quoted 12 lines

Sent: Thursday, September 10, 2020 7:46 PM
To: Tejasree Kondoj <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob <[email protected]>; Narayana Prasad <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 4 lines
Quoted 1 line · On Thu, 10 Sep 2020 22:14:41 +0530 Tejasree Kondoj <[email protected]>…

Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to

distinguish

Quoted 8 lines
Quoted 3 lines

plain packets from IPsec decrypted plain packets.

Please provide an implementation, API's without any driver support should not be accepted.

Also, we need a test for this.

Quoted 7 lines
Quoted 7 lines

[Tejasree] We would like to defer the patch and add implementation, test case in next cycle.

Quoted 4 lines

+1
Also, I think the word SECURITY is too high-level, and if specifically you mention here an item for IPSec, perhaps you can

consider renaming.

Quoted 7 lines
Quoted 7 lines

[Tejasree] This item matches security processed packets and not specific to IPsec.
Will change commit description as follows:
" Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to match packets that were security processed. For example, in case of inline IPsec, it can be used to distinguish plain packets from IPsec decrypted

plain packets"

Quoted 7 lines
Quoted 1 line

Would that be fine?

It would be more clear, yes, thank you, but in this case I suggest to have a field in the spec that you can match on it.
For example, is it viable to know if the packet was processed by IPSec and not AES? Maybe you want to have 2 flow with this new item, but still differentiate between the types.

Quoted 3 lines

Why not use mark/tag/meta to set this value?
The application will insert a flow that sends to security and mark the flow with some ID then the application can check this ID.

[Tejasree] SECURITY itself wouldn't make distinction on protocol. It would be combined with MARK_ID to know if the packet was processed by IPsec and not AES.

MARK_ID alone couldn't be used as we wouldn't know if it is plain packet or security processed plain packet.

Rules would be as follows:
Rule #1
[ETH] [IP] [ESP] [SPI] → [SECURITY] [MARK_ID] [END] Rule #2
[SECURITY] [MARK_ID] [ETH] [IP] → [QUEUE] [END]

Quoted 3 lines

Best,
Ori

#7 lore raw

Hi Tejasree,
PSB

Quoted 142 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 125 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Tuesday, September 22, 2020 1:22 PM
To: Asaf Penso <[email protected]>; Tejasree Kondoj <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

----------------------------------------------------------------------
Hi

Quoted 7 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Monday, September 21, 2020 7:09 PM
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 47 lines

Regards,
Asaf Penso

Quoted 44 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Monday, September 21, 2020 11:59 AM
To: Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 4 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Thursday, September 17, 2020 3:09 PM
To: Stephen Hemminger <[email protected]>; Tejasree

Kondoj

Quoted 19 lines

<[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

-------------------------------------------------------------------
---

Quoted 2 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen

Hemminger

Quoted 26 lines
Quoted 26 lines
Quoted 25 lines
Quoted 12 lines

Sent: Thursday, September 10, 2020 7:46 PM
To: Tejasree Kondoj <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob <[email protected]>; Narayana Prasad <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 4 lines
Quoted 1 line · On Thu, 10 Sep 2020 22:14:41 +0530 Tejasree Kondoj <[email protected]>…

Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to

distinguish

Quoted 8 lines
Quoted 3 lines

plain packets from IPsec decrypted plain packets.

Please provide an implementation, API's without any driver support should not be accepted.

Also, we need a test for this.

Quoted 7 lines
Quoted 7 lines

[Tejasree] We would like to defer the patch and add implementation, test case in next cycle.

Quoted 4 lines

+1
Also, I think the word SECURITY is too high-level, and if specifically you mention here an item for IPSec, perhaps you can

consider renaming.

Quoted 7 lines
Quoted 7 lines

[Tejasree] This item matches security processed packets and not specific to IPsec.
Will change commit description as follows:
" Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to match packets that were security processed. For example, in case of inline IPsec, it can be used to distinguish plain packets from IPsec decrypted

plain packets"

Quoted 7 lines
Quoted 1 line

Would that be fine?

It would be more clear, yes, thank you, but in this case I suggest to have a field in the spec that you can match on it.
For example, is it viable to know if the packet was processed by IPSec and not AES? Maybe you want to have 2 flow with this new item, but still differentiate between the types.

Quoted 3 lines

Why not use mark/tag/meta to set this value?
The application will insert a flow that sends to security and mark the flow with some ID then the application can check this ID.

[Tejasree] SECURITY itself wouldn't make distinction on protocol. It would be combined with MARK_ID to know if the packet was processed by IPsec and not AES.

Quoted 9 lines

MARK_ID alone couldn't be used as we wouldn't know if it is plain packet or security processed plain packet.

Rules would be as follows:
Rule #1
[ETH] [IP] [ESP] [SPI] → [SECURITY] [MARK_ID] [END] Rule #2
[SECURITY] [MARK_ID] [ETH] [IP] → [QUEUE] [END]

I don't understand why in rule #1 you can't have the mark value to also mark the security.
From your patch I understand that security is just one bit This means that you can say if MSB bit in mark is set then it comes from security.

Ori,

Quoted 3 lines
Quoted 3 lines

Best,
Ori

#8 lore raw
In reply to Tejasree Kondoj

Hi Ori,

Please see inline.

Thanks,
Tejasree

Quoted 165 lines

-----Original Message-----
From: Tejasree Kondoj
Sent: Tuesday, September 22, 2020 2:37 PM
To: Ori Kam <[email protected]>; Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 69 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Tuesday, September 22, 2020 1:22 PM
To: Asaf Penso <[email protected]>; Tejasree Kondoj <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

----------------------------------------------------------------------
Hi

Quoted 49 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Monday, September 21, 2020 7:09 PM
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Regards,
Asaf Penso

Quoted 39 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Monday, September 21, 2020 11:59 AM
To: Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 4 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Thursday, September 17, 2020 3:09 PM
To: Stephen Hemminger <[email protected]>; Tejasree

Kondoj

Quoted 13 lines

<[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 14 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

External Email

-----------------------------------------------------------------
--
---

Quoted 2 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen

Hemminger

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Sent: Thursday, September 10, 2020 7:46 PM
To: Tejasree Kondoj <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh

Yigit

Quoted 45 lines
Quoted 20 lines
Quoted 20 lines
Quoted 19 lines
Quoted 10 lines

<[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob <[email protected]>; Narayana Prasad <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 1 line · On Thu, 10 Sep 2020 22:14:41 +0530 Tejasree Kondoj <[email protected]>…

Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to

distinguish

Quoted 8 lines
Quoted 3 lines

plain packets from IPsec decrypted plain packets.

Please provide an implementation, API's without any driver support should not be accepted.

Also, we need a test for this.

Quoted 7 lines
Quoted 7 lines

[Tejasree] We would like to defer the patch and add implementation, test case in next cycle.

Quoted 4 lines

+1
Also, I think the word SECURITY is too high-level, and if specifically you mention here an item for IPSec, perhaps you can

consider renaming.

Quoted 8 lines
Quoted 8 lines

[Tejasree] This item matches security processed packets and not specific to IPsec.
Will change commit description as follows:
" Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to match packets that were security processed. For example, in case of inline IPsec, it can be used to distinguish plain packets from IPsec decrypted

plain packets"

Quoted 7 lines
Quoted 1 line

Would that be fine?

It would be more clear, yes, thank you, but in this case I suggest to have a field in the spec that you can match on it.
For example, is it viable to know if the packet was processed by IPSec and not AES? Maybe you want to have 2 flow with this new item, but still differentiate between the types.

Quoted 3 lines

Why not use mark/tag/meta to set this value?
The application will insert a flow that sends to security and mark the flow with some ID then the application can check this ID.

[Tejasree] SECURITY itself wouldn't make distinction on protocol. It would be combined with MARK_ID to know if the packet was processed by IPsec and not AES.

MARK_ID alone couldn't be used as we wouldn't know if it is plain packet or security processed plain packet.

Rules would be as follows:
Rule #1
[ETH] [IP] [ESP] [SPI] → [SECURITY] [MARK_ID] [END] Rule #2 [SECURITY] [MARK_ID] [ETH] [IP] → [QUEUE] [END]

Quoted 5 lines

I don't understand why in rule #1 you can't have the mark value to also mark the security.
From your patch I understand that security is just one bit This means that you can say if MSB bit in mark is set then it comes from security.

[Tejasree] We can use MSB of MARK_ID but that would mean we would be reserving it for security.

Quoted 3 lines
Quoted 3 lines

Best,
Ori

#9 lore raw

Hi

Quoted 177 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Tuesday, September 22, 2020 5:18 PM
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Hi Ori,

Please see inline.

Thanks,
Tejasree

Quoted 165 lines

-----Original Message-----
From: Tejasree Kondoj
Sent: Tuesday, September 22, 2020 2:37 PM
To: Ori Kam <[email protected]>; Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 69 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Tuesday, September 22, 2020 1:22 PM
To: Asaf Penso <[email protected]>; Tejasree Kondoj <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

----------------------------------------------------------------------
Hi

Quoted 49 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Monday, September 21, 2020 7:09 PM
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Regards,
Asaf Penso

Quoted 39 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Monday, September 21, 2020 11:59 AM
To: Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 4 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Thursday, September 17, 2020 3:09 PM
To: Stephen Hemminger <[email protected]>; Tejasree

Kondoj

Quoted 13 lines

<[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 14 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

External Email

-----------------------------------------------------------------
--
---

Quoted 2 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen

Hemminger

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Sent: Thursday, September 10, 2020 7:46 PM
To: Tejasree Kondoj <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh

Yigit

Quoted 45 lines
Quoted 20 lines
Quoted 20 lines
Quoted 19 lines
Quoted 10 lines

<[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob <[email protected]>; Narayana Prasad <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 1 line · On Thu, 10 Sep 2020 22:14:41 +0530 Tejasree Kondoj <[email protected]>…

Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to

distinguish

Quoted 8 lines
Quoted 3 lines

plain packets from IPsec decrypted plain packets.

Please provide an implementation, API's without any driver support should not be accepted.

Also, we need a test for this.

Quoted 7 lines
Quoted 7 lines

[Tejasree] We would like to defer the patch and add implementation, test case in next cycle.

Quoted 4 lines

+1
Also, I think the word SECURITY is too high-level, and if specifically you mention here an item for IPSec, perhaps you can

consider renaming.

Quoted 8 lines
Quoted 8 lines

[Tejasree] This item matches security processed packets and not specific to IPsec.
Will change commit description as follows:
" Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to match packets that were security processed. For example, in case of inline IPsec, it can be used to distinguish plain packets from IPsec decrypted

plain packets"

Quoted 7 lines
Quoted 1 line

Would that be fine?

It would be more clear, yes, thank you, but in this case I suggest to have a field in the spec that you can match on it.
For example, is it viable to know if the packet was processed by IPSec and not AES? Maybe you want to have 2 flow with this new item, but still differentiate between the types.

Quoted 3 lines

Why not use mark/tag/meta to set this value?
The application will insert a flow that sends to security and mark the flow with some ID then the application can check this ID.

[Tejasree] SECURITY itself wouldn't make distinction on protocol. It would be combined with MARK_ID to know if the packet was processed by IPsec and not AES.

MARK_ID alone couldn't be used as we wouldn't know if it is plain packet or security processed plain packet.

Rules would be as follows:
Rule #1
[ETH] [IP] [ESP] [SPI] → [SECURITY] [MARK_ID] [END] Rule #2 [SECURITY] [MARK_ID] [ETH] [IP] → [QUEUE] [END]

Quoted 9 lines
Quoted 5 lines

I don't understand why in rule #1 you can't have the mark value to also mark the security.
From your patch I understand that security is just one bit This means that you can say if MSB bit in mark is set then it comes from security.

[Tejasree] We can use MSB of MARK_ID but that would mean we would be reserving it for security.

[Ori] but why does the PMD needs it? the application know what it needs so it can use it, It is the application decision to send to the security right? So it knows what values to set.

Also the application can use tag or any other data item.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Best,
Ori

#10 lore raw

Thanks,
Tejasree

Quoted 212 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Wednesday, September 23, 2020 8:00 PM
To: Tejasree Kondoj <[email protected]>; Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

----------------------------------------------------------------------
Hi

Quoted 5 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Tuesday, September 22, 2020 5:18 PM
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 68 lines

Hi Ori,

Please see inline.

Thanks,
Tejasree

Quoted 61 lines

-----Original Message-----
From: Tejasree Kondoj
Sent: Tuesday, September 22, 2020 2:37 PM
To: Ori Kam <[email protected]>; Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 41 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Tuesday, September 22, 2020 1:22 PM
To: Asaf Penso <[email protected]>; Tejasree Kondoj <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

------------------------------------------------------------------
----
Hi

Quoted 19 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Monday, September 21, 2020 7:09 PM
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Regards,
Asaf Penso

Quoted 9 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Monday, September 21, 2020 11:59 AM
To: Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh

Yigit

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

<[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Thanks
Tejasree

Quoted 4 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Thursday, September 17, 2020 3:09 PM
To: Stephen Hemminger <[email protected]>;

Tejasree

Quoted 29 lines
Quoted 29 lines
Quoted 29 lines
Quoted 14 lines
Quoted 14 lines

Kondoj

Quoted 13 lines

<[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

External Email

-------------------------------------------------------------
----
--
---

Quoted 2 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen

Hemminger

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Sent: Thursday, September 10, 2020 7:46 PM
To: Tejasree Kondoj <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh

Quoted 5 lines
Quoted 5 lines

Yigit

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

<[email protected]>; Andrew Rybchenko
<[email protected]>; Jerin Jacob
<[email protected]>; Narayana Prasad
<[email protected]>; Anoob Joseph

<[email protected]>;

Quoted 66 lines
Quoted 65 lines
Quoted 44 lines
Quoted 18 lines
Quoted 18 lines
Quoted 17 lines
Quoted 8 lines

[email protected]
Subject: Re: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 1 line · On Thu, 10 Sep 2020 22:14:41 +0530 Tejasree Kondoj <[email protected]>…

Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to

distinguish

Quoted 8 lines
Quoted 3 lines

plain packets from IPsec decrypted plain packets.

Please provide an implementation, API's without any driver support should not be accepted.

Also, we need a test for this.

Quoted 8 lines
Quoted 8 lines

[Tejasree] We would like to defer the patch and add implementation, test case in next cycle.

Quoted 5 lines

+1
Also, I think the word SECURITY is too high-level, and if specifically you mention here an item for IPSec, perhaps you can

consider renaming.

Quoted 8 lines
Quoted 8 lines

[Tejasree] This item matches security processed packets and not specific to IPsec.
Will change commit description as follows:
" Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to match packets that were security processed. For example, in case of inline IPsec, it can be used to distinguish plain packets from IPsec decrypted

plain packets"

Quoted 7 lines
Quoted 1 line

Would that be fine?

It would be more clear, yes, thank you, but in this case I suggest to have a field in the spec that you can match on it. For example, is it viable to know if the packet was processed by IPSec and not AES? Maybe you want to have 2 flow with this new item, but still differentiate between the types.

Quoted 3 lines

Why not use mark/tag/meta to set this value?
The application will insert a flow that sends to security and mark the flow with some ID then the application can check this ID.

[Tejasree] SECURITY itself wouldn't make distinction on protocol. It would be combined with MARK_ID to know if the packet was processed by IPsec and not AES.

MARK_ID alone couldn't be used as we wouldn't know if it is plain packet or security processed plain packet.

Rules would be as follows:
Rule #1
[ETH] [IP] [ESP] [SPI] → [SECURITY] [MARK_ID] [END] Rule #2 [SECURITY] [MARK_ID] [ETH] [IP] → [QUEUE] [END]

I don't understand why in rule #1 you can't have the mark value to also mark the security.
From your patch I understand that security is just one bit This means that you can say if MSB bit in mark is set then it comes from security.

Quoted 9 lines
Quoted 3 lines

[Tejasree] We can use MSB of MARK_ID but that would mean we would be reserving it for security.

[Ori] but why does the PMD needs it? the application know what it needs so it can use it, It is the application decision to send to the security right? So it knows what values to set.

Also the application can use tag or any other data item.

[Tejasree] PMD needs it to establish connection between security and final action to be done (queue for example).

First rule works on the outer packet where the inner packet would be hidden by the protocol (like encrypted payload in IPsec) and the second rule will act on the de-capsulated packet. So the packets itself are different and we cannot have one rule.

In IPsec it is valid (and a very trivial usage) to have one outer flow constitute multiple inner flows. Without this, application will not be able to configure hardware to treat inner flows differently.

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Best,
Ori

#11 lore raw

Thanks,
Ori

Quoted 231 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Thursday, September 24, 2020 8:31 AM

Thanks,
Tejasree

Quoted 212 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Wednesday, September 23, 2020 8:00 PM
To: Tejasree Kondoj <[email protected]>; Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

----------------------------------------------------------------------
Hi

Quoted 5 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Tuesday, September 22, 2020 5:18 PM
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 68 lines

Hi Ori,

Please see inline.

Thanks,
Tejasree

Quoted 61 lines

-----Original Message-----
From: Tejasree Kondoj
Sent: Tuesday, September 22, 2020 2:37 PM
To: Ori Kam <[email protected]>; Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 41 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Tuesday, September 22, 2020 1:22 PM
To: Asaf Penso <[email protected]>; Tejasree Kondoj <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

------------------------------------------------------------------
----
Hi

Quoted 19 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Monday, September 21, 2020 7:09 PM
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Regards,
Asaf Penso

Quoted 9 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Monday, September 21, 2020 11:59 AM
To: Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh

Yigit

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

<[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Thanks
Tejasree

Quoted 4 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Thursday, September 17, 2020 3:09 PM
To: Stephen Hemminger <[email protected]>;

Tejasree

Quoted 29 lines
Quoted 29 lines
Quoted 29 lines
Quoted 14 lines
Quoted 14 lines

Kondoj

Quoted 13 lines

<[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

External Email

-------------------------------------------------------------
----
--
---

Quoted 2 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen

Hemminger

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Sent: Thursday, September 10, 2020 7:46 PM
To: Tejasree Kondoj <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh

Quoted 5 lines
Quoted 5 lines

Yigit

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

<[email protected]>; Andrew Rybchenko
<[email protected]>; Jerin Jacob
<[email protected]>; Narayana Prasad
<[email protected]>; Anoob Joseph

<[email protected]>;

Quoted 66 lines
Quoted 65 lines
Quoted 44 lines
Quoted 18 lines
Quoted 18 lines
Quoted 17 lines
Quoted 8 lines

[email protected]
Subject: Re: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 1 line · On Thu, 10 Sep 2020 22:14:41 +0530 Tejasree Kondoj <[email protected]>…

Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to

distinguish

Quoted 8 lines
Quoted 3 lines

plain packets from IPsec decrypted plain packets.

Please provide an implementation, API's without any driver support should not be accepted.

Also, we need a test for this.

Quoted 8 lines
Quoted 8 lines

[Tejasree] We would like to defer the patch and add implementation, test case in next cycle.

Quoted 5 lines

+1
Also, I think the word SECURITY is too high-level, and if specifically you mention here an item for IPSec, perhaps you can

consider renaming.

Quoted 8 lines
Quoted 8 lines

[Tejasree] This item matches security processed packets and not specific to IPsec.
Will change commit description as follows:
" Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to match packets that were security processed. For example, in case of inline IPsec, it can be used to distinguish plain packets from IPsec decrypted

plain packets"

Quoted 7 lines
Quoted 1 line

Would that be fine?

It would be more clear, yes, thank you, but in this case I suggest to have a field in the spec that you can match on it. For example, is it viable to know if the packet was processed by IPSec and not AES? Maybe you want to have 2 flow with this new item, but still differentiate between the types.

Quoted 3 lines

Why not use mark/tag/meta to set this value?
The application will insert a flow that sends to security and mark the flow with some ID then the application can check this ID.

[Tejasree] SECURITY itself wouldn't make distinction on protocol. It would be combined with MARK_ID to know if the packet was processed by IPsec and not AES.

MARK_ID alone couldn't be used as we wouldn't know if it is plain packet or security processed plain packet.

Rules would be as follows:
Rule #1
[ETH] [IP] [ESP] [SPI] → [SECURITY] [MARK_ID] [END] Rule #2 [SECURITY] [MARK_ID] [ETH] [IP] → [QUEUE] [END]

I don't understand why in rule #1 you can't have the mark value to also mark the security.
From your patch I understand that security is just one bit This means that you can say if MSB bit in mark is set then it comes from security.

Quoted 9 lines
Quoted 3 lines

[Tejasree] We can use MSB of MARK_ID but that would mean we would be reserving it for security.

[Ori] but why does the PMD needs it? the application know what it needs so it can use it, It is the application decision to send to the security right? So it knows what values to set.

Also the application can use tag or any other data item.

[Tejasree] PMD needs it to establish connection between security and final action to be done (queue for example).

Quoted 9 lines

First rule works on the outer packet where the inner packet would be hidden by the protocol (like encrypted payload in IPsec) and the second rule will act on the de-capsulated packet. So the packets itself are different and we cannot have one rule.

In IPsec it is valid (and a very trivial usage) to have one outer flow constitute
multiple inner flows. Without this, application will not be able to configure hardware to treat inner flows differently.

Fully agree with you about the app needs to know if it passed security
But this goes also for example simple tunnel where the app may decap the packet in the on the first flow and then do matching on the inner 5 tuple but it will need to know if the packet was decaped or what is the vni.

So in your case the app will send traffic to security and mark it as one that was gone to security then in the second rule the app will match on the mark and do what it wants with it.

I simply don't see why you need new metadata item just to mark if it passed security.

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Best,
Ori

#12 lore raw

Hi Ori,

Please see inline.

Thanks,
Tejasree

Quoted 277 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Thursday, September 24, 2020 3:22 PM
To: Tejasree Kondoj <[email protected]>; Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

----------------------------------------------------------------------
Thanks,
Ori

Quoted 4 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Thursday, September 24, 2020 8:31 AM

Quoted 8 lines

Thanks,
Tejasree

Quoted 5 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Wednesday, September 23, 2020 8:00 PM
To: Tejasree Kondoj <[email protected]>; Asaf Penso <[email protected]>; Stephen Hemminger

<[email protected]>

Quoted 82 lines
Quoted 82 lines

Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

--------------------------------------------------------------------
--
Hi

Quoted 66 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Tuesday, September 22, 2020 5:18 PM
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Hi Ori,

Please see inline.

Thanks,
Tejasree

Quoted 54 lines

-----Original Message-----
From: Tejasree Kondoj
Sent: Tuesday, September 22, 2020 2:37 PM
To: Ori Kam <[email protected]>; Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 34 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Tuesday, September 22, 2020 1:22 PM
To: Asaf Penso <[email protected]>; Tejasree Kondoj <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

--------------------------------------------------------------
----
----
Hi

Quoted 11 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Monday, September 21, 2020 7:09 PM
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Regards,
Asaf Penso

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Monday, September 21, 2020 11:59 AM
To: Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>;

Ferruh

Quoted 5 lines
Quoted 5 lines

Yigit

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

<[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph

<[email protected]>;

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines

[email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 4 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Thursday, September 17, 2020 3:09 PM
To: Stephen Hemminger <[email protected]>;

Quoted 7 lines
Quoted 7 lines

Tejasree

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Kondoj

Quoted 5 lines

<[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>;

Ferruh

Quoted 110 lines
Quoted 98 lines
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

---------------------------------------------------------
----
----
--
---

Quoted 2 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen

Hemminger

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Sent: Thursday, September 10, 2020 7:46 PM
To: Tejasree Kondoj <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh

Quoted 5 lines
Quoted 5 lines

Yigit

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

<[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob <[email protected]>; Narayana Prasad <[email protected]>; Anoob Joseph

<[email protected]>;

Quoted 67 lines
Quoted 66 lines
Quoted 45 lines
Quoted 19 lines
Quoted 19 lines
Quoted 18 lines
Quoted 9 lines

[email protected]
Subject: Re: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 2 lines · On Thu, 10 Sep 2020 22:14:41 +0530 Tejasree Kondoj <[email protected]>…

Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to

distinguish

Quoted 8 lines
Quoted 3 lines

plain packets from IPsec decrypted plain packets.

Please provide an implementation, API's without any driver support should not be accepted.

Also, we need a test for this.

Quoted 8 lines
Quoted 8 lines

[Tejasree] We would like to defer the patch and add implementation, test case in next cycle.

Quoted 5 lines

+1
Also, I think the word SECURITY is too high-level, and if specifically you mention here an item for IPSec, perhaps you can

consider renaming.

Quoted 8 lines
Quoted 8 lines

[Tejasree] This item matches security processed packets and not specific to IPsec.
Will change commit description as follows:
" Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to match packets that were security processed. For example, in case of inline IPsec, it can be used to distinguish plain packets from IPsec decrypted

plain packets"

Quoted 7 lines
Quoted 1 line

Would that be fine?

It would be more clear, yes, thank you, but in this case I suggest to have a field in the spec that you can match on it. For example, is it viable to know if the packet was processed by IPSec and not AES? Maybe you want to have 2 flow with this new item, but still differentiate between the types.

Quoted 3 lines

Why not use mark/tag/meta to set this value?
The application will insert a flow that sends to security and mark the flow with some ID then the application can check this ID.

[Tejasree] SECURITY itself wouldn't make distinction on protocol. It would be combined with MARK_ID to know if the packet was processed by IPsec and not AES.

MARK_ID alone couldn't be used as we wouldn't know if it is plain packet or security processed plain packet.

Rules would be as follows:
Rule #1
[ETH] [IP] [ESP] [SPI] → [SECURITY] [MARK_ID] [END] Rule #2 [SECURITY] [MARK_ID] [ETH] [IP] → [QUEUE] [END]

I don't understand why in rule #1 you can't have the mark value to also mark the security.
From your patch I understand that security is just one bit This means that you can say if MSB bit in mark is set then it comes from security.

Quoted 9 lines
Quoted 3 lines

[Tejasree] We can use MSB of MARK_ID but that would mean we would be reserving it for security.

[Ori] but why does the PMD needs it? the application know what it needs so it can use it, It is the application decision to send to the security right? So it knows what values to set.

Also the application can use tag or any other data item.

[Tejasree] PMD needs it to establish connection between security and final action to be done (queue for example).

Quoted 9 lines

First rule works on the outer packet where the inner packet would be hidden by the protocol (like encrypted payload in IPsec) and the second rule will act on the de-capsulated packet. So the packets itself are different and we cannot have one rule.

In IPsec it is valid (and a very trivial usage) to have one outer
flow constitute multiple inner flows. Without this, application will not be able to configure hardware to treat inner flows differently.

Fully agree with you about the app needs to know if it passed security But this goes also for example simple tunnel where the app may decap the packet in the on the first flow and then do matching on the inner 5 tuple but it will need to know if the packet was decaped or what is the vni.

Quoted 7 lines

So in your case the app will send traffic to security and mark it as one that was gone to security then in the second rule the app will match on the mark and do what it wants with it.

I simply don't see why you need new metadata item just to mark if it passed security.

[Tejasree] Plain packets need to be differentiated from protocol processed ones.
In case of regular tunnel, it may or may not be required to differentiate. But with IPsec, it is mandatory to differentiate. So either we will need to reserve MSB of MARK_ID or allow SECURITY.

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Best,
Ori

#13 lore raw
Quoted 288 lines · Tejasree Kondoj

Hi Ori,

Please see inline.

Thanks,
Tejasree

Quoted 281 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Thursday, September 24, 2020 3:22 PM
To: Tejasree Kondoj <[email protected]>; Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

----------------------------------------------------------------------
Thanks,
Ori

Quoted 4 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Thursday, September 24, 2020 8:31 AM

Quoted 8 lines

Thanks,
Tejasree

Quoted 5 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Wednesday, September 23, 2020 8:00 PM
To: Tejasree Kondoj <[email protected]>; Asaf Penso <[email protected]>; Stephen Hemminger

<[email protected]>

Quoted 82 lines
Quoted 82 lines

Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

--------------------------------------------------------------------
--
Hi

Quoted 66 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Tuesday, September 22, 2020 5:18 PM
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Hi Ori,

Please see inline.

Thanks,
Tejasree

Quoted 54 lines

-----Original Message-----
From: Tejasree Kondoj
Sent: Tuesday, September 22, 2020 2:37 PM
To: Ori Kam <[email protected]>; Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 34 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Tuesday, September 22, 2020 1:22 PM
To: Asaf Penso <[email protected]>; Tejasree Kondoj <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

--------------------------------------------------------------
----
----
Hi

Quoted 11 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Monday, September 21, 2020 7:09 PM
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Regards,
Asaf Penso

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Monday, September 21, 2020 11:59 AM
To: Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>;

Ferruh

Quoted 5 lines
Quoted 5 lines

Yigit

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

<[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph

<[email protected]>;

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines

[email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 4 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Thursday, September 17, 2020 3:09 PM
To: Stephen Hemminger <[email protected]>;

Quoted 7 lines
Quoted 7 lines

Tejasree

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Kondoj

Quoted 5 lines

<[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>;

Ferruh

Quoted 110 lines
Quoted 98 lines
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

---------------------------------------------------------
----
----
--
---

Quoted 2 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen

Hemminger

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Sent: Thursday, September 10, 2020 7:46 PM
To: Tejasree Kondoj <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh

Quoted 5 lines
Quoted 5 lines

Yigit

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

<[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob <[email protected]>; Narayana Prasad <[email protected]>; Anoob Joseph

<[email protected]>;

Quoted 67 lines
Quoted 66 lines
Quoted 45 lines
Quoted 19 lines
Quoted 19 lines
Quoted 18 lines
Quoted 9 lines

[email protected]
Subject: Re: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 2 lines · On Thu, 10 Sep 2020 22:14:41 +0530 Tejasree Kondoj <[email protected]>…

Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to

distinguish

Quoted 8 lines
Quoted 3 lines

plain packets from IPsec decrypted plain packets.

Please provide an implementation, API's without any driver support should not be accepted.

Also, we need a test for this.

Quoted 8 lines
Quoted 8 lines

[Tejasree] We would like to defer the patch and add implementation, test case in next cycle.

Quoted 5 lines

+1
Also, I think the word SECURITY is too high-level, and if specifically you mention here an item for IPSec, perhaps you can

consider renaming.

Quoted 8 lines
Quoted 8 lines

[Tejasree] This item matches security processed packets and not specific to IPsec.
Will change commit description as follows:
" Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to match packets that were security processed. For example, in case of inline IPsec, it can be used to distinguish plain packets from IPsec decrypted

plain packets"

Quoted 7 lines
Quoted 1 line

Would that be fine?

It would be more clear, yes, thank you, but in this case I suggest to have a field in the spec that you can match on it. For example, is it viable to know if the packet was processed by IPSec and not AES? Maybe you want to have 2 flow with this new item, but still differentiate between the types.

Quoted 3 lines

Why not use mark/tag/meta to set this value?
The application will insert a flow that sends to security and mark the flow with some ID then the application can check this ID.

[Tejasree] SECURITY itself wouldn't make distinction on protocol. It would be combined with MARK_ID to know if the packet was processed by IPsec and not AES.

MARK_ID alone couldn't be used as we wouldn't know if it is plain packet or security processed plain packet.

Rules would be as follows:
Rule #1
[ETH] [IP] [ESP] [SPI] → [SECURITY] [MARK_ID] [END] Rule #2 [SECURITY] [MARK_ID] [ETH] [IP] → [QUEUE] [END]

I don't understand why in rule #1 you can't have the mark value to also mark the security.
From your patch I understand that security is just one bit This
means that you can say if MSB bit in mark is set then it comes from security.

Quoted 9 lines
Quoted 3 lines

[Tejasree] We can use MSB of MARK_ID but that would mean we would be reserving it for security.

[Ori] but why does the PMD needs it? the application know what it needs so it can use it, It is the application decision to send to the security right? So it knows what values to set.

Also the application can use tag or any other data item.

[Tejasree] PMD needs it to establish connection between security and final action to be done (queue for example).

Quoted 9 lines

First rule works on the outer packet where the inner packet would be hidden by the protocol (like encrypted payload in IPsec) and the second rule will act on the de-capsulated packet. So the packets itself are different and we cannot have one rule.

In IPsec it is valid (and a very trivial usage) to have one outer
flow constitute multiple inner flows. Without this, application will not be able to configure hardware to treat inner flows differently.

Fully agree with you about the app needs to know if it passed security But this goes also for example simple tunnel where the app may decap the packet in the on the first flow and then do matching on the inner 5 tuple but it will need to know if the packet was decaped or what is the vni.

So in your case the app will send traffic to security and mark it as one that was gone to security then in the second rule the app will match on the mark and do what it wants with it.

Quoted 7 lines
Quoted 3 lines

I simply don't see why you need new metadata item just to mark if it passed security.

[Tejasree] Plain packets need to be differentiated from protocol processed ones.
In case of regular tunnel, it may or may not be required to differentiate. But with IPsec, it is mandatory to differentiate. So either we will need to reserve MSB of MARK_ID or allow SECURITY.

Reserving a bit in MARK is same as using SECURITY item, I didn't get why any arbitrary MARK value can't be used for this as suggested.

Can't application do as following:
[flow A] -> [decrypt] [mark id=0x10 all processed packets] [packets with mark id=0x10] -> [queue 3]

Since application knows the mark value for first rule, it can use same value for second rule.

Or are we missing something? Like packets are decrypted without a specific rule, hence preventing to mark them, but you still want to apply an action to processed packets? Missing implementation makes it harder to understand your intention.

#14 lore raw
Quoted 299 lines · Ferruh Yigit
Quoted 288 lines · Tejasree Kondoj

Hi Ori,

Please see inline.

Thanks,
Tejasree

Quoted 281 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Thursday, September 24, 2020 3:22 PM
To: Tejasree Kondoj <[email protected]>; Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

----------------------------------------------------------------------
Thanks,
Ori

Quoted 4 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Thursday, September 24, 2020 8:31 AM

Quoted 8 lines

Thanks,
Tejasree

Quoted 5 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Wednesday, September 23, 2020 8:00 PM
To: Tejasree Kondoj <[email protected]>; Asaf Penso <[email protected]>; Stephen Hemminger

<[email protected]>

Quoted 82 lines
Quoted 82 lines

Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

--------------------------------------------------------------------

Signature · 1 line
Hi
Quoted 66 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Tuesday, September 22, 2020 5:18 PM
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Hi Ori,

Please see inline.

Thanks,
Tejasree

Quoted 54 lines

-----Original Message-----
From: Tejasree Kondoj
Sent: Tuesday, September 22, 2020 2:37 PM
To: Ori Kam <[email protected]>; Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 34 lines

-----Original Message-----
From: Ori Kam <[email protected]>
Sent: Tuesday, September 22, 2020 1:22 PM
To: Asaf Penso <[email protected]>; Tejasree Kondoj <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

--------------------------------------------------------------
----
----
Hi

Quoted 11 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Monday, September 21, 2020 7:09 PM
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Regards,
Asaf Penso

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

-----Original Message-----
From: Tejasree Kondoj <[email protected]>
Sent: Monday, September 21, 2020 11:59 AM
To: Asaf Penso <[email protected]>; Stephen Hemminger <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>;

Ferruh

Quoted 5 lines
Quoted 5 lines

Yigit

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

<[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph

<[email protected]>;

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines

[email protected]
Subject: RE: [dpdk-dev] [PATCH] ethdev: add security flow item

Please see inline.

Thanks
Tejasree

Quoted 4 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Thursday, September 17, 2020 3:09 PM
To: Stephen Hemminger <[email protected]>;

Quoted 7 lines
Quoted 7 lines

Tejasree

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Kondoj

Quoted 5 lines

<[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>;

Ferruh

Quoted 110 lines
Quoted 98 lines
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

Yigit <[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob Kollanukkaran <[email protected]>; Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph <[email protected]>; [email protected]
Subject: [EXT] RE: [dpdk-dev] [PATCH] ethdev: add security flow item

External Email

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

---------------------------------------------------------
----
----

Signature · 1 line
---
Quoted 2 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Stephen

Hemminger

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Sent: Thursday, September 10, 2020 7:46 PM
To: Tejasree Kondoj <[email protected]>
Cc: Akhil Goyal <[email protected]>; Radu Nicolau <[email protected]>; Declan Doherty <[email protected]>; Ori Kam <[email protected]>; NBU-Contact-Thomas Monjalon <[email protected]>; Ferruh

Quoted 5 lines
Quoted 5 lines

Yigit

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

<[email protected]>; Andrew Rybchenko <[email protected]>; Jerin Jacob <[email protected]>; Narayana Prasad <[email protected]>; Anoob Joseph

<[email protected]>;

Quoted 67 lines
Quoted 66 lines
Quoted 45 lines
Quoted 19 lines
Quoted 19 lines
Quoted 18 lines
Quoted 9 lines

[email protected]
Subject: Re: [dpdk-dev] [PATCH] ethdev: add security flow item

Quoted 2 lines · On Thu, 10 Sep 2020 22:14:41 +0530 Tejasree Kondoj <[email protected]>…

Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY
to

distinguish

Quoted 8 lines
Quoted 3 lines

plain packets from IPsec decrypted plain packets.

Signed-off-by: Tejasree Kondoj <[email protected]>

Please provide an implementation, API's without any driver support should not be accepted.

Also, we need a test for this.

Quoted 8 lines
Quoted 8 lines

[Tejasree] We would like to defer the patch and add implementation, test case in next cycle.

Quoted 5 lines

+1
Also, I think the word SECURITY is too high-level, and if specifically you mention here an item for IPSec, perhaps you can

consider renaming.

Quoted 8 lines
Quoted 8 lines

[Tejasree] This item matches security processed packets and not specific to IPsec.
Will change commit description as follows:
" Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to match packets that were security processed. For example, in case of inline IPsec, it can be used to distinguish plain packets from IPsec decrypted

plain packets"

Quoted 7 lines
Quoted 1 line

Would that be fine?

It would be more clear, yes, thank you, but in this case I suggest to have a field in the spec that you can match on it. For example, is it viable to know if the packet was processed by IPSec and not AES? Maybe you want to have 2 flow with this new item, but still differentiate between the types.

Quoted 3 lines

Why not use mark/tag/meta to set this value?
The application will insert a flow that sends to security and mark the flow with some ID then the application can check this ID.

[Tejasree] SECURITY itself wouldn't make distinction on protocol. It would be combined with MARK_ID to know if the packet was processed by IPsec and not AES.

MARK_ID alone couldn't be used as we wouldn't know if it is plain packet or security processed plain packet.

Rules would be as follows:
Rule #1
[ETH] [IP] [ESP] [SPI] → [SECURITY] [MARK_ID] [END] Rule #2 [SECURITY] [MARK_ID] [ETH] [IP] → [QUEUE] [END]

I don't understand why in rule #1 you can't have the mark value to also mark the security.
 From your patch I understand that security is just one bit This means that you can say if MSB bit in mark is set then it comes from security.

Quoted 9 lines
Quoted 3 lines

[Tejasree] We can use MSB of MARK_ID but that would mean we would be reserving it for security.

[Ori] but why does the PMD needs it? the application know what it needs so it can use it, It is the application decision to send to the security right? So it knows what values to set.

Also the application can use tag or any other data item.

[Tejasree] PMD needs it to establish connection between security and final action to be done (queue for example).

Quoted 9 lines

First rule works on the outer packet where the inner packet would be hidden by the protocol (like encrypted payload in IPsec) and the second rule will act on the de-capsulated packet. So the packets itself are different and we cannot have one rule.

  In IPsec it is valid (and a very trivial usage) to have one outer flow constitute multiple inner flows. Without this, application will not be able to configure hardware to treat inner flows differently.

Fully agree with you about the app needs to know if it passed security But this goes also for example simple tunnel where the app may decap the packet in the on the first flow and then do matching on the inner 5 tuple but it will need to know if the packet was decaped or what is the vni.

So in your case the app will send traffic to security and mark it as one that was gone to security then in the second rule the app will match on the mark and do what it wants with it.

Quoted 7 lines
Quoted 3 lines

I simply don't see why you need new metadata item just to mark if it passed security.

[Tejasree] Plain packets need to be differentiated from protocol processed ones.
In case of regular tunnel, it may or may not be required to differentiate. But with IPsec, it is mandatory to differentiate. So either we will need to reserve MSB of MARK_ID or allow SECURITY.

Reserving a bit in MARK is same as using SECURITY item, I didn't get why any arbitrary MARK value can't be used for this as suggested.

Quoted 8 lines

Can't application do as following:
[flow A] -> [decrypt] [mark id=0x10 all processed packets] [packets with mark id=0x10] -> [queue 3]

Since application knows the mark value for first rule, it can use same value for second rule.

Or are we missing something? Like packets are decrypted without a specific rule, hence preventing to mark them, but you still want to apply an action to processed packets? Missing implementation makes it harder to understand your intention.

The patch is stale, rejecting it, please send a new version if required.