dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen
Subsystems (3)
Krzysztof Kozlowski
maintainerPATCH v2 1/2 dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen
The ADC in S3C/S5P/Exynos SoCs can be used also for handling touch screen. In such case the second interrupt is required. This second interrupt can be anyway provided, even without touch screens. This fixes dtbs_check warnings like:
arch/arm/boot/dts/s5pv210-aquila.dt.yaml: adc@e1700000: interrupts: [[23], [24]] is too long
---
Changes since v1:
1. Fix if:has-touchscreen, as pointed by Rob.
2. Add Ack.
--- .../bindings/iio/adc/samsung,exynos-adc.yaml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml +13 -1
@@ -41,7 +41,10 @@ properties: maxItems: 2 interrupts: - maxItems: 1 + description: + ADC interrupt followed by optional touchscreen interrupt. + minItems: 1 + maxItems: 2 "#io-channel-cells": const: 1
@@ -107,6 +110,15 @@ allOf: items: - const: adc + - if: + required: + - has-touchscreen + then: + properties: + interrupts: + minItems: 2 + maxItems: 2 + examples: - | adc: adc@12d10000 {
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerPATCH v2 2/2 dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210
The ADC in S5Pv210 does not have ADC phy registers in separate block for which syscon would be needed. Remove this requirement to fix dtbs_check warnings like:
arch/arm/boot/dts/s5pv210-fascinate4g.dt.yaml: adc@e1700000: 'samsung,syscon-phandle' is a required property
---
Changes since v1:
1. Add Ack.
--- .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 - 1 file changed, 1 deletion(-)
Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml +0 -1
@@ -81,7 +81,6 @@ allOf: - samsung,exynos-adc-v2 - samsung,exynos3250-adc - samsung,exynos4212-adc - - samsung,s5pv210-adc then: required: - samsung,syscon-phandle
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v2 2/2] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210
Quoted 9 lines · Krzysztof Kozlowski
The ADC in S5Pv210 does not have ADC phy registers in separate block for which syscon would be needed. Remove this requirement to fix
dtbs_checkwarnings like:
arch/arm/boot/dts/s5pv210-fascinate4g.dt.yaml: adc@e1700000: 'samsung,syscon-phandle' is a required propertySigned-off-by Krzysztof Kozlowski <[email protected]>Acked-by Jonathan Cameron <[email protected]>
Quoted 8 lines
---
Changes since v1:
1. Add Ack.--- .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 - 1 file changed, 1 deletion(-)
Quoted 10 lines · Krzysztof Kozlowski
The ADC in S3C/S5P/Exynos SoCs can be used also for handling touch screen. In such case the second interrupt is required. This second interrupt can be anyway provided, even without touch screens. This fixes
dtbs_checkwarnings like:
arch/arm/boot/dts/s5pv210-aquila.dt.yaml: adc@e1700000: interrupts: [[23], [24]] is too longSigned-off-by Krzysztof Kozlowski <[email protected]>Acked-by Jonathan Cameron <[email protected]>
Quoted 9 lines
---
Changes since v1:
1. Fix if:has-touchscreen, as pointed by Rob.
2. Add Ack.--- .../bindings/iio/adc/samsung,exynos-adc.yaml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
Krzysztof Kozlowski
maintainerQuoted 21 lines · Rob Herring
Quoted 10 lines · Krzysztof Kozlowski
The ADC in S3C/S5P/Exynos SoCs can be used also for handling touch screen. In such case the second interrupt is required. This second interrupt can be anyway provided, even without touch screens. This fixes
dtbs_checkwarnings like:
arch/arm/boot/dts/s5pv210-aquila.dt.yaml: adc@e1700000: interrupts: [[23], [24]] is too longSigned-off-by Krzysztof Kozlowski <[email protected]>Acked-by Jonathan Cameron <[email protected]>Quoted 9 lines
---
Changes since v1:
1. Fix if:has-touchscreen, as pointed by Rob.
2. Add Ack.--- .../bindings/iio/adc/samsung,exynos-adc.yaml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
Quoted 1 line
Reviewed-by Rob Herring <[email protected]>
Jonathan,
Could you pick up these two?
Best regards,
Krzysztof
Jonathan Cameron
maintainerQuoted 22 lines · On Wed, 16 Sep 2020 08:17:47 +0200 Krzysztof Kozlowski <[email protected]> wrote:
Quoted 21 lines · Rob Herring
Quoted 19 lines · Krzysztof Kozlowski
The ADC in S3C/S5P/Exynos SoCs can be used also for handling touch screen. In such case the second interrupt is required. This second interrupt can be anyway provided, even without touch screens. This fixes
dtbs_checkwarnings like:
arch/arm/boot/dts/s5pv210-aquila.dt.yaml: adc@e1700000: interrupts: [[23], [24]] is too longSigned-off-by Krzysztof Kozlowski <[email protected]>Acked-by Jonathan Cameron <[email protected]>---
Changes since v1:
1. Fix if:has-touchscreen, as pointed by Rob.
2. Add Ack.--- .../bindings/iio/adc/samsung,exynos-adc.yaml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
Quoted 5 lines
Quoted 1 line
Reviewed-by Rob Herring <[email protected]>Jonathan,
Could you pick up these two?
Done. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to possibly poke them.
Thanks,
Jonathan
Quoted 4 lines
Best regards,
Krzysztof