dt-bindings: i2c: imx-lpi2c: Add properties and use unevaluatedProperties
Subsystems (5)
PATCH v3 1/4 dt-bindings: i2c: imx-lpi2c: Add properties and use unevaluatedProperties
Additional properties actually might appear (e.g. power-domains) so describe all typical properties, reference generic i2c schema and use unevaluatedProperties to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: i2c@5a800000:
'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dt.yaml: i2c@5a800000:
'touchscreen@2c' does not match any of the regexes: 'pinctrl-[0-9]+'
---
Changes since v2:
1. Add assigned-clock-parents
Changes since v1:
1. Add more properties and include /schemas/i2c/i2c-controller.yaml#
--- .../bindings/i2c/i2c-imx-lpi2c.yaml | 20 +++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml +18 -2
@@ -9,6 +9,9 @@ title: Freescale Low Power Inter IC (LPI2C) for i.MX maintainers: - Anson Huang <[email protected]> +allOf: + - $ref: /schemas/i2c/i2c-controller.yaml# + properties: compatible: enum:
@@ -16,29 +19,42 @@ properties: - fsl,imx8qxp-lpi2c - fsl,imx8qm-lpi2c + '#address-cells': true + '#size-cells': true + reg: maxItems: 1 interrupts: maxItems: 1 + assigned-clock-parents: true + assigned-clock-rates: true + assigned-clocks: true + clock-frequency: true + + clock-names: + maxItems: 1 + clocks: maxItems: 1 + power-domains: true + required: - compatible - reg - interrupts - clocks -additionalProperties: false +unevaluatedProperties: false examples: - | #include <dt-bindings/clock/imx7ulp-clock.h> #include <dt-bindings/interrupt-controller/arm-gic.h> - lpi2c7@40a50000 { + i2c@40a50000 { compatible = "fsl,imx7ulp-lpi2c"; reg = <0x40A50000 0x10000>; interrupt-parent = <&intc>;
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v3 2/4 dt-bindings: i2c: imx-lpi2c: Fix i.MX 8QXP compatible matching
The i.MX 8QXP DTSes use two compatibles so update the binding to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: i2c@5a820000:
compatible: ['fsl,imx8qxp-lpi2c', 'fsl,imx7ulp-lpi2c'] is too long
--- .../devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml +7 -4
@@ -14,10 +14,13 @@ allOf: properties: compatible: - enum: - - fsl,imx7ulp-lpi2c - - fsl,imx8qxp-lpi2c - - fsl,imx8qm-lpi2c + oneOf: + - enum: + - fsl,imx7ulp-lpi2c + - fsl,imx8qm-lpi2c + - items: + - const: fsl,imx8qxp-lpi2c + - const: fsl,imx7ulp-lpi2c '#address-cells': true '#size-cells': true
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v3 3/4 dt-bindings: i2c: imx: Add properties and use unevaluatedProperties
In reply to Krzysztof KozlowskiAdditional properties actually might appear (e.g. power-domains) so describe all typical properties, reference generic i2c schema and use unevaluatedProperties to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: i2c@30a20000:
'#address-cells', '#size-cells', 'pmic@25' do not match any of the regexes: 'pinctrl-[0-9]+'
---
Changes since v2:
1. None
Changes since v1:
1. Add more properties and include /schemas/i2c/i2c-controller.yaml#
--- Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/i2c/i2c-imx.yaml +7 -1
@@ -9,6 +9,9 @@ title: Freescale Inter IC (I2C) and High Speed Inter IC (HS-I2C) for i.MX maintainers: - Wolfram Sang <[email protected]> +allOf: + - $ref: /schemas/i2c/i2c-controller.yaml# + properties: compatible: oneOf:
@@ -38,6 +41,9 @@ properties: - fsl,imx8mp-i2c - const: fsl,imx21-i2c + '#address-cells': true + '#size-cells': true + reg: maxItems: 1
@@ -75,7 +81,7 @@ required: - interrupts - clocks -additionalProperties: false +unevaluatedProperties: false examples: - |
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Rob Herring
maintainerRe: [PATCH v3 3/4] dt-bindings: i2c: imx: Add properties and use unevaluatedProperties
Quoted 35 lines · Krzysztof Kozlowski
Additional properties actually might appear (e.g. power-domains) so describe all typical properties, reference generic i2c schema and use unevaluatedProperties to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: i2c@30a20000:'#address-cells', '#size-cells', 'pmic@25' do not match any of the regexes: 'pinctrl-[0-9]+'Signed-off-by Krzysztof Kozlowski <[email protected]>---
Changes since v2:
1. NoneChanges since v1:
1. Add more properties and include /schemas/i2c/i2c-controller.yaml#--- Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/i2c/i2c-imx.yaml +3
-0@@ -9,6 +9,9 @@ title: Freescale Inter IC (I2C) and High Speed Inter IC (HS-I2C) for i.MX maintainers: - Wolfram Sang <[email protected]> +allOf: + - $ref: /schemas/i2c/i2c-controller.yaml# + properties: compatible: oneOf:
Documentation/devicetree/bindings/i2c/i2c-imx.yaml properties: · line 45
Quoted 5 lines
Documentation/devicetree/bindings/i2c/i2c-imx.yaml +2
-0@@ -38,6 +41,9 @@ properties: - fsl,imx8mp-i2c - const: fsl,imx21-i2c + '#address-cells': true + '#size-cells': true
Drop these.
Quoted 16 lines
Documentation/devicetree/bindings/i2c/i2c-imx.yaml +2
-1+ reg: maxItems: 1@@ -75,7 +81,7 @@ required: - interrupts - clocks -additionalProperties: false +unevaluatedProperties: false examples: - |Signature · 1 line
2.17.1
PATCH v3 4/4 dt-bindings: i2c: imx: Fix i.MX 7 compatible matching
In reply to Krzysztof KozlowskiThe i.MX 7 DTSes use two compatibles so update the binding to fix dtbs_check warnings like:
arch/arm/boot/dts/imx7d-cl-som-imx7.dt.yaml: i2c@30a20000:
compatible: ['fsl,imx7d-i2c', 'fsl,imx21-i2c'] is not valid under any of the given schemas (Possible causes of the failure):
arch/arm/boot/dts/imx7d-cl-som-imx7.dt.yaml: i2c@30a20000:
compatible: ['fsl,imx7d-i2c', 'fsl,imx21-i2c'] is too long
--- Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/i2c/i2c-imx.yaml +3 -0
@@ -21,6 +21,9 @@ properties: - items: - const: fsl,imx35-i2c - const: fsl,imx1-i2c + - items: + - const: fsl,imx7d-i2c + - const: fsl,imx21-i2c - items: - enum: - fsl,imx25-i2c
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Rob Herring
maintainerQuoted 38 lines · Krzysztof Kozlowski
Additional properties actually might appear (e.g. power-domains) so describe all typical properties, reference generic i2c schema and use unevaluatedProperties to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: i2c@5a800000:
'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dt.yaml: i2c@5a800000:
'touchscreen@2c' does not match any of the regexes: 'pinctrl-[0-9]+'Signed-off-by Krzysztof Kozlowski <[email protected]>---
Changes since v2:
1. Add assigned-clock-parentsChanges since v1:
1. Add more properties and include /schemas/i2c/i2c-controller.yaml#--- .../bindings/i2c/i2c-imx-lpi2c.yaml | 20 +++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml +3
-0@@ -9,6 +9,9 @@ title: Freescale Low Power Inter IC (LPI2C) for i.MX maintainers: - Anson Huang <[email protected]> +allOf: + - $ref: /schemas/i2c/i2c-controller.yaml# + properties: compatible: enum:
Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml properties: · line 23
Quoted 5 lines
Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml +2
-0@@ -16,29 +19,42 @@ properties: - fsl,imx8qxp-lpi2c - fsl,imx8qm-lpi2c + '#address-cells': true + '#size-cells': true
Can drop these as they are in i2c-controller.yaml.
Quoted 9 lines
Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml +3
-0+ reg: maxItems: 1 interrupts: maxItems: 1 + assigned-clock-parents: true + assigned-clock-rates: true
Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml properties: · line 42
Quoted 10 lines
Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml +7
-0+ assigned-clocks: true + clock-frequency: true + + clock-names: + maxItems: 1 + clocks: maxItems: 1 + power-domains: true
How many?
Quoted 23 lines
Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml +3
-2+ required: - compatible - reg - interrupts - clocks -additionalProperties: false +unevaluatedProperties: false examples: - | #include <dt-bindings/clock/imx7ulp-clock.h> #include <dt-bindings/interrupt-controller/arm-gic.h> - lpi2c7@40a50000 { + i2c@40a50000 { compatible = "fsl,imx7ulp-lpi2c"; reg = <0x40A50000 0x10000>; interrupt-parent = <&intc>;Signature · 1 line
2.17.1