Skip to contentSkip to conversation

board: ns3: check bnxt chimp handshake status

PATCH New Rayagonda Kokatanur 3 participants 3 messages Aug 25, 2020 – Sep 10, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 board: ns3: check bnxt chimp handshake status

Chimp is a core in Broadcom netxtream controller (bnxt). Add support to check bnxt's chimp component status.

---
Changes from V1:
-Address review comments from Simon,
Add comment about chimp failure.

 board/broadcom/bcmns3/ns3.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
board/broadcom/bcmns3/ns3.c +17 -0
index 0357cd0e32..10ae344a06 100644
@@ -12,6 +12,7 @@
 #include <asm/armv8/mmu.h>
 #include <asm/arch-bcmns3/bl33_info.h>
 #include <dt-bindings/memory/bcm-ns3-mc.h>
+#include <broadcom/chimp.h>
 
 /* Default reset-level = 3 and strap-val = 0 */
 #define L3_RESET	30
@@ -210,8 +211,24 @@ void reset_cpu(ulong level)
 #ifdef CONFIG_OF_BOARD_SETUP
 int ft_board_setup(void *fdt, struct bd_info *bd)
 {
+	u32 chimp_hs = CHIMP_HANDSHAKE_WAIT_TIMEOUT;
+
 	gic_lpi_tables_init();
 
+	/*
+	 * Check for chimp handshake status.
+	 * Zero timeout value will actually fall to default timeout.
+	 *
+	 * System boot is independent of chimp handshake.
+	 * chimp handshake failure is not a catastrophic error.
+	 * Hence continue booting if chimp handshake fails.
+	 */
+	chimp_handshake_status_optee(0, &chimp_hs);
+	if (chimp_hs == CHIMP_HANDSHAKE_SUCCESS)
+		printf("ChiMP handshake successful\n");
+	else
+		printf("ERROR: ChiMP handshake status 0x%x\n", chimp_hs);
+
 	return mem_info_parse_fixup(fdt);
 }
 #endif /* CONFIG_OF_BOARD_SETUP */
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 board: ns3: check bnxt chimp handshake status

Quoted 4 lines · Rayagonda Kokatanur

Chimp is a core in Broadcom netxtream controller (bnxt). Add support to check bnxt's chimp component status.

Quoted 8 lines

---
Changes from V1:
-Address review comments from Simon,
Add comment about chimp failure.

 board/broadcom/bcmns3/ns3.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
#2 lore raw

PATCH v2 1/1 board: ns3: check bnxt chimp handshake status

In reply to Rayagonda Kokatanur
Quoted 5 lines · Rayagonda Kokatanur

Chimp is a core in Broadcom netxtream controller (bnxt). Add support to check bnxt's chimp component status.

Applied to u-boot/next, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200910/fb12ab63/attachment.sig>