Skip to contentSkip to conversation

target/i386/kvm: Add missing fallthrough comment

PATCH Applied Thomas Huth 4 participants 4 messages Sep 11, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 target/i386/kvm: Add missing fallthrough comment

Let's make this file compilable with -Werror=implicit-fallthrough :
Looking at the code, it seems like the fallthrough is intended here, so we should add the corresponding "/* fallthrough */" comment here.

---
 target/i386/kvm.c | 1 +
 1 file changed, 1 insertion(+)
target/i386/kvm.c +1 -0
index 205b68bc0c..283d3305d5 100644
@@ -1568,6 +1568,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
             if (env->nr_dies < 2) {
                 break;
             }
+            /* fallthrough */
         case 4:
         case 0xb:
         case 0xd:
Signature · 1 line
2.18.2
Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · Thomas Huth

Let's make this file compilable with -Werror=implicit-fallthrough :
Looking at the code, it seems like the fallthrough is intended here, so we should add the corresponding "/* fallthrough */" comment here.

---
 target/i386/kvm.c | 1 +
 1 file changed, 1 insertion(+)
target/i386/kvm.c +0 -0
index 205b68bc0c..283d3305d5 100644

target/i386/kvm.c int kvm_arch_init_vcpu(CPUState *cs) · line 1574

Quoted 7 lines
target/i386/kvm.c +1 -0
@@ -1568,6 +1568,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
             if (env->nr_dies < 2) {
                 break;
             }
+            /* fallthrough */
         case 4:
         case 0xb:
         case 0xd:
#2 lore raw
In reply to Thomas Huth
Patchew URL: https://patchew.org/QEMU/[email protected]/

Patchew URL: https://patchew.org/QEMU/[email protected]/

Hi,

This series failed build test on FreeBSD host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base"

# branch
if qemu-system-x86_64 --help >/dev/null 2>&1; then
  QEMU=qemu-system-x86_64
elif /usr/libexec/qemu-kvm --help >/dev/null 2>&1; then
  QEMU=/usr/libexec/qemu-kvm
else
  exit 1
fi
make vm-build-freebsd J=21 QEMU=$QEMU
exit 0
=== TEST SCRIPT END ===

The full log is available at
http://patchew.org/logs/[email protected]/testing.FreeBSD/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]

#3 lore raw
In reply to Thomas Huth

Le 11/09/2020 à 14:53, Thomas Huth a écrit :

Quoted 15 lines

Let's make this file compilable with -Werror=implicit-fallthrough :
Looking at the code, it seems like the fallthrough is intended here, so we should add the corresponding "/* fallthrough */" comment here.

---
 target/i386/kvm.c | 1 +
 1 file changed, 1 insertion(+)
target/i386/kvm.c +0 -0
index 205b68bc0c..283d3305d5 100644

target/i386/kvm.c int kvm_arch_init_vcpu(CPUState *cs) · line 1574

Quoted 7 lines
target/i386/kvm.c +1 -0
@@ -1568,6 +1568,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
             if (env->nr_dies < 2) {
                 break;
             }
+            /* fallthrough */
         case 4:
         case 0xb:
         case 0xd:

Applied to my trivial-patches branch.

Thanks,
Laurent