Skip to contentSkip to conversation

clk: at91: Drop unused at91sam9g45_pcr_layout

PATCH In review Krzysztof Kozlowski 5 participants 19 messages Sep 2, 2020 – Sep 16, 2020

Subsystems (9)
lore
Share & tools
lore
#0 lore raw

PATCH 1/10 clk: at91: Drop unused at91sam9g45_pcr_layout

The at91sam9g45_pcr_layout is not used so drop it to fix build warning:

drivers/clk/at91/at91sam9g45.c:49:36: warning:
'at91sam9g45_pcr_layout' defined but not used [-Wunused-const-variable=]

---
 drivers/clk/at91/at91sam9g45.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/clk/at91/at91sam9g45.c +0 -7
index c88ee20bee31..cb4a406ed15d 100644
@@ -46,13 +46,6 @@ static const struct {
 	{ .n = "pck1",  .p = "prog1",    .id = 9 },
 };
 
-static const struct clk_pcr_layout at91sam9g45_pcr_layout = {
-	.offset = 0x10c,
-	.cmd = BIT(12),
-	.pid_mask = GENMASK(5, 0),
-	.div_mask = GENMASK(17, 16),
-};
-
 struct pck {
 	char *n;
 	u8 id;
Signature · 7 lines
2.17.1


_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
#1 lore raw

PATCH 2/10 clk: fixed: Add missing kerneldoc

Add missing kerneldoc to fix compile warnings like:

drivers/clk/clk-fixed-factor.c:211: warning: Function parameter or member 'node' not described in 'of_fixed_factor_clk_setup'

---
 drivers/clk/clk-fixed-factor.c | 1 +
 drivers/clk/clk-fixed-rate.c   | 1 +
 2 files changed, 2 insertions(+)
drivers/clk/clk-fixed-factor.c +1 -0
index 8b343e59dc61..910e6e74ae90 100644
@@ -206,6 +206,7 @@ static struct clk_hw *_of_fixed_factor_clk_setup(struct device_node *node)
 
 /**
  * of_fixed_factor_clk_setup() - Setup function for simple fixed factor clock
+ * @node:	device node for the clock
  */
 void __init of_fixed_factor_clk_setup(struct device_node *node)
 {
drivers/clk/clk-fixed-rate.c +1 -0
index 77499a27c8fb..45501637705c 100644
@@ -168,6 +168,7 @@ static struct clk_hw *_of_fixed_clk_setup(struct device_node *node)
 
 /**
  * of_fixed_clk_setup() - Setup function for simple fixed rate clock
+ * @node:	device node for the clock
  */
 void __init of_fixed_clk_setup(struct device_node *node)
 {
Signature · 7 lines
2.17.1


_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
#2 lore raw

PATCH 3/10 clk: bulk: Simplify with dev_err_probe()

In reply to Krzysztof Kozlowski

Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed.

---
 drivers/clk/clk-bulk.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/clk/clk-bulk.c +2 -3
index e9e16425c739..15978d2a1233 100644
@@ -96,9 +96,8 @@ static int __clk_bulk_get(struct device *dev, int num_clks,
 			if (ret == -ENOENT && optional)
 				continue;
 
-			if (ret != -EPROBE_DEFER)
-				dev_err(dev, "Failed to get clk '%s': %d\n",
-					clks[i].id, ret);
+			dev_err_probe(dev, ret, "Failed to get clk '%s'\n",
+				      clks[i].id);
 			goto err;
 		}
 	}
Signature · 7 lines
2.17.1


_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
#3 lore raw

PATCH 4/10 clk: gpio: Simplify with dev_err_probe()

In reply to Krzysztof Kozlowski

Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed.

---
 drivers/clk/clk-gpio.c | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)
drivers/clk/clk-gpio.c +4 -12
index 38755a241ab7..a3cc53edcb11 100644
@@ -199,7 +199,6 @@ static int gpio_clk_driver_probe(struct platform_device *pdev)
 	struct gpio_desc *gpiod;
 	struct clk_hw *hw;
 	bool is_mux;
-	int ret;
 
 	is_mux = of_device_is_compatible(node, "gpio-mux-clock");
 
@@ -211,17 +210,10 @@ static int gpio_clk_driver_probe(struct platform_device *pdev)
 
 	gpio_name = is_mux ? "select" : "enable";
 	gpiod = devm_gpiod_get(dev, gpio_name, GPIOD_OUT_LOW);
-	if (IS_ERR(gpiod)) {
-		ret = PTR_ERR(gpiod);
-		if (ret == -EPROBE_DEFER)
-			pr_debug("%pOFn: %s: GPIOs not yet available, retry later\n",
-					node, __func__);
-		else
-			pr_err("%pOFn: %s: Can't get '%s' named GPIO property\n",
-					node, __func__,
-					gpio_name);
-		return ret;
-	}
+	if (IS_ERR(gpiod))
+		return dev_err_probe(dev, PTR_ERR(gpiod),
+				     "%pOFn: Can't get '%s' named GPIO property\n",
+				     node, gpio_name);
 
 	if (is_mux)
 		hw = clk_hw_register_gpio_mux(dev, gpiod);
Signature · 7 lines
2.17.1


_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
maintainer
#4 lore raw

Re: [PATCH 04/10] clk: gpio: Simplify with dev_err_probe()

Quoting Krzysztof Kozlowski (2020-09-02 08:03:42)

Quoted 11 lines
drivers/clk/clk-gpio.c +0 -3
index 38755a241ab7..a3cc53edcb11 100644
@@ -211,17 +210,10 @@ static int gpio_clk_driver_probe(struct platform_device *pdev)
 
        gpio_name = is_mux ? "select" : "enable";
        gpiod = devm_gpiod_get(dev, gpio_name, GPIOD_OUT_LOW);
-       if (IS_ERR(gpiod)) {
-               ret = PTR_ERR(gpiod);
-               if (ret == -EPROBE_DEFER)

drivers/clk/clk-gpio.c static int gpio_clk_driver_probe(struct platform_device *pdev) · line 214

Quoted 10 lines
drivers/clk/clk-gpio.c +2 -8
-                       pr_debug("%pOFn: %s: GPIOs not yet available, retry later\n",
-                                       node, __func__);
-               else
-                       pr_err("%pOFn: %s: Can't get '%s' named GPIO property\n",
-                                       node, __func__,
-                                       gpio_name);
-               return ret;
-       }
+       if (IS_ERR(gpiod))
+               return dev_err_probe(dev, PTR_ERR(gpiod),

This is cool! I wonder if we could make it even more simplified with

	ret = dev_err_probe_ptr(dev, ptr, ...)
	if (ret)
		return ret;

then we don't have to do the PTR_ERR() or IS_ERR() dance in all the drivers. It could already be changed here to look at the return value of dev_err_probe() so please do that at the least.

It would also even be more super duper cool if we had a way to save some sort of cookie when the provider can't find it and is returning the -EPROBE_DEFER value. Maybe the provider could use device_set_deferred_probe_reason() on error and then if dev_err_probe() is called without any string it can print what is in the device's deferred probe reason? Or append to it whatever string is passed from the device driver? Sometimes the provider has more info like the DT property is malformed or the provider isn't probed yet which would probably help understand the deferred problem more.

#5 lore raw

Re: [PATCH 04/10] clk: gpio: Simplify with dev_err_probe()

Quoted 25 lines · Stephen Boyd

Quoting Krzysztof Kozlowski (2020-09-02 08:03:42)

Quoted 11 lines
drivers/clk/clk-gpio.c +0 -3
index 38755a241ab7..a3cc53edcb11 100644
@@ -211,17 +210,10 @@ static int gpio_clk_driver_probe(struct platform_device *pdev)
 
        gpio_name = is_mux ? "select" : "enable";
        gpiod = devm_gpiod_get(dev, gpio_name, GPIOD_OUT_LOW);
-       if (IS_ERR(gpiod)) {
-               ret = PTR_ERR(gpiod);
-               if (ret == -EPROBE_DEFER)

drivers/clk/clk-gpio.c static int gpio_clk_driver_probe(struct platform_device *pdev) · line 214

Quoted 10 lines
drivers/clk/clk-gpio.c +2 -8
-                       pr_debug("%pOFn: %s: GPIOs not yet available, retry later\n",
-                                       node, __func__);
-               else
-                       pr_err("%pOFn: %s: Can't get '%s' named GPIO property\n",
-                                       node, __func__,
-                                       gpio_name);
-               return ret;
-       }
+       if (IS_ERR(gpiod))
+               return dev_err_probe(dev, PTR_ERR(gpiod),

This is cool! I wonder if we could make it even more simplified with

Quoted 7 lines
	ret = dev_err_probe_ptr(dev, ptr, ...)
	if (ret)
		return ret;

then we don't have to do the PTR_ERR() or IS_ERR() dance in all the drivers. It could already be changed here to look at the return value of dev_err_probe() so please do that at the least.

I think this could be achieved with Rob's work here:
git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git dev_err-removal

It would make this patchset obsolete. Up to you then if you plan to wait for Rob's work.

Quoted 9 lines

It would also even be more super duper cool if we had a way to save some sort of cookie when the provider can't find it and is returning the -EPROBE_DEFER value. Maybe the provider could use device_set_deferred_probe_reason() on error and then if dev_err_probe() is called without any string it can print what is in the device's deferred probe reason? Or append to it whatever string is passed from the device driver? Sometimes the provider has more info like the DT property is malformed or the provider isn't probed yet which would probably help understand the deferred problem more.

Yes, good point. If all (or most) messages are moved to the providers, it would be easier to print also the defer reasons.

Best regards,
Krzysztof

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

#6 lore raw

PATCH 5/10 clk: sunxi-ng: Simplify with dev_err_probe()

In reply to Krzysztof Kozlowski

Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed.

---
 drivers/clk/sunxi-ng/ccu-sun8i-de2.c     | 28 ++++++++----------------
 drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c  | 19 +++++-----------
 drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c |  9 +++-----
 3 files changed, 18 insertions(+), 38 deletions(-)
drivers/clk/sunxi-ng/ccu-sun8i-de2.c +9 -19
index 524f33275bc7..0de024d3e466 100644
@@ -297,29 +297,19 @@ static int sunxi_de2_clk_probe(struct platform_device *pdev)
 		return PTR_ERR(reg);
 
 	bus_clk = devm_clk_get(&pdev->dev, "bus");
-	if (IS_ERR(bus_clk)) {
-		ret = PTR_ERR(bus_clk);
-		if (ret != -EPROBE_DEFER)
-			dev_err(&pdev->dev, "Couldn't get bus clk: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(bus_clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk),
+				     "Couldn't get bus clk\n");
 
 	mod_clk = devm_clk_get(&pdev->dev, "mod");
-	if (IS_ERR(mod_clk)) {
-		ret = PTR_ERR(mod_clk);
-		if (ret != -EPROBE_DEFER)
-			dev_err(&pdev->dev, "Couldn't get mod clk: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(mod_clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(mod_clk),
+				     "Couldn't get mod clk\n");
 
 	rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
-	if (IS_ERR(rstc)) {
-		ret = PTR_ERR(rstc);
-		if (ret != -EPROBE_DEFER)
-			dev_err(&pdev->dev,
-				"Couldn't get reset control: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(rstc))
+		return dev_err_probe(&pdev->dev, PTR_ERR(rstc),
+				     "Couldn't get reset control\n");
 
 	/* The clocks need to be enabled for us to access the registers */
 	ret = clk_prepare_enable(bus_clk);
drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c +6 -13
index 6616e8114f62..541c3d32b93e 100644
@@ -215,21 +215,14 @@ static int sun9i_a80_de_clk_probe(struct platform_device *pdev)
 		return PTR_ERR(reg);
 
 	bus_clk = devm_clk_get(&pdev->dev, "bus");
-	if (IS_ERR(bus_clk)) {
-		ret = PTR_ERR(bus_clk);
-		if (ret != -EPROBE_DEFER)
-			dev_err(&pdev->dev, "Couldn't get bus clk: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(bus_clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk),
+				     "Couldn't get bus clk\n");
 
 	rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
-	if (IS_ERR(rstc)) {
-		ret = PTR_ERR(rstc);
-		if (ret != -EPROBE_DEFER)
-			dev_err(&pdev->dev,
-				"Couldn't get reset control: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(rstc))
+		return dev_err_probe(&pdev->dev, PTR_ERR(rstc),
+				     "Couldn't get reset control\n");
 
 	/* The bus clock needs to be enabled for us to access the registers */
 	ret = clk_prepare_enable(bus_clk);
drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c +3 -6
index 4b4a507d04ed..f6a3989fea36 100644
@@ -103,12 +103,9 @@ static int sun9i_a80_usb_clk_probe(struct platform_device *pdev)
 		return PTR_ERR(reg);
 
 	bus_clk = devm_clk_get(&pdev->dev, "bus");
-	if (IS_ERR(bus_clk)) {
-		ret = PTR_ERR(bus_clk);
-		if (ret != -EPROBE_DEFER)
-			dev_err(&pdev->dev, "Couldn't get bus clk: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(bus_clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk),
+				     "Couldn't get bus clk\n");
 
 	/* The bus clock needs to be enabled for us to access the registers */
 	ret = clk_prepare_enable(bus_clk);
Signature · 1 line
2.17.1
#7 lore raw

PATCH 6/10 clk: keystone: Simplify with dev_err_probe()

In reply to Krzysztof Kozlowski

Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed.

---
 drivers/clk/keystone/syscon-clk.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/clk/keystone/syscon-clk.c +3 -6
index 5b3d36462174..12ddcbed00e4 100644
@@ -102,12 +102,9 @@ static int ti_syscon_gate_clk_probe(struct platform_device *pdev)
 		return -EINVAL;
 
 	regmap = syscon_node_to_regmap(dev->of_node);
-	if (IS_ERR(regmap)) {
-		if (PTR_ERR(regmap) == -EPROBE_DEFER)
-			return -EPROBE_DEFER;
-		dev_err(dev, "failed to find parent regmap\n");
-		return PTR_ERR(regmap);
-	}
+	if (IS_ERR(regmap))
+		return dev_err_probe(dev, PTR_ERR(regmap),
+				     "failed to find parent regmap\n");
 
 	num_clks = 0;
 	for (p = data; p->name; p++)
Signature · 1 line
2.17.1
#8 lore raw

PATCH 7/10 clk: meson: Simplify with dev_err_probe()

In reply to Krzysztof Kozlowski

Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed.

---
 drivers/clk/meson/axg-audio.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/clk/meson/axg-audio.c +2 -6
index 53715e36326c..dc22b0c45743 100644
@@ -1509,12 +1509,8 @@ static int devm_clk_get_enable(struct device *dev, char *id)
 	int ret;
 
 	clk = devm_clk_get(dev, id);
-	if (IS_ERR(clk)) {
-		ret = PTR_ERR(clk);
-		if (ret != -EPROBE_DEFER)
-			dev_err(dev, "failed to get %s", id);
-		return ret;
-	}
+	if (IS_ERR(clk))
+		return dev_err_probe(dev, PTR_ERR(clk), "failed to get %s", id);
 
 	ret = clk_prepare_enable(clk);
 	if (ret) {
Signature · 1 line
2.17.1
maintainer Acked-by on v1 7/10
#9 lore raw

Re: [PATCH 07/10] clk: meson: Simplify with dev_err_probe()

Quoted 4 lines · Krzysztof Kozlowski

Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed.

Quoted 23 lines
---
 drivers/clk/meson/axg-audio.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/clk/meson/axg-audio.c +2 -6
index 53715e36326c..dc22b0c45743 100644
@@ -1509,12 +1509,8 @@ static int devm_clk_get_enable(struct device *dev, char *id)
 	int ret;
 
 	clk = devm_clk_get(dev, id);
-	if (IS_ERR(clk)) {
-		ret = PTR_ERR(clk);
-		if (ret != -EPROBE_DEFER)
-			dev_err(dev, "failed to get %s", id);
-		return ret;
-	}
+	if (IS_ERR(clk))
+		return dev_err_probe(dev, PTR_ERR(clk), "failed to get %s", id);
 
 	ret = clk_prepare_enable(clk);
 	if (ret) {
#10 lore raw

PATCH 8/10 clk: qcom: Simplify with dev_err_probe()

In reply to Krzysztof Kozlowski

Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed.

---
 drivers/clk/qcom/apcs-msm8916.c      |  9 +++------
 drivers/clk/qcom/clk-spmi-pmic-div.c | 10 ++++------
 2 files changed, 7 insertions(+), 12 deletions(-)
drivers/clk/qcom/apcs-msm8916.c +3 -6
index cf69a97d0439..5e85625b1d02 100644
@@ -77,12 +77,9 @@ static int qcom_apcs_msm8916_clk_probe(struct platform_device *pdev)
 	a53cc->parent_map = gpll0_a53cc_map;
 
 	a53cc->pclk = devm_clk_get(parent, NULL);
-	if (IS_ERR(a53cc->pclk)) {
-		ret = PTR_ERR(a53cc->pclk);
-		if (ret != -EPROBE_DEFER)
-			dev_err(dev, "failed to get clk: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(a53cc->pclk))
+		return dev_err_probe(dev, PTR_ERR(a53cc->pclk),
+				     "failed to get clk\n");
 
 	a53cc->clk_nb.notifier_call = a53cc_notifier_cb;
 	ret = clk_notifier_register(a53cc->pclk, &a53cc->clk_nb);
drivers/clk/qcom/clk-spmi-pmic-div.c +4 -6
index f2cf55cee2fd..3088050fb016 100644
@@ -237,12 +237,10 @@ static int spmi_pmic_clkdiv_probe(struct platform_device *pdev)
 	cc->nclks = nclks;
 
 	cxo = clk_get(dev, "xo");
-	if (IS_ERR(cxo)) {
-		ret = PTR_ERR(cxo);
-		if (ret != -EPROBE_DEFER)
-			dev_err(dev, "failed to get xo clock\n");
-		return ret;
-	}
+	if (IS_ERR(cxo))
+		return dev_err_probe(dev, PTR_ERR(cxo),
+				     "failed to get xo clock\n");
+
 	cxo_hz = clk_get_rate(cxo);
 	clk_put(cxo);
 
Signature · 7 lines
2.17.1


_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
#11 lore raw

PATCH 9/10 clk: davinci: Add missing kerneldoc

In reply to Krzysztof Kozlowski

Add missing kerneldoc to fix compile warning:

drivers/clk/davinci/da8xx-cfgchip.c:578: warning: Function parameter or member 'dev' not described in 'da8xx_cfgchip_register_usb1_clk48'

---
 drivers/clk/davinci/da8xx-cfgchip.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/davinci/da8xx-cfgchip.c +1 -0
index bdc52364b421..77d18276bfe8 100644
@@ -571,6 +571,7 @@ static const struct clk_ops da8xx_usb1_clk48_ops = {
 
 /**
  * da8xx_cfgchip_register_usb1_clk48 - Register a new USB 1.1 PHY clock
+ * @dev: The device
  * @regmap: The CFGCHIP regmap
  */
 static struct da8xx_usb1_clk48 *
Signature · 1 line
2.17.1
maintainer Reviewed-by on v1 9/10
#12 lore raw

Re: [PATCH 09/10] clk: davinci: Add missing kerneldoc

Quoted 6 lines · Krzysztof Kozlowski

Add missing kerneldoc to fix compile warning:

drivers/clk/davinci/da8xx-cfgchip.c:578: warning: Function parameter or member 'dev' not described in 'da8xx_cfgchip_register_usb1_clk48'

---

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

#13 lore raw

PATCH 10/10 clk: davinci: Simplify with dev_err_probe()

In reply to Krzysztof Kozlowski

Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed.

---
 drivers/clk/davinci/da8xx-cfgchip.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/davinci/da8xx-cfgchip.c +1 -2
index 77d18276bfe8..4103d605e804 100644
@@ -510,8 +510,7 @@ da8xx_cfgchip_register_usb0_clk48(struct device *dev,
 
 	fck_clk = devm_clk_get(dev, "fck");
 	if (IS_ERR(fck_clk)) {
-		if (PTR_ERR(fck_clk) != -EPROBE_DEFER)
-			dev_err(dev, "Missing fck clock\n");
+		dev_err_probe(dev, PTR_ERR(fck_clk), "Missing fck clock\n");
 		return ERR_CAST(fck_clk);
 	}
 
Signature · 7 lines
2.17.1


_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
maintainer Acked-by on v1 1/10
#15 lore raw
In reply to Krzysztof Kozlowski
Quoted 6 lines · Krzysztof Kozlowski

The at91sam9g45_pcr_layout is not used so drop it to fix build warning:

drivers/clk/at91/at91sam9g45.c:49:36: warning:
'at91sam9g45_pcr_layout' defined but not used [-Wunused-const-variable=]

Quoted 25 lines
---
 drivers/clk/at91/at91sam9g45.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/clk/at91/at91sam9g45.c +0 -7
index c88ee20bee31..cb4a406ed15d 100644
@@ -46,13 +46,6 @@ static const struct {
 	{ .n = "pck1",  .p = "prog1",    .id = 9 },
 };
 
-static const struct clk_pcr_layout at91sam9g45_pcr_layout = {
-	.offset = 0x10c,
-	.cmd = BIT(12),
-	.pid_mask = GENMASK(5, 0),
-	.div_mask = GENMASK(17, 16),
-};
-
 struct pck {
 	char *n;
 	u8 id;
Signature · 1 line
2.17.1
Signature · 3 lines
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#16 lore raw
Quoted 13 lines · Alexandre Belloni
Quoted 6 lines · Krzysztof Kozlowski

The at91sam9g45_pcr_layout is not used so drop it to fix build warning:

drivers/clk/at91/at91sam9g45.c:49:36: warning:
'at91sam9g45_pcr_layout' defined but not used [-Wunused-const-variable=]

Quoted 4 lines
---
 drivers/clk/at91/at91sam9g45.c | 7 -------
 1 file changed, 7 deletions(-)

Hi Stephen,

If the dev_err_probe() waits/skips/goes to /dev/null, then how about the fixes in the series? This patch and few other?

Best regards,
Krzysztof

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

maintainer
#17 lore raw

Quoting Krzysztof Kozlowski (2020-09-11 08:34:41)

Quoted 15 lines · Alexandre Belloni
Quoted 13 lines · Krzysztof Kozlowski
Quoted 6 lines

The at91sam9g45_pcr_layout is not used so drop it to fix build warning:

drivers/clk/at91/at91sam9g45.c:49:36: warning:
'at91sam9g45_pcr_layout' defined but not used [-Wunused-const-variable=]

Quoted 4 lines
---
 drivers/clk/at91/at91sam9g45.c | 7 -------
 1 file changed, 7 deletions(-)
Quoted 4 lines

Hi Stephen,

If the dev_err_probe() waits/skips/goes to /dev/null, then how about the fixes in the series? This patch and few other?

Yes if dev_err_probe() is superseded by Rob's work then the fixes should be fine to pick up. Can you resend the fixes?

#18 lore raw
Quoted 17 lines · Stephen Boyd

Quoting Krzysztof Kozlowski (2020-09-11 08:34:41)

Quoted 15 lines · Alexandre Belloni
Quoted 13 lines · Krzysztof Kozlowski
Quoted 6 lines

The at91sam9g45_pcr_layout is not used so drop it to fix build warning:

drivers/clk/at91/at91sam9g45.c:49:36: warning:
'at91sam9g45_pcr_layout' defined but not used [-Wunused-const-variable=]

Quoted 4 lines
---
 drivers/clk/at91/at91sam9g45.c | 7 -------
 1 file changed, 7 deletions(-)
Quoted 7 lines
Quoted 4 lines

Hi Stephen,

If the dev_err_probe() waits/skips/goes to /dev/null, then how about the fixes in the series? This patch and few other?

Yes if dev_err_probe() is superseded by Rob's work then the fixes should be fine to pick up. Can you resend the fixes?

Sure, I will send the fixes only.

Best regards,
Krzysztof

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic