Skip to contentSkip to conversation

getaddrinfo_a.3: Use C99 style to declare loop counter variables

PATCH In review Alejandro Colomar 2 participants 2 messages Sep 11, 2020 – Sep 12, 2020 Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 getaddrinfo_a.3: Use C99 style to declare loop counter variables

---
 man3/getaddrinfo_a.3 | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
man3/getaddrinfo_a.3 +4 -4
index 3a8ddc98e..ca108df1a 100644
@@ -495,7 +495,7 @@ static void
 wait_requests(void)
 {
     char *id;
-    int i, ret, n;
+    int ret, n;
     struct gaicb const **wait_reqs = calloc(nreqs, sizeof(*wait_reqs));
                 /* NULL elements are ignored by gai_suspend(). */
 
@@ -516,7 +516,7 @@ wait_requests(void)
         return;
     }
 
-    for (i = 0; i < nreqs; i++) {
+    for (int i = 0; i < nreqs; i++) {
         if (wait_reqs[i] == NULL)
             continue;
 
@@ -554,11 +554,11 @@ cancel_requests(void)
 static void
 list_requests(void)
 {
-    int i, ret;
+    int ret;
     char host[NI_MAXHOST];
     struct addrinfo *res;
 
-    for (i = 0; i < nreqs; i++) {
+    for (int i = 0; i < nreqs; i++) {
         printf("[%02d] %s: ", i, reqs[i]\->ar_name);
         ret = gai_error(reqs[i]);
 
Signature · 1 line
2.28.0
#1 lore raw

Hello Alex,

Quoted 1 line · Alejandro Colomar

Thanks. Patch applied.

Cheers,

Michael

Quoted 41 lines
---
 man3/getaddrinfo_a.3 | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
man3/getaddrinfo_a.3 +4 -4
index 3a8ddc98e..ca108df1a 100644
@@ -495,7 +495,7 @@ static void
 wait_requests(void)
 {
     char *id;
-    int i, ret, n;
+    int ret, n;
     struct gaicb const **wait_reqs = calloc(nreqs, sizeof(*wait_reqs));
                 /* NULL elements are ignored by gai_suspend(). */
 
@@ -516,7 +516,7 @@ wait_requests(void)
         return;
     }
 
-    for (i = 0; i < nreqs; i++) {
+    for (int i = 0; i < nreqs; i++) {
         if (wait_reqs[i] == NULL)
             continue;
 
@@ -554,11 +554,11 @@ cancel_requests(void)
 static void
 list_requests(void)
 {
-    int i, ret;
+    int ret;
     char host[NI_MAXHOST];
     struct addrinfo *res;
 
-    for (i = 0; i < nreqs; i++) {
+    for (int i = 0; i < nreqs; i++) {
         printf("[%02d] %s: ", i, reqs[i]\->ar_name);
         ret = gai_error(reqs[i]);
 
Signature · 3 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/