perf bench: Fix 2 memory sanitizer warnings
Ian Rogers
reviewerPATCH 1/1 perf bench: Fix 2 memory sanitizer warnings
Memory sanitizer warns if a write is performed where the memory being read for the write is uninitialized. Avoid this warning by initializing the memory.
Signed-off-by Ian Rogers <[email protected]>
--- tools/perf/bench/sched-messaging.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/bench/sched-messaging.c +2 -2
@@ -66,11 +66,10 @@ static void fdpair(int fds[2])/* Block until we're ready to go */ static void ready (int ready_out,int wakefd) { -char dummy;struct pollfd pollfd = { .fd = wakefd, .events =POLLIN };/* Tell them we're ready. */ -if (write (ready_out, &dummy,1 ) !=1 ) +if (write (ready_out,"R" ,1 ) !=1 )err (EXIT_FAILURE ,"CLIENT: ready write" );/* Wait for "GO" signal */
@@ -85,6 +84,7 @@ static void *sender(struct sender_context *ctx)unsigned int i, j;ready (ctx->ready_out, ctx->wakefd); +memset (data,'S' ,sizeof (data));/* Now pump to every receiver. */ for (i =0 ; i < nr_loops; i++) {
Signature · 1 line
2.28.0.618.gf4bc123cb7-goog
Quoted 5 lines · Ian Rogers
Memory sanitizer warns if a write is performed where the memory being read for the write is uninitialized. Avoid this warning by initializing the memory.
Signed-off-by Ian Rogers <[email protected]>
Acked-by Jiri Olsa <[email protected]>
thanks,
jirka
Quoted 32 lines
--- tools/perf/bench/sched-messaging.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/perf/bench/sched-messaging.c +2
-2@@ -66,11 +66,10 @@ static void fdpair(int fds[2])/* Block until we're ready to go */ static void ready (int ready_out,int wakefd) { -char dummy;struct pollfd pollfd = { .fd = wakefd, .events =POLLIN };/* Tell them we're ready. */ -if (write (ready_out, &dummy,1 ) !=1 ) +if (write (ready_out,"R" ,1 ) !=1 )err (EXIT_FAILURE ,"CLIENT: ready write" );/* Wait for "GO" signal */ @@ -85,6 +84,7 @@ static void *sender(struct sender_context *ctx)unsigned int i, j;ready (ctx->ready_out, ctx->wakefd); +memset (data,'S' ,sizeof (data));/* Now pump to every receiver. */ for (i =0 ; i < nr_loops; i++) {Signature · 1 line
2.28.0.618.gf4bc123cb7-goog
Em Sat, Sep 12, 2020 at 10:51:24PM +0200, Jiri Olsa escreveu:
Quoted 8 lines · Ian Rogers
Quoted 5 lines
Memory sanitizer warns if a write is performed where the memory being read for the write is uninitialized. Avoid this warning by initializing the memory.
Signed-off-by Ian Rogers <[email protected]>Acked-by Jiri Olsa <[email protected]>
Thanks, applied.
- Arnaldo