cmd/button: return button status
PATCH 1/1 cmd/button: return button status
To make the button command useful in a shell script it should return the status of the button:
* 0 (true) - pressed, on
* 1 (false) - not pressed, off
The button command takes only one argument. Correct maxargs.
--- cmd/button.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
cmd/button.c +2 -2
@@ -75,11 +75,11 @@ int do_button(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) ret =show_button_state (dev); -return 0 ; +return !ret; }U_BOOT_CMD ( - button,4 ,1 , do_button, + button,2 ,1 , do_button,"manage buttons" ,"<button_label> \tGet button state\n" "button list\t\tShow a list of buttons"
--
2.28.0
PATCH 1/1 cmd/button: return button status
Quoted 11 lines
To make the button command useful in a shell script it should return the status of the button:
* 0 (true) - pressed, on
* 1 (false) - not pressed, offThe button command takes only one argument. Correct maxargs.
Signed-off-by Heinrich Schuchardt <[email protected]>
Quoted 25 lines
---
cmd/button.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)cmd/button.c +1
-1@@ -75,11 +75,11 @@ int do_button(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) ret =show_button_state (dev); -return 0 ; +return !ret; }U_BOOT_CMD(
- button, 4, 1,do_button,
+ button, 2, 1,do_button,
"manage buttons",
"<button_label> \tGet button state\n"
"button list\t\tShow a list of buttons"
--
2.28.0
PATCH 1/1 cmd/button: return button status
In reply to Heinrich SchuchardtQuoted 25 lines · Heinrich Schuchardt
To make the button command useful in a shell script it should return the status of the button:
* 0 (true) - pressed, on
* 1 (false) - not pressed, offThe button command takes only one argument. Correct maxargs.
Signed-off-by Heinrich Schuchardt <[email protected]>Reviewed-by Philippe Reynes <[email protected]>--- cmd/button.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)--
2.28.0cmd/button.c +0
-0@@ -75,11 +75,11 @@ int do_button(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) ret =show_button_state (dev);
cmd/button.c int do_button(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) · line 85
Quoted 10 lines
cmd/button.c +2
-2-return 0 ; +return !ret; }U_BOOT_CMD ( - button,4 ,1 , do_button, + button,2 ,1 , do_button,"manage buttons" ,"<button_label> \tGet button state\n" "button list\t\tShow a list of buttons"
This in turn breaks the current button test, which I believe needs to be updated to match. Thanks.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200912/4648c24e/attachment.sig>