Skip to contentSkip to conversation

iio:dac:ad5592r: Fix use of true where iio_shared_by enum required

PATCH In review Jonathan Cameron 2 participants 2 messages Sep 13, 2020 – Sep 17, 2020

Subsystems (2)
lore
Share & tools
lore

Jonathan Cameron

author maintainer
#0 lore raw

PATCH 1/1 iio:dac:ad5592r: Fix use of true where iio_shared_by enum required

From: Jonathan Cameron <[email protected]>

Given true evaluates to 1, this should IIO_SHARED_BY_TYPE.

Cc Alexandru Ardelean <[email protected]>
Fixes 56ca9db862bf ("iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs")
---
 drivers/iio/dac/ad5592r-base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/dac/ad5592r-base.c +1 -1
index cc4875660a69..456bf5292c44 100644
@@ -488,7 +488,7 @@ static const struct iio_chan_spec_ext_info ad5592r_ext_info[] = {
 	{
 	 .name = "scale_available",
 	 .read = ad5592r_show_scale_available,
-	 .shared = true,
+	 .shared = IIO_SHARED_BY_TYPE,
 	 },
 	{},
 };
Signature · 1 line
2.28.0
#1 lore raw
Quoted 3 lines · On Sun, 13 Sep 2020 12:47:31 +0100 Jonathan Cameron <[email protected]> wrote:

From: Jonathan Cameron <[email protected]>

Given true evaluates to 1, this should IIO_SHARED_BY_TYPE.

I sent this same one out before and then lost it. I've picked that version up as at was reviewed at that time.

Sorry for the noise.

Jonathan

Quoted 21 lines
Cc Alexandru Ardelean <[email protected]>
Fixes 56ca9db862bf ("iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs")
---
 drivers/iio/dac/ad5592r-base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/dac/ad5592r-base.c +1 -1
index cc4875660a69..456bf5292c44 100644
@@ -488,7 +488,7 @@ static const struct iio_chan_spec_ext_info ad5592r_ext_info[] = {
 	{
 	 .name = "scale_available",
 	 .read = ad5592r_show_scale_available,
-	 .shared = true,
+	 .shared = IIO_SHARED_BY_TYPE,
 	 },
 	{},
 };