Skip to contentSkip to conversation

mm/compaction.c: micro-optimization remove unnecessary branch

PATCH Applied [email protected] 1 participant 1 message Sep 13, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/compaction.c: micro-optimization remove unnecessary branch

From: Mateusz Nosek <[email protected]>

The same code can work both for 'zone->compact_considered > defer_limit' and 'zone->compact_considered >= defer_limit'. In the latter there is one branch less which is more effective considering performance.

---
 mm/compaction.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
mm/compaction.c +2 -3
index 176dcded298e..6c63844fc061 100644
@@ -180,11 +180,10 @@ bool compaction_deferred(struct zone *zone, int order)
 		return false;
 
 	/* Avoid possible overflow */
-	if (++zone->compact_considered > defer_limit)
+	if (++zone->compact_considered >= defer_limit) {
 		zone->compact_considered = defer_limit;
-
-	if (zone->compact_considered >= defer_limit)
 		return false;
+	}
 
 	trace_mm_compaction_deferred(zone, order);
 
Signature · 1 line
2.20.1