Skip to contentSkip to conversation

package/libcap: needs MMU

PATCH New Fabrice Fontaine 3 participants 3 messages Sep 13, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libcap: needs MMU

libcap uses fork() since version 2.33 and
https://git.kernel.org/pub/scm/linux/kernel/git/morgan/libcap.git/commit/?id=ef485973d5547431782f9e5f4323eabfebb38622

So add MMU dependency to avoid the following build failure on applications using libcap without MMU such as ntp:

/tmp/instance-0/output-1/host/opt/ext-toolchain/arm-buildroot-uclinux-uclibcgnueabi/bin/ld.real: /tmp/instance-0/output-1/host/bin/../arm-buildroot-uclinux-uclibcgnueabi/sysroot/usr/lib/libcap.a(cap_proc.o): in function `cap_launch':
/tmp/instance-0/output-1/build/libcap-2.42/libcap/cap_proc.c:912: undefined reference to `fork'

Fixes:
- http://autobuild.buildroot.org/results/89f39dae01c07977062b909079bfcd45a68060d3

---
 package/libcap/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/libcap/Config.in +1 -0
index 5b0c827191..1145ff0dd2 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBCAP
 	bool "libcap"
+	depends on BR2_USE_MMU # fork()
 	help
 	  This library implements the user-space interfaces to the
 	  POSIX 1003.1e capabilities available in Linux kernels. These
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 package/libcap: needs MMU

Hi Fabric,

Quoted 11 lines · Fabrice Fontaine

libcap uses fork() since version 2.33 and
https://git.kernel.org/pub/scm/linux/kernel/git/morgan/libcap.git/commit/?id=ef485973d5547431782f9e5f4323eabfebb38622

So add MMU dependency to avoid the following build failure on applications using libcap without MMU such as ntp:

/tmp/instance-0/output-1/host/opt/ext-toolchain/arm-buildroot-uclinux-uclibcgnueabi/bin/ld.real: /tmp/instance-0/output-1/host/bin/../arm-buildroot-uclinux-uclibcgnueabi/sysroot/usr/lib/libcap.a(cap_proc.o): in function `cap_launch':
/tmp/instance-0/output-1/build/libcap-2.42/libcap/cap_proc.c:912: undefined reference to `fork'

Fixes:
- http://autobuild.buildroot.org/results/89f39dae01c07977062b909079bfcd45a68060d3

It might be worth noting that all current libcap reverse dependencies depend on MMU already.

baruch

Quoted 16 lines
---
 package/libcap/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/libcap/Config.in +1 -0
index 5b0c827191..1145ff0dd2 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBCAP
 	bool "libcap"
+	depends on BR2_USE_MMU # fork()
 	help
 	  This library implements the user-space interfaces to the
 	  POSIX 1003.1e capabilities available in Linux kernels. These
Signature · 3 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 package/libcap: needs MMU

In reply to Fabrice Fontaine
Quoted 6 lines · On Sun, 13 Sep 2020 18:50:48 +0200 Fabrice Fontaine…

libcap uses fork() since version 2.33 and
https://git.kernel.org/pub/scm/linux/kernel/git/morgan/libcap.git/commit/?id=ef485973d5547431782f9e5f4323eabfebb38622

So add MMU dependency to avoid the following build failure on applications using libcap without MMU such as ntp:

Quoted 7 lines

/tmp/instance-0/output-1/host/opt/ext-toolchain/arm-buildroot-uclinux-uclibcgnueabi/bin/ld.real: /tmp/instance-0/output-1/host/bin/../arm-buildroot-uclinux-uclibcgnueabi/sysroot/usr/lib/libcap.a(cap_proc.o): in function `cap_launch':
/tmp/instance-0/output-1/build/libcap-2.42/libcap/cap_proc.c:912: undefined reference to `fork'

Fixes:
- http://autobuild.buildroot.org/results/89f39dae01c07977062b909079bfcd45a68060d3

I've applied, but after dropping the BR2_USE_MMU dependency on the BR2_PACKAGE_LIBCAP_TOOLS option, since it was no longer needed. As suggested by Baruch, I've added a note in the commit log to say that all reverse dependencies of libcap already have a BR2_USE_MMU dependency.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com