pinctrl: single: fix debug output when #pinctrl-cells = 2
Subsystems (3)
PATCH v2 1/1 pinctrl: single: fix debug output when #pinctrl-cells = 2
The debug output in pcs_parse_one_pinctrl_entry() needs to be updated to print the correct pinctrl register value when #pinctrl-cells is 2.
---
v2 change:
this is a fix to my prior email where I referred to #pinctrl-cells = 3 which is incorrect. pinctrl_spec.args_count is 3 but #pinctrl-cells = 2
https://lore.kernel.org/linux-omap/[email protected]/
drivers/pinctrl/pinctrl-single.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/pinctrl-single.c +1 -1
@@ -1033,7 +1033,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs, }dev_dbg (pcs->dev,"%pOFn index: 0x%x value: 0x%x\n" , - pinctrl_spec.np, offset, pinctrl_spec.args[1 ]); + pinctrl_spec.np, offset, vals[found].val); pin =pcs_get_pin_by_offset (pcs, offset);if (pin <0 ) {
Signature · 1 line
2.25.1
Quoted 7 lines · Drew Fustini
The debug output in
pcs_parse_one_pinctrl_entry()needs to be updated to print the correct pinctrl register value when #pinctrl-cells is 2.Fixes a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")Reported-by Trent Piepho <[email protected]>Signed-off-by Drew Fustini <[email protected]>
Quoted 5 lines
---
v2 change:
this is a fix to my prior email where I referred to #pinctrl-cells = 3 which is incorrect. pinctrl_spec.args_count is 3 but #pinctrl-cells = 2
https://lore.kernel.org/linux-omap/[email protected]/
Quoted 19 lines
drivers/pinctrl/pinctrl-single.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pinctrl/pinctrl-single.c +1
-1@@ -1033,7 +1033,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs, }dev_dbg (pcs->dev,"%pOFn index: 0x%x value: 0x%x\n" , - pinctrl_spec.np, offset, pinctrl_spec.args[1 ]); + pinctrl_spec.np, offset, vals[found].val); pin =pcs_get_pin_by_offset (pcs, offset);if (pin <0 ) {Signature · 1 line
2.25.1
Quoted 7 lines · Drew Fustini
The debug output in
pcs_parse_one_pinctrl_entry()needs to be updated to print the correct pinctrl register value when #pinctrl-cells is 2.Fixes a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")Reported-by Trent Piepho <[email protected]>Signed-off-by Drew Fustini <[email protected]>
Quoted 5 lines
---
v2 change:
this is a fix to my prior email where I referred to #pinctrl-cells = 3 which is incorrect. pinctrl_spec.args_count is 3 but #pinctrl-cells = 2
https://lore.kernel.org/linux-omap/[email protected]/
Patch applied!
Yours,
Linus Walleij