cypto: mediatek - fix leaks in mtk_desc_ring_alloc
Subsystems (2)
PATCH v6 1/1 cypto: mediatek - fix leaks in mtk_desc_ring_alloc
In the init loop, if an error occurs in function 'dma_alloc_coherent', then goto the err_cleanup section, after run i--,
in the array ring, the struct mtk_ring with index i will not be released, causing memory leaks
Fixes 785e5c616c849 ("crypto: mediatek - Add crypto driver support for some MediaTek chips")
Cc Ryder Lee <[email protected]>
Signed-off-by Xiaoliang Pang <[email protected]>
--- drivers/crypto/mediatek/mtk-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/mediatek/mtk-platform.c +2 -2
@@ -469,13 +469,13 @@ static int mtk_desc_ring_alloc(struct mtk_cryp *cryp)return 0 ; err_cleanup: -for (; i--; ) { +do {dma_free_coherent (cryp->dev,MTK_DESC_RING_SZ , ring[i]->res_base, ring[i]->res_dma);dma_free_coherent (cryp->dev,MTK_DESC_RING_SZ , ring[i]->cmd_base, ring[i]->cmd_dma);kfree (ring[i]); - } + }while (i--);return err; }
Signature · 1 line
2.17.1
Herbert Xu
maintainerQuoted 11 lines · Xiaoliang Pang
In the init loop, if an error occurs in function '
dma_alloc_coherent', then goto theerr_cleanupsection, after run i--,
in the array ring, the structmtk_ringwith index i will not be released, causing memory leaksFixes 785e5c616c849 ("crypto: mediatek - Add crypto driver support for some MediaTek chips")Cc Ryder Lee <[email protected]>Signed-off-by Xiaoliang Pang <[email protected]>--- drivers/crypto/mediatek/mtk-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt