amdgpu/gmc_v9: Warn if SDPIF_MMIO_CNTRL_0 is not set
Subsystems (2)
PATCH 1/1 amdgpu/gmc_v9: Warn if SDPIF_MMIO_CNTRL_0 is not set
With IOMMU enabled, if SDPIF_MMIO_CNTRL_0 is not set appropriately the system hangs without any trace during S3.
To ease debug and to ensure that the failure, if any, was caused by a race conditions that disabled write access to SDPIF_MMIO_CNTRL_0 register, warn the user about it.
--- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +4 -1
@@ -1546,8 +1546,11 @@ static void gmc_v9_0_init_golden_registers(struct amdgpu_device *adev)*/ void gmc_v9_0_restore_registers (struct amdgpu_device *adev) { -if (adev->asic_type ==CHIP_RAVEN ) +if (adev->asic_type ==CHIP_RAVEN ) {WREG32_SOC15 (DCE ,0 , mmDCHUBBUB_SDPIF_MMIO_CNTRL_0, adev->gmc.sdpif_register); +WARN_ON (adev->gmc.sdpif_register != + RREG32_SOC15(DCE, 0, mmDCHUBBUB_SDPIF_MMIO_CNTRL_0); + } }/**
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 10 lines · Shirish S
With IOMMU enabled, if
SDPIF_MMIO_CNTRL_0is not set appropriately the system hangs without any trace during S3.To ease debug and to ensure that the failure, if any, was caused by a race conditions that disabled write access to
SDPIF_MMIO_CNTRL_0register, warn the user about it.Signed-off-by Shirish S <[email protected]>
Quoted 24 lines
--- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +4
-2@@ -1546,8 +1546,11 @@ static void gmc_v9_0_init_golden_registers(struct amdgpu_device *adev)*/ void gmc_v9_0_restore_registers (struct amdgpu_device *adev) { -if (adev->asic_type ==CHIP_RAVEN ) +if (adev->asic_type ==CHIP_RAVEN ) {WREG32_SOC15 (DCE ,0 , mmDCHUBBUB_SDPIF_MMIO_CNTRL_0, adev->gmc.sdpif_register); +WARN_ON (adev->gmc.sdpif_register != + RREG32_SOC15(DCE, 0, mmDCHUBBUB_SDPIF_MMIO_CNTRL_0); + } }/** -- 2.17.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx