lib/ipsec: remove experimental tag
PATCH 1/1 lib/ipsec: remove experimental tag
Since librte_ipsec was first introduced in 19.02 and there were no changes in it's public API since 19.11, it should be considered mature enough to remove the 'experimental' tag from it.
--- MAINTAINERS | 2 +- lib/librte_ipsec/rte_ipsec.h | 8 -------- lib/librte_ipsec/rte_ipsec_group.h | 3 --- lib/librte_ipsec/rte_ipsec_sa.h | 5 ----- lib/librte_ipsec/rte_ipsec_sad.h | 7 ------- lib/librte_ipsec/rte_ipsec_version.map | 2 +- 6 files changed, 2 insertions(+), 25 deletions(-)
MAINTAINERS +1 -1
@@ -1286,7 +1286,7 @@ M: Jiayu Hu <[email protected]> F: lib/librte_gso/ F: doc/guides/prog_guide/generic_segmentation_offload_lib.rst -IPsec - EXPERIMENTAL +IPsec M: Konstantin Ananyev <[email protected]> T: git://dpdk.org/next/dpdk-next-crypto F: lib/librte_ipsec/
lib/librte_ipsec/rte_ipsec.h +0 -8
@@ -10,10 +10,6 @@* * RTE IPsec support. * -* @warning -* @b EXPERIMENTAL: -* All functions in this file may be changed or removed without prior notice. -* * librte_ipsec provides a framework for data-path IPsec protocol * processing (ESP/AH). */
@@ -94,7 +90,6 @@ struct rte_ipsec_session {* - Zero if operation completed successfully. * - -EINVAL if the parameters are invalid. */ -__rte_experimental int rte_ipsec_session_prepare (struct rte_ipsec_session *ss);
@@ -119,7 +114,6 @@ rte_ipsec_session_prepare(struct rte_ipsec_session *ss);* @return * Number of successfully processed packets, with error code set in rte_errno. */ -__rte_experimental static inline uint16_t rte_ipsec_pkt_crypto_prepare (const struct rte_ipsec_session *ss,struct rte_mbuf *mb[],struct rte_crypto_op *cop[],uint16_t num)
@@ -127,7 +121,6 @@ rte_ipsec_pkt_crypto_prepare(const struct rte_ipsec_session *ss,return ss->pkt_func.prepare.async (ss, mb, cop, num); } -__rte_experimental static inline uint16_t rte_ipsec_pkt_cpu_prepare (const struct rte_ipsec_session *ss,struct rte_mbuf *mb[],uint16_t num)
@@ -158,7 +151,6 @@ rte_ipsec_pkt_cpu_prepare(const struct rte_ipsec_session *ss,* @return * Number of successfully processed packets, with error code set in rte_errno. */ -__rte_experimental static inline uint16_t rte_ipsec_pkt_process (const struct rte_ipsec_session *ss,struct rte_mbuf *mb[],uint16_t num)
lib/librte_ipsec/rte_ipsec_group.h +0 -3
@@ -7,7 +7,6 @@/** * @file rte_ipsec_group.h -* @b EXPERIMENTAL: this API may change without prior notice * * RTE IPsec support. * It is not recommended to include this file directly,
@@ -42,7 +41,6 @@ struct rte_ipsec_group {* @return * The pointer to the related *rte_ipsec_session* structure. */ -__rte_experimental static inline struct rte_ipsec_session *rte_ipsec_ses_from_crypto (const struct rte_crypto_op *cop) {
@@ -79,7 +77,6 @@ rte_ipsec_ses_from_crypto(const struct rte_crypto_op *cop)* @return * Number of filled elements in *grp* array. */ -__rte_experimental static inline uint16_t rte_ipsec_pkt_crypto_group (const struct rte_crypto_op *cop[],struct rte_mbuf *mb[],struct rte_ipsec_group grp[],uint16_t num)
lib/librte_ipsec/rte_ipsec_sa.h +0 -5
@@ -7,7 +7,6 @@/** * @file rte_ipsec_sa.h -* @b EXPERIMENTAL: this API may change without prior notice * * Defines API to manage IPsec Security Association (SA) objects. */
@@ -132,7 +131,6 @@ enum {* @return * SA type value. */ -__rte_experimental uint64_t rte_ipsec_sa_type (const struct rte_ipsec_sa *sa);
@@ -144,7 +142,6 @@ rte_ipsec_sa_type(const struct rte_ipsec_sa *sa);* - Actual size required for SA with given parameters. * - -EINVAL if the parameters are invalid. */ -__rte_experimental int rte_ipsec_sa_size (const struct rte_ipsec_sa_prm *prm);
@@ -161,7 +158,6 @@ rte_ipsec_sa_size(const struct rte_ipsec_sa_prm *prm);* - -EINVAL if the parameters are invalid. * - -ENOSPC if the size of the provided buffer is not big enough. */ -__rte_experimental int rte_ipsec_sa_init (struct rte_ipsec_sa *sa,const struct rte_ipsec_sa_prm *prm,uint32_t size);
@@ -171,7 +167,6 @@ rte_ipsec_sa_init(struct rte_ipsec_sa *sa, const struct rte_ipsec_sa_prm *prm,* @param sa * Pointer to SA object to de-initialize. */ -__rte_experimental void rte_ipsec_sa_fini (struct rte_ipsec_sa *sa);
lib/librte_ipsec/rte_ipsec_sad.h +0 -7
@@ -10,7 +10,6 @@/** * @file rte_ipsec_sad.h -* @b EXPERIMENTAL: this API may change without prior notice * * RTE IPsec security association database (SAD) support. * Contains helper functions to lookup and maintain SAD
@@ -82,7 +81,6 @@ struct rte_ipsec_sad_conf {* @return * 0 on success, negative value otherwise */ -__rte_experimental int rte_ipsec_sad_add(struct rte_ipsec_sad *sad, const union rte_ipsec_sad_key *key,
@@ -103,7 +101,6 @@ rte_ipsec_sad_add(struct rte_ipsec_sad *sad,* @return * 0 on success, negative value otherwise */ -__rte_experimental int rte_ipsec_sad_del(struct rte_ipsec_sad *sad, const union rte_ipsec_sad_key *key,
@@ -119,7 +116,6 @@ rte_ipsec_sad_del(struct rte_ipsec_sad *sad,* Handle to SAD object on success * NULL otherwise with rte_errno set to an appropriate values. */ -__rte_experimental struct rte_ipsec_sad *rte_ipsec_sad_create (const char *name,const struct rte_ipsec_sad_conf *conf);
@@ -133,7 +129,6 @@ rte_ipsec_sad_create(const char *name, const struct rte_ipsec_sad_conf *conf);* set appropriately. Possible rte_errno values include: * - ENOENT - required entry not available to return. */ -__rte_experimental struct rte_ipsec_sad *rte_ipsec_sad_find_existing (const char *name);
@@ -145,7 +140,6 @@ rte_ipsec_sad_find_existing(const char *name);* @return * None */ -__rte_experimental void rte_ipsec_sad_destroy (struct rte_ipsec_sad *sad);
@@ -165,7 +159,6 @@ rte_ipsec_sad_destroy(struct rte_ipsec_sad *sad);* @return * -EINVAL for incorrect arguments, otherwise number of successful lookups. */ -__rte_experimental int rte_ipsec_sad_lookup(const struct rte_ipsec_sad *sad, const union rte_ipsec_sad_key *keys[],
lib/librte_ipsec/rte_ipsec_version.map +1 -1
@@ -1,4 +1,4 @@ -EXPERIMENTAL { +DPDK_21 { global: rte_ipsec_pkt_crypto_group;
Signature · 13 lines
2.25.1 -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
Quoted 6 lines
Since
librte_ipsecwas first introduced in 19.02 and there were no changes in it's public API since 19.11, it should be considered mature enough to remove the 'experimental' tag from it.Signed-off-by Conor Walsh <[email protected]>---
Quoted 1 line
2.25.1
PATCH v2 1/1 lib/ipsec: remove experimental tag
In reply to Conor WalshSince librte_ipsec was first introduced in 19.02 and there were no changes in it's public API since 19.11, it should be considered mature enough to remove the 'experimental' tag from it.
The RTE_SATP_LOG2_NUM enum is also being dropped from rte_ipsec_sa.h to avoid possible ABI problems in the future.
---
v2: RTE_SATP_LOG2_NUM dropped from enum
--- MAINTAINERS | 2 +- doc/guides/rel_notes/release_20_11.rst | 1 + lib/librte_ipsec/rte_ipsec.h | 8 -------- lib/librte_ipsec/rte_ipsec_group.h | 3 --- lib/librte_ipsec/rte_ipsec_sa.h | 8 +------- lib/librte_ipsec/rte_ipsec_sad.h | 7 ------- lib/librte_ipsec/rte_ipsec_version.map | 2 +- 7 files changed, 4 insertions(+), 27 deletions(-)
MAINTAINERS +1 -1
@@ -1286,7 +1286,7 @@ M: Jiayu Hu <[email protected]> F: lib/librte_gso/ F: doc/guides/prog_guide/generic_segmentation_offload_lib.rst -IPsec - EXPERIMENTAL +IPsec M: Konstantin Ananyev <[email protected]> T: git://dpdk.org/next/dpdk-next-crypto F: lib/librte_ipsec/
doc/guides/rel_notes/release_20_11.rst +1 -0
@@ -100,6 +100,7 @@ ABI Changes Also, make sure to start the actual text at the margin. ======================================================= +* ipsec: ``RTE_SATP_LOG2_NUM`` has been dropped from ``enum`` Known Issues ------------
lib/librte_ipsec/rte_ipsec.h +0 -8
@@ -10,10 +10,6 @@* * RTE IPsec support. * -* @warning -* @b EXPERIMENTAL: -* All functions in this file may be changed or removed without prior notice. -* * librte_ipsec provides a framework for data-path IPsec protocol * processing (ESP/AH). */
@@ -94,7 +90,6 @@ struct rte_ipsec_session {* - Zero if operation completed successfully. * - -EINVAL if the parameters are invalid. */ -__rte_experimental int rte_ipsec_session_prepare (struct rte_ipsec_session *ss);
@@ -119,7 +114,6 @@ rte_ipsec_session_prepare(struct rte_ipsec_session *ss);* @return * Number of successfully processed packets, with error code set in rte_errno. */ -__rte_experimental static inline uint16_t rte_ipsec_pkt_crypto_prepare (const struct rte_ipsec_session *ss,struct rte_mbuf *mb[],struct rte_crypto_op *cop[],uint16_t num)
@@ -127,7 +121,6 @@ rte_ipsec_pkt_crypto_prepare(const struct rte_ipsec_session *ss,return ss->pkt_func.prepare.async (ss, mb, cop, num); } -__rte_experimental static inline uint16_t rte_ipsec_pkt_cpu_prepare (const struct rte_ipsec_session *ss,struct rte_mbuf *mb[],uint16_t num)
@@ -158,7 +151,6 @@ rte_ipsec_pkt_cpu_prepare(const struct rte_ipsec_session *ss,* @return * Number of successfully processed packets, with error code set in rte_errno. */ -__rte_experimental static inline uint16_t rte_ipsec_pkt_process (const struct rte_ipsec_session *ss,struct rte_mbuf *mb[],uint16_t num)
lib/librte_ipsec/rte_ipsec_group.h +0 -3
@@ -7,7 +7,6 @@/** * @file rte_ipsec_group.h -* @b EXPERIMENTAL: this API may change without prior notice * * RTE IPsec support. * It is not recommended to include this file directly,
@@ -42,7 +41,6 @@ struct rte_ipsec_group {* @return * The pointer to the related *rte_ipsec_session* structure. */ -__rte_experimental static inline struct rte_ipsec_session *rte_ipsec_ses_from_crypto (const struct rte_crypto_op *cop) {
@@ -79,7 +77,6 @@ rte_ipsec_ses_from_crypto(const struct rte_crypto_op *cop)* @return * Number of filled elements in *grp* array. */ -__rte_experimental static inline uint16_t rte_ipsec_pkt_crypto_group (const struct rte_crypto_op *cop[],struct rte_mbuf *mb[],struct rte_ipsec_group grp[],uint16_t num)
lib/librte_ipsec/rte_ipsec_sa.h +1 -7
@@ -7,7 +7,6 @@/** * @file rte_ipsec_sa.h -* @b EXPERIMENTAL: this API may change without prior notice * * Defines API to manage IPsec Security Association (SA) objects. */
@@ -90,8 +89,7 @@ enum {RTE_SATP_LOG2_SQN =RTE_SATP_LOG2_MODE +2 ,RTE_SATP_LOG2_ESN ,RTE_SATP_LOG2_ECN , -RTE_SATP_LOG2_DSCP , - RTE_SATP_LOG2_NUM + RTE_SATP_LOG2_DSCP };#define RTE_IPSEC_SATP_IPV_MASK (1ULL << RTE_SATP_LOG2_IPV)
@@ -132,7 +130,6 @@ enum {* @return * SA type value. */ -__rte_experimental uint64_t rte_ipsec_sa_type (const struct rte_ipsec_sa *sa);
@@ -144,7 +141,6 @@ rte_ipsec_sa_type(const struct rte_ipsec_sa *sa);* - Actual size required for SA with given parameters. * - -EINVAL if the parameters are invalid. */ -__rte_experimental int rte_ipsec_sa_size (const struct rte_ipsec_sa_prm *prm);
@@ -161,7 +157,6 @@ rte_ipsec_sa_size(const struct rte_ipsec_sa_prm *prm);* - -EINVAL if the parameters are invalid. * - -ENOSPC if the size of the provided buffer is not big enough. */ -__rte_experimental int rte_ipsec_sa_init (struct rte_ipsec_sa *sa,const struct rte_ipsec_sa_prm *prm,uint32_t size);
@@ -171,7 +166,6 @@ rte_ipsec_sa_init(struct rte_ipsec_sa *sa, const struct rte_ipsec_sa_prm *prm,* @param sa * Pointer to SA object to de-initialize. */ -__rte_experimental void rte_ipsec_sa_fini (struct rte_ipsec_sa *sa);
lib/librte_ipsec/rte_ipsec_sad.h +0 -7
@@ -10,7 +10,6 @@/** * @file rte_ipsec_sad.h -* @b EXPERIMENTAL: this API may change without prior notice * * RTE IPsec security association database (SAD) support. * Contains helper functions to lookup and maintain SAD
@@ -82,7 +81,6 @@ struct rte_ipsec_sad_conf {* @return * 0 on success, negative value otherwise */ -__rte_experimental int rte_ipsec_sad_add(struct rte_ipsec_sad *sad, const union rte_ipsec_sad_key *key,
@@ -103,7 +101,6 @@ rte_ipsec_sad_add(struct rte_ipsec_sad *sad,* @return * 0 on success, negative value otherwise */ -__rte_experimental int rte_ipsec_sad_del(struct rte_ipsec_sad *sad, const union rte_ipsec_sad_key *key,
@@ -119,7 +116,6 @@ rte_ipsec_sad_del(struct rte_ipsec_sad *sad,* Handle to SAD object on success * NULL otherwise with rte_errno set to an appropriate values. */ -__rte_experimental struct rte_ipsec_sad *rte_ipsec_sad_create (const char *name,const struct rte_ipsec_sad_conf *conf);
@@ -133,7 +129,6 @@ rte_ipsec_sad_create(const char *name, const struct rte_ipsec_sad_conf *conf);* set appropriately. Possible rte_errno values include: * - ENOENT - required entry not available to return. */ -__rte_experimental struct rte_ipsec_sad *rte_ipsec_sad_find_existing (const char *name);
@@ -145,7 +140,6 @@ rte_ipsec_sad_find_existing(const char *name);* @return * None */ -__rte_experimental void rte_ipsec_sad_destroy (struct rte_ipsec_sad *sad);
@@ -165,7 +159,6 @@ rte_ipsec_sad_destroy(struct rte_ipsec_sad *sad);* @return * -EINVAL for incorrect arguments, otherwise number of successful lookups. */ -__rte_experimental int rte_ipsec_sad_lookup(const struct rte_ipsec_sad *sad, const union rte_ipsec_sad_key *keys[],
lib/librte_ipsec/rte_ipsec_version.map +1 -1
@@ -1,4 +1,4 @@ -EXPERIMENTAL { +DPDK_21 { global: rte_ipsec_pkt_crypto_group;
Signature · 1 line
2.25.1
Hello Conor,
Quoted 9 lines · Conor Walsh
Since
librte_ipsecwas first introduced in 19.02 and there were no changes in it's public API since 19.11, it should be considered mature enough to remove the 'experimental' tag from it.
TheRTE_SATP_LOG2_NUMenum is also being dropped fromrte_ipsec_sa.hto avoid possible ABI problems in the future.---
v2:RTE_SATP_LOG2_NUMdropped from enum
Small comments that I guess could be fixed while applying.
Commit title prefixes don't start with lib/.
Quoted 30 lines
Signed-off-by Conor Walsh <[email protected]>--- MAINTAINERS | 2 +- doc/guides/rel_notes/release_20_11.rst | 1 + lib/librte_ipsec/rte_ipsec.h | 8 -------- lib/librte_ipsec/rte_ipsec_group.h | 3 --- lib/librte_ipsec/rte_ipsec_sa.h | 8 +------- lib/librte_ipsec/rte_ipsec_sad.h | 7 ------- lib/librte_ipsec/rte_ipsec_version.map | 2 +- 7 files changed, 4 insertions(+), 27 deletions(-)MAINTAINERS +1
-1@@ -1286,7 +1286,7 @@ M: Jiayu Hu <[email protected]> F: lib/librte_gso/ F: doc/guides/prog_guide/generic_segmentation_offload_lib.rst -IPsec - EXPERIMENTAL +IPsec M: Konstantin Ananyev <[email protected]> T: git://dpdk.org/next/dpdk-next-crypto F: lib/librte_ipsec/doc/guides/rel_notes/release_20_11.rst +0
-0
doc/guides/rel_notes/release_20_11.rst ABI Changes · line 103
Quoted 4 lines
doc/guides/rel_notes/release_20_11.rst +1
-0@@ -100,6 +100,7 @@ ABI Changes Also, make sure to start the actual text at the margin. ======================================================= +* ipsec: ``RTE_SATP_LOG2_NUM`` has been dropped from ``enum``
There is no ABI compat in this release, and this is an API change.
Documentation blocks are separated with double empty lines (like it was before your patch).
Quoted 3 lines
doc/guides/rel_notes/release_20_11.rst +0
-0Known Issues ------------
Signature · 1 line
David Marchand
Hi David,
Quoted 19 lines
Hello Conor,
Quoted 5 lines · Conor Walsh
Since
librte_ipsecwas first introduced in 19.02 and there were no changes in it's public API since 19.11, it should be considered mature enough to remove the 'experimental' tag from it.
TheRTE_SATP_LOG2_NUMenum is also being dropped from
rte_ipsec_sa.hQuoted 4 lines
to avoid possible ABI problems in the future.
---
v2:RTE_SATP_LOG2_NUMdropped from enumSmall comments that I guess could be fixed while applying.
Commit title prefixes don't start with
lib/.
[...]
Quoted 5 lines
There is no ABI compat in this release, and this is an API change.
Documentation blocks are separated with double empty lines (like it was before your patch).
I will correct these issues, V3 coming soon.
/Conor.
PATCH v3 1/1 ipsec: remove experimental tag
In reply to Conor WalshSince librte_ipsec was first introduced in 19.02 and there were no changes in it's public API since 19.11, it should be considered mature enough to remove the 'experimental' tag from it.
The RTE_SATP_LOG2_NUM enum is also being dropped from rte_ipsec_sa.h to avoid possible ABI problems in the future.
---
v2: RTE_SATP_LOG2_NUM dropped from enum
---
v3: fix commit title and move from ABI to API in release notes
--- MAINTAINERS | 2 +- doc/guides/rel_notes/release_20_11.rst | 2 ++ lib/librte_ipsec/rte_ipsec.h | 8 -------- lib/librte_ipsec/rte_ipsec_group.h | 3 --- lib/librte_ipsec/rte_ipsec_sa.h | 8 +------- lib/librte_ipsec/rte_ipsec_sad.h | 7 ------- lib/librte_ipsec/rte_ipsec_version.map | 2 +- 7 files changed, 5 insertions(+), 27 deletions(-)
MAINTAINERS +1 -1
@@ -1286,7 +1286,7 @@ M: Jiayu Hu <[email protected]> F: lib/librte_gso/ F: doc/guides/prog_guide/generic_segmentation_offload_lib.rst -IPsec - EXPERIMENTAL +IPsec M: Konstantin Ananyev <[email protected]> T: git://dpdk.org/next/dpdk-next-crypto F: lib/librte_ipsec/
doc/guides/rel_notes/release_20_11.rst +2 -0
@@ -84,6 +84,8 @@ API Changes Also, make sure to start the actual text at the margin. ======================================================= +* ipsec: ``RTE_SATP_LOG2_NUM`` has been dropped from ``enum`` + ABI Changes -----------
lib/librte_ipsec/rte_ipsec.h +0 -8
@@ -10,10 +10,6 @@* * RTE IPsec support. * -* @warning -* @b EXPERIMENTAL: -* All functions in this file may be changed or removed without prior notice. -* * librte_ipsec provides a framework for data-path IPsec protocol * processing (ESP/AH). */
@@ -94,7 +90,6 @@ struct rte_ipsec_session {* - Zero if operation completed successfully. * - -EINVAL if the parameters are invalid. */ -__rte_experimental int rte_ipsec_session_prepare (struct rte_ipsec_session *ss);
@@ -119,7 +114,6 @@ rte_ipsec_session_prepare(struct rte_ipsec_session *ss);* @return * Number of successfully processed packets, with error code set in rte_errno. */ -__rte_experimental static inline uint16_t rte_ipsec_pkt_crypto_prepare (const struct rte_ipsec_session *ss,struct rte_mbuf *mb[],struct rte_crypto_op *cop[],uint16_t num)
@@ -127,7 +121,6 @@ rte_ipsec_pkt_crypto_prepare(const struct rte_ipsec_session *ss,return ss->pkt_func.prepare.async (ss, mb, cop, num); } -__rte_experimental static inline uint16_t rte_ipsec_pkt_cpu_prepare (const struct rte_ipsec_session *ss,struct rte_mbuf *mb[],uint16_t num)
@@ -158,7 +151,6 @@ rte_ipsec_pkt_cpu_prepare(const struct rte_ipsec_session *ss,* @return * Number of successfully processed packets, with error code set in rte_errno. */ -__rte_experimental static inline uint16_t rte_ipsec_pkt_process (const struct rte_ipsec_session *ss,struct rte_mbuf *mb[],uint16_t num)
lib/librte_ipsec/rte_ipsec_group.h +0 -3
@@ -7,7 +7,6 @@/** * @file rte_ipsec_group.h -* @b EXPERIMENTAL: this API may change without prior notice * * RTE IPsec support. * It is not recommended to include this file directly,
@@ -42,7 +41,6 @@ struct rte_ipsec_group {* @return * The pointer to the related *rte_ipsec_session* structure. */ -__rte_experimental static inline struct rte_ipsec_session *rte_ipsec_ses_from_crypto (const struct rte_crypto_op *cop) {
@@ -79,7 +77,6 @@ rte_ipsec_ses_from_crypto(const struct rte_crypto_op *cop)* @return * Number of filled elements in *grp* array. */ -__rte_experimental static inline uint16_t rte_ipsec_pkt_crypto_group (const struct rte_crypto_op *cop[],struct rte_mbuf *mb[],struct rte_ipsec_group grp[],uint16_t num)
lib/librte_ipsec/rte_ipsec_sa.h +1 -7
@@ -7,7 +7,6 @@/** * @file rte_ipsec_sa.h -* @b EXPERIMENTAL: this API may change without prior notice * * Defines API to manage IPsec Security Association (SA) objects. */
@@ -90,8 +89,7 @@ enum {RTE_SATP_LOG2_SQN =RTE_SATP_LOG2_MODE +2 ,RTE_SATP_LOG2_ESN ,RTE_SATP_LOG2_ECN , -RTE_SATP_LOG2_DSCP , - RTE_SATP_LOG2_NUM + RTE_SATP_LOG2_DSCP };#define RTE_IPSEC_SATP_IPV_MASK (1ULL << RTE_SATP_LOG2_IPV)
@@ -132,7 +130,6 @@ enum {* @return * SA type value. */ -__rte_experimental uint64_t rte_ipsec_sa_type (const struct rte_ipsec_sa *sa);
@@ -144,7 +141,6 @@ rte_ipsec_sa_type(const struct rte_ipsec_sa *sa);* - Actual size required for SA with given parameters. * - -EINVAL if the parameters are invalid. */ -__rte_experimental int rte_ipsec_sa_size (const struct rte_ipsec_sa_prm *prm);
@@ -161,7 +157,6 @@ rte_ipsec_sa_size(const struct rte_ipsec_sa_prm *prm);* - -EINVAL if the parameters are invalid. * - -ENOSPC if the size of the provided buffer is not big enough. */ -__rte_experimental int rte_ipsec_sa_init (struct rte_ipsec_sa *sa,const struct rte_ipsec_sa_prm *prm,uint32_t size);
@@ -171,7 +166,6 @@ rte_ipsec_sa_init(struct rte_ipsec_sa *sa, const struct rte_ipsec_sa_prm *prm,* @param sa * Pointer to SA object to de-initialize. */ -__rte_experimental void rte_ipsec_sa_fini (struct rte_ipsec_sa *sa);
lib/librte_ipsec/rte_ipsec_sad.h +0 -7
@@ -10,7 +10,6 @@/** * @file rte_ipsec_sad.h -* @b EXPERIMENTAL: this API may change without prior notice * * RTE IPsec security association database (SAD) support. * Contains helper functions to lookup and maintain SAD
@@ -82,7 +81,6 @@ struct rte_ipsec_sad_conf {* @return * 0 on success, negative value otherwise */ -__rte_experimental int rte_ipsec_sad_add(struct rte_ipsec_sad *sad, const union rte_ipsec_sad_key *key,
@@ -103,7 +101,6 @@ rte_ipsec_sad_add(struct rte_ipsec_sad *sad,* @return * 0 on success, negative value otherwise */ -__rte_experimental int rte_ipsec_sad_del(struct rte_ipsec_sad *sad, const union rte_ipsec_sad_key *key,
@@ -119,7 +116,6 @@ rte_ipsec_sad_del(struct rte_ipsec_sad *sad,* Handle to SAD object on success * NULL otherwise with rte_errno set to an appropriate values. */ -__rte_experimental struct rte_ipsec_sad *rte_ipsec_sad_create (const char *name,const struct rte_ipsec_sad_conf *conf);
@@ -133,7 +129,6 @@ rte_ipsec_sad_create(const char *name, const struct rte_ipsec_sad_conf *conf);* set appropriately. Possible rte_errno values include: * - ENOENT - required entry not available to return. */ -__rte_experimental struct rte_ipsec_sad *rte_ipsec_sad_find_existing (const char *name);
@@ -145,7 +140,6 @@ rte_ipsec_sad_find_existing(const char *name);* @return * None */ -__rte_experimental void rte_ipsec_sad_destroy (struct rte_ipsec_sad *sad);
@@ -165,7 +159,6 @@ rte_ipsec_sad_destroy(struct rte_ipsec_sad *sad);* @return * -EINVAL for incorrect arguments, otherwise number of successful lookups. */ -__rte_experimental int rte_ipsec_sad_lookup(const struct rte_ipsec_sad *sad, const union rte_ipsec_sad_key *keys[],
lib/librte_ipsec/rte_ipsec_version.map +1 -1
@@ -1,4 +1,4 @@ -EXPERIMENTAL { +DPDK_21 { global: rte_ipsec_pkt_crypto_group;
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v3] ipsec: remove experimental tag
Quoted 8 lines
Since
librte_ipsecwas first introduced in 19.02 and there were no changes in it's public API since 19.11, it should be considered mature enough to remove the 'experimental' tag from it.
TheRTE_SATP_LOG2_NUMenum is also being dropped fromrte_ipsec_sa.hto avoid possible ABI problems in the future.---
Quoted 1 line
2.25.1
Kinsella, Ray
Acked-byRe: [dpdk-dev] [PATCH v3] ipsec: remove experimental tag
Quoted 7 lines · Konstantin
Quoted 7 lines
Since
librte_ipsecwas first introduced in 19.02 and there were no changes in it's public API since 19.11, it should be considered mature enough to remove the 'experimental' tag from it.
TheRTE_SATP_LOG2_NUMenum is also being dropped fromrte_ipsec_sa.hto avoid possible ABI problems in the future.
Quoted 6 lines
Quoted 1 line
---
Quoted 1 line
2.25.1
Akhil Goyal
Acked-byRe: [dpdk-dev] [PATCH v3] ipsec: remove experimental tag
Quoted 10 lines · Konstantin
Quoted 5 lines
Quoted 5 lines
Since
librte_ipsecwas first introduced in 19.02 and there were no changes in it's public API since 19.11, it should be considered mature enough to remove the 'experimental' tag from it.
TheRTE_SATP_LOG2_NUMenum is also being dropped fromrte_ipsec_sa.hto
Quoted 2 lines
Quoted 2 lines
avoid possible ABI problems in the future.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
---
Quoted 1 line
2.25.1
Acked-by Ray Kinsella <[email protected]>
Akhil Goyal
AppliedRe: [dpdk-dev] [PATCH v3] ipsec: remove experimental tag
Quoted 12 lines
Quoted 6 lines · Konstantin
Quoted 5 lines
Quoted 5 lines
Since
librte_ipsecwas first introduced in 19.02 and there were no changes in it's public API since 19.11, it should be considered mature enough to remove the 'experimental' tag from it.
TheRTE_SATP_LOG2_NUMenum is also being dropped from
rte_ipsec_sa.hQuoted 5 lines
to
Quoted 4 lines
Quoted 3 lines
avoid possible ABI problems in the future.
---
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
2.25.1
Acked-by Ray Kinsella <[email protected]>Acked-by Akhil Goyal <[email protected]>
Applied to dpdk-next-crypto
Thanks.