Skip to contentSkip to conversation

docs/memory-barriers.txt: Fix a typo in CPU MEMORY BARRIERS section

PATCH Applied Fox Chen 3 participants 3 messages Sep 9, 2020 – Sep 14, 2020

Subsystems (3)
lore
Share & tools
lore

Fox Chen

author
#0 lore raw

PATCH 1/1 docs/memory-barriers.txt: Fix a typo in CPU MEMORY BARRIERS section

Commit 39323c6 smp_mb__{before,after}_atomic(): update Documentation has a typo in CPU MEORY BARRIERS section:
"RMW functions that do not imply are memory barrier are ..." should be "RMW functions that do not imply a memory barrier are ...".

This patch fixes this typo.

---
 Documentation/memory-barriers.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/memory-barriers.txt +1 -1
index 96186332e5f4..20b8a7b30320 100644
@@ -1870,7 +1870,7 @@ There are some more advanced barrier functions:
 
      These are for use with atomic RMW functions that do not imply memory
      barriers, but where the code needs a memory barrier. Examples for atomic
-     RMW functions that do not imply are memory barrier are e.g. add,
+     RMW functions that do not imply a memory barrier are e.g. add,
      subtract, (failed) conditional operations, _relaxed functions,
      but not atomic_read or atomic_set. A common example where a memory
      barrier may be required is when atomic ops are used for reference
Signature · 1 line
2.25.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 17 lines · Fox Chen

Commit 39323c6 smp_mb__{before,after}_atomic(): update Documentation has a typo in CPU MEORY BARRIERS section:
"RMW functions that do not imply are memory barrier are ..." should be "RMW functions that do not imply a memory barrier are ...".

This patch fixes this typo.

---
 Documentation/memory-barriers.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/memory-barriers.txt +0 -0
index 96186332e5f4..20b8a7b30320 100644

Documentation/memory-barriers.txt There are some more advanced barrier functions: · line 1876

Quoted 8 lines
Documentation/memory-barriers.txt +1 -1
@@ -1870,7 +1870,7 @@ There are some more advanced barrier functions:
 
      These are for use with atomic RMW functions that do not imply memory
      barriers, but where the code needs a memory barrier. Examples for atomic
-     RMW functions that do not imply are memory barrier are e.g. add,
+     RMW functions that do not imply a memory barrier are e.g. add,
      subtract, (failed) conditional operations, _relaxed functions,
      but not atomic_read or atomic_set. A common example where a memory
      barrier may be required is when atomic ops are used for reference

The document remains unreadable, but this is still worth fixing!

Will

maintainer Applied
#2 lore raw
Quoted 29 lines · Will Deacon
Quoted 17 lines · Fox Chen

Commit 39323c6 smp_mb__{before,after}_atomic(): update Documentation has a typo in CPU MEORY BARRIERS section:
"RMW functions that do not imply are memory barrier are ..." should be "RMW functions that do not imply a memory barrier are ...".

This patch fixes this typo.

---
 Documentation/memory-barriers.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/memory-barriers.txt +0 -0
index 96186332e5f4..20b8a7b30320 100644

Documentation/memory-barriers.txt There are some more advanced barrier functions: · line 1876

Quoted 8 lines
Documentation/memory-barriers.txt +1 -1
@@ -1870,7 +1870,7 @@ There are some more advanced barrier functions:
 
      These are for use with atomic RMW functions that do not imply memory
      barriers, but where the code needs a memory barrier. Examples for atomic
-     RMW functions that do not imply are memory barrier are e.g. add,
+     RMW functions that do not imply a memory barrier are e.g. add,
      subtract, (failed) conditional operations, _relaxed functions,
      but not atomic_read or atomic_set. A common example where a memory
      barrier may be required is when atomic ops are used for reference

The document remains unreadable, but this is still worth fixing!

Quoted 1 line

Queued for v5.11, thank you both!

Thanx, Paul