Skip to contentSkip to conversation

tests/qtest/qmp-cmd-test: Use inclusive language

PATCH In review Thomas Huth 4 participants 5 messages Sep 14, 2020 – Sep 15, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tests/qtest/qmp-cmd-test: Use inclusive language

We simply want to ignore certain queries here, so let's rather use the term 'ignore' to express this intention.

---
v2: Changed naming according to suggestions

 tests/qtest/qmp-cmd-test.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
tests/qtest/qmp-cmd-test.c +5 -5
index 3109a9fe96..8a4c570e83 100644
@@ -82,9 +82,9 @@ static void test_query(const void *data)
     qtest_quit(qts);
 }
 
-static bool query_is_blacklisted(const char *cmd)
+static bool query_is_ignored(const char *cmd)
 {
-    const char *blacklist[] = {
+    const char *ignored[] = {
         /* Not actually queries: */
         "add-fd",
         /* Success depends on target arch: */
@@ -101,8 +101,8 @@ static bool query_is_blacklisted(const char *cmd)
     };
     int i;
 
-    for (i = 0; blacklist[i]; i++) {
-        if (!strcmp(cmd, blacklist[i])) {
+    for (i = 0; ignored[i]; i++) {
+        if (!strcmp(cmd, ignored[i])) {
             return true;
         }
     }
@@ -179,7 +179,7 @@ static void add_query_tests(QmpSchema *schema)
             continue;
         }
 
-        if (query_is_blacklisted(si->name)) {
+        if (query_is_ignored(si->name)) {
             continue;
         }
 
Signature · 1 line
2.18.2
#1 lore raw

It seems to me that "blacklist" is a very commonly used technical term, and expresses the concept more precisely.

I am not sure what "inclusive language" is or what relationship it has with technical work on QEMU.

Thanks,

Claudio

Quoted 47 lines · Thomas Huth

We simply want to ignore certain queries here, so let's rather use the term 'ignore' to express this intention.

---
v2: Changed naming according to suggestions

 tests/qtest/qmp-cmd-test.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
tests/qtest/qmp-cmd-test.c +5 -5
index 3109a9fe96..8a4c570e83 100644
@@ -82,9 +82,9 @@ static void test_query(const void *data)
     qtest_quit(qts);
 }
 
-static bool query_is_blacklisted(const char *cmd)
+static bool query_is_ignored(const char *cmd)
 {
-    const char *blacklist[] = {
+    const char *ignored[] = {
         /* Not actually queries: */
         "add-fd",
         /* Success depends on target arch: */
@@ -101,8 +101,8 @@ static bool query_is_blacklisted(const char *cmd)
     };
     int i;
 
-    for (i = 0; blacklist[i]; i++) {
-        if (!strcmp(cmd, blacklist[i])) {
+    for (i = 0; ignored[i]; i++) {
+        if (!strcmp(cmd, ignored[i])) {
             return true;
         }
     }
@@ -179,7 +179,7 @@ static void add_query_tests(QmpSchema *schema)
             continue;
         }
 
-        if (query_is_blacklisted(si->name)) {
+        if (query_is_ignored(si->name)) {
             continue;
         }
 
#2 lore raw
Quoted 4 lines · Claudio Fontana

It seems to me that "blacklist" is a very commonly used technical term, and expresses the concept more precisely.

I am not sure what "inclusive language" is or what relationship it has with technical work on QEMU.

See e.g.: https://itsfoss.com/linux-kernel-inclusive-code/

Even the Linux kernel folks are trying to avoid the terms in new code:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=master#n322

HTH,
Thomas

Quoted 14 lines

Thanks,

Claudio

Quoted 9 lines · Thomas Huth

We simply want to ignore certain queries here, so let's rather use the term 'ignore' to express this intention.

---
v2: Changed naming according to suggestions

 tests/qtest/qmp-cmd-test.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by on v2 1/1
#3 lore raw
In reply to Thomas Huth
Quoted 9 lines · Thomas Huth

We simply want to ignore certain queries here, so let's rather use the term 'ignore' to express this intention.

---
v2: Changed naming according to suggestions

 tests/qtest/qmp-cmd-test.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|