linux-next: build warning after merge of the net-next tree
Subsystems (7)
Hi all,
After merging the net-next tree, today's linux-next build (powerpc ppc64_defconfig) produced this warning:
net/bridge/br_multicast.c: In function 'br_multicast_find_port':net/bridge/br_multicast.c:1818:21: warning: unused variable 'br' [-Wunused-variable]
1818 | struct net_bridge *br = mp->br;
| ^~
Introduced by commit
0436862e417e ("net: bridge: mcast: support for IGMPv3/MLDv2 ALLOW_NEW_SOURCES report")
Maybe turning mlock_dereference into a static inline function would help.
Signature · 2 lines
Cheers, Stephen Rothwell
Jakub Kicinski
maintainerQuoted 10 lines · On Tue, 8 Sep 2020 13:00:00 +1000 Stephen Rothwell wrote:
Hi all,
After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
net/bridge/br_multicast.c: In function 'br_multicast_find_port':net/bridge/br_multicast.c:1818:21: warning: unused variable 'br' [-Wunused-variable]
1818 | structnet_bridge*br =mp->br;
| ^~
Quoted 5 lines
Introduced by commit
0436862e417e("net: bridge: mcast: support for IGMPv3/MLDv2ALLOW_NEW_SOURCESreport")Maybe turning
mlock_dereferenceinto a static inline function would help.
Or perhaps provide a better definition of whatever is making the reference disappear? RCU_LOCKDEP_WARN()?
Thanks for the report!
PATCH 1/1 net: bridge: mcast: fix unused br var when lockdep isn't defined
In reply to Stephen RothwellStephen reported the following warning:
net/bridge/br_multicast.c: In function 'br_multicast_find_port':
net/bridge/br_multicast.c:1818:21: warning: unused variable 'br' [-Wunused-variable]
1818 | struct net_bridge *br = mp->br;
| ^~
It happens due to bridge's mlock_dereference() when lockdep isn't defined. Silence the warning by annotating the variable as __maybe_unused.
--- net/bridge/br_multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/bridge/br_multicast.c +1 -1
@@ -1814,8 +1814,8 @@ br_multicast_find_port(struct net_bridge_mdb_entry *mp,struct net_bridge_port *p, const unsigned char *src) { + struct net_bridge *br __maybe_unused = mp->br;struct net_bridge_port_group *pg; -struct net_bridge *br = mp->br; for (pg = mlock_dereference(mp->ports, br); pg;
Signature · 1 line
2.25.4
Jakub Kicinski
maintainerRe: [PATCH net-next] net: bridge: mcast: fix unused br var when lockdep isn't defined
Quoted 21 lines · On Tue, 8 Sep 2020 10:17:13 +0300 Nikolay Aleksandrov wrote:
Stephen reported the following warning:
net/bridge/br_multicast.c: In function 'br_multicast_find_port':
net/bridge/br_multicast.c:1818:21: warning: unused variable 'br' [-Wunused-variable]
1818 | structnet_bridge*br =mp->br;
| ^~It happens due to bridge's
mlock_dereference()when lockdep isn't defined. Silence the warning by annotating the variable as__maybe_unused.Fixes 0436862e417e ("net: bridge: mcast: support for IGMPv3/MLDv2 ALLOW_NEW_SOURCES report")Reported-by Stephen Rothwell <[email protected]>Signed-off-by Nikolay Aleksandrov <[email protected]>--- net/bridge/br_multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)net/bridge/br_multicast.c +0
-0
net/bridge/br_multicast.c br_multicast_find_port(struct net_bridge_mdb_entry *mp, · line 1821
Quoted 9 lines
net/bridge/br_multicast.c +1
-1@@ -1814,8 +1814,8 @@ br_multicast_find_port(struct net_bridge_mdb_entry *mp,struct net_bridge_port *p, const unsigned char *src) { + struct net_bridge *br __maybe_unused = mp->br;struct net_bridge_port_group *pg; -struct net_bridge *br = mp->br; for (pg = mlock_dereference(mp->ports, br); pg;
That's a lazy fix :( Is everyone using lockdep annotations going to sprinkle __maybe_unused throughout the code? Macros should also always evaluate their arguments.
Jakub Kicinski
maintainerPATCH 1/1 rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition
We run into a unused variable warning in bridge code when variable is only used inside the condition of rcu_dereference_protected().
#define mlock_dereference(X, br) \ rcu_dereference_protected(X, lockdep_is_held(&br->multicast_lock))
Since on builds with CONFIG_PROVE_RCU=n rcu_dereference_protected() compiles to nothing the compiler doesn't see the variable use.
Prevent the warning by adding the condition as dead code. We need to un-hide the declaration of lockdep_tasklist_lock_is_held() and fix a bug the crept into a net/sched header.
--- include/linux/rcupdate.h | 2 +- include/linux/sched/task.h | 2 -- include/net/sch_generic.h | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-)
include/linux/rcupdate.h +1 -1
@@ -320,7 +320,7 @@ static inline void rcu_preempt_sleep_check(void) { }#else /* #ifdef CONFIG_PROVE_RCU */ -#define RCU_LOCKDEP_WARN (c, s) do { } while (0) +#define RCU_LOCKDEP_WARN (c, s) do { } while (0 && (c))#define rcu_sleep_check () do { } while (0)#endif /* #else #ifdef CONFIG_PROVE_RCU */
include/linux/sched/task.h +0 -2
@@ -47,9 +47,7 @@ extern spinlock_t mmlist_lock;extern union thread_union init_thread_union;extern struct task_struct init_task; -#ifdef CONFIG_PROVE_RCU extern int lockdep_tasklist_lock_is_held (void ); -#endif /* #ifdef CONFIG_PROVE_RCU */ extern asmlinkage void schedule_tail(struct task_struct *prev);extern void init_idle (struct task_struct *idle,int cpu);
include/net/sch_generic.h +1 -1
@@ -443,7 +443,7 @@ static inline bool lockdep_tcf_proto_is_locked(struct tcf_proto *tp) return lockdep_is_held(&tp->lock); }#else -static inline bool lockdep_tcf_chain_is_locked (struct tcf_block *chain) +static inline bool lockdep_tcf_chain_is_locked (struct tcf_chain *chain) {return true; }
Signature · 1 line
2.24.1
Re: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition
Quoted 62 lines · Jakub Kicinski
We run into a unused variable warning in bridge code when variable is only used inside the condition of
rcu_dereference_protected().#define mlock_dereference(X, br) \ rcu_dereference_protected(X, lockdep_is_held(&br->multicast_lock))Since on builds with
CONFIG_PROVE_RCU=nrcu_dereference_protected()compiles to nothing the compiler doesn't see the variable use.Prevent the warning by adding the condition as dead code. We need to un-hide the declaration of
lockdep_tasklist_lock_is_held()and fix a bug the crept into a net/sched header.Signed-off-by Jakub Kicinski <[email protected]>---
include/linux/rcupdate.h | 2 +- include/linux/sched/task.h | 2 -- include/net/sch_generic.h | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-)include/linux/rcupdate.h +1
-1@@ -320,7 +320,7 @@ static inline void rcu_preempt_sleep_check(void) { }#else /* #ifdef CONFIG_PROVE_RCU */ -#define RCU_LOCKDEP_WARN (c, s) do { } while (0) +#define RCU_LOCKDEP_WARN (c, s) do { } while (0 && (c))#define rcu_sleep_check () do { } while (0)#endif /* #else #ifdef
CONFIG_PROVE_RCU*/include/linux/sched/task.h +0
-2@@ -47,9 +47,7 @@ extern spinlock_t mmlist_lock;extern union thread_union init_thread_union;extern struct task_struct init_task; -#ifdef CONFIG_PROVE_RCU extern int lockdep_tasklist_lock_is_held (void ); -#endif /* #ifdef CONFIG_PROVE_RCU */ extern asmlinkage void schedule_tail(struct task_struct *prev);extern void init_idle (struct task_struct *idle,int cpu);include/net/sch_generic.h +1
-1@@ -443,7 +443,7 @@ static inline bool lockdep_tcf_proto_is_locked(struct tcf_proto *tp) return lockdep_is_held(&tp->lock); }#else -static inline bool lockdep_tcf_chain_is_locked(struct tcf_block *chain) +static inline bool lockdep_tcf_chain_is_locked (struct tcf_chain *chain)
Quoted 3 lines
{
return true;
}Ah, you want to solve it for all. :)
Looks and sounds good to me,
Jakub Kicinski
maintainerRe: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition
Quoted 3 lines · On Tue, 08 Sep 2020 21:15:56 +0300 [email protected] wrote:
Ah, you want to solve it for all. :)
Looks and sounds good to me,Reviewed-by Nikolay Aleksandrov <[email protected]>
Actually, I give up, lockdep_is_held() is not defined without CONFIG_LOCKDEP, let's just go with your patch..
Joel Fernandes
Reviewed-byRe: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition
Quoted 7 lines · Jakub Kicinski
Quoted 3 lines · On Tue, 08 Sep 2020 21:15:56 +0300 [email protected] wrote:
Ah, you want to solve it for all. :)
Looks and sounds good to me,Reviewed-by Nikolay Aleksandrov <[email protected]>Actually, I give up,
lockdep_is_held()is not defined withoutCONFIG_LOCKDEP, let's just go with your patch..
Care to send a patch just for the RCU macro then? Not sure what Dave is applying but if the net-next tree is not taking the RCU macro change, then send another one with my tag:
thanks!
- Joel
Jakub Kicinski
maintainerRe: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition
Quoted 6 lines · On Mon, 14 Sep 2020 16:21:22 -0400 Joel Fernandes wrote:
Quoted 5 lines · Jakub Kicinski
Quoted 3 lines · On Tue, 08 Sep 2020 21:15:56 +0300 [email protected] wrote:
Ah, you want to solve it for all. :)
Looks and sounds good to me,Reviewed-by Nikolay Aleksandrov <[email protected]>
Quoted 6 lines
Quoted 2 lines
Actually, I give up,
lockdep_is_held()is not defined withoutCONFIG_LOCKDEP, let's just go with your patch..Care to send a patch just for the RCU macro then? Not sure what Dave is applying but if the net-next tree is not taking the RCU macro change, then send another one with my tag:
Seems like quite a few places depend on the macro disappearing its argument. I was concerned that it's going to be had to pick out whether !LOCKDEP builds should return true or false from LOCKDEP helpers, but perhaps relying on the linker errors even more is not such poor taste?
Does the patch below look acceptable to you?
--->8------------
rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition
We run into a unused variable warning in bridge code when variable is only used inside the condition of rcu_dereference_protected().
#define mlock_dereference(X, br) \ rcu_dereference_protected(X, lockdep_is_held(&br->multicast_lock))
Since on builds with CONFIG_PROVE_RCU=n rcu_dereference_protected() compiles to nothing the compiler doesn't see the variable use.
Prevent the warning by adding the condition as dead code. We need to un-hide the declaration of lockdep_tasklist_lock_is_held(), lockdep_sock_is_held(), RCU lock maps and remove some declarations in net/sched header, because they have a wrong type.
Add forward declarations of lockdep_is_held(), lock_is_held() which will cause a linker errors if actually used with !LOCKDEP. At least RCU expects some locks _not_ to be held so it's hard to pick true/false for a dummy implementation.
--- include/linux/lockdep.h | 6 ++++++ include/linux/rcupdate.h | 11 ++++++----- include/linux/rcupdate_trace.h | 4 ++-- include/linux/sched/task.h | 2 -- include/net/sch_generic.h | 12 ------------ include/net/sock.h | 2 -- 6 files changed, 14 insertions(+), 23 deletions(-)
include/linux/lockdep.h +6 -0
@@ -371,6 +371,12 @@ static inline void lockdep_unregister_key(struct lock_class_key *key)#define lockdep_depth (tsk) (0) +/* +* Dummy forward declarations, allow users to write less ifdef-y code +* and depend on dead code elimination. +*/ +int lock_is_held (const void *); +int lockdep_is_held (const void *);#define lockdep_is_held_type (l, r) (1)#define lockdep_assert_held (l) do { (void)(l); } while (0)
include/linux/rcupdate.h +6 -5
@@ -234,6 +234,11 @@ bool rcu_lockdep_current_cpu_online(void);static inline bool rcu_lockdep_current_cpu_online (void ) {return true; }#endif /* #else #if defined(CONFIG_HOTPLUG_CPU) && defined(CONFIG_PROVE_RCU) */ +extern struct lockdep_map rcu_lock_map; +extern struct lockdep_map rcu_bh_lock_map; +extern struct lockdep_map rcu_sched_lock_map; +extern struct lockdep_map rcu_callback_map; +#ifdef CONFIG_DEBUG_LOCK_ALLOC static inline void rcu_lock_acquire (struct lockdep_map *map)
@@ -246,10 +251,6 @@ static inline void rcu_lock_release(struct lockdep_map *map)lock_release (map, _THIS_IP_); } -extern struct lockdep_map rcu_lock_map; -extern struct lockdep_map rcu_bh_lock_map; -extern struct lockdep_map rcu_sched_lock_map; -extern struct lockdep_map rcu_callback_map;int debug_lockdep_rcu_enabled (void );int rcu_read_lock_held (void );int rcu_read_lock_bh_held (void );
@@ -320,7 +321,7 @@ static inline void rcu_preempt_sleep_check(void) { }#else /* #ifdef CONFIG_PROVE_RCU */ -#define RCU_LOCKDEP_WARN (c, s) do { } while (0) +#define RCU_LOCKDEP_WARN (c, s) do { } while (0 && (c))#define rcu_sleep_check () do { } while (0)#endif /* #else #ifdef CONFIG_PROVE_RCU */
include/linux/rcupdate_trace.h +2 -2
@@ -11,10 +11,10 @@#include <linux/sched.h> #include <linux/rcupdate.h> -#ifdef CONFIG_DEBUG_LOCK_ALLOC -extern struct lockdep_map rcu_trace_lock_map; +#ifdef CONFIG_DEBUG_LOCK_ALLOC +static inline int rcu_read_lock_trace_held (void ) {return lock_is_held (&rcu_trace_lock_map);
include/linux/sched/task.h +0 -2
@@ -47,9 +47,7 @@ extern spinlock_t mmlist_lock;extern union thread_union init_thread_union;extern struct task_struct init_task; -#ifdef CONFIG_PROVE_RCU extern int lockdep_tasklist_lock_is_held (void ); -#endif /* #ifdef CONFIG_PROVE_RCU */ extern asmlinkage void schedule_tail(struct task_struct *prev);extern void init_idle (struct task_struct *idle,int cpu);
include/net/sch_generic.h +0 -12
@@ -432,7 +432,6 @@ struct tcf_block {struct mutex proto_destroy_lock;/* Lock for proto_destroy hashtable. */ }; -#ifdef CONFIG_PROVE_LOCKING static inline bool lockdep_tcf_chain_is_locked (struct tcf_chain *chain) {return lockdep_is_held (&chain->filter_chain_lock);
@@ -442,17 +441,6 @@ static inline bool lockdep_tcf_proto_is_locked(struct tcf_proto *tp) {return lockdep_is_held (&tp->lock); } -#else -static inline bool lockdep_tcf_chain_is_locked (struct tcf_block *chain) -{ -return true; -} - -static inline bool lockdep_tcf_proto_is_locked (struct tcf_proto *tp) -{ -return true; -} -#endif /* #ifdef CONFIG_PROVE_LOCKING */ #define tcf_chain_dereference (p, chain) \ rcu_dereference_protected(p, lockdep_tcf_chain_is_locked(chain))
include/net/sock.h +0 -2
@@ -1566,13 +1566,11 @@ do { \lockdep_init_map (&(sk)->sk_lock.dep_map, (name), (key),0 ); \ }while (0 ) -#ifdef CONFIG_LOCKDEP static inline bool lockdep_sock_is_held(const struct sock *sk) {return lockdep_is_held (&sk->sk_lock) ||lockdep_is_held (&sk->sk_lock.slock); } -#endif void lock_sock_nested (struct sock *sk,int subclass);
Signature · 1 line
2.24.1
Paul E. McKenney
maintainerRe: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition
Quoted 14 lines · Jakub Kicinski
Quoted 6 lines · On Mon, 14 Sep 2020 16:21:22 -0400 Joel Fernandes wrote:
Quoted 5 lines · Jakub Kicinski
Quoted 3 lines · On Tue, 08 Sep 2020 21:15:56 +0300 [email protected] wrote:
Ah, you want to solve it for all. :)
Looks and sounds good to me,Reviewed-by Nikolay Aleksandrov <[email protected]>Quoted 6 lines
Quoted 2 lines
Actually, I give up,
lockdep_is_held()is not defined withoutCONFIG_LOCKDEP, let's just go with your patch..Care to send a patch just for the RCU macro then? Not sure what Dave is applying but if the net-next tree is not taking the RCU macro change, then send another one with my tag:
Quoted 6 lines
Seems like quite a few places depend on the macro disappearing its argument. I was concerned that it's going to be had to pick out whether !LOCKDEP builds should return true or false from LOCKDEP helpers, but perhaps relying on the linker errors even more is not such poor taste?
Does the patch below look acceptable to you?
The thing to check would be whether all compilers do sufficient dead-code elimination (it used to be that they did not). One way to get a quick sniff test of this would be to make sure that a dead-code lockdep_is_held() is in common code, and then expose this patch to kbuild test robot.
Seem reasonable?
Thanx, Paul
Quoted 169 lines
--->8------------
rcu: prevent
RCU_LOCKDEP_WARN()from swallowing the conditionWe run into a unused variable warning in bridge code when variable is only used inside the condition of
rcu_dereference_protected().#define mlock_dereference(X, br) \ rcu_dereference_protected(X, lockdep_is_held(&br->multicast_lock))Since on builds with
CONFIG_PROVE_RCU=nrcu_dereference_protected()compiles to nothing the compiler doesn't see the variable use.Prevent the warning by adding the condition as dead code. We need to un-hide the declaration of
lockdep_tasklist_lock_is_held(),lockdep_sock_is_held(), RCU lock maps and remove some declarations in net/sched header, because they have a wrong type.Add forward declarations of
lockdep_is_held(),lock_is_held()which will cause a linker errors if actually used with !LOCKDEP. At least RCU expects some locks _not_ to be held so it's hard to pick true/false for a dummy implementation.Signed-off-by Jakub Kicinski <[email protected]>--- include/linux/lockdep.h | 6 ++++++ include/linux/rcupdate.h | 11 ++++++----- include/linux/rcupdate_trace.h | 4 ++-- include/linux/sched/task.h | 2 -- include/net/sch_generic.h | 12 ------------ include/net/sock.h | 2 -- 6 files changed, 14 insertions(+), 23 deletions(-)include/linux/lockdep.h +6
-0@@ -371,6 +371,12 @@ static inline void lockdep_unregister_key(struct lock_class_key *key)#define lockdep_depth (tsk) (0) +/* +* Dummy forward declarations, allow users to write less ifdef-y code +* and depend on dead code elimination. +*/ +int lock_is_held (const void *); +int lockdep_is_held (const void *);#define lockdep_is_held_type (l, r) (1)#define lockdep_assert_held (l) do { (void)(l); } while (0)include/linux/rcupdate.h +6
-5@@ -234,6 +234,11 @@ bool rcu_lockdep_current_cpu_online(void);static inline bool rcu_lockdep_current_cpu_online (void ) {return true; }#endif /* #else #if defined(CONFIG_HOTPLUG_CPU) && defined(CONFIG_PROVE_RCU) */ +extern struct lockdep_map rcu_lock_map; +extern struct lockdep_map rcu_bh_lock_map; +extern struct lockdep_map rcu_sched_lock_map; +extern struct lockdep_map rcu_callback_map; +#ifdef CONFIG_DEBUG_LOCK_ALLOC static inline void rcu_lock_acquire (struct lockdep_map *map)@@ -246,10 +251,6 @@ static inline void rcu_lock_release(struct lockdep_map *map)lock_release (map, _THIS_IP_); } -extern struct lockdep_map rcu_lock_map; -extern struct lockdep_map rcu_bh_lock_map; -extern struct lockdep_map rcu_sched_lock_map; -extern struct lockdep_map rcu_callback_map;int debug_lockdep_rcu_enabled (void );int rcu_read_lock_held (void );int rcu_read_lock_bh_held (void );@@ -320,7 +321,7 @@ static inline void rcu_preempt_sleep_check(void) { }#else /* #ifdef CONFIG_PROVE_RCU */ -#define RCU_LOCKDEP_WARN (c, s) do { } while (0) +#define RCU_LOCKDEP_WARN (c, s) do { } while (0 && (c))#define rcu_sleep_check () do { } while (0)#endif /* #else #ifdef CONFIG_PROVE_RCU */ include/linux/rcupdate_trace.h +2
-2@@ -11,10 +11,10 @@#include <linux/sched.h> #include <linux/rcupdate.h> -#ifdef CONFIG_DEBUG_LOCK_ALLOC -extern struct lockdep_map rcu_trace_lock_map; +#ifdef CONFIG_DEBUG_LOCK_ALLOC +static inline int rcu_read_lock_trace_held (void ) {return lock_is_held (&rcu_trace_lock_map);include/linux/sched/task.h +0
-2@@ -47,9 +47,7 @@ extern spinlock_t mmlist_lock;extern union thread_union init_thread_union;extern struct task_struct init_task; -#ifdef CONFIG_PROVE_RCU extern int lockdep_tasklist_lock_is_held (void ); -#endif /* #ifdef CONFIG_PROVE_RCU */ extern asmlinkage void schedule_tail(struct task_struct *prev);extern void init_idle (struct task_struct *idle,int cpu);include/net/sch_generic.h +0
-12@@ -432,7 +432,6 @@ struct tcf_block {struct mutex proto_destroy_lock;/* Lock for proto_destroy hashtable. */ }; -#ifdef CONFIG_PROVE_LOCKING static inline bool lockdep_tcf_chain_is_locked (struct tcf_chain *chain) {return lockdep_is_held (&chain->filter_chain_lock);@@ -442,17 +441,6 @@ static inline bool lockdep_tcf_proto_is_locked(struct tcf_proto *tp) {return lockdep_is_held (&tp->lock); } -#else -static inline bool lockdep_tcf_chain_is_locked (struct tcf_block *chain) -{ -return true; -} - -static inline bool lockdep_tcf_proto_is_locked (struct tcf_proto *tp) -{ -return true; -} -#endif /* #ifdef CONFIG_PROVE_LOCKING */ #define tcf_chain_dereference (p, chain) \ rcu_dereference_protected(p, lockdep_tcf_chain_is_locked(chain))include/net/sock.h +0
-2@@ -1566,13 +1566,11 @@ do { \lockdep_init_map (&(sk)->sk_lock.dep_map, (name), (key),0 ); \ }while (0 ) -#ifdef CONFIG_LOCKDEP static inline bool lockdep_sock_is_held(const struct sock *sk) {return lockdep_is_held (&sk->sk_lock) ||lockdep_is_held (&sk->sk_lock.slock); } -#endif void lock_sock_nested (struct sock *sk,int subclass);Signature · 1 line
2.24.1
Jakub Kicinski
maintainerRe: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition
Quoted 5 lines · On Mon, 14 Sep 2020 17:20:11 -0700 Paul E. McKenney wrote:
Quoted 5 lines
Seems like quite a few places depend on the macro disappearing its argument. I was concerned that it's going to be had to pick out whether !LOCKDEP builds should return true or false from LOCKDEP helpers, but perhaps relying on the linker errors even more is not such poor taste?
Quoted 7 lines
Quoted 1 line
Does the patch below look acceptable to you?
The thing to check would be whether all compilers do sufficient dead-code elimination (it used to be that they did not). One way to get a quick sniff test of this would be to make sure that a dead-code
lockdep_is_held()is in common code, and then expose this patch to kbuild test robot.
I'm pretty sure it's in common code because kbuild bot complaints were the reason I gave up the first time around ;)
I'll expose this to kbuild bot via my kernel.org tree in case it doesn't consider scissored patches and report back!
Paul E. McKenney
maintainerRe: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition
Quoted 14 lines · Jakub Kicinski
Quoted 5 lines · On Mon, 14 Sep 2020 17:20:11 -0700 Paul E. McKenney wrote:
Quoted 5 lines
Seems like quite a few places depend on the macro disappearing its argument. I was concerned that it's going to be had to pick out whether !LOCKDEP builds should return true or false from LOCKDEP helpers, but perhaps relying on the linker errors even more is not such poor taste?
Quoted 7 lines
Quoted 1 line
Does the patch below look acceptable to you?
The thing to check would be whether all compilers do sufficient dead-code elimination (it used to be that they did not). One way to get a quick sniff test of this would be to make sure that a dead-code
lockdep_is_held()is in common code, and then expose this patch to kbuild test robot.
Quoted 5 lines
I'm pretty sure it's in common code because kbuild bot complaints were the reason I gave up the first time around ;)
I'll expose this to kbuild bot via my kernel.org tree in case it doesn't consider scissored patches and report back!
Sounds good, thank you!
Thanx, Paul
Re: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition
In reply to Jakub KicinskiQuoted 45 lines · Jakub Kicinski
Quoted 6 lines · On Mon, 14 Sep 2020 16:21:22 -0400 Joel Fernandes wrote:
Quoted 5 lines · Jakub Kicinski
Quoted 3 lines · On Tue, 08 Sep 2020 21:15:56 +0300 [email protected] wrote:
Ah, you want to solve it for all. :)
Looks and sounds good to me,Reviewed-by Nikolay Aleksandrov <[email protected]>Quoted 6 lines
Quoted 2 lines
Actually, I give up,
lockdep_is_held()is not defined withoutCONFIG_LOCKDEP, let's just go with your patch..Care to send a patch just for the RCU macro then? Not sure what Dave is applying but if the net-next tree is not taking the RCU macro change, then send another one with my tag:
Seems like quite a few places depend on the macro disappearing its argument. I was concerned that it's going to be had to pick out whether !LOCKDEP builds should return true or false from LOCKDEP helpers, but perhaps relying on the linker errors even more is not such poor taste?
Does the patch below look acceptable to you?
--->8------------
rcu: prevent
RCU_LOCKDEP_WARN()from swallowing the conditionWe run into a unused variable warning in bridge code when variable is only used inside the condition of
rcu_dereference_protected().#define mlock_dereference(X, br) \ rcu_dereference_protected(X, lockdep_is_held(&br->multicast_lock))Since on builds with
CONFIG_PROVE_RCU=nrcu_dereference_protected()compiles to nothing the compiler doesn't see the variable use.Prevent the warning by adding the condition as dead code. We need to un-hide the declaration of
lockdep_tasklist_lock_is_held(),lockdep_sock_is_held(), RCU lock maps and remove some declarations in net/sched header, because they have a wrong type.Add forward declarations of
lockdep_is_held(),lock_is_held()which will cause a linker errors if actually used with !LOCKDEP. At least RCU expects some locks _not_ to be held so it's hard to pick true/false for a dummy implementation.
Quoted 8 lines
Signed-off-by Jakub Kicinski <[email protected]>--- include/linux/lockdep.h | 6 ++++++ include/linux/rcupdate.h | 11 ++++++----- include/linux/rcupdate_trace.h | 4 ++-- include/linux/sched/task.h | 2 -- include/net/sch_generic.h | 12 ------------ include/net/sock.h | 2 --
Would it make sense to split it into individual patches?
So 1 for rcu, 1 for lockdep and then 1 for networking. The lockdep ones may need PeterZ's ack.
thanks,
- Joel
Quoted 137 lines
6 files changed, 14 insertions(+), 23 deletions(-)include/linux/lockdep.h +6
-0@@ -371,6 +371,12 @@ static inline void lockdep_unregister_key(struct lock_class_key *key)#define lockdep_depth (tsk) (0) +/* +* Dummy forward declarations, allow users to write less ifdef-y code +* and depend on dead code elimination. +*/ +int lock_is_held (const void *); +int lockdep_is_held (const void *);#define lockdep_is_held_type (l, r) (1)#define lockdep_assert_held (l) do { (void)(l); } while (0)include/linux/rcupdate.h +6
-5@@ -234,6 +234,11 @@ bool rcu_lockdep_current_cpu_online(void);static inline bool rcu_lockdep_current_cpu_online (void ) {return true; }#endif /* #else #if defined(CONFIG_HOTPLUG_CPU) && defined(CONFIG_PROVE_RCU) */ +extern struct lockdep_map rcu_lock_map; +extern struct lockdep_map rcu_bh_lock_map; +extern struct lockdep_map rcu_sched_lock_map; +extern struct lockdep_map rcu_callback_map; +#ifdef CONFIG_DEBUG_LOCK_ALLOC static inline void rcu_lock_acquire (struct lockdep_map *map)@@ -246,10 +251,6 @@ static inline void rcu_lock_release(struct lockdep_map *map)lock_release (map, _THIS_IP_); } -extern struct lockdep_map rcu_lock_map; -extern struct lockdep_map rcu_bh_lock_map; -extern struct lockdep_map rcu_sched_lock_map; -extern struct lockdep_map rcu_callback_map;int debug_lockdep_rcu_enabled (void );int rcu_read_lock_held (void );int rcu_read_lock_bh_held (void );@@ -320,7 +321,7 @@ static inline void rcu_preempt_sleep_check(void) { }#else /* #ifdef CONFIG_PROVE_RCU */ -#define RCU_LOCKDEP_WARN (c, s) do { } while (0) +#define RCU_LOCKDEP_WARN (c, s) do { } while (0 && (c))#define rcu_sleep_check () do { } while (0)#endif /* #else #ifdef CONFIG_PROVE_RCU */ include/linux/rcupdate_trace.h +2
-2@@ -11,10 +11,10 @@#include <linux/sched.h> #include <linux/rcupdate.h> -#ifdef CONFIG_DEBUG_LOCK_ALLOC -extern struct lockdep_map rcu_trace_lock_map; +#ifdef CONFIG_DEBUG_LOCK_ALLOC +static inline int rcu_read_lock_trace_held (void ) {return lock_is_held (&rcu_trace_lock_map);include/linux/sched/task.h +0
-2@@ -47,9 +47,7 @@ extern spinlock_t mmlist_lock;extern union thread_union init_thread_union;extern struct task_struct init_task; -#ifdef CONFIG_PROVE_RCU extern int lockdep_tasklist_lock_is_held (void ); -#endif /* #ifdef CONFIG_PROVE_RCU */ extern asmlinkage void schedule_tail(struct task_struct *prev);extern void init_idle (struct task_struct *idle,int cpu);include/net/sch_generic.h +0
-12@@ -432,7 +432,6 @@ struct tcf_block {struct mutex proto_destroy_lock;/* Lock for proto_destroy hashtable. */ }; -#ifdef CONFIG_PROVE_LOCKING static inline bool lockdep_tcf_chain_is_locked (struct tcf_chain *chain) {return lockdep_is_held (&chain->filter_chain_lock);@@ -442,17 +441,6 @@ static inline bool lockdep_tcf_proto_is_locked(struct tcf_proto *tp) {return lockdep_is_held (&tp->lock); } -#else -static inline bool lockdep_tcf_chain_is_locked (struct tcf_block *chain) -{ -return true; -} - -static inline bool lockdep_tcf_proto_is_locked (struct tcf_proto *tp) -{ -return true; -} -#endif /* #ifdef CONFIG_PROVE_LOCKING */ #define tcf_chain_dereference (p, chain) \ rcu_dereference_protected(p, lockdep_tcf_chain_is_locked(chain))include/net/sock.h +0
-2@@ -1566,13 +1566,11 @@ do { \lockdep_init_map (&(sk)->sk_lock.dep_map, (name), (key),0 ); \ }while (0 ) -#ifdef CONFIG_LOCKDEP static inline bool lockdep_sock_is_held(const struct sock *sk) {return lockdep_is_held (&sk->sk_lock) ||lockdep_is_held (&sk->sk_lock.slock); } -#endif void lock_sock_nested (struct sock *sk,int subclass);Signature · 1 line
2.24.1
David Miller
maintainerRe: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition
In reply to Jakub KicinskiFrom: Jakub Kicinski <[email protected]>
Date: Tue, 8 Sep 2020 10:36:24 -0700
Quoted 7 lines
We run into a unused variable warning in bridge code when variable is only used inside the condition of
rcu_dereference_protected().#define mlock_dereference(X, br) \ rcu_dereference_protected(X, lockdep_is_held(&br->multicast_lock))
Quoted 8 lines
Since on builds with
CONFIG_PROVE_RCU=nrcu_dereference_protected()compiles to nothing the compiler doesn't see the variable use.Prevent the warning by adding the condition as dead code. We need to un-hide the declaration of
lockdep_tasklist_lock_is_held()and fix a bug the crept into a net/sched header.Signed-off-by Jakub Kicinski <[email protected]>
I ended up applying Nikolay's fix, but this situation with the rcu macros needs to be addressed.
Re: [PATCH net-next] net: bridge: mcast: fix unused br var when lockdep isn't defined
In reply to Jakub KicinskiQuoted 33 lines · Jakub Kicinski
Quoted 3 lines · On Tue, 8 Sep 2020 10:17:13 +0300 Nikolay Aleksandrov wrote:
Stephen reported the following warning:
net/bridge/br_multicast.c: In function 'br_multicast_find_port':
net/bridge/br_multicast.c:1818:21: warning: unused variable 'br'[-Wunused-variable]
Quoted 4 lines
1818 | struct net_bridge *br = mp->br; | ^~It happens due to bridge's
mlock_dereference()when lockdep isn'tdefined.
Quoted 3 lines
Silence the warning by annotating the variable as
__maybe_unused.Fixes 0436862e417e ("net: bridge: mcast: support for IGMPv3/MLDv2
ALLOW_NEW_SOURCESreport")net/bridge/br_multicast.c br_multicast_find_port(struct
Quoted 11 lines
Reported-by Stephen Rothwell <[email protected]>Signed-off-by Nikolay Aleksandrov <[email protected]>--- net/bridge/br_multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)net/bridge/br_multicast.c +0
-0@@ -1814,8 +1814,8 @@ br_multicast_find_port(struct
net_bridge_mdb_entry*mp,Quoted 7 lines
net/bridge/br_multicast.c +1
-1struct net_bridge_port *p, const unsigned char *src) { + struct net_bridge *br __maybe_unused = mp->br;struct net_bridge_port_group *pg; -struct net_bridge *br = mp->br;
Quoted 6 lines
net/bridge/br_multicast.c br_multicast_find_port(struct net_bridge_mdb_entry *mp, · line 1821
Quoted 2 lines
net/bridge/br_multicast.c +0
-0for (pg = mlock_dereference(mp->ports, br); pg;That's a lazy fix :( Is everyone using lockdep annotations going to sprinkle
__maybe_unusedthroughout the code? Macros should also always evaluate their arguments.
When the local variable's only used for lockdep, I guess. :)
Here we don't actually need it at all, alternatively we can just drop it and use mp->br.