Skip to contentSkip to conversation

dt-bindings: mailbox: fsl,mu: Fix i.MX 8QXP compatible matching

PATCH Applied Krzysztof Kozlowski 2 participants 6 messages Sep 3, 2020 – Nov 10, 2020

Subsystems (2)
Device tree bindings Mailbox API
lore
Share & tools
lore

Krzysztof Kozlowski

author
#0 lore raw

PATCH v2 1/3 dt-bindings: mailbox: fsl,mu: Fix i.MX 8QXP compatible matching

The Mailbox on i.MX 8QXP (fsl,imx8qxp-mu) can also be compatible with fsl,imx8-mu-scu (for fast IPC) so adjust the compatibles to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: mailbox@5d1f0000:
compatible: ['fsl,imx8-mu-scu', 'fsl,imx8qxp-mu', 'fsl,imx6sx-mu'] is not valid under any of the given schemas (Possible causes of the failure):

arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: mailbox@5d1f0000:

    compatible: ['fsl,imx8-mu-scu', 'fsl,imx8qxp-mu', 'fsl,imx6sx-mu'] is too long
Signed-off-by Krzysztof Kozlowski <[email protected]>

---

Changes since v1:
1. None

---
 Documentation/devicetree/bindings/mailbox/fsl,mu.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/mailbox/fsl,mu.yaml +2 -1
index 8a3470b64d06..7ed096360be2 100644
@@ -38,8 +38,9 @@ properties:
           - const: fsl,imx6sx-mu
       - description: To communicate with i.MX8 SCU with fast IPC
         items:
-          - const: fsl,imx8qxp-mu
           - const: fsl,imx8-mu-scu
+          - const: fsl,imx8qxp-mu
+          - const: fsl,imx6sx-mu
 
   reg:
     maxItems: 1
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH v2 2/3 dt-bindings: mailbox: fsl,mu: Add missing power-domains

Add quite common property - power-domains - to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml:

    mailbox@5d280000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by Krzysztof Kozlowski <[email protected]>

---

Changes since v1:
1. Add missing properties instead of unevaluatedProperties

---
 Documentation/devicetree/bindings/mailbox/fsl,mu.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/mailbox/fsl,mu.yaml +2 -0
index 7ed096360be2..e372dcce8037 100644
@@ -72,6 +72,8 @@ properties:
     description: boolean, if present, means it is for side B MU.
     type: boolean
 
+  power-domains: true
+
 required:
   - compatible
   - reg
Signature · 1 line
2.17.1
maintainer
#2 lore raw

Re: [PATCH v2 2/3] dt-bindings: mailbox: fsl,mu: Add missing power-domains

Quoted 21 lines · Krzysztof Kozlowski

Add quite common property - power-domains - to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml:

    mailbox@5d280000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by Krzysztof Kozlowski <[email protected]>

---

Changes since v1:
1. Add missing properties instead of unevaluatedProperties

---
 Documentation/devicetree/bindings/mailbox/fsl,mu.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/mailbox/fsl,mu.yaml +0 -0
index 7ed096360be2..e372dcce8037 100644

Documentation/devicetree/bindings/mailbox/fsl,mu.yaml properties: · line 75

Quoted 4 lines
Documentation/devicetree/bindings/mailbox/fsl,mu.yaml +1 -0
@@ -72,6 +72,8 @@ properties:
     description: boolean, if present, means it is for side B MU.
     type: boolean
 
+  power-domains: true

How many?

Quoted 7 lines
Documentation/devicetree/bindings/mailbox/fsl,mu.yaml +1 -0
+
 required:
   - compatible
   - reg
Signature · 1 line
2.17.1
author
#3 lore raw

PATCH v2 3/3 MAINTAINERS: Add dt-bindings to mailbox entry

In reply to Krzysztof Kozlowski

Cover the dt-bindings of mailbox drivers by mailbox maintainers entry.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---

Changes since v1:
1. New patch

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index bb0cb31d323b..d3d8dedbaf22 100644
@@ -10417,6 +10417,7 @@ MAILBOX API
 M:	Jassi Brar <[email protected]>
 L:	[email protected]
 S:	Maintained
+F:	Documentation/devicetree/bindings/mailbox/
 F:	drivers/mailbox/
 F:	include/linux/mailbox_client.h
 F:	include/linux/mailbox_controller.h
Signature · 1 line
2.17.1
author
#4 lore raw

Re: [PATCH v2 3/3] MAINTAINERS: Add dt-bindings to mailbox entry

Quoted 8 lines · Krzysztof Kozlowski

Cover the dt-bindings of mailbox drivers by mailbox maintainers entry.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---

Changes since v1:
1. New patch

Jassi,

Any comments on this patch?

Best regards,
Krzysztof

maintainer Applied
#5 lore raw
In reply to Krzysztof Kozlowski
Quoted 13 lines · Krzysztof Kozlowski

The Mailbox on i.MX 8QXP (fsl,imx8qxp-mu) can also be compatible with fsl,imx8-mu-scu (for fast IPC) so adjust the compatibles to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: mailbox@5d1f0000:
compatible: ['fsl,imx8-mu-scu', 'fsl,imx8qxp-mu', 'fsl,imx6sx-mu'] is not valid under any of the given schemas (Possible causes of the failure):

arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: mailbox@5d1f0000:

    compatible: ['fsl,imx8-mu-scu', 'fsl,imx8qxp-mu', 'fsl,imx6sx-mu'] is too long
Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 8 lines

---

Changes since v1:
1. None

---
 Documentation/devicetree/bindings/mailbox/fsl,mu.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks!