libbpf: fix a compilation error with xsk.c for ubuntu 16.04
Subsystems (4)
PATCH 1/1 libbpf: fix a compilation error with xsk.c for ubuntu 16.04
When syncing latest libbpf repo to bcc, ubuntu 16.04 (4.4.0 LTS kernel) failed compilation for xsk.c:
In file included from /tmp/debuild.0jkauG/bcc/src/cc/libbpf/src/xsk.c:23:0:
/tmp/debuild.0jkauG/bcc/src/cc/libbpf/src/xsk.c: In function ‘xsk_get_ctx’:
/tmp/debuild.0jkauG/bcc/src/cc/libbpf/include/linux/list.h:81:9: warning: implicit declaration of function ‘container_of’ [-Wimplicit-function-declaration]
container_of(ptr, type, member)
^
/tmp/debuild.0jkauG/bcc/src/cc/libbpf/include/linux/list.h:83:9: note: in expansion of macro ‘list_entry’
list_entry((ptr)->next, type, member)
...
src/cc/CMakeFiles/bpf-static.dir/build.make:209: recipe for target 'src/cc/CMakeFiles/bpf-static.dir/libbpf/src/xsk.c.o' failed
Commit 2f6324a3937f ("libbpf: Support shared umems between queues and devices") added include file <linux/list.h>, which uses macro "container_of". xsk.c file also includes <linux/ethtool.h> before <linux/list.h>.
In a more recent distro kernel, <linux/ethtool.h> includes <linux/kernel.h> which contains the macro definition for "container_of". So compilation is all fine. But in ubuntu 16.04 kernel, <linux/ethtool.h> does not contain <linux/kernel.h> which caused the above compilation error.
Let explicitly add <linux/kernel.h> in xsk.c to avoid compilation error in old distro's.
--- tools/lib/bpf/xsk.c | 1 + 1 file changed, 1 insertion(+)
tools/lib/bpf/xsk.c +1 -0
@@ -20,6 +20,7 @@#include <linux/if_ether.h> #include <linux/if_packet.h> #include <linux/if_xdp.h> +#include <linux/kernel.h> #include <linux/list.h> #include <linux/sockios.h> #include <net/if.h>
Signature · 1 line
2.24.1
Quoted 25 lines · Yonghong Song
When syncing latest libbpf repo to bcc, ubuntu 16.04 (4.4.0 LTS kernel) failed compilation for
xsk.c:
In file included from/tmp/debuild.0jkauG/bcc/src/cc/libbpf/src/xsk.c:23:0:
/tmp/debuild.0jkauG/bcc/src/cc/libbpf/src/xsk.c: In function ‘xsk_get_ctx’:
/tmp/debuild.0jkauG/bcc/src/cc/libbpf/include/linux/list.h:81:9: warning: implicit declaration of function ‘container_of’ [-Wimplicit-function-declaration]
container_of(ptr, type, member)
^
/tmp/debuild.0jkauG/bcc/src/cc/libbpf/include/linux/list.h:83:9: note: in expansion of macro ‘list_entry’list_entry((ptr)->next, type, member)...
src/cc/CMakeFiles/bpf-static.dir/build.make:209: recipe for target 'src/cc/CMakeFiles/bpf-static.dir/libbpf/src/xsk.c.o' failedCommit
2f6324a3937f("libbpf: Support shared umems between queues and devices") added include file <linux/list.h>, which uses macro "container_of".xsk.cfile also includes <linux/ethtool.h> before <linux/list.h>.In a more recent distro kernel, <
linux/ethtool.h> includes <linux/kernel.h> which contains the macro definition for "container_of". So compilation is all fine. But in ubuntu 16.04 kernel, <linux/ethtool.h> does not contain <linux/kernel.h> which caused the above compilation error.
Quoted 6 lines
Let explicitly add <
linux/kernel.h> inxsk.cto avoid compilation error in old distro's.Fixes 2f6324a3937f ("libbpf: Support shared umems between queues and devices")Signed-off-by Yonghong Song <[email protected]>---
Quoted 18 lines
tools/lib/bpf/xsk.c | 1 + 1 file changed, 1 insertion(+)tools/lib/bpf/xsk.c +1
-1@@ -20,6 +20,7 @@#include <linux/if_ether.h> #include <linux/if_packet.h> #include <linux/if_xdp.h> +#include <linux/kernel.h> #include <linux/list.h> #include <linux/sockios.h> #include <net/if.h> --2.24.1
Quoted 27 lines · Andrii Nakryiko
Quoted 25 lines · Yonghong Song
When syncing latest libbpf repo to bcc, ubuntu 16.04 (4.4.0 LTS kernel) failed compilation for
xsk.c:
In file included from/tmp/debuild.0jkauG/bcc/src/cc/libbpf/src/xsk.c:23:0:
/tmp/debuild.0jkauG/bcc/src/cc/libbpf/src/xsk.c: In function ‘xsk_get_ctx’:
/tmp/debuild.0jkauG/bcc/src/cc/libbpf/include/linux/list.h:81:9: warning: implicit declaration of function ‘container_of’ [-Wimplicit-function-declaration]
container_of(ptr, type, member)
^
/tmp/debuild.0jkauG/bcc/src/cc/libbpf/include/linux/list.h:83:9: note: in expansion of macro ‘list_entry’list_entry((ptr)->next, type, member)...
src/cc/CMakeFiles/bpf-static.dir/build.make:209: recipe for target 'src/cc/CMakeFiles/bpf-static.dir/libbpf/src/xsk.c.o' failedCommit
2f6324a3937f("libbpf: Support shared umems between queues and devices") added include file <linux/list.h>, which uses macro "container_of".xsk.cfile also includes <linux/ethtool.h> before <linux/list.h>.In a more recent distro kernel, <
linux/ethtool.h> includes <linux/kernel.h> which contains the macro definition for "container_of". So compilation is all fine. But in ubuntu 16.04 kernel, <linux/ethtool.h> does not contain <linux/kernel.h> which caused the above compilation error.
Quoted 8 lines
Quoted 6 lines
Let explicitly add <
linux/kernel.h> inxsk.cto avoid compilation error in old distro's.Fixes 2f6324a3937f ("libbpf: Support shared umems between queues and devices")Signed-off-by Yonghong Song <[email protected]>---
Acked-by Andrii Nakryiko <[email protected]>
Alexei Starovoitov
AppliedQuoted 33 lines · Song Liu
Quoted 30 lines · Andrii Nakryiko
Quoted 28 lines · Yonghong Song
When syncing latest libbpf repo to bcc, ubuntu 16.04 (4.4.0 LTS kernel) failed compilation for
xsk.c:
In file included from/tmp/debuild.0jkauG/bcc/src/cc/libbpf/src/xsk.c:23:0:
/tmp/debuild.0jkauG/bcc/src/cc/libbpf/src/xsk.c: In function ‘xsk_get_ctx’:
/tmp/debuild.0jkauG/bcc/src/cc/libbpf/include/linux/list.h:81:9: warning: implicit declaration of function ‘container_of’ [-Wimplicit-function-declaration]
container_of(ptr, type, member)
^
/tmp/debuild.0jkauG/bcc/src/cc/libbpf/include/linux/list.h:83:9: note: in expansion of macro ‘list_entry’list_entry((ptr)->next, type, member)...
src/cc/CMakeFiles/bpf-static.dir/build.make:209: recipe for target 'src/cc/CMakeFiles/bpf-static.dir/libbpf/src/xsk.c.o' failedCommit
2f6324a3937f("libbpf: Support shared umems between queues and devices") added include file <linux/list.h>, which uses macro "container_of".xsk.cfile also includes <linux/ethtool.h> before <linux/list.h>.In a more recent distro kernel, <
linux/ethtool.h> includes <linux/kernel.h> which contains the macro definition for "container_of". So compilation is all fine. But in ubuntu 16.04 kernel, <linux/ethtool.h> does not contain <linux/kernel.h> which caused the above compilation error.Let explicitly add <
linux/kernel.h> inxsk.cto avoid compilation error in old distro's.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Fixes 2f6324a3937f ("libbpf: Support shared umems between queues and devices")Signed-off-by Yonghong Song <[email protected]>---
Acked-by Andrii Nakryiko <[email protected]>Acked-by Song Liu <[email protected]>
Applied. Thanks