Skip to contentSkip to conversation

MAINTAINERS changes related to netvsc

PATCH In review Stephen Hemminger 3 participants 10 messages Sep 15, 2020 – Nov 28, 2020

lore
Share & tools
lore
#0 lore raw

cover MAINTAINERS changes related to netvsc

Breakout three small changes to netvsc maintainers

Stephen Hemminger (3):
MAINTAINERS remove experimental tag from vdev_netvsc MAINTAINERS - drop Kys and Haiyang MAINTAINERS - remove expermental tag of netvsd PMD

 MAINTAINERS | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/3 MAINTAINERS remove experimental tag from vdev_netvsc

Vdev_netvsc has been around for several years. It no longer needs to be marked experimental.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index 3b16d7a4b8c8..32db0996181f 100644
@@ -768,7 +768,7 @@ F: buildtools/options-ibverbs-static.sh
 F: doc/guides/nics/mlx5.rst
 F: doc/guides/nics/features/mlx5.ini
 
-Microsoft vdev_netvsc - EXPERIMENTAL
+Microsoft vdev_netvsc
 M: Matan Azrad <[email protected]>
 F: drivers/net/vdev_netvsc/
 F: doc/guides/nics/vdev_netvsc.rst
Signature · 1 line
2.27.0
#2 lore raw

Re: [dpdk-dev] [PATCH 1/3] MAINTAINERS remove experimental tag from vdev_netvsc

Quoted 14 lines · Stephen Hemminger

Vdev_netvsc has been around for several years. It no longer needs to be marked experimental.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index 3b16d7a4b8c8..32db0996181f 100644

MAINTAINERS F: buildtools/options-ibverbs-static.sh · line 774

Quoted 8 lines
MAINTAINERS +1 -1
@@ -768,7 +768,7 @@ F: buildtools/options-ibverbs-static.sh
 F: doc/guides/nics/mlx5.rst
 F: doc/guides/nics/features/mlx5.ini
 
-Microsoft vdev_netvsc - EXPERIMENTAL
+Microsoft vdev_netvsc
 M: Matan Azrad <[email protected]>
 F: drivers/net/vdev_netvsc/
 F: doc/guides/nics/vdev_netvsc.rst

As far as I remember 'vdev_netvsc' was interim solution until 'netvsc' was ready. In this patchset 'netvsc' is also becoming mature.

Wouldn't be easier to keep 'vdev_netvsc' experimental to be able to remove it soon?

#3 lore raw

Re: [dpdk-dev] [PATCH 1/3] MAINTAINERS remove experimental tag from vdev_netvsc

Quoted 27 lines · On Tue, 15 Sep 2020 10:42:07 +0100 Ferruh Yigit <[email protected]> wrote:
Quoted 14 lines · Stephen Hemminger

Vdev_netvsc has been around for several years. It no longer needs to be marked experimental.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index 3b16d7a4b8c8..32db0996181f 100644

MAINTAINERS F: buildtools/options-ibverbs-static.sh · line 774

Quoted 8 lines
MAINTAINERS +1 -1
@@ -768,7 +768,7 @@ F: buildtools/options-ibverbs-static.sh
 F: doc/guides/nics/mlx5.rst
 F: doc/guides/nics/features/mlx5.ini
 
-Microsoft vdev_netvsc - EXPERIMENTAL
+Microsoft vdev_netvsc
 M: Matan Azrad <[email protected]>
 F: drivers/net/vdev_netvsc/
 F: doc/guides/nics/vdev_netvsc.rst

As far as I remember 'vdev_netvsc' was interim solution until 'netvsc' was ready. In this patchset 'netvsc' is also becoming mature.

Quoted 2 lines

Wouldn't be easier to keep 'vdev_netvsc' experimental to be able to remove it soon?

Let me discuss with Long Li and management. Maybe replace EXPERIMENTAL with DEPRECATED in 20.11.

#4 lore raw

Re: [dpdk-dev] [PATCH 1/3] MAINTAINERS remove experimental tag from vdev_netvsc

15/09/2020 16:47, Stephen Hemminger:

Quoted 16 lines
Quoted 15 lines · Ferruh Yigit

MAINTAINERS F: buildtools/options-ibverbs-static.sh · line 774

Quoted 10 lines · Stephen Hemminger

Vdev_netvsc has been around for several years. It no longer needs to be marked experimental.

---

MAINTAINERS +1 -1
-Microsoft vdev_netvsc - EXPERIMENTAL
+Microsoft vdev_netvsc
 M: Matan Azrad <[email protected]>
 F: drivers/net/vdev_netvsc/
 F: doc/guides/nics/vdev_netvsc.rst

As far as I remember 'vdev_netvsc' was interim solution until 'netvsc' was ready. In this patchset 'netvsc' is also becoming mature.

Quoted 5 lines
Quoted 2 lines

Wouldn't be easier to keep 'vdev_netvsc' experimental to be able to remove it soon?

Let me discuss with Long Li and management. Maybe replace EXPERIMENTAL with DEPRECATED in 20.11.

Would be strange to switch from experimental to deprecated :)

+Cc Matan

I think you still need this platform driver (with failsafe and tap) in case you need rte_flow. Or is it well supported with netvsc PMD?

#5 lore raw

Re: [dpdk-dev] [PATCH 1/3] MAINTAINERS remove experimental tag from vdev_netvsc

06/10/2020 00:41, Thomas Monjalon:

Quoted 23 lines

15/09/2020 16:47, Stephen Hemminger:

Quoted 16 lines
Quoted 15 lines · Ferruh Yigit

MAINTAINERS F: buildtools/options-ibverbs-static.sh · line 774

Quoted 10 lines · Stephen Hemminger

Vdev_netvsc has been around for several years. It no longer needs to be marked experimental.

---

MAINTAINERS +1 -1
-Microsoft vdev_netvsc - EXPERIMENTAL
+Microsoft vdev_netvsc
 M: Matan Azrad <[email protected]>
 F: drivers/net/vdev_netvsc/
 F: doc/guides/nics/vdev_netvsc.rst

As far as I remember 'vdev_netvsc' was interim solution until 'netvsc' was ready. In this patchset 'netvsc' is also becoming mature.

Quoted 5 lines
Quoted 2 lines

Wouldn't be easier to keep 'vdev_netvsc' experimental to be able to remove it soon?

Let me discuss with Long Li and management. Maybe replace EXPERIMENTAL with DEPRECATED in 20.11.

Quoted 6 lines

Would be strange to switch from experimental to deprecated :)

+Cc Matan

I think you still need this platform driver (with failsafe and tap) in case you need rte_flow. Or is it well supported with netvsc PMD?

No update...
I classify this patch as rejected.

#6 lore raw

Re: [dpdk-dev] [PATCH 1/3] MAINTAINERS remove experimental tag from vdev_netvsc

In reply to Thomas Monjalon
Quoted 23 lines · On Tue, 06 Oct 2020 00:41:55 +0200 Thomas Monjalon <[email protected]> wrote:

15/09/2020 16:47, Stephen Hemminger:

Quoted 16 lines
Quoted 15 lines · Ferruh Yigit

MAINTAINERS F: buildtools/options-ibverbs-static.sh · line 774

Quoted 10 lines · Stephen Hemminger

Vdev_netvsc has been around for several years. It no longer needs to be marked experimental.

---

MAINTAINERS +1 -1
-Microsoft vdev_netvsc - EXPERIMENTAL
+Microsoft vdev_netvsc
 M: Matan Azrad <[email protected]>
 F: drivers/net/vdev_netvsc/
 F: doc/guides/nics/vdev_netvsc.rst  

As far as I remember 'vdev_netvsc' was interim solution until 'netvsc' was ready. In this patchset 'netvsc' is also becoming mature.

Quoted 5 lines
Quoted 2 lines

Wouldn't be easier to keep 'vdev_netvsc' experimental to be able to remove it soon?

Let me discuss with Long Li and management. Maybe replace EXPERIMENTAL with DEPRECATED in 20.11.

Quoted 6 lines

Would be strange to switch from experimental to deprecated :)

+Cc Matan

I think you still need this platform driver (with failsafe and tap) in case you need rte_flow. Or is it well supported with netvsc PMD?

This needs more discussion. Netvsc PMD does not support rte_flow because there is not a good/complete implementation of rte_flow library in pure software form. It might be possible using the BPF stuff that tap supports.

I do not know of anybody who is using vdev_netvsc/failsafe with rte_flow. Part of the problem is that the TAP implementation of rte_flow supports a much smaller subset of features than the VF device (MLX).

#7 lore raw

PATCH 2/3 MAINTAINERS - drop Kys and Haiyang

In reply to Stephen Hemminger

These two maintainers deal with the Linux side of netvsc and are not relevant for DPDK.

---
 MAINTAINERS | 2 --
 1 file changed, 2 deletions(-)
MAINTAINERS +0 -2
index 32db0996181f..e3e70c25560d 100644
@@ -775,8 +775,6 @@ F: doc/guides/nics/vdev_netvsc.rst
 
 Microsoft Hyper-V netvsc - EXPERIMENTAL
 M: Stephen Hemminger <[email protected]>
-M: K. Y. Srinivasan <[email protected]>
-M: Haiyang Zhang <[email protected]>
 M: Long Li <[email protected]>
 F: drivers/net/netvsc/
 F: doc/guides/nics/netvsc.rst
Signature · 1 line
2.27.0
#8 lore raw

PATCH 3/3 MAINTAINERS - remove expermental tag of netvsd PMD

In reply to Stephen Hemminger

With Long's help the driver is now stable enough for real usage.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index e3e70c25560d..d9717c1997e6 100644
@@ -773,7 +773,7 @@ M: Matan Azrad <[email protected]>
 F: drivers/net/vdev_netvsc/
 F: doc/guides/nics/vdev_netvsc.rst
 
-Microsoft Hyper-V netvsc - EXPERIMENTAL
+Microsoft Hyper-V netvsc
 M: Stephen Hemminger <[email protected]>
 M: Long Li <[email protected]>
 F: drivers/net/netvsc/
Signature · 1 line
2.27.0
#9 lore raw
In reply to Stephen Hemminger

15/09/2020 04:03, Stephen Hemminger:

Quoted 6 lines

Breakout three small changes to netvsc maintainers

Stephen Hemminger (3):
MAINTAINERS remove experimental tag from vdev_netvsc MAINTAINERS - drop Kys and Haiyang MAINTAINERS - remove expermental tag of netvsd PMD

Squashed patches 2 and 3, and rejected patch 1 because of no reply.