spi: xilinx: Fix info message during probe
Subsystems (2)
PATCH 1/1 spi: xilinx: Fix info message during probe
The info message was showing the mapped address of the device. To avoid security problems, all virtual addresses are converted to __ptrval__, so the message was useless/ugly:
[ 2.304949] xilinx_spi b0010000.spi-flash: at 0xB0010000 mapped to 0x(____ptrval____), irq=37
Use %pR instead:
[ 15.021354] xilinx_spi b0010000.spi-flash: at [mem 0xb0010000-0xb001ffff], irq=37
--- drivers/spi/spi-xilinx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/spi/spi-xilinx.c +1 -2
@@ -491,8 +491,7 @@ static int xilinx_spi_probe(struct platform_device *pdev) goto put_master; } -dev_info (&pdev->dev,"at 0x%08llX mapped to 0x%p, irq=%d\n" , - (unsigned long long )res->start, xspi->regs, xspi->irq); +dev_info (&pdev->dev,"at %pR, irq=%d\n" , res, xspi->irq);if (pdata) {for (i =0 ; i < pdata->num_devices; i++)
Signature · 7 lines
2.28.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 21 lines · Ricardo Ribalda
The info message was showing the mapped address of the device. To avoid security problems, all virtual addresses are converted to
__ptrval__, so the message was useless/ugly:[ 2.304949] xilinx_spi b0010000.spi-flash: at 0xB0010000 mapped to 0x(____ptrval____), irq=37Use %pR instead:
[ 15.021354] xilinx_spi b0010000.spi-flash: at [mem 0xb0010000-0xb001ffff], irq=37Signed-off-by Ricardo Ribalda <[email protected]>--- drivers/spi/spi-xilinx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/spi/spi-xilinx.c +0
-0
drivers/spi/spi-xilinx.c static int xilinx_spi_probe(struct platform_device *pdev) · line 497
Quoted 9 lines
drivers/spi/spi-xilinx.c +1
-2@@ -491,8 +491,7 @@ static int xilinx_spi_probe(struct platform_device *pdev) goto put_master; } -dev_info (&pdev->dev,"at 0x%08llX mapped to 0x%p, irq=%d\n" , - (unsigned long long )res->start, xspi->regs, xspi->irq); +dev_info (&pdev->dev,"at %pR, irq=%d\n" , res, xspi->irq);if (pdata) {for (i =0 ; i < pdata->num_devices; i++)
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Mark Brown
maintainerQuoted 9 lines · Ricardo Ribalda
The info message was showing the mapped address of the device. To avoid security problems, all virtual addresses are converted to
__ptrval__, so the message was useless/ugly:[ 2.304949] xilinx_spi b0010000.spi-flash: at 0xB0010000 mapped to 0x(____ptrval____), irq=37Use %pR instead:
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: xilinx: Fix info message during probe
commit: 985be7ebfbf79767bc3705eee7de635edd4eba7d
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel