PCI: rpadlpar: use for_each_child_of_node() and for_each_node_by_name
PATCH 1/1 PCI: rpadlpar: use for_each_child_of_node() and for_each_node_by_name
Use for_each_child_of_node() and for_each_node_by_name macro instead of open coding it.
Signed-off-by Qinglang Miao <[email protected]>
--- drivers/pci/hotplug/rpadlpar_core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/pci/hotplug/rpadlpar_core.c +4 -4
@@ -40,13 +40,13 @@ static DEFINE_MUTEX(rpadlpar_mutex);static struct device_node *find_vio_slot_node (char *drc_name) {struct device_node *parent =of_find_node_by_name (NULL ,"vdevice" ); -struct device_node *dn =NULL ; +struct device_node *dn;int rc;if (!parent)return NULL ; -while ((dn =of_get_next_child (parent, dn))) { +for_each_child_of_node (parent, dn) { rc =rpaphp_check_drc_props (dn, drc_name,NULL );if (rc ==0 )break ;
@@ -60,10 +60,10 @@ static struct device_node *find_vio_slot_node(char *drc_name)static struct device_node *find_php_slot_pci_node (char *drc_name,char *drc_type) { -struct device_node *np =NULL ; +struct device_node *np;int rc; -while ((np =of_find_node_by_name (np,"pci" ))) { +for_each_node_by_name (np,"pci" ) { rc =rpaphp_check_drc_props (np, drc_name, drc_type);if (rc ==0 )break ;
Signature · 1 line
2.23.0
Bjorn Helgaas
AppliedQuoted 4 lines · Qinglang Miao
Use
for_each_child_of_node()andfor_each_node_by_namemacro instead of open coding it.Signed-off-by Qinglang Miao <[email protected]>
Applied to pci/hotplug for v5.10, thanks!
Quoted 40 lines
--- drivers/pci/hotplug/rpadlpar_core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/pci/hotplug/rpadlpar_core.c +4
-4@@ -40,13 +40,13 @@ static DEFINE_MUTEX(rpadlpar_mutex);static struct device_node *find_vio_slot_node (char *drc_name) {struct device_node *parent =of_find_node_by_name (NULL ,"vdevice" ); -struct device_node *dn =NULL ; +struct device_node *dn;int rc;if (!parent)return NULL ; -while ((dn =of_get_next_child (parent, dn))) { +for_each_child_of_node (parent, dn) { rc =rpaphp_check_drc_props (dn, drc_name,NULL );if (rc ==0 )break ;@@ -60,10 +60,10 @@ static struct device_node *find_vio_slot_node(char *drc_name)static struct device_node *find_php_slot_pci_node (char *drc_name,char *drc_type) { -struct device_node *np =NULL ; +struct device_node *np;int rc; -while ((np =of_find_node_by_name (np,"pci" ))) { +for_each_node_by_name (np,"pci" ) { rc =rpaphp_check_drc_props (np, drc_name, drc_type);if (rc ==0 )break ;Signature · 1 line
2.23.0