Skip to contentSkip to conversation

Add support for custom names for AT24 EEPROMs

PATCH Applied Jon Hunter 4 participants 15 messages Sep 16, 2020 – Sep 24, 2020

Subsystems (5)
lore
Share & tools
lore

Jon Hunter

author maintainer
#0 lore raw

v2 cover Add support for custom names for AT24 EEPROMs

For platforms that have multiple boards and hence have multiple EEPROMs for identifying the different boards, it is useful to label the EEPROMs in device-tree so that they can be easily identified. For example, MAC address information is stored in the EEPROM on the processor module for some Jetson platforms which is not only required by the kernel but the bootloader as well. So having a simple way to identify the EEPROM is needed.

Changes since V1:
- By default initialise the nvmem_config.id as NVMEM_DEVID_AUTO and not NVMEM_DEVID_NONE
- Dropped the 'maxItems' from the dt-binding doc.

Jon Hunter (5):
misc: eeprom: at24: Initialise AT24 NVMEM ID field
dt-bindings: eeprom: at24: Add label property for AT24
misc: eeprom: at24: Support custom device names for AT24 EEPROMs
arm64: tegra: Add label properties for EEPROMs
arm64: tegra: Populate EEPROMs for Jetson Xavier NX

 .../devicetree/bindings/eeprom/at24.yaml      |  3 +++
 .../boot/dts/nvidia/tegra186-p2771-0000.dts   |  1 +
 .../arm64/boot/dts/nvidia/tegra186-p3310.dtsi |  1 +
 .../arm64/boot/dts/nvidia/tegra194-p2888.dtsi |  1 +
 .../boot/dts/nvidia/tegra194-p2972-0000.dts   |  1 +
 .../nvidia/tegra194-p3509-0000+p3668-0000.dts | 14 ++++++++++++
 .../boot/dts/nvidia/tegra194-p3668-0000.dtsi  | 16 ++++++++++++++
 .../arm64/boot/dts/nvidia/tegra210-p2180.dtsi |  1 +
 .../boot/dts/nvidia/tegra210-p2371-2180.dts   |  1 +
 .../boot/dts/nvidia/tegra210-p3450-0000.dts   |  2 ++
 drivers/misc/eeprom/at24.c                    | 22 ++++++++++++++++++-
 11 files changed, 62 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.1
author maintainer
#1 lore raw

PATCH v2 1/5 misc: eeprom: at24: Initialise AT24 NVMEM ID field

The AT24 EEPROM driver does not initialise the 'id' field of the nvmem_config structure and because the entire structure is not initialised, it ends up with a random value. This causes the NVMEM driver to append the device 'devid' value to name of the NVMEM device. Ideally for I2C devices such as the AT24 that already have a unique name, we would not bother to append the 'devid'. However, given that this has always been done for AT24 devices, we cannot remove the 'devid' as this will change the name of the userspace sysfs node for the NVMEM device. Nonetheless we should ensure that the 'id' field of the nvmem_config structure is initialised so that there is no chance of a random value causes problems in the future. Therefore, set the NVMEM config.id to NVMEM_DEVID_AUTO for AT24 EEPROMs so that the 'devid' is always appended.

---
 drivers/misc/eeprom/at24.c | 1 +
 1 file changed, 1 insertion(+)
drivers/misc/eeprom/at24.c +1 -0
index e9df1ca251df..f76624b5c033 100644
@@ -715,6 +715,7 @@ static int at24_probe(struct i2c_client *client)
 
 	nvmem_config.name = dev_name(dev);
 	nvmem_config.dev = dev;
+	nvmem_config.id = NVMEM_DEVID_AUTO;
 	nvmem_config.read_only = !writable;
 	nvmem_config.root_only = !(flags & AT24_FLAG_IRUGO);
 	nvmem_config.owner = THIS_MODULE;
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH V2 1/5] misc: eeprom: at24: Initialise AT24 NVMEM ID field

Quoted 33 lines · Jon Hunter

The AT24 EEPROM driver does not initialise the 'id' field of the nvmem_config structure and because the entire structure is not initialised, it ends up with a random value. This causes the NVMEM driver to append the device 'devid' value to name of the NVMEM device. Ideally for I2C devices such as the AT24 that already have a unique name, we would not bother to append the 'devid'. However, given that this has always been done for AT24 devices, we cannot remove the 'devid' as this will change the name of the userspace sysfs node for the NVMEM device. Nonetheless we should ensure that the 'id' field of the nvmem_config structure is initialised so that there is no chance of a random value causes problems in the future. Therefore, set the NVMEM config.id to NVMEM_DEVID_AUTO for AT24 EEPROMs so that the 'devid' is always appended.

---
 drivers/misc/eeprom/at24.c | 1 +
 1 file changed, 1 insertion(+)
drivers/misc/eeprom/at24.c +1 -1
index e9df1ca251df..f76624b5c033 100644
@@ -715,6 +715,7 @@ static int at24_probe(struct i2c_client *client)
 
        nvmem_config.name = dev_name(dev);
        nvmem_config.dev = dev;
+       nvmem_config.id = NVMEM_DEVID_AUTO;
        nvmem_config.read_only = !writable;
        nvmem_config.root_only = !(flags & AT24_FLAG_IRUGO);
        nvmem_config.owner = THIS_MODULE;
--
Quoted 2 lines

2.25.1

Ha! I only now noticed I already have a patch for this in my tree from Vadym Kochan for this cycle. I'll drop this one.

Bartosz

#3 lore raw

Re: [PATCH V2 1/5] misc: eeprom: at24: Initialise AT24 NVMEM ID field

Quoted 41 lines · Bartosz Golaszewski
Quoted 33 lines · Jon Hunter

The AT24 EEPROM driver does not initialise the 'id' field of the nvmem_config structure and because the entire structure is not initialised, it ends up with a random value. This causes the NVMEM driver to append the device 'devid' value to name of the NVMEM device. Ideally for I2C devices such as the AT24 that already have a unique name, we would not bother to append the 'devid'. However, given that this has always been done for AT24 devices, we cannot remove the 'devid' as this will change the name of the userspace sysfs node for the NVMEM device. Nonetheless we should ensure that the 'id' field of the nvmem_config structure is initialised so that there is no chance of a random value causes problems in the future. Therefore, set the NVMEM config.id to NVMEM_DEVID_AUTO for AT24 EEPROMs so that the 'devid' is always appended.

---
 drivers/misc/eeprom/at24.c | 1 +
 1 file changed, 1 insertion(+)
drivers/misc/eeprom/at24.c +1 -1
index e9df1ca251df..f76624b5c033 100644
@@ -715,6 +715,7 @@ static int at24_probe(struct i2c_client *client)
 
        nvmem_config.name = dev_name(dev);
        nvmem_config.dev = dev;
+       nvmem_config.id = NVMEM_DEVID_AUTO;
        nvmem_config.read_only = !writable;
        nvmem_config.root_only = !(flags & AT24_FLAG_IRUGO);
        nvmem_config.owner = THIS_MODULE;
--
Quoted 2 lines

2.25.1

Ha! I only now noticed I already have a patch for this in my tree from Vadym Kochan for this cycle. I'll drop this one.

Quoted 1 line

Bartosz

-ETOOEARLY, nevermind my comment, it's for a different issue. I queued this for v5.10.

Thanks!
Bartosz

author maintainer
#4 lore raw

PATCH v2 2/5 dt-bindings: eeprom: at24: Add label property for AT24

In reply to Jon Hunter

Add a label property for the AT24 EEPROM to allow a custom name to be used for identifying the EEPROM on a board. This is useful when there is more than one EEPROM present.

---
 Documentation/devicetree/bindings/eeprom/at24.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/eeprom/at24.yaml +3 -0
index 4cee72d53318..6edfa705b486 100644
@@ -114,6 +114,9 @@ properties:
           - const: renesas,r1ex24128
           - const: atmel,24c128
 
+  label:
+    description: Descriptive name of the EEPROM.
+
   reg:
     maxItems: 1
 
Signature · 1 line
2.25.1
maintainer Reviewed-by on v2 2/5
#5 lore raw

Re: [PATCH V2 2/5] dt-bindings: eeprom: at24: Add label property for AT24

Quoted 9 lines · Jon Hunter

Add a label property for the AT24 EEPROM to allow a custom name to be used for identifying the EEPROM on a board. This is useful when there is more than one EEPROM present.

---
 Documentation/devicetree/bindings/eeprom/at24.yaml | 3 +++
 1 file changed, 3 insertions(+)
#6 lore raw

Re: [PATCH V2 2/5] dt-bindings: eeprom: at24: Add label property for AT24

In reply to Jon Hunter
Quoted 25 lines · Jon Hunter

Add a label property for the AT24 EEPROM to allow a custom name to be used for identifying the EEPROM on a board. This is useful when there is more than one EEPROM present.

---
 Documentation/devicetree/bindings/eeprom/at24.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/eeprom/at24.yaml +3 -1
index 4cee72d53318..6edfa705b486 100644
@@ -114,6 +114,9 @@ properties:
           - const: renesas,r1ex24128
           - const: atmel,24c128
 
+  label:
+    description: Descriptive name of the EEPROM.
+
   reg:
     maxItems: 1
 
--
Quoted 2 lines

2.25.1

Queued for v5.10, thanks!

Bartosz

author maintainer
#7 lore raw

PATCH v2 3/5 misc: eeprom: at24: Support custom device names for AT24 EEPROMs

In reply to Jon Hunter

By using the label property, a more descriptive name can be populated for AT24 EEPROMs NVMEM device. Update the AT24 driver to check to see if the label property is present and if so, use this as the name for NVMEM device. Please note that when the 'label' property is present for the AT24 EEPROM, we do not want the NVMEM driver to append the 'devid' to the name and so the nvmem_config.id is initialised to NVMEM_DEVID_NONE.

---
 drivers/misc/eeprom/at24.c | 23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)
drivers/misc/eeprom/at24.c +21 -2
index f76624b5c033..305f2e13107b 100644
@@ -713,9 +713,28 @@ static int at24_probe(struct i2c_client *client)
 			return err;
 	}
 
-	nvmem_config.name = dev_name(dev);
+	/*
+	 * If the 'label' property is not present for the AT24 EEPROM,
+	 * then nvmem_config.id is initialised to NVMEM_DEVID_AUTO,
+	 * and this will append the 'devid' to the name of the NVMEM
+	 * device. This is purely legacy and the AT24 driver has always
+	 * defaulted to this. However, if the 'label' property is
+	 * present then this means that the name is specified by the
+	 * firmware and this name should be used verbatim and so it is
+	 * not necessary to append the 'devid'.
+	 */
+	if (device_property_present(dev, "label")) {
+		nvmem_config.id = NVMEM_DEVID_NONE;
+		err = device_property_read_string(dev, "label",
+						  &nvmem_config.name);
+		if (err)
+			return err;
+	} else {
+		nvmem_config.id = NVMEM_DEVID_AUTO;
+		nvmem_config.name = dev_name(dev);
+	}
+
 	nvmem_config.dev = dev;
-	nvmem_config.id = NVMEM_DEVID_AUTO;
 	nvmem_config.read_only = !writable;
 	nvmem_config.root_only = !(flags & AT24_FLAG_IRUGO);
 	nvmem_config.owner = THIS_MODULE;
Signature · 1 line
2.25.1
#8 lore raw

Re: [PATCH V2 3/5] misc: eeprom: at24: Support custom device names for AT24 EEPROMs

Quoted 11 lines · Jon Hunter

By using the label property, a more descriptive name can be populated for AT24 EEPROMs NVMEM device. Update the AT24 driver to check to see if the label property is present and if so, use this as the name for NVMEM device. Please note that when the 'label' property is present for the AT24 EEPROM, we do not want the NVMEM driver to append the 'devid' to the name and so the nvmem_config.id is initialised to NVMEM_DEVID_NONE.

---

Queued for v5.10, thanks!

Bartosz

author maintainer
#9 lore raw

PATCH v2 4/5 arm64: tegra: Add label properties for EEPROMs

In reply to Jon Hunter

Populate the label property for the AT24 EEPROMs on the various Jetson platforms. Note that the name 'module' is used to identify the EEPROM on the processor module board and the name 'system' is used to identify the EEPROM on the main base board (which is sometimes referred to as the carrier board).

---
 arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts | 1 +
 arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi     | 1 +
 arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi     | 1 +
 arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 1 +
 arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi     | 1 +
 arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 1 +
 arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts | 2 ++
 7 files changed, 8 insertions(+)
arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts +1 -0
index 802b8c52489a..381a84912ba8 100644
@@ -222,6 +222,7 @@ eeprom@57 {
 			compatible = "atmel,24c02";
 			reg = <0x57>;
 
+			label = "system";
 			vcc-supply = <&vdd_1v8>;
 			address-width = <8>;
 			pagesize = <8>;
arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi +1 -0
index 53d92fdd7f06..fd9177447711 100644
@@ -173,6 +173,7 @@ eeprom@50 {
 			compatible = "atmel,24c02";
 			reg = <0x50>;
 
+			label = "module";
 			vcc-supply = <&vdd_1v8>;
 			address-width = <8>;
 			pagesize = <8>;
arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi +1 -0
index 0ea0bd83cb8e..d71b7a1140fe 100644
@@ -64,6 +64,7 @@ eeprom@50 {
 				compatible = "atmel,24c02";
 				reg = <0x50>;
 
+				label = "module";
 				vcc-supply = <&vdd_1v8ls>;
 				address-width = <8>;
 				pagesize = <8>;
arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts +1 -0
index 4d8a0e10250f..54d057beec59 100644
@@ -28,6 +28,7 @@ eeprom@56 {
 				compatible = "atmel,24c02";
 				reg = <0x56>;
 
+				label = "system";
 				vcc-supply = <&vdd_1v8ls>;
 				address-width = <8>;
 				pagesize = <8>;
arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi +1 -0
index 85ee7e6b71ac..6077d572d828 100644
@@ -273,6 +273,7 @@ eeprom@50 {
 			compatible = "atmel,24c02";
 			reg = <0x50>;
 
+			label = "module";
 			vcc-supply = <&vdd_1v8>;
 			address-width = <8>;
 			pagesize = <8>;
arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts +1 -0
index 56adf287a82c..4c9c2a054642 100644
@@ -86,6 +86,7 @@ eeprom@57 {
 			compatible = "atmel,24c02";
 			reg = <0x57>;
 
+			label = "system";
 			vcc-supply = <&vdd_1v8>;
 			address-width = <8>;
 			pagesize = <8>;
arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts +2 -0
index ba892cd4b5a9..859241db4b4d 100644
@@ -144,6 +144,7 @@ eeprom@50 {
 			compatible = "atmel,24c02";
 			reg = <0x50>;
 
+			label = "module";
 			vcc-supply = <&vdd_1v8>;
 			address-width = <8>;
 			pagesize = <8>;
@@ -155,6 +156,7 @@ eeprom@57 {
 			compatible = "atmel,24c02";
 			reg = <0x57>;
 
+			label = "system";
 			vcc-supply = <&vdd_1v8>;
 			address-width = <8>;
 			pagesize = <8>;
Signature · 1 line
2.25.1
author maintainer
#10 lore raw

PATCH v2 5/5 arm64: tegra: Populate EEPROMs for Jetson Xavier NX

In reply to Jon Hunter

Populate the EEPROMs that are present on the Jetson Xavier NX developer platform.

---
 .../nvidia/tegra194-p3509-0000+p3668-0000.dts    | 14 ++++++++++++++
 .../boot/dts/nvidia/tegra194-p3668-0000.dtsi     | 16 ++++++++++++++++
 2 files changed, 30 insertions(+)
arch/arm64/boot/dts/nvidia/tegra194-p3509-0000+p3668-0000.dts +14 -0
index c1c589805d6b..7f97b34216a0 100644
@@ -27,6 +27,20 @@ ddc: i2c@3190000 {
 			status = "okay";
 		};
 
+		i2c@3160000 {
+			eeprom@57 {
+				compatible = "atmel,24c02";
+				reg = <0x57>;
+
+				label = "system";
+				vcc-supply = <&vdd_1v8>;
+				address-width = <8>;
+				pagesize = <8>;
+				size = <256>;
+				read-only;
+			};
+		};
+
 		hda@3510000 {
 			nvidia,model = "jetson-xavier-nx-hda";
 			status = "okay";
arch/arm64/boot/dts/nvidia/tegra194-p3668-0000.dtsi +16 -0
index 10cb836aea7e..a2893be80507 100644
@@ -58,6 +58,22 @@ serial@c280000 {
 			status = "okay";
 		};
 
+		i2c@3160000 {
+			status = "okay";
+
+			eeprom@50 {
+				compatible = "atmel,24c02";
+				reg = <0x50>;
+
+				label = "module";
+				vcc-supply = <&vdd_1v8ls>;
+				address-width = <8>;
+				pagesize = <8>;
+				size = <256>;
+				read-only;
+			};
+		};
+
 		/* SDMMC1 (SD/MMC) */
 		mmc@3400000 {
 			status = "okay";
Signature · 1 line
2.25.1
#11 lore raw
In reply to Jon Hunter
Quoted 34 lines · Jon Hunter

For platforms that have multiple boards and hence have multiple EEPROMs for identifying the different boards, it is useful to label the EEPROMs in device-tree so that they can be easily identified. For example, MAC address information is stored in the EEPROM on the processor module for some Jetson platforms which is not only required by the kernel but the bootloader as well. So having a simple way to identify the EEPROM is needed.

Changes since V1:
- By default initialise the nvmem_config.id as NVMEM_DEVID_AUTO and not NVMEM_DEVID_NONE
- Dropped the 'maxItems' from the dt-binding doc.

Jon Hunter (5):
misc: eeprom: at24: Initialise AT24 NVMEM ID field
dt-bindings: eeprom: at24: Add label property for AT24
misc: eeprom: at24: Support custom device names for AT24 EEPROMs
arm64: tegra: Add label properties for EEPROMs
arm64: tegra: Populate EEPROMs for Jetson Xavier NX

 .../devicetree/bindings/eeprom/at24.yaml      |  3 +++
 .../boot/dts/nvidia/tegra186-p2771-0000.dts   |  1 +
 .../arm64/boot/dts/nvidia/tegra186-p3310.dtsi |  1 +
 .../arm64/boot/dts/nvidia/tegra194-p2888.dtsi |  1 +
 .../boot/dts/nvidia/tegra194-p2972-0000.dts   |  1 +
 .../nvidia/tegra194-p3509-0000+p3668-0000.dts | 14 ++++++++++++
 .../boot/dts/nvidia/tegra194-p3668-0000.dtsi  | 16 ++++++++++++++
 .../arm64/boot/dts/nvidia/tegra210-p2180.dtsi |  1 +
 .../boot/dts/nvidia/tegra210-p2371-2180.dts   |  1 +
 .../boot/dts/nvidia/tegra210-p3450-0000.dts   |  2 ++
 drivers/misc/eeprom/at24.c                    | 22 ++++++++++++++++++-
 11 files changed, 62 insertions(+), 1 deletion(-)
Quoted 3 lines

--
2.25.1

Just FYI: I'm fine with the at24 part. I can take them through my tree for v5.10. Who is taking the DTS patches for tegra? Thierry? I can provide you with an immutable branch if that's fine. I can't just ack the at24 patches because they conflict with what I already have in my tree for v5.10.

Bartosz

author maintainer
#12 lore raw
Quoted 39 lines · Bartosz Golaszewski
Quoted 34 lines · Jon Hunter

For platforms that have multiple boards and hence have multiple EEPROMs for identifying the different boards, it is useful to label the EEPROMs in device-tree so that they can be easily identified. For example, MAC address information is stored in the EEPROM on the processor module for some Jetson platforms which is not only required by the kernel but the bootloader as well. So having a simple way to identify the EEPROM is needed.

Changes since V1:
- By default initialise the nvmem_config.id as NVMEM_DEVID_AUTO and not NVMEM_DEVID_NONE
- Dropped the 'maxItems' from the dt-binding doc.

Jon Hunter (5):
misc: eeprom: at24: Initialise AT24 NVMEM ID field
dt-bindings: eeprom: at24: Add label property for AT24
misc: eeprom: at24: Support custom device names for AT24 EEPROMs
arm64: tegra: Add label properties for EEPROMs
arm64: tegra: Populate EEPROMs for Jetson Xavier NX

 .../devicetree/bindings/eeprom/at24.yaml      |  3 +++
 .../boot/dts/nvidia/tegra186-p2771-0000.dts   |  1 +
 .../arm64/boot/dts/nvidia/tegra186-p3310.dtsi |  1 +
 .../arm64/boot/dts/nvidia/tegra194-p2888.dtsi |  1 +
 .../boot/dts/nvidia/tegra194-p2972-0000.dts   |  1 +
 .../nvidia/tegra194-p3509-0000+p3668-0000.dts | 14 ++++++++++++
 .../boot/dts/nvidia/tegra194-p3668-0000.dtsi  | 16 ++++++++++++++
 .../arm64/boot/dts/nvidia/tegra210-p2180.dtsi |  1 +
 .../boot/dts/nvidia/tegra210-p2371-2180.dts   |  1 +
 .../boot/dts/nvidia/tegra210-p3450-0000.dts   |  2 ++
 drivers/misc/eeprom/at24.c                    | 22 ++++++++++++++++++-
 11 files changed, 62 insertions(+), 1 deletion(-)
Quoted 3 lines

--
2.25.1

Quoted 5 lines

Just FYI: I'm fine with the at24 part. I can take them through my tree for v5.10. Who is taking the DTS patches for tegra? Thierry? I can provide you with an immutable branch if that's fine. I can't just ack the at24 patches because they conflict with what I already have in my tree for v5.10.

Thanks. Yes Thierry is picking up the DTS patches.

Cheers
Jon

Signature · 1 line
nvpublic
#13 lore raw
In reply to Bartosz Golaszewski
Quoted 39 lines · Bartosz Golaszewski
Quoted 34 lines · Jon Hunter

For platforms that have multiple boards and hence have multiple EEPROMs for identifying the different boards, it is useful to label the EEPROMs in device-tree so that they can be easily identified. For example, MAC address information is stored in the EEPROM on the processor module for some Jetson platforms which is not only required by the kernel but the bootloader as well. So having a simple way to identify the EEPROM is needed.

Changes since V1:
- By default initialise the nvmem_config.id as NVMEM_DEVID_AUTO and not NVMEM_DEVID_NONE
- Dropped the 'maxItems' from the dt-binding doc.

Jon Hunter (5):
misc: eeprom: at24: Initialise AT24 NVMEM ID field
dt-bindings: eeprom: at24: Add label property for AT24
misc: eeprom: at24: Support custom device names for AT24 EEPROMs
arm64: tegra: Add label properties for EEPROMs
arm64: tegra: Populate EEPROMs for Jetson Xavier NX

 .../devicetree/bindings/eeprom/at24.yaml      |  3 +++
 .../boot/dts/nvidia/tegra186-p2771-0000.dts   |  1 +
 .../arm64/boot/dts/nvidia/tegra186-p3310.dtsi |  1 +
 .../arm64/boot/dts/nvidia/tegra194-p2888.dtsi |  1 +
 .../boot/dts/nvidia/tegra194-p2972-0000.dts   |  1 +
 .../nvidia/tegra194-p3509-0000+p3668-0000.dts | 14 ++++++++++++
 .../boot/dts/nvidia/tegra194-p3668-0000.dtsi  | 16 ++++++++++++++
 .../arm64/boot/dts/nvidia/tegra210-p2180.dtsi |  1 +
 .../boot/dts/nvidia/tegra210-p2371-2180.dts   |  1 +
 .../boot/dts/nvidia/tegra210-p3450-0000.dts   |  2 ++
 drivers/misc/eeprom/at24.c                    | 22 ++++++++++++++++++-
 11 files changed, 62 insertions(+), 1 deletion(-)
Quoted 3 lines

--
2.25.1

Quoted 5 lines

Just FYI: I'm fine with the at24 part. I can take them through my tree for v5.10. Who is taking the DTS patches for tegra? Thierry? I can provide you with an immutable branch if that's fine. I can't just ack the at24 patches because they conflict with what I already have in my tree for v5.10.

I don't think I'll need an immutable branch since the device tree changes are not dependent on anything in the bindings, except maybe for validation, or the driver.

Thierry

#14 lore raw
Quoted 47 lines · Thierry Reding
Quoted 39 lines · Bartosz Golaszewski
Quoted 34 lines · Jon Hunter

For platforms that have multiple boards and hence have multiple EEPROMs for identifying the different boards, it is useful to label the EEPROMs in device-tree so that they can be easily identified. For example, MAC address information is stored in the EEPROM on the processor module for some Jetson platforms which is not only required by the kernel but the bootloader as well. So having a simple way to identify the EEPROM is needed.

Changes since V1:
- By default initialise the nvmem_config.id as NVMEM_DEVID_AUTO and not NVMEM_DEVID_NONE
- Dropped the 'maxItems' from the dt-binding doc.

Jon Hunter (5):
misc: eeprom: at24: Initialise AT24 NVMEM ID field
dt-bindings: eeprom: at24: Add label property for AT24
misc: eeprom: at24: Support custom device names for AT24 EEPROMs
arm64: tegra: Add label properties for EEPROMs
arm64: tegra: Populate EEPROMs for Jetson Xavier NX

 .../devicetree/bindings/eeprom/at24.yaml      |  3 +++
 .../boot/dts/nvidia/tegra186-p2771-0000.dts   |  1 +
 .../arm64/boot/dts/nvidia/tegra186-p3310.dtsi |  1 +
 .../arm64/boot/dts/nvidia/tegra194-p2888.dtsi |  1 +
 .../boot/dts/nvidia/tegra194-p2972-0000.dts   |  1 +
 .../nvidia/tegra194-p3509-0000+p3668-0000.dts | 14 ++++++++++++
 .../boot/dts/nvidia/tegra194-p3668-0000.dtsi  | 16 ++++++++++++++
 .../arm64/boot/dts/nvidia/tegra210-p2180.dtsi |  1 +
 .../boot/dts/nvidia/tegra210-p2371-2180.dts   |  1 +
 .../boot/dts/nvidia/tegra210-p3450-0000.dts   |  2 ++
 drivers/misc/eeprom/at24.c                    | 22 ++++++++++++++++++-
 11 files changed, 62 insertions(+), 1 deletion(-)
Quoted 3 lines

--
2.25.1

Quoted 5 lines

Just FYI: I'm fine with the at24 part. I can take them through my tree for v5.10. Who is taking the DTS patches for tegra? Thierry? I can provide you with an immutable branch if that's fine. I can't just ack the at24 patches because they conflict with what I already have in my tree for v5.10.

Quoted 5 lines

I don't think I'll need an immutable branch since the device tree changes are not dependent on anything in the bindings, except maybe for validation, or the driver.

Thierry

Ok sounds good then.

Bartosz