mm: remove mmu_notifier_get
Subsystems (2)
PATCH 1/1 mm: remove mmu_notifier_get
Remove the unused mmu_notifier_get inline function.
--- include/linux/mmu_notifier.h | 10 ---------- 1 file changed, 10 deletions(-)
include/linux/mmu_notifier.h +0 -10
@@ -279,16 +279,6 @@ static inline int mm_has_notifiers(struct mm_struct *mm)struct mmu_notifier *mmu_notifier_get_locked (const struct mmu_notifier_ops *ops,struct mm_struct *mm); -static inline struct mmu_notifier * -mmu_notifier_get (const struct mmu_notifier_ops *ops,struct mm_struct *mm) -{ -struct mmu_notifier *ret; - -mmap_write_lock (mm); - ret =mmu_notifier_get_locked (ops, mm); -mmap_write_unlock (mm); -return ret; -}void mmu_notifier_put (struct mmu_notifier *subscription);void mmu_notifier_synchronize (void );
Signature · 1 line
2.28.0
Quoted 17 lines · Christoph Hellwig
Remove the unused
mmu_notifier_getinline function.Signed-off-by Christoph Hellwig <[email protected]>--- include/linux/mmu_notifier.h | 10 ---------- 1 file changed, 10 deletions(-)include/linux/mmu_notifier.h +0
-2@@ -279,16 +279,6 @@ static inline int mm_has_notifiers(struct mm_struct *mm)struct mmu_notifier *mmu_notifier_get_locked (const struct mmu_notifier_ops *ops,struct mm_struct *mm); -static inline struct mmu_notifier * -mmu_notifier_get (const struct mmu_notifier_ops *ops,struct mm_struct *mm)
include/linux/mmu_notifier.h static inline int mm_has_notifiers(struct mm_struct *mm) · line 283
Quoted 10 lines
include/linux/mmu_notifier.h +0
-8-{ -struct mmu_notifier *ret; - -mmap_write_lock (mm); - ret =mmu_notifier_get_locked (ops, mm); -mmap_write_unlock (mm); -return ret; -}void mmu_notifier_put (struct mmu_notifier *subscription);void mmu_notifier_synchronize (void );
The doc of mmu_notifier_get_locked() has a reference to this function.
"Each call to mmu_notifier_get() must be paired with a call to mmu_notifier_put()." - that should have been mmu_notifier_get_locked(), maybe fix that up right away.
Signature · 3 lines
Thanks, David / dhildenb
Quoted 15 lines · Christoph Hellwig
Remove the unused
mmu_notifier_getinline function.Signed-off-by Christoph Hellwig <[email protected]>include/linux/mmu_notifier.h | 10 ---------- 1 file changed, 10 deletions(-)include/linux/mmu_notifier.h +1
-2+++ b/include/linux/mmu_notifier.h@@ -279,16 +279,6 @@ static inline int mm_has_notifiers(struct mm_struct *mm)struct mmu_notifier *mmu_notifier_get_locked (const struct mmu_notifier_ops *ops,struct mm_struct *mm); -static inline struct mmu_notifier * -mmu_notifier_get (const struct mmu_notifier_ops *ops,struct mm_struct *mm)
include/linux/mmu_notifier.h static inline int mm_has_notifiers(struct mm_struct *mm) · line 283
Quoted 10 lines
include/linux/mmu_notifier.h +0
-8-{ -struct mmu_notifier *ret; - -mmap_write_lock (mm); - ret =mmu_notifier_get_locked (ops, mm); -mmap_write_unlock (mm); -return ret; -}void mmu_notifier_put (struct mmu_notifier *subscription);void mmu_notifier_synchronize (void );
Looks like I missed this from
Though, I have a vauge recollection that some SVA IOMMU patches posted wanted to use this too? They can bring it back if it makes sense
Looks like David is right about the comment, but aside from that:
v2 should go through Andrew's tree
Thanks,
Jason