package/18xx-ti-utils: update makefile in order to compile wlconf
PATCH 1/1 package/18xx-ti-utils: update makefile in order to compile wlconf
--- package/18xx-ti-utils/18xx-ti-utils.mk | 5 +++++ 1 file changed, 5 insertions(+)
package/18xx-ti-utils/18xx-ti-utils.mk +5 -0
@@ -21,6 +21,11 @@ define 18XX_TI_UTILS_BUILD_CMDS NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D) \ CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \ $(18XX_TI_UTILS_BUILD_TARGET) + + $(TARGET_MAKE_ENV) CROSS_COMPILE=$(TARGET_CROSS) \ + NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D)/wlconf \ + CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \ + $(18XX_TI_UTILS_BUILD_TARGET) endef define 18XX_TI_UTILS_INSTALL_TARGET_CMDS
Signature · 1 line
2.17.1
PATCH 1/1 package/18xx-ti-utils: update makefile in order to compile wlconf
Hello Miken,
Thanks for your contribution!
Quoted 10 lines · On Wed, 16 Sep 2020 09:58:34 -0400 Miken Valabdas via buildroot…
Signed-off-by Miken Valabdas <[email protected]>--- package/18xx-ti-utils/18xx-ti-utils.mk | 5 +++++ 1 file changed, 5 insertions(+)package/18xx-ti-utils/18xx-ti-utils.mk +0
-0
package/18xx-ti-utils/18xx-ti-utils.mk define 18XX_TI_UTILS_BUILD_CMDS · line 28
Quoted 8 lines
package/18xx-ti-utils/18xx-ti-utils.mk +5
-0@@ -21,6 +21,11 @@ define 18XX_TI_UTILS_BUILD_CMDS NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D) \ CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \ $(18XX_TI_UTILS_BUILD_TARGET) + + $(TARGET_MAKE_ENV) CROSS_COMPILE=$(TARGET_CROSS) \ + NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D)/wlconf \ + CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \ + $(18XX_TI_UTILS_BUILD_TARGET)
So this is going to build another tool, but you haven't changed the 18XX_TI_UTILS_INSTALL_TARGET_CMDS to also install it. So how is this tool going to be practically useful ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Valabdas
PATCH 1/1 package/18xx-ti-utils: update makefile in order to compile wlconf
Hello Thomas,
Thanks for your message.
The reason why I haven't changed the 18XX_TI_UTILS_INSTALL_TARGET_CMDS is because this tool will be used in a host computer (not on the target board) in conjunction with BR2_ROOTFS_POST_IMAGE_SCRIPT. In resume, this tool will be used by a script through BR2_ROOTFS_POST_IMAGE_SCRIPT. The script itself will install the appropriate output (after doing some stuffs).
Thanks!
Miken
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: 16 septembre 2020 10:57
To: Valabdas, Miken <[email protected]>
Cc: buildroot at buildroot.org
Subject: Re: [Buildroot] [PATCH] package/18xx-ti-utils: update makefile in order to compile wlconf
Hello Miken,
Thanks for your contribution!
Quoted 11 lines · On Wed, 16 Sep 2020 09:58:34 -0400 Miken Valabdas via buildroot…
Signed-off-by Miken Valabdas <[email protected]>--- package/18xx-ti-utils/18xx-ti-utils.mk | 5 +++++ 1 file changed, 5 insertions(+)package/18xx-ti-utils/18xx-ti-utils.mk +0
-0
package/18xx-ti-utils/18xx-ti-utils.mk define 18XX_TI_UTILS_BUILD_CMDS · line 28
Quoted 8 lines
package/18xx-ti-utils/18xx-ti-utils.mk +5
-0@@ -21,6 +21,11 @@ define 18XX_TI_UTILS_BUILD_CMDS NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D) \ CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \ $(18XX_TI_UTILS_BUILD_TARGET) + + $(TARGET_MAKE_ENV) CROSS_COMPILE=$(TARGET_CROSS) \ + NFSROOT="$(STAGING_DIR)" NLVER=3 $(MAKE) -C $(@D)/wlconf \ + CFLAGS="$(TARGET_CFLAGS) $(18XX_TI_UTILS_CFLAGS)" \ + $(18XX_TI_UTILS_BUILD_TARGET)
So this is going to build another tool, but you haven't changed the 18XX_TI_UTILS_INSTALL_TARGET_CMDS to also install it. So how is this tool going to be practically useful ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://urldefense.com/v3/__https://bootlin.com__;!!Po4YltK3bPMkYw!nIVmpi0i8yXDE-CppSCDd56kOjhCnuUXrq0QLj-UBQgyigt5BaYRYF8QHgYt3qmOJ1jr2Fkv$
PATCH 1/1 package/18xx-ti-utils: update makefile in order to compile wlconf
Hello,
Quoted 10 lines · Miken
Thanks for your message.
The reason why I haven't changed the 18XX_TI_UTILS_INSTALL_TARGET_CMDS is because this tool will be used in a host computer (not on the target board) in conjunction with
BR2_ROOTFS_POST_IMAGE_SCRIPT.In resume, this tool will be used by a script through
BR2_ROOTFS_POST_IMAGE_SCRIPT. The script itself will install the appropriate output (after doing some stuffs).
OK, so this tool is built with the host compiler, and runs on the host machine. It seems weird as you're passing CFLAGS="$(TARGET_CFLAGS) ..." for example.
Also, a host tool should be installed in $(HOST_DIR)/bin or $(HOST_DIR)/sbin.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Valabdas
PATCH 1/1 package/18xx-ti-utils: update makefile in order to compile wlconf
Hello,
I see, I will change accordingly. Thanks for your input.
Regards,
Miken.
mvalabdas at distech-controls.com
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: 16 septembre 2020 12:29
To: Valabdas, Miken <[email protected]>
Cc: buildroot at buildroot.org
Subject: Re: [Buildroot] [PATCH] package/18xx-ti-utils: update makefile in order to compile wlconf
Hello,
Quoted 10 lines · Miken
Thanks for your message.
The reason why I haven't changed the 18XX_TI_UTILS_INSTALL_TARGET_CMDS is because this tool will be used in a host computer (not on the target board) in conjunction with
BR2_ROOTFS_POST_IMAGE_SCRIPT.In resume, this tool will be used by a script through
BR2_ROOTFS_POST_IMAGE_SCRIPT. The script itself will install the appropriate output (after doing some stuffs).
OK, so this tool is built with the host compiler, and runs on the host machine. It seems weird as you're passing CFLAGS="$(TARGET_CFLAGS) ..." for example.
Also, a host tool should be installed in $(HOST_DIR)/bin or $(HOST_DIR)/sbin.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://urldefense.com/v3/__https://bootlin.com__;!!Po4YltK3bPMkYw!jjfxu5py5t8nd8ucVhSs2-N5n3EdfjudvNwyVbcc5lGNbET1KSf4rOMlgzqqIxvs7YGLi0TO$