clk: at91: drop unused at91sam9g45_pcr_layout
Subsystems (4)
PATCH 1/6 clk: at91: drop unused at91sam9g45_pcr_layout
The at91sam9g45_pcr_layout is not used so drop it to fix build warning:
drivers/clk/at91/at91sam9g45.c:49:36: warning:
'at91sam9g45_pcr_layout' defined but not used [-Wunused-const-variable=]
--- drivers/clk/at91/at91sam9g45.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/clk/at91/at91sam9g45.c +0 -7
@@ -46,13 +46,6 @@ static const struct { { .n = "pck1", .p = "prog1", .id = 9 }, }; -static const struct clk_pcr_layout at91sam9g45_pcr_layout = { - .offset =0x10c , - .cmd =BIT (12 ), - .pid_mask =GENMASK (5 ,0 ), - .div_mask =GENMASK (17 ,16 ), -}; - struct pck { char *n; u8 id;
Signature · 7 lines
2.17.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH 2/6 clk: fixed: add missing kerneldoc
Add missing kerneldoc to fix compile warnings like:
drivers/clk/clk-fixed-factor.c:211: warning: Function parameter or member 'node' not described in 'of_fixed_factor_clk_setup'
--- drivers/clk/clk-fixed-factor.c | 1 + drivers/clk/clk-fixed-rate.c | 1 + 2 files changed, 2 insertions(+)
drivers/clk/clk-fixed-factor.c +1 -0
@@ -206,6 +206,7 @@ static struct clk_hw *_of_fixed_factor_clk_setup(struct device_node *node)/** * of_fixed_factor_clk_setup() - Setup function for simple fixed factor clock +* @node: device node for the clock */ void __init of_fixed_factor_clk_setup (struct device_node *node) {
drivers/clk/clk-fixed-rate.c +1 -0
@@ -168,6 +168,7 @@ static struct clk_hw *_of_fixed_clk_setup(struct device_node *node)/** * of_fixed_clk_setup() - Setup function for simple fixed rate clock +* @node: device node for the clock */ void __init of_fixed_clk_setup (struct device_node *node) {
Signature · 7 lines
2.17.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 2/6] clk: fixed: add missing kerneldoc
Quoting Krzysztof Kozlowski (2020-09-16 09:17:36)
Quoted 6 lines
Add missing kerneldoc to fix compile warnings like:
drivers/clk/clk-fixed-factor.c:211: warning: Function parameter or member 'node' not described in 'of_fixed_factor_clk_setup'Signed-off-by Krzysztof Kozlowski <[email protected]>---
Applied to clk-next
PATCH 3/6 clk: davinci: add missing kerneldoc
In reply to Krzysztof KozlowskiAdd missing kerneldoc to fix compile warning:
drivers/clk/davinci/da8xx-cfgchip.c:578: warning: Function parameter or member 'dev' not described in 'da8xx_cfgchip_register_usb1_clk48'
--- drivers/clk/davinci/da8xx-cfgchip.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/davinci/da8xx-cfgchip.c +1 -0
@@ -571,6 +571,7 @@ static const struct clk_ops da8xx_usb1_clk48_ops = {/** * da8xx_cfgchip_register_usb1_clk48 - Register a new USB 1.1 PHY clock +* @dev: The device * @regmap: The CFGCHIP regmap */ static struct da8xx_usb1_clk48 *
Signature · 7 lines
2.17.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 3/6] clk: davinci: add missing kerneldoc
Quoting Krzysztof Kozlowski (2020-09-16 09:17:37)
Quoted 7 lines
Add missing kerneldoc to fix compile warning:
drivers/clk/davinci/da8xx-cfgchip.c:578: warning: Function parameter or member 'dev' not described in 'da8xx_cfgchip_register_usb1_clk48'Signed-off-by Krzysztof Kozlowski <[email protected]>Reviewed-by David Lechner <[email protected]>---
Applied to clk-next
PATCH 4/6 clk: mmp: pxa1928: drop unused 'clk' variable
In reply to Krzysztof Kozlowski'clk' is assigned but never read:
drivers/clk/mmp/clk-of-pxa1928.c: In function ‘pxa1928_pll_init’:
drivers/clk/mmp/clk-of-pxa1928.c:71:14: warning: variable ‘clk’ set but not used [-Wunused-but-set-variable]
--- drivers/clk/mmp/clk-of-pxa1928.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/mmp/clk-of-pxa1928.c +1 -2
@@ -68,7 +68,6 @@ static struct mmp_clk_factor_tbl uart_factor_tbl[] = {static void pxa1928_pll_init (struct pxa1928_clk_unit *pxa_unit) { -struct clk *clk;struct mmp_clk_unit *unit = &pxa_unit->unit; mmp_register_fixed_rate_clks(unit, fixed_rate_clks,
@@ -77,7 +76,7 @@ static void pxa1928_pll_init(struct pxa1928_clk_unit *pxa_unit)mmp_register_fixed_factor_clks (unit, fixed_factor_clks,ARRAY_SIZE (fixed_factor_clks)); - clk = mmp_clk_register_factor("uart_pll", "pll1_416", + mmp_clk_register_factor("uart_pll", "pll1_416", CLK_SET_RATE_PARENT, pxa_unit->mpmu_base + MPMU_UART_PLL, &uart_factor_masks, uart_factor_tbl,
Signature · 7 lines
2.17.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 4/6] clk: mmp: pxa1928: drop unused 'clk' variable
Quoting Krzysztof Kozlowski (2020-09-16 09:17:38)
Quoted 7 lines
'clk' is assigned but never read:
drivers/clk/mmp/clk-of-pxa1928.c: In function ‘pxa1928_pll_init’:
drivers/clk/mmp/clk-of-pxa1928.c:71:14: warning: variable ‘clk’ set but not used [-Wunused-but-set-variable]Signed-off-by Krzysztof Kozlowski <[email protected]>---
Applied to clk-next
PATCH 5/6 clk: si5341: drop unused 'err' variable
In reply to Krzysztof Kozlowski'err' is assigned but never read:
/drivers/clk/clk-si5341.c: In function ‘si5341_output_get_parent’:
drivers/clk/clk-si5341.c:886:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable]
--- drivers/clk/clk-si5341.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/clk/clk-si5341.c +1 -3
@@ -883,11 +883,9 @@ static int si5341_output_set_parent(struct clk_hw *hw, u8 index)static u8 si5341_output_get_parent (struct clk_hw *hw) {struct clk_si5341_output *output =to_clk_si5341_output (hw); -int err;u32 val; - err =regmap_read (output->data->regmap, -SI5341_OUT_MUX_SEL (output), &val); +regmap_read (output->data->regmap,SI5341_OUT_MUX_SEL (output), &val);return val &0x7 ; }
Signature · 7 lines
2.17.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 5/6] clk: si5341: drop unused 'err' variable
Quoting Krzysztof Kozlowski (2020-09-16 09:17:39)
Quoted 7 lines
'err' is assigned but never read:
/drivers/clk/clk-si5341.c: In function ‘si5341_output_get_parent’:
drivers/clk/clk-si5341.c:886:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable]Signed-off-by Krzysztof Kozlowski <[email protected]>---
Applied to clk-next
PATCH 6/6 clk: rockchip: rk3308: drop unused mux_timer_src_p
In reply to Krzysztof KozlowskiThe parent names 'mux_timer_src_p' is not used:
In file included from drivers/clk/rockchip/clk-rk3308.c:13:0:
drivers/clk/rockchip/clk-rk3308.c:136:7: warning: ‘mux_timer_src_p’ defined but not used [-Wunused-const-variable=]
--- drivers/clk/rockchip/clk-rk3308.c | 1 - 1 file changed, 1 deletion(-)
drivers/clk/rockchip/clk-rk3308.c +0 -1
@@ -133,7 +133,6 @@ PNAME(mux_uart1_p) = { "clk_uart1_src", "dummy", "clk_uart1_frac" };PNAME (mux_uart2_p) = {"clk_uart2_src" ,"dummy" ,"clk_uart2_frac" };PNAME (mux_uart3_p) = {"clk_uart3_src" ,"dummy" ,"clk_uart3_frac" };PNAME (mux_uart4_p) = {"clk_uart4_src" ,"dummy" ,"clk_uart4_frac" }; -PNAME (mux_timer_src_p) = {"xin24m" ,"clk_rtc32k" };PNAME (mux_dclk_vop_p) = {"dclk_vop_src" ,"dclk_vop_frac" ,"xin24m" };PNAME (mux_nandc_p) = {"clk_nandc_div" ,"clk_nandc_div50" };PNAME (mux_sdmmc_p) = {"clk_sdmmc_div" ,"clk_sdmmc_div50" };
Signature · 7 lines
2.17.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Heiko Stübner
maintainerRe: [PATCH 6/6] clk: rockchip: rk3308: drop unused mux_timer_src_p
Am Mittwoch, 16. September 2020, 18:17:40 CEST schrieb Krzysztof Kozlowski:
Quoted 6 lines
The parent names '
mux_timer_src_p' is not used:In file included from
drivers/clk/rockchip/clk-rk3308.c:13:0:
drivers/clk/rockchip/clk-rk3308.c:136:7: warning: ‘mux_timer_src_p’ defined but not used [-Wunused-const-variable=]Signed-off-by Krzysztof Kozlowski <[email protected]>
applied for 5.10
Thanks
Heiko
Quoting Krzysztof Kozlowski (2020-09-16 09:17:35)
Quoted 8 lines
The
at91sam9g45_pcr_layoutis not used so drop it to fix build warning:
drivers/clk/at91/at91sam9g45.c:49:36: warning:
'at91sam9g45_pcr_layout' defined but not used [-Wunused-const-variable=]Signed-off-by Krzysztof Kozlowski <[email protected]>---
Applied to clk-next