Skip to contentSkip to conversation

dt-bindings: soc: ti: ti,pruss: fix schema ID

PATCH In review Krzysztof Kozlowski 4 participants 5 messages Sep 17, 2020

Subsystems (2)
Device tree bindings TI Keystone multicore navigator drivers
lore
Share & tools
lore

Krzysztof Kozlowski

author
#0 lore raw

PATCH 1/1 dt-bindings: soc: ti: ti,pruss: fix schema ID

Add missing '#' to fix schema errors:

$id: 'http://devicetree.org/schemas/soc/ti/ti,pruss.yaml' does not match 'http://devicetree.org/schemas/.*\\.yaml#'
$schema: 'http://devicetree.org/meta-schemas/core.yaml' is not one of ['http://devicetree.org/meta-schemas/core.yaml#', 'http://devicetree.org/meta-schemas/base.yaml#'] Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml: ignoring, error in schema: $id

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml +2 -2
index cf7dc83f724f..037c51b2f972 100644
@@ -1,8 +1,8 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml
-$schema: http://devicetree.org/meta-schemas/core.yaml
+$id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: |+
   TI Programmable Real-Time Unit and Industrial Communication Subsystem
Signature · 1 line
2.17.1
#1 lore raw
Quoted 17 lines · Krzysztof Kozlowski

Add missing '#' to fix schema errors:

$id: 'http://devicetree.org/schemas/soc/ti/ti,pruss.yaml' does not match 'http://devicetree.org/schemas/.*\\.yaml#'
$schema: 'http://devicetree.org/meta-schemas/core.yaml' is not one of ['http://devicetree.org/meta-schemas/core.yaml#', 'http://devicetree.org/meta-schemas/base.yaml#'] Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml: ignoring, error in schema: $id

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml +0 -0
index cf7dc83f724f..037c51b2f972 100644

Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml line 5

Quoted 7 lines
Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml +2 -2
@@ -1,8 +1,8 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml
-$schema: http://devicetree.org/meta-schemas/core.yaml
+$id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#

I've double checked and "#" was present in the original patch sent and ack for upstream: https://patchwork.kernel.org/patch/11729649/
It seems like something got wrong on linux-next but this is the only diff between original patch and one found in linux-next. Thank you for taking care of it.

Best regards,
Grzegorz

author
#2 lore raw
Quoted 24 lines · Grzegorz Jaszczyk
Quoted 22 lines · Krzysztof Kozlowski

Add missing '#' to fix schema errors:

$id: 'http://devicetree.org/schemas/soc/ti/ti,pruss.yaml' does not match 'http://devicetree.org/schemas/.*\\.yaml#'
$schema: 'http://devicetree.org/meta-schemas/core.yaml' is not one of ['http://devicetree.org/meta-schemas/core.yaml#', 'http://devicetree.org/meta-schemas/base.yaml#'] Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml: ignoring, error in schema: $id

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml +0 -2
index cf7dc83f724f..037c51b2f972 100644
@@ -1,8 +1,8 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml
-$schema: http://devicetree.org/meta-schemas/core.yaml
Quoted 8 lines

Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml line 5

Quoted 2 lines
Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml +2 -0
+$id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#

I've double checked and "#" was present in the original patch sent and ack for upstream: https://patchwork.kernel.org/patch/11729649/
It seems like something got wrong on linux-next but this is the only diff between original patch and one found in linux-next. Thank you for taking care of it.

Indeed that's weird. It must get lost when applying...

Best regards,
Krzysztof

Acked-by
#3 lore raw
Quoted 11 lines · Krzysztof Kozlowski
Quoted 9 lines · Grzegorz Jaszczyk
Quoted 7 lines · Krzysztof Kozlowski

Add missing '#' to fix schema errors:

$id: 'http://devicetree.org/schemas/soc/ti/ti,pruss.yaml' does not match 'http://devicetree.org/schemas/.*\\.yaml#'
$schema: 'http://devicetree.org/meta-schemas/core.yaml' is not one of ['http://devicetree.org/meta-schemas/core.yaml#', 'http://devicetree.org/meta-schemas/base.yaml#'] Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml: ignoring, error in schema: $id

Thanks for the fix, Krzysztof.

Fixes bd691ce0ba9d ("dt-bindings: soc: ti: Add TI PRUSS bindings")
Quoted 1 line
Quoted 1 line
Quoted 1 line
Signed-off-by Krzysztof Kozlowski <[email protected]>

With that,

Acked-by Suman Anna <[email protected]>

Santosh,
Can you please pick this up before you send your pull request to arm-soc maintainers?

You may also want to check your tooling to see what happened.

regards
Suman

Quoted 28 lines
Quoted 14 lines
Quoted 14 lines
---
 Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml +0 -2
index cf7dc83f724f..037c51b2f972 100644
@@ -1,8 +1,8 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml
-$schema: http://devicetree.org/meta-schemas/core.yaml
Quoted 8 lines

Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml line 5

Quoted 2 lines
Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml +2 -0
+$id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#

I've double checked and "#" was present in the original patch sent and ack for upstream: https://patchwork.kernel.org/patch/11729649/
It seems like something got wrong on linux-next but this is the only diff between original patch and one found in linux-next. Thank you for taking care of it.

Indeed that's weird. It must get lost when applying...

Best regards,
Krzysztof

#4 lore raw
In reply to Krzysztof Kozlowski
Quoted 35 lines · Krzysztof Kozlowski
Quoted 24 lines · Grzegorz Jaszczyk
Quoted 22 lines · Krzysztof Kozlowski

Add missing '#' to fix schema errors:

$id: 'https://urldefense.com/v3/__http://devicetree.org/schemas/soc/ti/ti,pruss.yaml__;!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIG6IBFwLA$ ' does not match 'https://urldefense.com/v3/__http://devicetree.org/schemas/.**A5C*5C.yaml*__;KiUlIw!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIGpNPP7ig$ '
$schema: 'https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml__;!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIEdWH0Bzw$ ' is not one of ['https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIHcNI2bOQ$ ', 'https://urldefense.com/v3/__http://devicetree.org/meta-schemas/base.yaml*__;Iw!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIFH0HvA-g$ '] Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml: ignoring, error in schema: $id

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
  Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml +0 -2
index cf7dc83f724f..037c51b2f972 100644
@@ -1,8 +1,8 @@
  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
  %YAML 1.2
  ---
-$id: https://urldefense.com/v3/__http://devicetree.org/schemas/soc/ti/ti,pruss.yaml__;!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIG6IBFwLA$
-$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml__;!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIEdWH0Bzw$
Quoted 8 lines

Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml line 5

Quoted 2 lines
Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml +2 -0
+$id: https://urldefense.com/v3/__http://devicetree.org/schemas/soc/ti/ti,pruss.yaml*__;Iw!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIHAb7bLvA$
+$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIHcNI2bOQ$

I've double checked and "#" was present in the original patch sent and
ack for upstream: https://urldefense.com/v3/__https://patchwork.kernel.org/patch/11729649/__;!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIEaRPpx1g$
It seems like something got wrong on linux-next but this is the only
diff between original patch and one found in linux-next. Thank you for
taking care of it.

Quoted 2 lines

Indeed that's weird. It must get lost when applying...

These URLs get mangled sometimes and I needed to fix them. Will fix the original commit. Thanks for reporting.