Skip to contentSkip to conversation

powerpc/64: Set up a kernel stack for secondaries before cpu_restore()

PATCH Superseded Jordan Niethe 2 participants 4 messages Sep 17, 2020 – Sep 22, 2020 PowerPC

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 powerpc/64: Set up a kernel stack for secondaries before cpu_restore()

Currently in generic_secondary_smp_init(), cur_cpu_spec->cpu_restore() is called before a stack has been set up in r1. This was previously fine as the cpu_restore() functions were implemented in assembly and did not use a stack. However commit 5a61ef74f269 ("powerpc/64s: Support new device tree binding for discovering CPU features") used __restore_cpu_cpufeatures() as the cpu_restore() function for a device-tree features based cputable entry. This is a C function and hence uses a stack in r1.

generic_secondary_smp_init() is entered on the secondary cpus via the primary cpu using the OPAL call opal_start_cpu(). In OPAL, each hardware thread has its own stack. The OPAL call is ran in the primary's hardware thread. During the call, a job is scheduled on a secondary cpu that will start executing at the address of generic_secondary_smp_init(). Hence the value that will be left in r1 when the secondary cpu enters the kernel is part of that secondary cpu's individual OPAL stack. This means that __restore_cpu_cpufeatures() will write to that OPAL stack. This is not horribly bad as each hardware thread has its own stack and the call that enters the kernel from OPAL never returns, but it is still wrong and should be corrected.

Create the temp kernel stack before calling cpu_restore().

Fixes 5a61ef74f269 ("powerpc/64s: Support new device tree binding for discovering CPU features")

---
v2: Add more detail to the commit message

---
 arch/powerpc/kernel/head_64.S | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/powerpc/kernel/head_64.S +4 -4
index 0e05a9a47a4b..4b7f4c6c2600 100644
@@ -420,6 +420,10 @@ generic_secondary_common_init:
 	/* From now on, r24 is expected to be logical cpuid */
 	mr	r24,r5
 
+	/* Create a temp kernel stack for use before relocation is on.	*/
+	ld	r1,PACAEMERGSP(r13)
+	subi	r1,r1,STACK_FRAME_OVERHEAD
+
 	/* See if we need to call a cpu state restore handler */
 	LOAD_REG_ADDR(r23, cur_cpu_spec)
 	ld	r23,0(r23)
@@ -448,10 +452,6 @@ generic_secondary_common_init:
 	sync				/* order paca.run and cur_cpu_spec */
 	isync				/* In case code patching happened */
 
-	/* Create a temp kernel stack for use before relocation is on.	*/
-	ld	r1,PACAEMERGSP(r13)
-	subi	r1,r1,STACK_FRAME_OVERHEAD
-
 	b	__secondary_start
 #endif /* SMP */
 
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 2/2 powerpc/64s: Convert some cpu_setup() and cpu_restore() functions to C

The only thing keeping the cpu_setup() and cpu_restore() functions used in the cputable entries for Power7, Power8, Power9 and Power10 in assembly was cpu_restore() being called before there was a stack in generic_secondary_smp_init(). Commit ("powerpc/64: Set up a kernel stack for secondaries before cpu_restore()") means that it is now possible to use C.

Rewrite the functions in C so they are a little bit easier to read. This is not changing their functionality.

---
 arch/powerpc/include/asm/cpu_setup_power.h |  12 +
 arch/powerpc/kernel/cpu_setup_power.S      | 252 -------------------
 arch/powerpc/kernel/cpu_setup_power.c      | 269 +++++++++++++++++++++
 arch/powerpc/kernel/cputable.c             |   9 +-
 4 files changed, 282 insertions(+), 260 deletions(-)
 create mode 100644 arch/powerpc/include/asm/cpu_setup_power.h
 delete mode 100644 arch/powerpc/kernel/cpu_setup_power.S
 create mode 100644 arch/powerpc/kernel/cpu_setup_power.c
arch/powerpc/include/asm/cpu_setup_power.h new file +12 -0
new file mode 100644
index 000000000000..24be9131f803
@@ -0,0 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/*
+ * Copyright (C) 2020 IBM Corporation
+ */
+void __setup_cpu_power7(unsigned long offset, struct cpu_spec *spec);
+void __restore_cpu_power7(void);
+void __setup_cpu_power8(unsigned long offset, struct cpu_spec *spec);
+void __restore_cpu_power8(void);
+void __setup_cpu_power9(unsigned long offset, struct cpu_spec *spec);
+void __restore_cpu_power9(void);
+void __setup_cpu_power10(unsigned long offset, struct cpu_spec *spec);
+void __restore_cpu_power10(void);
arch/powerpc/kernel/cpu_setup_power.S deleted +0 -252

252 lines not on this page · raw message

arch/powerpc/kernel/cpu_setup_power.c new file +269 -0

269 lines not on this page · raw message

arch/powerpc/kernel/cputable.c +1 -8
index 3d406a9626e8..bce545280056 100644
@@ -59,19 +59,12 @@ extern void __setup_cpu_7410(unsigned long offset, struct cpu_spec* spec);
 extern void __setup_cpu_745x(unsigned long offset, struct cpu_spec* spec);
 #endif /* CONFIG_PPC32 */
 #ifdef CONFIG_PPC64
+#include <asm/cpu_setup_power.h>
 extern void __setup_cpu_ppc970(unsigned long offset, struct cpu_spec* spec);
 extern void __setup_cpu_ppc970MP(unsigned long offset, struct cpu_spec* spec);
 extern void __setup_cpu_pa6t(unsigned long offset, struct cpu_spec* spec);
 extern void __restore_cpu_pa6t(void);
 extern void __restore_cpu_ppc970(void);
-extern void __setup_cpu_power7(unsigned long offset, struct cpu_spec* spec);
-extern void __restore_cpu_power7(void);
-extern void __setup_cpu_power8(unsigned long offset, struct cpu_spec* spec);
-extern void __restore_cpu_power8(void);
-extern void __setup_cpu_power9(unsigned long offset, struct cpu_spec* spec);
-extern void __restore_cpu_power9(void);
-extern void __setup_cpu_power10(unsigned long offset, struct cpu_spec* spec);
-extern void __restore_cpu_power10(void);
 extern long __machine_check_early_realmode_p7(struct pt_regs *regs);
 extern long __machine_check_early_realmode_p8(struct pt_regs *regs);
 extern long __machine_check_early_realmode_p9(struct pt_regs *regs);
Signature · 1 line
2.17.1
#2 lore raw
In reply to Jordan Niethe

Hi Jordan,

Quoted 23 lines · Jordan Niethe

Currently in generic_secondary_smp_init(), cur_cpu_spec->cpu_restore() is called before a stack has been set up in r1. This was previously fine as the cpu_restore() functions were implemented in assembly and did not use a stack. However commit 5a61ef74f269 ("powerpc/64s: Support new device tree binding for discovering CPU features") used __restore_cpu_cpufeatures() as the cpu_restore() function for a device-tree features based cputable entry. This is a C function and hence uses a stack in r1.

generic_secondary_smp_init() is entered on the secondary cpus via the primary cpu using the OPAL call opal_start_cpu(). In OPAL, each hardware thread has its own stack. The OPAL call is ran in the primary's hardware thread. During the call, a job is scheduled on a secondary cpu that will start executing at the address of generic_secondary_smp_init(). Hence the value that will be left in r1 when the secondary cpu enters the kernel is part of that secondary cpu's individual OPAL stack. This means that __restore_cpu_cpufeatures() will write to that OPAL stack. This is not horribly bad as each hardware thread has its own stack and the call that enters the kernel from OPAL never returns, but it is still wrong and should be corrected.

Create the temp kernel stack before calling cpu_restore().

Quoted 7 lines
Fixes 5a61ef74f269 ("powerpc/64s: Support new device tree binding for discovering CPU features")

---
v2: Add more detail to the commit message

---
 arch/powerpc/kernel/head_64.S | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Unfortunately this breaks booting via kexec.

In that case the secondaries come in to 0x60 and spin until they're released by smp_release_cpus(), which is before emergency_stack_init() has run. That means they pick up a bad r1 value and crash/get stuck.

I'm not sure what the best solution is.

I've thought in the past that it would be nicer if the CPU setup didn't run until the secondary is told to start (via PACAPROCSTART), ie. more the CPU setup call below there.

But that opens the possibility that we run threads with different settings of some SPRs until SMP bringup, and if the user has said not to start secondaries then possibly for ever. And I haven't though hard enough about whether that's actually problematic (running with different SPR values).

cheers

Quoted 28 lines
arch/powerpc/kernel/head_64.S +4 -4
index 0e05a9a47a4b..4b7f4c6c2600 100644
@@ -420,6 +420,10 @@ generic_secondary_common_init:
 	/* From now on, r24 is expected to be logical cpuid */
 	mr	r24,r5
 
+	/* Create a temp kernel stack for use before relocation is on.	*/
+	ld	r1,PACAEMERGSP(r13)
+	subi	r1,r1,STACK_FRAME_OVERHEAD
+
 	/* See if we need to call a cpu state restore handler */
 	LOAD_REG_ADDR(r23, cur_cpu_spec)
 	ld	r23,0(r23)
@@ -448,10 +452,6 @@ generic_secondary_common_init:
 	sync				/* order paca.run and cur_cpu_spec */
 	isync				/* In case code patching happened */
 
-	/* Create a temp kernel stack for use before relocation is on.	*/
-	ld	r1,PACAEMERGSP(r13)
-	subi	r1,r1,STACK_FRAME_OVERHEAD
-
 	b	__secondary_start
 #endif /* SMP */
 
Signature · 1 line
2.17.1
#3 lore raw
Quoted 35 lines · Michael Ellerman

Hi Jordan,

Quoted 23 lines · Jordan Niethe

Currently in generic_secondary_smp_init(), cur_cpu_spec->cpu_restore() is called before a stack has been set up in r1. This was previously fine as the cpu_restore() functions were implemented in assembly and did not use a stack. However commit 5a61ef74f269 ("powerpc/64s: Support new device tree binding for discovering CPU features") used __restore_cpu_cpufeatures() as the cpu_restore() function for a device-tree features based cputable entry. This is a C function and hence uses a stack in r1.

generic_secondary_smp_init() is entered on the secondary cpus via the primary cpu using the OPAL call opal_start_cpu(). In OPAL, each hardware thread has its own stack. The OPAL call is ran in the primary's hardware thread. During the call, a job is scheduled on a secondary cpu that will start executing at the address of generic_secondary_smp_init(). Hence the value that will be left in r1 when the secondary cpu enters the kernel is part of that secondary cpu's individual OPAL stack. This means that __restore_cpu_cpufeatures() will write to that OPAL stack. This is not horribly bad as each hardware thread has its own stack and the call that enters the kernel from OPAL never returns, but it is still wrong and should be corrected.

Create the temp kernel stack before calling cpu_restore().

Quoted 7 lines
Fixes 5a61ef74f269 ("powerpc/64s: Support new device tree binding for discovering CPU features")

---
v2: Add more detail to the commit message

---
 arch/powerpc/kernel/head_64.S | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Quoted 7 lines

Unfortunately this breaks booting via kexec.

In that case the secondaries come in to 0x60 and spin until they're released by smp_release_cpus(), which is before emergency_stack_init() has run. That means they pick up a bad r1 value and crash/get stuck.

I'm not sure what the best solution is.

Would it be simplest to just call smp_release_cpus() after setting up the stack?

Quoted 42 lines

I've thought in the past that it would be nicer if the CPU setup didn't run until the secondary is told to start (via PACAPROCSTART), ie. more the CPU setup call below there.

But that opens the possibility that we run threads with different settings of some SPRs until SMP bringup, and if the user has said not to start secondaries then possibly for ever. And I haven't though hard enough about whether that's actually problematic (running with different SPR values).

cheers

Quoted 28 lines
arch/powerpc/kernel/head_64.S +4 -5
index 0e05a9a47a4b..4b7f4c6c2600 100644
@@ -420,6 +420,10 @@ generic_secondary_common_init:
      /* From now on, r24 is expected to be logical cpuid */
      mr      r24,r5
 
+     /* Create a temp kernel stack for use before relocation is on.  */
+     ld      r1,PACAEMERGSP(r13)
+     subi    r1,r1,STACK_FRAME_OVERHEAD
+
      /* See if we need to call a cpu state restore handler */
      LOAD_REG_ADDR(r23, cur_cpu_spec)
      ld      r23,0(r23)
@@ -448,10 +452,6 @@ generic_secondary_common_init:
      sync                            /* order paca.run and cur_cpu_spec */
      isync                           /* In case code patching happened */
 
-     /* Create a temp kernel stack for use before relocation is on.  */
-     ld      r1,PACAEMERGSP(r13)
-     subi    r1,r1,STACK_FRAME_OVERHEAD
-
      b       __secondary_start
 #endif /* SMP */
 
--

2.17.1