hinic: fix potential resource leak
Subsystems (3)
PATCH v2 1/1 hinic: fix potential resource leak
In rx_request_irq(), it will just return what irq_set_affinity_hint() returns. If it is failed, the napi and irq requested are not freed properly. So add exits for failures to handle these.
Signed-off-by Wei Li <[email protected]>
---
v1 -> v2:
- Free irq as well when irq_set_affinity_hint() fails.
--- drivers/net/ethernet/huawei/hinic/hinic_rx.c | 21 +++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-)
drivers/net/ethernet/huawei/hinic/hinic_rx.c +14 -7
@@ -543,18 +543,25 @@ static int rx_request_irq(struct hinic_rxq *rxq)if (err) {netif_err (nic_dev, drv, rxq->netdev,"Failed to set RX interrupt coalescing attribute\n" ); -rx_del_napi (rxq); -return err; + goto err_req_irq; } err =request_irq (rq->irq, rx_irq,0 , rxq->irq_name, rxq); -if (err) { -rx_del_napi (rxq); -return err; - } +if (err) + goto err_req_irq;cpumask_set_cpu (qp->q_id %num_online_cpus (), &rq->affinity_mask); -return irq_set_affinity_hint (rq->irq, &rq->affinity_mask); + err =irq_set_affinity_hint (rq->irq, &rq->affinity_mask); +if (err) + goto err_irq_affinity; + +return 0 ; + +err_irq_affinity: +free_irq (rq->irq, rxq); +err_req_irq: +rx_del_napi (rxq); +return err; }static void rx_free_irq (struct hinic_rxq *rxq)
Signature · 1 line
2.17.1
From: Wei Li <[email protected]>
Date: Thu, 17 Sep 2020 20:29:50 +0800
Quoted 8 lines
In
rx_request_irq(), it will just return whatirq_set_affinity_hint()returns. If it is failed, the napi and irq requested are not freed properly. So add exits for failures to handle these.Signed-off-by Wei Li <[email protected]>---
v1 -> v2:
- Free irq as well whenirq_set_affinity_hint()fails.
Applied, thank you.