Skip to contentSkip to conversation

examples/ioat: fix stats print

PATCH Superseded Kevin Laatz 3 participants 5 messages Sep 17, 2020 – Oct 8, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 examples/ioat: fix stats print

Currently some of the status string at the top of the stats output is being cut off. To fix this, the status string array size has been increased.

Bugzilla ID: 536

Fixes 632bcd9b5d4f ("examples/ioat: print statistics")
---
 examples/ioat/ioatfwd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
examples/ioat/ioatfwd.c +1 -1
index 43a19843ee..8a8c81edfb 100644
@@ -168,7 +168,7 @@ print_stats(char *prgname)
 	struct rte_rawdev_xstats_name *names_xstats;
 	uint64_t *xstats;
 	unsigned int *ids_xstats, nb_xstats;
-	char status_string[120]; /* to print at the top of the output */
+	char status_string[140]; /* to print at the top of the output */
 	int status_strlen;
 	int ret;
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 16 lines · Kevin Laatz

Currently some of the status string at the top of the stats output is being cut off. To fix this, the status string array size has been increased.

Bugzilla ID: 536

Fixes 632bcd9b5d4f ("examples/ioat: print statistics")
---
 examples/ioat/ioatfwd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
examples/ioat/ioatfwd.c +0 -0
index 43a19843ee..8a8c81edfb 100644

examples/ioat/ioatfwd.c print_stats(char *prgname) · line 174

Quoted 8 lines
examples/ioat/ioatfwd.c +1 -1
@@ -168,7 +168,7 @@ print_stats(char *prgname)
 	struct rte_rawdev_xstats_name *names_xstats;
 	uint64_t *xstats;
 	unsigned int *ids_xstats, nb_xstats;
-	char status_string[120]; /* to print at the top of the output */
+	char status_string[140]; /* to print at the top of the output */
 	int status_strlen;
 	int ret;
 

This seems a rather small increment - normally if a string is too small I'd bump it up by a serious amount. 255 might be a good value here.

Also, to avoid the display looking strange in case of future truncation (which is not very likely with a size of 255 if you increment to that), the final '\n' should be included in the printf rather than in the string to be printed.

Regards,
/Bruce

#2 lore raw

PATCH v2 1/1 examples/ioat: fix stats print

In reply to Kevin Laatz

Currently some of the status string at the top of the stats output is being cut off. To fix this, the status string array size has been increased. In addition to this, the "\n" has been moved to the printf, rather than having it in the last string, in case of future formatting issues due to truncation.

Bugzilla ID: 536

Fixes 632bcd9b5d4f ("examples/ioat: print statistics")

---
v2:
- Increased string array by larger value - ie. up to 255.
- Moved the "\n" to avoid future formatting issues from truncation.

---
 examples/ioat/ioatfwd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
examples/ioat/ioatfwd.c +3 -3
index 43a19843ee..4e971dc054 100644
@@ -168,7 +168,7 @@ print_stats(char *prgname)
 	struct rte_rawdev_xstats_name *names_xstats;
 	uint64_t *xstats;
 	unsigned int *ids_xstats, nb_xstats;
-	char status_string[120]; /* to print at the top of the output */
+	char status_string[255]; /* to print at the top of the output */
 	int status_strlen;
 	int ret;
 
@@ -194,7 +194,7 @@ print_stats(char *prgname)
 		"Rx Queues = %d, ", nb_queues);
 	status_strlen += snprintf(status_string + status_strlen,
 		sizeof(status_string) - status_strlen,
-		"Ring Size = %d\n", ring_size);
+		"Ring Size = %d", ring_size);
 
 	/* Allocate memory for xstats names and values */
 	ret = rte_rawdev_xstats_names_get(
@@ -251,7 +251,7 @@ print_stats(char *prgname)
 
 		memset(&delta_ts, 0, sizeof(struct total_statistics));
 
-		printf("%s", status_string);
+		printf("%s\n", status_string);
 
 		for (i = 0; i < cfg.nb_ports; i++) {
 			port_id = cfg.ports[i].rxtx_port;
Signature · 1 line
2.25.1
Acked-by on v2 1/1
#3 lore raw
Quoted 11 lines · Kevin Laatz

Currently some of the status string at the top of the stats output is being cut off. To fix this, the status string array size has been increased. In addition to this, the "\n" has been moved to the printf, rather than having it in the last string, in case of future formatting issues due to truncation.

Bugzilla ID: 536

Fixes 632bcd9b5d4f ("examples/ioat: print statistics")
#4 lore raw

17/09/2020 15:21, Bruce Richardson:

Quoted 9 lines · Kevin Laatz
Quoted 8 lines

Currently some of the status string at the top of the stats output is being cut off. To fix this, the status string array size has been increased. In addition to this, the "\n" has been moved to the printf, rather than having it in the last string, in case of future formatting issues due to truncation.

Bugzilla ID: 536

Fixes 632bcd9b5d4f ("examples/ioat: print statistics")

+Cc: [email protected]

Quoted 3 lines
Quoted 2 lines

Applied, thanks