dt-bindings: mfd: rohm,bd71837-pmic: Add common properties

PATCH Applied Krzysztof Kozlowski 4 participants 7 messages Sep 17, 2020 – Nov 4, 2020

Subsystems (2)

Device tree bindings Multifunction devices (MFD)

lore

Share & tools

lore

Krzysztof Kozlowski

author

2020-09-17 20:05 UTC #0 lore raw

PATCH v2 1/1 dt-bindings: mfd: rohm,bd71837-pmic: Add common properties

Add common properties appearing in DTSes (clock-names, clock-output-names) with the common values (actually used in DTSes) to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml:
pmic@4b: 'clock-names', 'clock-output-names', do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by Krzysztof Kozlowski <[email protected]>

---

Changes since v1:
1. Define the names, as used in existing DTS files.

---
 .../devicetree/bindings/mfd/rohm,bd71837-pmic.yaml          | 6 ++++++
 1 file changed, 6 insertions(+)

Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml +6 -0

index 65018a019e1d..3bfdd33702ad 100644
@@ -32,9 +32,15 @@ properties:
   clocks:
     maxItems: 1
 
+  clock-names:
+    const: osc
+
   "#clock-cells":
     const: 0
 
+  clock-output-names:
+    const: pmic_clk
+
 # The BD718x7 supports two different HW states as reset target states. States
 # are called as SNVS and READY. At READY state all the PMIC power outputs go
 # down and OTP is reload. At the SNVS state all other logic and external

Signature · 1 line

2.17.1

Vaittinen, Matti

Acked-by on v2 1/1

2020-09-18 05:49 UTC #1 lore raw

Hi deeee Ho peeps!

Quoted 27 lines · Krzysztof Kozlowski

Add common properties appearing in DTSes (clock-names, clock-output-names) with the common values (actually used in DTSes) to
fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml:
pmic@4b: 'clock-names', 'clock-output-names', do not match any of
the regexes: 'pinctrl-[0-9]+'
Signed-off-by Krzysztof Kozlowski <[email protected]>
---
Changes since v1:
1. Define the names, as used in existing DTS files.
---
 .../devicetree/bindings/mfd/rohm,bd71837-pmic.yaml          | 6
++++++
 1 file changed, 6 insertions(+)
(quoted diff) +0 -0
pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71837- pmic.yaml
index 65018a019e1d..3bfdd33702ad 100644

Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml properties: · line 36

Quoted 5 lines

Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml +2 -0
@@ -32,9 +32,15 @@ properties:
   clocks:
     maxItems: 1
 
+  clock-names:
+    const: osc

I guess existing board dtses use "osc" then? Ok.

Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml properties: · line 42

Quoted 5 lines

Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml +2 -0
   "#clock-cells":
     const: 0
 
+  clock-output-names:
+    const: pmic_clk

This is not a strong opinion but I feel that pmic_clk is a bit too generic name? I mean, what if there is a system with more than one PMICs? (I don't see such use-case with the BD718x7 though - but perhaps this can serve as a misleading example for other PMICs? For example with the ROHM BD96801 family there may be multiple PMICs in one system). Anyways - if Rob is happy with this then please go with it :)

Acked-by Matti Vaittinen <[email protected]>

*
Thanks again for improving these bindings! I am constantly struggling with these x_x. Writing the bindings is probably hardest part of PMIC driver development -_-;

Krzysztof Kozlowski

author

2020-09-18 06:58 UTC #2 lore raw

Quoted 34 lines · Matti

Hi deeee Ho peeps!
Quoted 30 lines · Krzysztof Kozlowski
Add common properties appearing in DTSes (clock-names, clock-output-names) with the common values (actually used in DTSes) to
fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml:
pmic@4b: 'clock-names', 'clock-output-names', do not match any of
the regexes: 'pinctrl-[0-9]+'
Signed-off-by Krzysztof Kozlowski <[email protected]>
---
Changes since v1:
1. Define the names, as used in existing DTS files.
---
 .../devicetree/bindings/mfd/rohm,bd71837-pmic.yaml          | 6
++++++
 1 file changed, 6 insertions(+)
(quoted diff) +0 -0
pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71837- pmic.yaml
index 65018a019e1d..3bfdd33702ad 100644
Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml +0 -0
@@ -32,9 +32,15 @@ properties:
   clocks:
     maxItems: 1
 

Quoted 4 lines

Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml properties: · line 36
Quoted 2 lines
Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml +2 -0
+  clock-names:
+    const: osc
I guess existing board dtses use "osc" then? Ok.

Yes.

Quoted 11 lines

Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml properties: · line 42
Quoted 6 lines
Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml +2 -0
   "#clock-cells":
     const: 0
 
+  clock-output-names:
+    const: pmic_clk
This is not a strong opinion but I feel that pmic_clk is a bit too generic name? I mean, what if there is a system with more than one PMICs? (I don't see such use-case with the BD718x7 though - but perhaps this can serve as a misleading example for other PMICs?

I don't expect two PMICs. Sometimes secondary device is added with few regulators, e.g. a MUIC. Still only one device can supply the CPU and probably this would be called PMIC.

Quoted 3 lines

For example
with the ROHM BD96801 family there may be multiple PMICs in one system). Anyways - if Rob is happy with this then please go with it :)

The name was taken from existing DTS files. That was Rob's idea as well.

Best regards,
Krzysztof

Quoted 8 lines

Acked-by Matti Vaittinen <[email protected]>
*
Thanks again for improving these bindings! I am constantly struggling with these x_x. Writing the bindings is probably hardest part of PMIC driver development -_-;

Rob Herring

maintainer Reviewed-by on v2 1/1

2020-09-23 20:32 UTC #3 lore raw

In reply to Krzysztof Kozlowski

Quoted 9 lines · Krzysztof Kozlowski

Add common properties appearing in DTSes (clock-names, clock-output-names) with the common values (actually used in DTSes) to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml:
pmic@4b: 'clock-names', 'clock-output-names', do not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by Krzysztof Kozlowski <[email protected]>

Quoted 8 lines

---
Changes since v1:
1. Define the names, as used in existing DTS files.
---
 .../devicetree/bindings/mfd/rohm,bd71837-pmic.yaml          | 6 ++++++
 1 file changed, 6 insertions(+)

Reviewed-by Rob Herring <[email protected]>

Krzysztof Kozlowski

author

2020-10-02 16:13 UTC #4 lore raw

In reply to Krzysztof Kozlowski

Quoted 9 lines · Krzysztof Kozlowski

Add common properties appearing in DTSes (clock-names, clock-output-names) with the common values (actually used in DTSes) to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml:
pmic@4b: 'clock-names', 'clock-output-names', do not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by Krzysztof Kozlowski <[email protected]>

Quoted 7 lines

---
Changes since v1:
1. Define the names, as used in existing DTS files.
---
 .../devicetree/bindings/mfd/rohm,bd71837-pmic.yaml          | 6 ++++++
 1 file changed, 6 insertions(+)

Dear Lee,

Could you take it via MFD tree? There is a review from Rob and ack from author (Matti).

Best regards,
Krzysztof

Lee Jones

2020-10-05 08:13 UTC #5 lore raw

Quoted 18 lines · Krzysztof Kozlowski

Quoted 9 lines · Krzysztof Kozlowski
Add common properties appearing in DTSes (clock-names, clock-output-names) with the common values (actually used in DTSes) to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml:
pmic@4b: 'clock-names', 'clock-output-names', do not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 7 lines
---
Changes since v1:
1. Define the names, as used in existing DTS files.
---
 .../devicetree/bindings/mfd/rohm,bd71837-pmic.yaml          | 6 ++++++
 1 file changed, 6 insertions(+)

Quoted 4 lines

Dear Lee,
Could you take it via MFD tree? There is a review from Rob and ack from author (Matti).

I don't usually take patches this late in the cycle.

Signature · 4 lines

Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Lee Jones

Applied

2020-11-04 15:19 UTC #6 lore raw

In reply to Krzysztof Kozlowski

Quoted 9 lines · Krzysztof Kozlowski

Add common properties appearing in DTSes (clock-names, clock-output-names) with the common values (actually used in DTSes) to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml:
pmic@4b: 'clock-names', 'clock-output-names', do not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by Krzysztof Kozlowski <[email protected]>

Quoted 7 lines

---
Changes since v1:
1. Define the names, as used in existing DTS files.
---
 .../devicetree/bindings/mfd/rohm,bd71837-pmic.yaml          | 6 ++++++
 1 file changed, 6 insertions(+)

Applied, thanks.

Signature · 4 lines

Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog