Skip to contentSkip to conversation

auto-t: fix testNetconfig

PATCH Applied James Prestwood 2 participants 2 messages Sep 17, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 auto-t: fix testNetconfig

The interface was hard coded to wln0 which works when running single tests but not when running multiple. Instead use the actual ifname that hostapd is using.

---
 autotests/testNetconfig/connection_test.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
autotests/testNetconfig/connection_test.py +3 -1
index 3a590aeb..6818ceff 100644
@@ -8,6 +8,7 @@ import iwd
 from iwd import IWD
 from iwd import PSKAgent
 from iwd import NetworkType
+from hostapd import HostapdCLI
 import testutil
 from config import ctx
 
@@ -54,10 +55,11 @@ class Test(unittest.TestCase):
 
     @classmethod
     def setUpClass(cls):
+        hapd = HostapdCLI()
         # TODO: This could be moved into test-runner itself if other tests ever
         #       require this functionality (p2p, FILS, etc.). Since its simple
         #       enough it can stay here for now.
-        ctx.start_process(['ifconfig', 'wln0', '192.168.1.1', 'netmask', '255.255.255.0'],
+        ctx.start_process(['ifconfig', hapd.ifname, '192.168.1.1', 'netmask', '255.255.255.0'],
                                 wait=True)
         ctx.start_process(['touch', '/tmp/dhcpd.leases'], wait=True)
         ctx.start_process(['dhcpd', '-cf', '/tmp/dhcpd.conf', '-lf', '/tmp/dhcpd.leases'])
Signature · 1 line
2.26.2
#1 lore raw

Hi James,

Quoted 7 lines · James Prestwood

The interface was hard coded to wln0 which works when running single tests but not when running multiple. Instead use the actual ifname that hostapd is using.

---
  autotests/testNetconfig/connection_test.py | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

Applied, thanks.

Regards,
-Denis