gpio: aspeed: fix ast2600 bank properties
Subsystems (2)
PATCH 1/1 gpio: aspeed: fix ast2600 bank properties
From: Tao Ren <[email protected]>
GPIO_U is mapped to the least significant byte of input/output mask, and the byte in "output" mask should be 0 because GPIO_U is input only. All the other bits need to be 1 because GPIO_V/W/X support both input and output modes.
Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the according bits need to be 1 because GPIO_Y/Z support both input and output modes.
--- drivers/gpio/gpio-aspeed.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/gpio-aspeed.c +2 -2
@@ -1114,8 +1114,8 @@ static const struct aspeed_gpio_config ast2500_config =static const struct aspeed_bank_props ast2600_bank_props[] = {/* input output */ - {5 ,0xffffffff ,0x0000ffff },/* U/V/W/X */ - {6 ,0xffff0000 ,0x0fff0000 },/* Y/Z */ + {5 ,0xffffffff ,0xffffff00 },/* U/V/W/X */ + {6 ,0x0000ffff ,0x0000ffff },/* Y/Z */ { }, };
Signature · 1 line
2.17.1
Quoted 7 lines · rentao.bupt at gmail.com
From: Tao Ren <[email protected]>
GPIO_Uis mapped to the least significant byte of input/output mask, and the byte in "output" mask should be 0 becauseGPIO_Uis input only. All the other bits need to be 1 because GPIO_V/W/X support both input and output modes.
Quoted 6 lines
Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the according bits need to be 1 because GPIO_Y/Z support both input and output modes.
Fixes ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")Signed-off-by Tao Ren <[email protected]>
Thanks Tao,
Quoted 14 lines · Andrew Jeffery
Quoted 11 lines · rentao.bupt at gmail.com
From: Tao Ren <[email protected]>
GPIO_Uis mapped to the least significant byte of input/output mask, and the byte in "output" mask should be 0 becauseGPIO_Uis input only. All the other bits need to be 1 because GPIO_V/W/X support both input and output modes.Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the according bits need to be 1 because GPIO_Y/Z support both input and output modes.
Quoted 6 lines
Quoted 2 lines
Fixes ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")Signed-off-by Tao Ren <[email protected]>Thanks Tao,
Reviewed-by Andrew Jeffery <[email protected]>
Thanks Andrew for the quick review.
Cheers,
Tao
Bartosz Golaszewski
AppliedQuoted 34 lines · On Wed, Sep 16, 2020 at 10:42 PM <[email protected]> wrote:
From: Tao Ren <[email protected]>
GPIO_Uis mapped to the least significant byte of input/output mask, and the byte in "output" mask should be 0 becauseGPIO_Uis input only. All the other bits need to be 1 because GPIO_V/W/X support both input and output modes.Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the according bits need to be 1 because GPIO_Y/Z support both input and output modes.
Fixes ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")Signed-off-by Tao Ren <[email protected]>--- drivers/gpio/gpio-aspeed.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpio/gpio-aspeed.c +2
-3@@ -1114,8 +1114,8 @@ static const struct aspeed_gpio_config ast2500_config =static const struct aspeed_bank_props ast2600_bank_props[] = {/* input output */ - {5 ,0xffffffff ,0x0000ffff },/* U/V/W/X */ - {6 ,0xffff0000 ,0x0fff0000 },/* Y/Z */ + {5 ,0xffffffff ,0xffffff00 },/* U/V/W/X */ + {6 ,0x0000ffff ,0x0000ffff },/* Y/Z */ { }, }; --
Quoted 2 lines
2.17.1
Queued for fixes, thanks!
Bartosz