drm/amdgpu: add helper function for indirect reg access (v3)
Subsystems (2)
PATCH 1/3 drm/amdgpu: add helper function for indirect reg access (v3)
Add helper function in order to remove RREG32/WREG32 in current pcie_rreg/wreg function for soc15 and onwards adapters.
PCIE_INDEX/DATA pairs are used to access regsiters outside of mmio bar in the helper functions. The new helper functions help remove the recursion of amdgpu_mm_rreg/wreg from pcie_rreg/wreg and provide the oppotunity to centralize direct and indirect access in a single function.
v2: Fixed typo and refine the comments
v3: Remove unnecessary volatile local variable
--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 13 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 129 +++++++++++++++++++++++++++++ 2 files changed, 142 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu.h +13 -0
@@ -1031,6 +1031,19 @@ uint8_t amdgpu_mm_rreg8(struct amdgpu_device *adev, uint32_t offset);u32 amdgpu_io_rreg (struct amdgpu_device *adev,u32 reg);void amdgpu_io_wreg (struct amdgpu_device *adev,u32 reg,u32 v); +u32 amdgpu_device_indirect_rreg (struct amdgpu_device *adev, +u32 pcie_index,u32 pcie_data, +u32 reg_addr); +u64 amdgpu_device_indirect_rreg64 (struct amdgpu_device *adev, +u32 pcie_index,u32 pcie_data, +u32 reg_addr); +void amdgpu_device_indirect_wreg (struct amdgpu_device *adev, +u32 pcie_index,u32 pcie_data, +u32 reg_addr,u32 reg_data); +void amdgpu_device_indirect_wreg64 (struct amdgpu_device *adev, +u32 pcie_index,u32 pcie_data, +u32 reg_addr,u64 reg_data); +bool amdgpu_device_asic_has_dc_support (enum amd_asic_type asic_type);bool amdgpu_device_has_dc_support (struct amdgpu_device *adev);
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +129 -0
135 lines not on this page · raw message
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 2/3 drm/amdgpu: switch to indirect reg access helper
Switch WREG32/RREG32_PCIE to use indirect reg access helper for soc15 and onwards
--- drivers/gpu/drm/amd/amdgpu/nv.c | 51 ++++++-------------------------------- drivers/gpu/drm/amd/amdgpu/soc15.c | 51 ++++++-------------------------------- 2 files changed, 16 insertions(+), 86 deletions(-)
drivers/gpu/drm/amd/amdgpu/nv.c +8 -43
@@ -69,75 +69,40 @@ static const struct amd_ip_funcs nv_common_ip_funcs;*/ static u32 nv_pcie_rreg (struct amdgpu_device *adev,u32 reg) { -unsigned long flags, address, data; -u32 r; +unsigned long address, data; address = adev->nbio.funcs->get_pcie_index_offset (adev); data = adev->nbio.funcs->get_pcie_data_offset (adev); -spin_lock_irqsave (&adev->pcie_idx_lock, flags); -WREG32 (address, reg); - (void )RREG32 (address); - r =RREG32 (data); -spin_unlock_irqrestore (&adev->pcie_idx_lock, flags); -return r; +return amdgpu_device_indirect_rreg (adev, address, data, reg); }static void nv_pcie_wreg (struct amdgpu_device *adev,u32 reg,u32 v) { -unsigned long flags, address, data; +unsigned long address, data; address = adev->nbio.funcs->get_pcie_index_offset (adev); data = adev->nbio.funcs->get_pcie_data_offset (adev); -spin_lock_irqsave (&adev->pcie_idx_lock, flags); -WREG32 (address, reg); - (void )RREG32 (address); -WREG32 (data, v); - (void )RREG32 (data); -spin_unlock_irqrestore (&adev->pcie_idx_lock, flags); +amdgpu_device_indirect_wreg (adev, address, data, reg, v); }static u64 nv_pcie_rreg64 (struct amdgpu_device *adev,u32 reg) { -unsigned long flags, address, data; -u64 r; +unsigned long address, data; address = adev->nbio.funcs->get_pcie_index_offset (adev); data = adev->nbio.funcs->get_pcie_data_offset (adev); -spin_lock_irqsave (&adev->pcie_idx_lock, flags); -/* read low 32 bit */ -WREG32 (address, reg); - (void )RREG32 (address); - r =RREG32 (data); - -/* read high 32 bit*/ -WREG32 (address, reg +4 ); - (void )RREG32 (address); - r |= ((u64 )RREG32 (data) <<32 ); -spin_unlock_irqrestore (&adev->pcie_idx_lock, flags); -return r; +return amdgpu_device_indirect_rreg64 (adev, address, data, reg); }static void nv_pcie_wreg64 (struct amdgpu_device *adev,u32 reg,u64 v) { -unsigned long flags, address, data; +unsigned long address, data; address = adev->nbio.funcs->get_pcie_index_offset (adev); data = adev->nbio.funcs->get_pcie_data_offset (adev); -spin_lock_irqsave (&adev->pcie_idx_lock, flags); -/* write low 32 bit */ -WREG32 (address, reg); - (void )RREG32 (address); -WREG32 (data, (u32)(v &0xffffffffULL )); - (void )RREG32 (data); - -/* write high 32 bit */ -WREG32 (address, reg +4 ); - (void )RREG32 (address); -WREG32 (data, (u32)(v >>32 )); - (void )RREG32 (data); -spin_unlock_irqrestore (&adev->pcie_idx_lock, flags); +amdgpu_device_indirect_wreg64 (adev, address, data, reg, v); }static u32 nv_didt_rreg (struct amdgpu_device *adev,u32 reg)
drivers/gpu/drm/amd/amdgpu/soc15.c +8 -43
83 lines not on this page · raw message
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 3/3 drm/amdgpu: support indirect access reg outside of mmio bar (v2)
In reply to Hawking Zhangsupport both direct and indirect accessor in unified helper functions.
v2: Retire indirect mmio access via mm_index/data
--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 23 +++---- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 95 ++++++++++++----------------- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 4 +- 4 files changed, 53 insertions(+), 71 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu.h +12 -11
@@ -1019,12 +1019,13 @@ int amdgpu_gpu_wait_for_idle(struct amdgpu_device *adev);void amdgpu_device_vram_access (struct amdgpu_device *adev,loff_t pos,uint32_t *buf,size_t size,bool write); -uint32_t amdgpu_mm_rreg (struct amdgpu_device *adev,uint32_t reg, +uint32_t amdgpu_device_rreg (struct amdgpu_device *adev, +uint32_t reg,uint32_t acc_flags); +void amdgpu_device_wreg (struct amdgpu_device *adev, +uint32_t reg,uint32_t v,uint32_t acc_flags); -void amdgpu_mm_wreg (struct amdgpu_device *adev,uint32_t reg,uint32_t v, -uint32_t acc_flags); -void amdgpu_mm_wreg_mmio_rlc (struct amdgpu_device *adev,uint32_t reg,uint32_t v, -uint32_t acc_flags); +void amdgpu_mm_wreg_mmio_rlc (struct amdgpu_device *adev, +uint32_t reg,uint32_t v);void amdgpu_mm_wreg8 (struct amdgpu_device *adev,uint32_t offset,uint8_t value);uint8_t amdgpu_mm_rreg8 (struct amdgpu_device *adev,uint32_t offset);
@@ -1054,8 +1055,8 @@ int emu_soc_asic_init(struct amdgpu_device *adev);*/ #define AMDGPU_REGS_NO_KIQ (1<<1) -#define RREG32_NO_KIQ (reg) amdgpu_mm_rreg(adev, (reg), AMDGPU_REGS_NO_KIQ) -#define WREG32_NO_KIQ (reg, v) amdgpu_mm_wreg(adev, (reg), (v), AMDGPU_REGS_NO_KIQ) +#define RREG32_NO_KIQ (reg) amdgpu_device_rreg(adev, (reg), AMDGPU_REGS_NO_KIQ) +#define WREG32_NO_KIQ (reg, v) amdgpu_device_wreg(adev, (reg), (v), AMDGPU_REGS_NO_KIQ)#define RREG32_KIQ (reg) amdgpu_kiq_rreg(adev, (reg))#define WREG32_KIQ (reg, v) amdgpu_kiq_wreg(adev, (reg), (v))
@@ -1063,9 +1064,9 @@ int emu_soc_asic_init(struct amdgpu_device *adev);#define RREG8 (reg) amdgpu_mm_rreg8(adev, (reg))#define WREG8 (reg, v) amdgpu_mm_wreg8(adev, (reg), (v)) -#define RREG32 (reg) amdgpu_mm_rreg(adev, (reg), 0) -#define DREG32 (reg) printk(KERN_INFO "REGISTER: " #reg " : 0x%08X\n", amdgpu_mm_rreg(adev, (reg), 0)) -#define WREG32 (reg, v) amdgpu_mm_wreg(adev, (reg), (v), 0) +#define RREG32 (reg) amdgpu_device_rreg(adev, (reg), 0) +#define DREG32 (reg) printk(KERN_INFO "REGISTER: " #reg " : 0x%08X\n", amdgpu_device_rreg(adev, (reg), 0)) +#define WREG32 (reg, v) amdgpu_device_wreg(adev, (reg), (v), 0)#define REG_SET (FIELD , v) (((v) << FIELD##_SHIFT) & FIELD##_MASK)#define REG_GET (FIELD , v) (((v) << FIELD##_SHIFT) & FIELD##_MASK)#define RREG32_PCIE (reg) adev->pcie_rreg(adev, (reg))
@@ -1111,7 +1112,7 @@ int emu_soc_asic_init(struct amdgpu_device *adev);WREG32_SMC (_Reg, tmp); \ } while (0) -#define DREG32_SYS (sqf, adev, reg) seq_printf((sqf), #reg " : 0x%08X\n", amdgpu_mm_rreg((adev), (reg), false)) +#define DREG32_SYS (sqf, adev, reg) seq_printf((sqf), #reg " : 0x%08X\n", amdgpu_device_rreg((adev), (reg), false))#define RREG32_IO (reg) amdgpu_io_rreg(adev, (reg))#define WREG32_IO (reg, v) amdgpu_io_wreg(adev, (reg), (v))
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +1 -1
@@ -267,7 +267,7 @@ static int amdgpu_debugfs_process_reg_op(bool read, struct file *f, }else { r =get_user (value, (uint32_t *)buf);if (!r) -amdgpu_mm_wreg_mmio_rlc (adev, *pos >>2 , value,0 ); +amdgpu_mm_wreg_mmio_rlc (adev, *pos >>2 , value); }if (r) { result = r;
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +38 -57
151 lines not on this page · raw message
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h +2 -2
@@ -35,7 +35,7 @@#define AMDGPU_JOB_GET_TIMELINE_NAME (job) \ job->base.s_fence->finished.ops->get_timeline_name(&job->base.s_fence->finished) -TRACE_EVENT(amdgpu_mm_rreg, +TRACE_EVENT(amdgpu_device_rreg, TP_PROTO(unsigned did, uint32_t reg, uint32_t value), TP_ARGS(did, reg, value), TP_STRUCT__entry(
@@ -54,7 +54,7 @@ TRACE_EVENT(amdgpu_mm_rreg, (unsigned long)__entry->value) ); -TRACE_EVENT(amdgpu_mm_wreg, +TRACE_EVENT(amdgpu_device_wreg, TP_PROTO(unsigned did, uint32_t reg, uint32_t value), TP_ARGS(did, reg, value), TP_STRUCT__entry(
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 3/3] drm/amdgpu: support indirect access reg outside of mmio bar (v2)
Am 18.09.20 um 14:37 schrieb Hawking Zhang:
Quoted 6 lines
support both direct and indirect accessor in unified helper functions.
v2: Retire indirect mmio access via mm_index/data
Signed-off-by Hawking Zhang <[email protected]>
Quoted 250 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 23 +++---- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 95 ++++++++++++----------------- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 4 +- 4 files changed, 53 insertions(+), 71 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu.h +12
-11@@ -1019,12 +1019,13 @@ int amdgpu_gpu_wait_for_idle(struct amdgpu_device *adev);void amdgpu_device_vram_access (struct amdgpu_device *adev,loff_t pos,uint32_t *buf,size_t size,bool write); -uint32_t amdgpu_mm_rreg (struct amdgpu_device *adev,uint32_t reg, +uint32_t amdgpu_device_rreg (struct amdgpu_device *adev, +uint32_t reg,uint32_t acc_flags); +void amdgpu_device_wreg (struct amdgpu_device *adev, +uint32_t reg,uint32_t v,uint32_t acc_flags); -void amdgpu_mm_wreg (struct amdgpu_device *adev,uint32_t reg,uint32_t v, -uint32_t acc_flags); -void amdgpu_mm_wreg_mmio_rlc (struct amdgpu_device *adev,uint32_t reg,uint32_t v, -uint32_t acc_flags); +void amdgpu_mm_wreg_mmio_rlc (struct amdgpu_device *adev, +uint32_t reg,uint32_t v);void amdgpu_mm_wreg8 (struct amdgpu_device *adev,uint32_t offset,uint8_t value);uint8_t amdgpu_mm_rreg8 (struct amdgpu_device *adev,uint32_t offset);@@ -1054,8 +1055,8 @@ int emu_soc_asic_init(struct amdgpu_device *adev);*/ #define AMDGPU_REGS_NO_KIQ (1<<1) -#define RREG32_NO_KIQ (reg) amdgpu_mm_rreg(adev, (reg), AMDGPU_REGS_NO_KIQ) -#define WREG32_NO_KIQ (reg, v) amdgpu_mm_wreg(adev, (reg), (v), AMDGPU_REGS_NO_KIQ) +#define RREG32_NO_KIQ (reg) amdgpu_device_rreg(adev, (reg), AMDGPU_REGS_NO_KIQ) +#define WREG32_NO_KIQ (reg, v) amdgpu_device_wreg(adev, (reg), (v), AMDGPU_REGS_NO_KIQ)#define RREG32_KIQ (reg) amdgpu_kiq_rreg(adev, (reg))#define WREG32_KIQ (reg, v) amdgpu_kiq_wreg(adev, (reg), (v))@@ -1063,9 +1064,9 @@ int emu_soc_asic_init(struct amdgpu_device *adev);#define RREG8 (reg) amdgpu_mm_rreg8(adev, (reg))#define WREG8 (reg, v) amdgpu_mm_wreg8(adev, (reg), (v)) -#define RREG32 (reg) amdgpu_mm_rreg(adev, (reg), 0) -#define DREG32 (reg) printk(KERN_INFO "REGISTER: " #reg " : 0x%08X\n", amdgpu_mm_rreg(adev, (reg), 0)) -#define WREG32 (reg, v) amdgpu_mm_wreg(adev, (reg), (v), 0) +#define RREG32 (reg) amdgpu_device_rreg(adev, (reg), 0) +#define DREG32 (reg) printk(KERN_INFO "REGISTER: " #reg " : 0x%08X\n", amdgpu_device_rreg(adev, (reg), 0)) +#define WREG32 (reg, v) amdgpu_device_wreg(adev, (reg), (v), 0)#define REG_SET (FIELD , v) (((v) << FIELD##_SHIFT) & FIELD##_MASK)#define REG_GET (FIELD , v) (((v) << FIELD##_SHIFT) & FIELD##_MASK)#define RREG32_PCIE (reg) adev->pcie_rreg(adev, (reg))@@ -1111,7 +1112,7 @@ int emu_soc_asic_init(struct amdgpu_device *adev);WREG32_SMC (_Reg, tmp); \ } while (0) -#define DREG32_SYS (sqf, adev, reg) seq_printf((sqf), #reg " : 0x%08X\n", amdgpu_mm_rreg((adev), (reg), false)) +#define DREG32_SYS (sqf, adev, reg) seq_printf((sqf), #reg " : 0x%08X\n", amdgpu_device_rreg((adev), (reg), false))#define RREG32_IO (reg) amdgpu_io_rreg(adev, (reg))#define WREG32_IO (reg, v) amdgpu_io_wreg(adev, (reg), (v))drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +1
-1@@ -267,7 +267,7 @@ static int amdgpu_debugfs_process_reg_op(bool read, struct file *f, }else { r =get_user (value, (uint32_t *)buf);if (!r) -amdgpu_mm_wreg_mmio_rlc (adev, *pos >>2 , value,0 ); +amdgpu_mm_wreg_mmio_rlc (adev, *pos >>2 , value); }if (r) { result = r;drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +38
-57@@ -303,10 +303,10 @@ void amdgpu_device_vram_access(struct amdgpu_device *adev, loff_t pos, }/* -* MMIO register access helper functions. +* register access helper functions. */ /** -* amdgpu_mm_rreg - read a memory mapped IO register +* amdgpu_device_rreg - read a memory mapped IO or indirect register * * @adev: amdgpu_device pointer * @reg: dword aligned register offset @@ -314,33 +314,29 @@ void amdgpu_device_vram_access(struct amdgpu_device *adev, loff_t pos,* * Returns the 32 bit value from the offset specified. */ -uint32_t amdgpu_mm_rreg (struct amdgpu_device *adev,uint32_t reg, -uint32_t acc_flags) +uint32_t amdgpu_device_rreg (struct amdgpu_device *adev, +uint32_t reg,uint32_t acc_flags) {uint32_t ret;if (adev->in_pci_err_recovery)return 0 ; -if (!(acc_flags &AMDGPU_REGS_NO_KIQ ) &&amdgpu_sriov_runtime (adev) && -down_read_trylock (&adev->reset_sem)) { - ret =amdgpu_kiq_rreg (adev, reg); -up_read (&adev->reset_sem); -return ret; +if ((reg *4 ) < adev->rmmio_size) { +if (!(acc_flags &AMDGPU_REGS_NO_KIQ ) && +amdgpu_sriov_runtime (adev) && +down_read_trylock (&adev->reset_sem)) { + ret =amdgpu_kiq_rreg (adev, reg); +up_read (&adev->reset_sem); + }else { + ret =readl (((void __iomem *)adev->rmmio) + (reg *4 )); + } + }else { + ret = adev->pcie_rreg (adev, reg *4 ); } -if ((reg *4 ) < adev->rmmio_size) - ret =readl (((void __iomem *)adev->rmmio) + (reg *4 )); -else { -unsigned long flags; - -spin_lock_irqsave (&adev->mmio_idx_lock, flags); -writel ((reg *4 ), ((void __iomem *)adev->rmmio) + (mmMM_INDEX *4 )); - ret =readl (((void __iomem *)adev->rmmio) + (mmMM_DATA *4 )); -spin_unlock_irqrestore (&adev->mmio_idx_lock, flags); - } +trace_amdgpu_device_rreg (adev->pdev->device, reg, ret); -trace_amdgpu_mm_rreg (adev->pdev->device, reg, ret);return ret; }@@ -394,29 +390,8 @@ void amdgpu_mm_wreg8(struct amdgpu_device *adev, uint32_t offset, uint8_t value)BUG (); } -static inline void amdgpu_mm_wreg_mmio (struct amdgpu_device *adev, -uint32_t reg,uint32_t v, -uint32_t acc_flags) -{ -if (adev->in_pci_err_recovery) -return ; - -trace_amdgpu_mm_wreg (adev->pdev->device, reg, v); - -if ((reg *4 ) < adev->rmmio_size) -writel (v, ((void __iomem *)adev->rmmio) + (reg *4 )); -else { -unsigned long flags; - -spin_lock_irqsave (&adev->mmio_idx_lock, flags); -writel ((reg *4 ), ((void __iomem *)adev->rmmio) + (mmMM_INDEX *4 )); -writel (v, ((void __iomem *)adev->rmmio) + (mmMM_DATA *4 )); -spin_unlock_irqrestore (&adev->mmio_idx_lock, flags); - } -} -/** -* amdgpu_mm_wreg - write to a memory mapped IO register +* amdgpu_device_wreg - write to a memory mapped IO or indirect register * * @adev: amdgpu_device pointer * @reg: dword aligned register offset @@ -425,20 +400,27 @@ static inline void amdgpu_mm_wreg_mmio(struct amdgpu_device *adev,* * Writes the value specified to the offset specified. */ -void amdgpu_mm_wreg (struct amdgpu_device *adev,uint32_t reg,uint32_t v, -uint32_t acc_flags) +void amdgpu_device_wreg (struct amdgpu_device *adev, +uint32_t reg,uint32_t v, +uint32_t acc_flags) {if (adev->in_pci_err_recovery)return ; -if (!(acc_flags &AMDGPU_REGS_NO_KIQ ) &&amdgpu_sriov_runtime (adev) && -down_read_trylock (&adev->reset_sem)) { -amdgpu_kiq_wreg (adev, reg, v); -up_read (&adev->reset_sem); -return ; +if ((reg *4 ) < adev->rmmio_size) { +if (!(acc_flags &AMDGPU_REGS_NO_KIQ ) && +amdgpu_sriov_runtime (adev) && +down_read_trylock (&adev->reset_sem)) { +amdgpu_kiq_wreg (adev, reg, v); +up_read (&adev->reset_sem); + }else { +writel (v, ((void __iomem *)adev->rmmio) + (reg *4 )); + } + }else { + adev->pcie_wreg (adev, reg *4 , v); } -amdgpu_mm_wreg_mmio (adev, reg, v, acc_flags); +trace_amdgpu_device_wreg (adev->pdev->device, reg, v); }/* @@ -446,21 +428,20 @@ void amdgpu_mm_wreg(struct amdgpu_device *adev, uint32_t reg, uint32_t v,* * this function is invoked only the debugfs register access * */ -void amdgpu_mm_wreg_mmio_rlc (struct amdgpu_device *adev,uint32_t reg,uint32_t v, -uint32_t acc_flags) +void amdgpu_mm_wreg_mmio_rlc (struct amdgpu_device *adev, +uint32_t reg,uint32_t v) {if (adev->in_pci_err_recovery)return ;if (amdgpu_sriov_fullaccess (adev) && - adev->gfx.rlc.funcs && - adev->gfx.rlc.funcs->is_rlcg_access_range) { - + adev->gfx.rlc.funcs && + adev->gfx.rlc.funcs->is_rlcg_access_range) {if (adev->gfx.rlc.funcs->is_rlcg_access_range (adev, reg))return adev->gfx.rlc.funcs->rlcg_wreg (adev, reg, v); + }else { +writel (v, ((void __iomem *)adev->rmmio) + (reg *4 )); } - -amdgpu_mm_wreg_mmio (adev, reg, v, acc_flags); }/** drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h +1
-1@@ -35,7 +35,7 @@#define AMDGPU_JOB_GET_TIMELINE_NAME (job) \ job->base.s_fence->finished.ops->get_timeline_name(&job->base.s_fence->finished) -TRACE_EVENT(amdgpu_mm_rreg, +TRACE_EVENT(amdgpu_device_rreg, TP_PROTO(unsigned did, uint32_t reg, uint32_t value), TP_ARGS(did, reg, value), TP_STRUCT__entry(
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h TRACE_EVENT(amdgpu_mm_rreg, · line 60
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h +1
-1@@ -54,7 +54,7 @@ TRACE_EVENT(amdgpu_mm_rreg, (unsigned long)__entry->value) ); -TRACE_EVENT(amdgpu_mm_wreg, +TRACE_EVENT(amdgpu_device_wreg, TP_PROTO(unsigned did, uint32_t reg, uint32_t value), TP_ARGS(did, reg, value), TP_STRUCT__entry(
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx