Skip to contentSkip to conversation

staging: spmi: hisi-spmi-controller: Use devm_ version of ioremap().

PATCH New Dan Carpenter 1 participant 1 message Sep 18, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: spmi: hisi-spmi-controller: Use devm_ version of ioremap().

The ioremap() was never unmapped in the probe error handling or in the remove function. The fix is to use the devm_ioremap() function so it gets cleaned up automatically.

Fixes 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver")
---
 drivers/staging/hikey9xx/hisi-spmi-controller.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/hikey9xx/hisi-spmi-controller.c +2 -1
index 5ffe79f45d9a..f831c43f4783 100644
@@ -281,7 +281,8 @@ static int spmi_controller_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	spmi_controller->base = ioremap(iores->start, resource_size(iores));
+	spmi_controller->base = devm_ioremap(&pdev->dev, iores->start,
+					     resource_size(iores));
 	if (!spmi_controller->base) {
 		dev_err(&pdev->dev, "can not remap base addr!\n");
 		return -EADDRNOTAVAIL;
Signature · 1 line
2.28.0