Skip to contentSkip to conversation

Input: ili210x: Enable suspend/resume functions

PATCH In review Adam Ford 2 participants 3 messages Sep 18, 2020 – Nov 4, 2020

Subsystems (2)
lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 Input: ili210x: Enable suspend/resume functions

Some people may wish to wake their system from sleep, so this patch enables a suspend and resume function which enables and disables IRQ wake functions.

drivers/input/touchscreen/ili210x.c +23 -0
index 199cf3daec10..9b1a61447054 100644
@@ -474,6 +474,28 @@ static int ili210x_i2c_probe(struct i2c_client *client,
 	return 0;
 }
 
+static int __maybe_unused ili210x_i2c_suspend(struct device *dev)
+{
+	struct i2c_client *client = to_i2c_client(dev);
+
+	if (device_may_wakeup(&client->dev))
+		enable_irq_wake(client->irq);
+
+	return 0;
+}
+
+static int __maybe_unused ili210x_i2c_resume(struct device *dev)
+{
+	struct i2c_client *client = to_i2c_client(dev);
+
+	if (device_may_wakeup(&client->dev))
+		disable_irq_wake(client->irq);
+
+	return 0;
+}
+
+static SIMPLE_DEV_PM_OPS(ili210x_i2c_pm, ili210x_i2c_suspend, ili210x_i2c_resume);
+
 static const struct i2c_device_id ili210x_i2c_id[] = {
 	{ "ili210x", (long)&ili210x_chip },
 	{ "ili2117", (long)&ili211x_chip },
@@ -495,6 +517,7 @@ MODULE_DEVICE_TABLE(of, ili210x_dt_ids);
 static struct i2c_driver ili210x_ts_driver = {
 	.driver = {
 		.name = "ili210x_i2c",
+		.pm = &ili210x_i2c_pm,
 		.of_match_table = ili210x_dt_ids,
 	},
 	.id_table = ili210x_i2c_id,
Signature · 1 line
2.25.1
author
#1 lore raw
Quoted 6 lines · Adam Ford

Some people may wish to wake their system from sleep, so this patch enables a suspend and resume function which enables and disables IRQ wake functions.

Gentle ping. Any feedback on this?

Quoted 45 lines
drivers/input/touchscreen/ili210x.c +23 -1
index 199cf3daec10..9b1a61447054 100644
@@ -474,6 +474,28 @@ static int ili210x_i2c_probe(struct i2c_client *client,
        return 0;
 }
 
+static int __maybe_unused ili210x_i2c_suspend(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+
+       if (device_may_wakeup(&client->dev))
+               enable_irq_wake(client->irq);
+
+       return 0;
+}
+
+static int __maybe_unused ili210x_i2c_resume(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+
+       if (device_may_wakeup(&client->dev))
+               disable_irq_wake(client->irq);
+
+       return 0;
+}
+
+static SIMPLE_DEV_PM_OPS(ili210x_i2c_pm, ili210x_i2c_suspend, ili210x_i2c_resume);
+
 static const struct i2c_device_id ili210x_i2c_id[] = {
        { "ili210x", (long)&ili210x_chip },
        { "ili2117", (long)&ili211x_chip },
@@ -495,6 +517,7 @@ MODULE_DEVICE_TABLE(of, ili210x_dt_ids);
 static struct i2c_driver ili210x_ts_driver = {
        .driver = {
                .name = "ili210x_i2c",
+               .pm = &ili210x_i2c_pm,
                .of_match_table = ili210x_dt_ids,
        },
        .id_table = ili210x_i2c_id,
--

2.25.1

maintainer
#2 lore raw

Hi Adam,

Quoted 9 lines · Adam Ford
Quoted 6 lines · Adam Ford

Some people may wish to wake their system from sleep, so this patch enables a suspend and resume function which enables and disables IRQ wake functions.

Gentle ping. Any feedback on this?

Ah, sorry. This should not be needed as for I2C devices that are configured as wakeup sources I2C core takes care of declaring interrupt line as wake IRQ and should configure it accordingly during the system state transitions.

See drivers/i2c/i2c-core-base.c - calls to dev_pm_set_[dedicated_]wake_irq() in i2c_device_probe().

Quoted 38 lines
Quoted 38 lines
drivers/input/touchscreen/ili210x.c +22 -0
index 199cf3daec10..9b1a61447054 100644
@@ -474,6 +474,28 @@ static int ili210x_i2c_probe(struct i2c_client *client,
        return 0;
 }
 
+static int __maybe_unused ili210x_i2c_suspend(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+
+       if (device_may_wakeup(&client->dev))
+               enable_irq_wake(client->irq);
+
+       return 0;
+}
+
+static int __maybe_unused ili210x_i2c_resume(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+
+       if (device_may_wakeup(&client->dev))
+               disable_irq_wake(client->irq);
+
+       return 0;
+}
+
+static SIMPLE_DEV_PM_OPS(ili210x_i2c_pm, ili210x_i2c_suspend, ili210x_i2c_resume);
+
 static const struct i2c_device_id ili210x_i2c_id[] = {
        { "ili210x", (long)&ili210x_chip },
        { "ili2117", (long)&ili211x_chip },
@@ -495,6 +517,7 @@ MODULE_DEVICE_TABLE(of, ili210x_dt_ids);
 static struct i2c_driver ili210x_ts_driver = {
        .driver = {
Quoted 8 lines
Quoted 8 lines
drivers/input/touchscreen/ili210x.c +1 -1
                .name = "ili210x_i2c",
+               .pm = &ili210x_i2c_pm,
                .of_match_table = ili210x_dt_ids,
        },
        .id_table = ili210x_i2c_id,
--

2.25.1

Thanks.

Signature · 1 line
Dmitry