Skip to contentSkip to conversation

IIO: Review request.

DISCUSSION Jonathan Cameron 3 participants 3 messages Sep 18, 2020 IIO

lore
Share & tools
lore

Jonathan Cameron

author maintainer
#0 lore raw

Hi All,

Classic being the maintainer problem, is that there is no one specific to pester when you can't get reviews on your own patches. Hence if anyone has some time I'd appreciate sanity checks on:

[PATCH 2/3] iio: Add __printf() attributes to various allocation functions
https://lore.kernel.org/linux-iio/[email protected]/

[PATCH 3/3] iio:core: Tidy up kernel-doc.
https://lore.kernel.org/linux-iio/[email protected]/

[PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required.
https://lore.kernel.org/linux-iio/[email protected]/

[PATCH] iio:accel:bma180: Fix use of true when should be iio_shared_by enum
https://lore.kernel.org/linux-iio/[email protected]/

For those last 2 I forgot I'd previously sent effectively the same fixes out earlier in the year but didn't get any reviews then either :(

Note I've randomly picked a few people who have done reviews or posted a lot of patches recently for the cc list. I'm more than happy if anyone else wants to join in with the fun :) Reviews are always appreciated for any code submitted to IIO from anyone. If you are unsure about something in a review, it is fine to say so. Hence even relatively new people can offer great value. We all started somewhere!

Thanks,

Jonathan

#1 lore raw
Quoted 10 lines · Jonathan Cameron

Hi All,

Classic being the maintainer problem, is that there is no one specific to pester when you can't get reviews on your own patches. Hence if anyone has some time I'd appreciate sanity checks on:

[PATCH 2/3] iio: Add __printf() attributes to various allocation functions
https://lore.kernel.org/linux-iio/[email protected]/

Examples show that rather
static __printf() for the first occurrence. Otherwise the entire list of these patches LGTM. You may put my Rb tag.

Quoted 22 lines

[PATCH 3/3] iio:core: Tidy up kernel-doc.
https://lore.kernel.org/linux-iio/[email protected]/

[PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required.
https://lore.kernel.org/linux-iio/[email protected]/

[PATCH] iio:accel:bma180: Fix use of true when should be iio_shared_by enum
https://lore.kernel.org/linux-iio/[email protected]/

For those last 2 I forgot I'd previously sent effectively the same fixes out earlier in the year but didn't get any reviews then either :(

Note I've randomly picked a few people who have done reviews or posted a lot of patches recently for the cc list. I'm more than happy if anyone else wants to join in with the fun :) Reviews are always appreciated for any code submitted to IIO from anyone. If you are unsure about something in a review, it is fine to say so. Hence even relatively new people can offer great value. We all started somewhere!

Thanks,

Jonathan

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 8 lines · On Fri, 18 Sep 2020 17:05:29 +0300 Andy Shevchenko <[email protected]>…
Quoted 7 lines · Jonathan Cameron

Hi All,

Classic being the maintainer problem, is that there is no one specific to pester when you can't get reviews on your own patches. Hence if anyone has some time I'd appreciate sanity checks on:

Quoted 7 lines
Quoted 3 lines

[PATCH 2/3] iio: Add __printf() attributes to various allocation functions
https://lore.kernel.org/linux-iio/[email protected]/

Examples show that rather
static __printf() for the first occurrence. Otherwise the entire list of these patches LGTM. You may put my Rb tag.

Thanks to everyone who jumped on these.

I'll fix up that and pick them up shortly.

Jonathan

Quoted 26 lines
Quoted 23 lines

[PATCH 3/3] iio:core: Tidy up kernel-doc.
https://lore.kernel.org/linux-iio/[email protected]/

[PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required.
https://lore.kernel.org/linux-iio/[email protected]/

[PATCH] iio:accel:bma180: Fix use of true when should be iio_shared_by enum
https://lore.kernel.org/linux-iio/[email protected]/

For those last 2 I forgot I'd previously sent effectively the same fixes out earlier in the year but didn't get any reviews then either :(

Note I've randomly picked a few people who have done reviews or posted a lot of patches recently for the cc list. I'm more than happy if anyone else wants to join in with the fun :) Reviews are always appreciated for any code submitted to IIO from anyone. If you are unsure about something in a review, it is fine to say so. Hence even relatively new people can offer great value. We all started somewhere!

Thanks,

Jonathan