ASoC: tas2770: Fix calling reset in probe
Subsystems (3)
PATCH 1/2 ASoC: tas2770: Fix calling reset in probe
tas2770_reset is called during i2c probe. The reset calls the snd_soc_component_write which depends on the tas2770->component being available. The component pointer is not set until codec_probe so move the reset to the codec_probe after the pointer is set.
--- sound/soc/codecs/tas2770.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/tas2770.c +2 -2
@@ -575,6 +575,8 @@ static int tas2770_codec_probe(struct snd_soc_component *component) tas2770->component = component; +tas2770_reset (tas2770); +return 0 ; }
@@ -771,8 +773,6 @@ static int tas2770_i2c_probe(struct i2c_client *client, tas2770->channel_size =0 ; tas2770->slot_width =0 ; -tas2770_reset (tas2770); - result =tas2770_register_codec (tas2770);if (result)dev_err (tas2770->dev,"Register codec failed.\n" );
Signature · 1 line
2.28.0
PATCH 2/2 ASoC: tas2770: Add missing bias level power states
Add the BIAS_STANDBY and BIAS_PREPARE to the set_bias_level or else the driver will return -EINVAL which is not correct as they are valid states.
--- sound/soc/codecs/tas2770.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
sound/soc/codecs/tas2770.c +6 -1
@@ -57,7 +57,12 @@ static int tas2770_set_bias_level(struct snd_soc_component *component,TAS2770_PWR_CTRL_MASK , TAS2770_PWR_CTRL_ACTIVE);break ; - +case SND_SOC_BIAS_STANDBY : +case SND_SOC_BIAS_PREPARE : +snd_soc_component_update_bits (component, +TAS2770_PWR_CTRL , +TAS2770_PWR_CTRL_MASK ,TAS2770_PWR_CTRL_MUTE ); +break ;case SND_SOC_BIAS_OFF : snd_soc_component_update_bits(component, TAS2770_PWR_CTRL,
Signature · 1 line
2.28.0
All
Quoted 4 lines · Dan Murphy
tas2770_resetis called during i2c probe. The reset calls thesnd_soc_component_writewhich depends on thetas2770->componentbeing available. The component pointer is not set untilcodec_probeso move the reset to thecodec_probeafter the pointer is set.
I have been updating the tas2770 to add another device to the driver and I have quite a few unexpected patches on top of these.
I am not even sure how this driver is even working at the moment.
I will re-submit the complete set of patches as Mark pointed out in another email chain.
So please ignore these patches for now plus the DT binding patch.
Dan