Skip to contentSkip to conversation

package/micropython: fix build with gcc 4.8

PATCH New Fabrice Fontaine 2 participants 2 messages Sep 19, 2020 – Sep 21, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/micropython: fix build with gcc 4.8

micropython uses -Wfloat-conversion since version 1.13 and
https://github.com/micropython/micropython/commit/30840ebc9925bb8ef025dbc2d5982b1bfeb75f1b

This will result in the following build failure with gcc 4.8:
arm-none-linux-gnueabi-gcc: error: unrecognized command line option '-Wfloat-conversion'

To avoid this build failure, set CWARN to an empty value moreover, while at it, move some duplicated variables under MICROPYTHON_MAKE_OPTS

Fixes:
- http://autobuild.buildroot.org/results/6fe5a5ab91a5d235147e74461bb165ec2cfdc967

---
 package/micropython/micropython.mk | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
package/micropython/micropython.mk +7 -7
index 7c83b18b4e..a126b3eeae 100644
@@ -23,22 +23,22 @@ endif
 
 # When building from a tarball we don't have some of the dependencies that are in
 # the git repository as submodules
-MICROPYTHON_MAKE_OPTS = MICROPY_PY_BTREE=0
-MICROPYTHON_MAKE_OPTS += MICROPY_PY_USSL=0
+MICROPYTHON_MAKE_OPTS += \
+	MICROPY_PY_BTREE=0 \
+	MICROPY_PY_USSL=0 \
+	CROSS_COMPILE=$(TARGET_CROSS) \
+	CFLAGS_EXTRA=$(MICROPYTHON_CFLAGS) \
+	CWARN=
 
 define MICROPYTHON_BUILD_CMDS
 	$(MICROPYTHON_MAKE_ENV) $(MAKE) -C $(@D)/mpy-cross
 	$(MICROPYTHON_MAKE_ENV) $(MAKE) -C $(@D)/ports/unix \
-		$(MICROPYTHON_MAKE_OPTS) \
-		CROSS_COMPILE=$(TARGET_CROSS) \
-		CFLAGS_EXTRA=$(MICROPYTHON_CFLAGS)
+		$(MICROPYTHON_MAKE_OPTS)
 endef
 
 define MICROPYTHON_INSTALL_TARGET_CMDS
 	$(MICROPYTHON_MAKE_ENV) $(MAKE) -C $(@D)/ports/unix \
 		$(MICROPYTHON_MAKE_OPTS) \
-		CROSS_COMPILE=$(TARGET_CROSS) \
-		CFLAGS_EXTRA=$(MICROPYTHON_CFLAGS) \
 		DESTDIR=$(TARGET_DIR) \
 		PREFIX=/usr \
 		install
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 package/micropython: fix build with gcc 4.8

Quoted 8 lines · Fabrice Fontaine,

micropython uses -Wfloat-conversion since version 1.13 and

https://github.com/micropython/micropython/commit/30840ebc9925bb8ef025dbc2d5982b1bfeb75f1b

This will result in the following build failure with gcc 4.8:
arm-none-linux-gnueabi-gcc: error: unrecognized command line option '-Wfloat-conversion'

Quoted 9 lines

To avoid this build failure, set CWARN to an empty value moreover, while at it, move some duplicated variables under MICROPYTHON_MAKE_OPTS

Fixes:
-
http://autobuild.buildroot.org/results/6fe5a5ab91a5d235147e74461bb165ec2cfdc967

Looks good thanks.

---

Quoted 40 lines
 package/micropython/micropython.mk | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
package/micropython/ renamed from package/micropython/micropython.mk +0 -0

micropython.mk
index 7c83b18b4e..a126b3eeae 100644

package/micropython/micropython.mk +0 -0
@@ -23,22 +23,22 @@ endif
 
 # When building from a tarball we don't have some of the dependencies

that are in

 # the git repository as submodules
package/micropython/micropython.mk +7 -8
-MICROPYTHON_MAKE_OPTS = MICROPY_PY_BTREE=0
-MICROPYTHON_MAKE_OPTS += MICROPY_PY_USSL=0
+MICROPYTHON_MAKE_OPTS += \
+       MICROPY_PY_BTREE=0 \
+       MICROPY_PY_USSL=0 \
+       CROSS_COMPILE=$(TARGET_CROSS) \
+       CFLAGS_EXTRA=$(MICROPYTHON_CFLAGS) \
+       CWARN=
 
 define MICROPYTHON_BUILD_CMDS
        $(MICROPYTHON_MAKE_ENV) $(MAKE) -C $(@D)/mpy-cross
        $(MICROPYTHON_MAKE_ENV) $(MAKE) -C $(@D)/ports/unix \
-               $(MICROPYTHON_MAKE_OPTS) \
-               CROSS_COMPILE=$(TARGET_CROSS) \
-               CFLAGS_EXTRA=$(MICROPYTHON_CFLAGS)
+               $(MICROPYTHON_MAKE_OPTS)
 endef
 
 define MICROPYTHON_INSTALL_TARGET_CMDS
        $(MICROPYTHON_MAKE_ENV) $(MAKE) -C $(@D)/ports/unix \
                $(MICROPYTHON_MAKE_OPTS) \
-               CROSS_COMPILE=$(TARGET_CROSS) \
-               CFLAGS_EXTRA=$(MICROPYTHON_CFLAGS) \
                DESTDIR=$(TARGET_DIR) \
                PREFIX=/usr \
                install
--
Quoted 3 lines

2.28.0

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200921/e8a31a49/attachment.html>