iio:magn:hmc5843: Fix passing true where iio_shared_by enum required.
Jonathan Cameron
maintainerPATCH 1/1 iio:magn:hmc5843: Fix passing true where iio_shared_by enum required.
From: Jonathan Cameron <[email protected]>
So it's obvious that the code is wrong in passing true, but I'm assuming that will actually evaluate to 1 and hence IIO_SHARED_BY_TYPE. The documentation however has this attribute as IIO_SHARED_BY_ALL. My current assumption is the documentation is wrong.
If anyone knows otherwise please shout out!
--- drivers/iio/magnetometer/hmc5843_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/magnetometer/hmc5843_core.c +2 -2
@@ -245,7 +245,7 @@ static const struct iio_enum hmc5843_meas_conf_enum = { };static const struct iio_chan_spec_ext_info hmc5843_ext_info[] = { -IIO_ENUM ("meas_conf" , true, &hmc5843_meas_conf_enum), +IIO_ENUM ("meas_conf" ,IIO_SHARED_BY_TYPE , &hmc5843_meas_conf_enum),IIO_ENUM_AVAILABLE ("meas_conf" , &hmc5843_meas_conf_enum),IIO_MOUNT_MATRIX (IIO_SHARED_BY_DIR , hmc5843_get_mount_matrix), { }
@@ -259,7 +259,7 @@ static const struct iio_enum hmc5983_meas_conf_enum = { };static const struct iio_chan_spec_ext_info hmc5983_ext_info[] = { -IIO_ENUM ("meas_conf" , true, &hmc5983_meas_conf_enum), +IIO_ENUM ("meas_conf" ,IIO_SHARED_BY_TYPE , &hmc5983_meas_conf_enum),IIO_ENUM_AVAILABLE ("meas_conf" , &hmc5983_meas_conf_enum),IIO_MOUNT_MATRIX (IIO_SHARED_BY_DIR , hmc5843_get_mount_matrix), { }
Signature · 1 line
2.28.0
Quoted 11 lines · Jonathan Cameron
From: Jonathan Cameron <[email protected]>
So it's obvious that the code is wrong in passing true, but I'm assuming that will actually evaluate to 1 and hence
IIO_SHARED_BY_TYPE. The documentation however has this attribute asIIO_SHARED_BY_ALL. My current assumption is the documentation is wrong.
If anyone knows otherwise please shout out!Signed-off-by Jonathan Cameron <[email protected]>Fixes 7247645f6865 ("iio: hmc5843: Move hmc5843 out of staging")Cc H. Nikolaus Schaller <[email protected]>
Obviously correct.
Quoted 26 lines
--- drivers/iio/magnetometer/hmc5843_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/iio/magnetometer/hmc5843_core.c +2
-2@@ -245,7 +245,7 @@ static const struct iio_enum hmc5843_meas_conf_enum = { };static const struct iio_chan_spec_ext_info hmc5843_ext_info[] = { -IIO_ENUM ("meas_conf" , true, &hmc5843_meas_conf_enum), +IIO_ENUM ("meas_conf" ,IIO_SHARED_BY_TYPE , &hmc5843_meas_conf_enum),IIO_ENUM_AVAILABLE ("meas_conf" , &hmc5843_meas_conf_enum),IIO_MOUNT_MATRIX (IIO_SHARED_BY_DIR , hmc5843_get_mount_matrix), { }@@ -259,7 +259,7 @@ static const struct iio_enum hmc5983_meas_conf_enum = { };static const struct iio_chan_spec_ext_info hmc5983_ext_info[] = { -IIO_ENUM ("meas_conf" , true, &hmc5983_meas_conf_enum), +IIO_ENUM ("meas_conf" ,IIO_SHARED_BY_TYPE , &hmc5983_meas_conf_enum),IIO_ENUM_AVAILABLE ("meas_conf" , &hmc5983_meas_conf_enum),IIO_MOUNT_MATRIX (IIO_SHARED_BY_DIR , hmc5843_get_mount_matrix), { }
Quoted 9 lines · Jonathan Cameron
From: Jonathan Cameron <[email protected]>
So it's obvious that the code is wrong in passing true, but I'm assuming that will actually evaluate to 1 and hence
IIO_SHARED_BY_TYPE. The documentation however has this attribute asIIO_SHARED_BY_ALL. My current assumption is the documentation is wrong.
If anyone knows otherwise please shout out!
Yeah this is much easier to understand than the odd boolean value.
Quoted 32 lines
Signed-off-by Jonathan Cameron <[email protected]>Fixes 7247645f6865 ("iio: hmc5843: Move hmc5843 out of staging")Cc H. Nikolaus Schaller <[email protected]>--- drivers/iio/magnetometer/hmc5843_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/iio/magnetometer/hmc5843_core.c +2
-3@@ -245,7 +245,7 @@ static const struct iio_enum hmc5843_meas_conf_enum = { };static const struct iio_chan_spec_ext_info hmc5843_ext_info[] = { -IIO_ENUM ("meas_conf" , true, &hmc5843_meas_conf_enum), +IIO_ENUM ("meas_conf" ,IIO_SHARED_BY_TYPE , &hmc5843_meas_conf_enum),IIO_ENUM_AVAILABLE ("meas_conf" , &hmc5843_meas_conf_enum),IIO_MOUNT_MATRIX (IIO_SHARED_BY_DIR , hmc5843_get_mount_matrix), { }@@ -259,7 +259,7 @@ static const struct iio_enum hmc5983_meas_conf_enum = { };static const struct iio_chan_spec_ext_info hmc5983_ext_info[] = { -IIO_ENUM ("meas_conf" , true, &hmc5983_meas_conf_enum), +IIO_ENUM ("meas_conf" ,IIO_SHARED_BY_TYPE , &hmc5983_meas_conf_enum),IIO_ENUM_AVAILABLE ("meas_conf" , &hmc5983_meas_conf_enum),IIO_MOUNT_MATRIX (IIO_SHARED_BY_DIR , hmc5843_get_mount_matrix), { } --2.28.0
Quoted 11 lines · On Fri, 18 Sep 2020 12:15:20 -0700 Matt Ranostay <[email protected]>…
Quoted 9 lines · Jonathan Cameron
From: Jonathan Cameron <[email protected]>
So it's obvious that the code is wrong in passing true, but I'm assuming that will actually evaluate to 1 and hence
IIO_SHARED_BY_TYPE. The documentation however has this attribute asIIO_SHARED_BY_ALL. My current assumption is the documentation is wrong.
If anyone knows otherwise please shout out!
Quoted 4 lines
Yeah this is much easier to understand than the odd boolean value.
Reviewed-by Matt Ranostay <[email protected]>
Thanks all.
Applied to the togreg branch of iio.git. I've not marked it for stable as it has no functional affect.
Jonathan
Quoted 32 lines
Quoted 32 lines
Signed-off-by Jonathan Cameron <[email protected]>Fixes 7247645f6865 ("iio: hmc5843: Move hmc5843 out of staging")Cc H. Nikolaus Schaller <[email protected]>--- drivers/iio/magnetometer/hmc5843_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/iio/magnetometer/hmc5843_core.c +2
-3@@ -245,7 +245,7 @@ static const struct iio_enum hmc5843_meas_conf_enum = { };static const struct iio_chan_spec_ext_info hmc5843_ext_info[] = { -IIO_ENUM ("meas_conf" , true, &hmc5843_meas_conf_enum), +IIO_ENUM ("meas_conf" ,IIO_SHARED_BY_TYPE , &hmc5843_meas_conf_enum),IIO_ENUM_AVAILABLE ("meas_conf" , &hmc5843_meas_conf_enum),IIO_MOUNT_MATRIX (IIO_SHARED_BY_DIR , hmc5843_get_mount_matrix), { }@@ -259,7 +259,7 @@ static const struct iio_enum hmc5983_meas_conf_enum = { };static const struct iio_chan_spec_ext_info hmc5983_ext_info[] = { -IIO_ENUM ("meas_conf" , true, &hmc5983_meas_conf_enum), +IIO_ENUM ("meas_conf" ,IIO_SHARED_BY_TYPE , &hmc5983_meas_conf_enum),IIO_ENUM_AVAILABLE ("meas_conf" , &hmc5983_meas_conf_enum),IIO_MOUNT_MATRIX (IIO_SHARED_BY_DIR , hmc5843_get_mount_matrix), { } --2.28.0
Quoted 11 lines
Am 13.09.2020 um 13:25 schrieb Jonathan Cameron <[email protected]>:
From: Jonathan Cameron <[email protected]>
So it's obvious that the code is wrong in passing true, but I'm assuming that will actually evaluate to 1 and hence
IIO_SHARED_BY_TYPE. The documentation however has this attribute asIIO_SHARED_BY_ALL. My current assumption is the documentation is wrong.
If anyone knows otherwise please shout out!
Quoted 3 lines
Signed-off-by Jonathan Cameron <[email protected]>Fixes 7247645f6865 ("iio: hmc5843: Move hmc5843 out of staging")Cc H. Nikolaus Schaller <[email protected]>
on GTA04 (omap3-gta04.dtsi).
Quoted 29 lines
---
drivers/iio/magnetometer/hmc5843_core.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/iio/magnetometer/hmc5843_core.c +2
-2@@ -245,7 +245,7 @@ static const struct iio_enum hmc5843_meas_conf_enum = { };static const struct iio_chan_spec_ext_info hmc5843_ext_info[] = { -IIO_ENUM ("meas_conf" , true, &hmc5843_meas_conf_enum), +IIO_ENUM ("meas_conf" ,IIO_SHARED_BY_TYPE , &hmc5843_meas_conf_enum),IIO_ENUM_AVAILABLE ("meas_conf" , &hmc5843_meas_conf_enum),IIO_MOUNT_MATRIX (IIO_SHARED_BY_DIR , hmc5843_get_mount_matrix), { }@@ -259,7 +259,7 @@ static const struct iio_enum hmc5983_meas_conf_enum = { };static const struct iio_chan_spec_ext_info hmc5983_ext_info[] = { -IIO_ENUM ("meas_conf" , true, &hmc5983_meas_conf_enum), +IIO_ENUM ("meas_conf" ,IIO_SHARED_BY_TYPE , &hmc5983_meas_conf_enum),IIO_ENUM_AVAILABLE ("meas_conf" , &hmc5983_meas_conf_enum),IIO_MOUNT_MATRIX (IIO_SHARED_BY_DIR , hmc5843_get_mount_matrix), { }Signature · 1 line
2.28.0
Jonathan Cameron
maintainerQuoted 10 lines · On Sun, 20 Sep 2020 19:12:47 +0200 "H. Nikolaus Schaller" <[email protected]>…
Quoted 10 lines
Am 13.09.2020 um 13:25 schrieb Jonathan Cameron <[email protected]>:
From: Jonathan Cameron <[email protected]>
So it's obvious that the code is wrong in passing true, but I'm assuming that will actually evaluate to 1 and hence
IIO_SHARED_BY_TYPE. The documentation however has this attribute asIIO_SHARED_BY_ALL. My current assumption is the documentation is wrong.
If anyone knows otherwise please shout out!
Quoted 7 lines
Quoted 3 lines
Signed-off-by Jonathan Cameron <[email protected]>Fixes 7247645f6865 ("iio: hmc5843: Move hmc5843 out of staging")Cc H. Nikolaus Schaller <[email protected]>Tested-by H. Nikolaus Schaller <[email protected]>on GTA04 (
omap3-gta04.dtsi).
Thanks, that's great. Added the tag and re-pushed as testing for the autobuilders to work their magic.
Thanks,
Jonathan
Quoted 31 lines
Quoted 30 lines
---
drivers/iio/magnetometer/hmc5843_core.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/iio/magnetometer/hmc5843_core.c +2
-2@@ -245,7 +245,7 @@ static const struct iio_enum hmc5843_meas_conf_enum = { };static const struct iio_chan_spec_ext_info hmc5843_ext_info[] = { -IIO_ENUM ("meas_conf" , true, &hmc5843_meas_conf_enum), +IIO_ENUM ("meas_conf" ,IIO_SHARED_BY_TYPE , &hmc5843_meas_conf_enum),IIO_ENUM_AVAILABLE ("meas_conf" , &hmc5843_meas_conf_enum),IIO_MOUNT_MATRIX (IIO_SHARED_BY_DIR , hmc5843_get_mount_matrix), { }@@ -259,7 +259,7 @@ static const struct iio_enum hmc5983_meas_conf_enum = { };static const struct iio_chan_spec_ext_info hmc5983_ext_info[] = { -IIO_ENUM ("meas_conf" , true, &hmc5983_meas_conf_enum), +IIO_ENUM ("meas_conf" ,IIO_SHARED_BY_TYPE , &hmc5983_meas_conf_enum),IIO_ENUM_AVAILABLE ("meas_conf" , &hmc5983_meas_conf_enum),IIO_MOUNT_MATRIX (IIO_SHARED_BY_DIR , hmc5843_get_mount_matrix), { }Signature · 1 line
2.28.0