Skip to contentSkip to conversation

tee: fix some comment typos in header files

PATCH In review Elvira Khabirova 3 participants 3 messages Sep 20, 2020 – Feb 3, 2021 TEE

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tee: fix some comment typos in header files

struct tee_param: revc -> recv.
TEE_IOC_SUPPL_SEND: typo introduced by copy-pasting, replace invalid description with description from the according argument struct.

---
 include/linux/tee_drv.h  | 2 +-
 include/uapi/linux/tee.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/tee_drv.h +1 -1
index d074302989dd..61557bc0e29f 100644
@@ -85,7 +85,7 @@ struct tee_param {
  * @close_session:	close a session
  * @invoke_func:	invoke a trusted function
  * @cancel_req:		request cancel of an ongoing invoke or open
- * @supp_revc:		called for supplicant to get a command
+ * @supp_recv:		called for supplicant to get a command
  * @supp_send:		called for supplicant to send a response
  * @shm_register:	register shared memory buffer in TEE
  * @shm_unregister:	unregister shared memory buffer in TEE
include/uapi/linux/tee.h +1 -1
index b619f37ee03e..7546be5ed4f8 100644
@@ -342,7 +342,7 @@ struct tee_iocl_supp_send_arg {
 };
 
 /**
- * TEE_IOC_SUPPL_SEND - Receive a request for a supplicant function
+ * TEE_IOC_SUPPL_SEND - Send a response to a received request
  *
  * Takes a struct tee_ioctl_buf_data which contains a struct
  * tee_iocl_supp_send_arg followed by any array of struct tee_param
Signature · 1 line
2.28.0
#1 lore raw

Hi,

Here is another one you can solve:

$ git grep -nw overlfow
net/sctp/tsnmap.c:78:    * overlfow our map

Thanks
--
Gustavo

Quoted 37 lines · Elvira Khabirova

struct tee_param: revc -> recv.
TEE_IOC_SUPPL_SEND: typo introduced by copy-pasting, replace invalid description with description from the according argument struct.

---
 include/linux/tee_drv.h  | 2 +-
 include/uapi/linux/tee.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/tee_drv.h +1 -1
index d074302989dd..61557bc0e29f 100644
@@ -85,7 +85,7 @@ struct tee_param {
  * @close_session:	close a session
  * @invoke_func:	invoke a trusted function
  * @cancel_req:		request cancel of an ongoing invoke or open
- * @supp_revc:		called for supplicant to get a command
+ * @supp_recv:		called for supplicant to get a command
  * @supp_send:		called for supplicant to send a response
  * @shm_register:	register shared memory buffer in TEE
  * @shm_unregister:	unregister shared memory buffer in TEE
include/uapi/linux/tee.h +1 -1
index b619f37ee03e..7546be5ed4f8 100644
@@ -342,7 +342,7 @@ struct tee_iocl_supp_send_arg {
 };
 
 /**
- * TEE_IOC_SUPPL_SEND - Receive a request for a supplicant function
+ * TEE_IOC_SUPPL_SEND - Send a response to a received request
  *
  * Takes a struct tee_ioctl_buf_data which contains a struct
  * tee_iocl_supp_send_arg followed by any array of struct tee_param
#2 lore raw
In reply to Elvira Khabirova
Quoted 10 lines · Elvira Khabirova

struct tee_param: revc -> recv.
TEE_IOC_SUPPL_SEND: typo introduced by copy-pasting, replace invalid description with description from the according argument struct.

---
 include/linux/tee_drv.h  | 2 +-
 include/uapi/linux/tee.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

I'll pick this up.

Thanks,
Jens

Quoted 30 lines
include/linux/tee_drv.h +1 -1
index d074302989dd..61557bc0e29f 100644
@@ -85,7 +85,7 @@ struct tee_param {
  * @close_session:     close a session
  * @invoke_func:       invoke a trusted function
  * @cancel_req:                request cancel of an ongoing invoke or open
- * @supp_revc:         called for supplicant to get a command
+ * @supp_recv:         called for supplicant to get a command
  * @supp_send:         called for supplicant to send a response
  * @shm_register:      register shared memory buffer in TEE
  * @shm_unregister:    unregister shared memory buffer in TEE
include/uapi/linux/tee.h +1 -2
index b619f37ee03e..7546be5ed4f8 100644
@@ -342,7 +342,7 @@ struct tee_iocl_supp_send_arg {
 };
 
 /**
- * TEE_IOC_SUPPL_SEND - Receive a request for a supplicant function
+ * TEE_IOC_SUPPL_SEND - Send a response to a received request
  *
  * Takes a struct tee_ioctl_buf_data which contains a struct
  * tee_iocl_supp_send_arg followed by any array of struct tee_param
--

2.28.0