media: firewire: fix memory leak

PATCH New Pavel Machek 1 participant 1 message Sep 20, 2020

Subsystems (2)

Media (V4L/DVB) Firewire media drivers (firedtv)

lore

Share & tools

lore

Pavel Machek

author

2020-09-20 09:01 UTC #0 lore raw

PATCH 1/1 media: firewire: fix memory leak

Fix memory leak in node_probe.

Signed-off-by Pavel Machek (CIP) <[email protected]>

drivers/media/firewire/firedtv-fw.c +4 -2

index 3f1ca40b9b98..8a8585261bb8 100644
@@ -272,8 +272,10 @@ static int node_probe(struct fw_unit *unit, const struct ieee1394_device_id *id)
 
 	name_len = fw_csr_string(unit->directory, CSR_MODEL,
 				 name, sizeof(name));
-	if (name_len < 0)
-		return name_len;
+	if (name_len < 0) {
+		err = name_len;
+		goto fail_free;
+	}
 	for (i = ARRAY_SIZE(model_names); --i; )
 		if (strlen(model_names[i]) <= name_len &&
 		    strncmp(name, model_names[i], name_len) == 0)

Signature · 2 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html