gpio: gpio-amd-fch: Fix typo on define of AMD_FCH_GPIO_REG_GPIO55_DEVSLP0
PATCH 1/1 gpio: gpio-amd-fch: Fix typo on define of AMD_FCH_GPIO_REG_GPIO55_DEVSLP0
Schematics show that the GPIO number is 55 (not 59). Trivial typo.
--- drivers/platform/x86/pcengines-apuv2.c | 2 +- include/linux/platform_data/gpio/gpio-amd-fch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/platform/x86/pcengines-apuv2.c +1 -1
@@ -32,7 +32,7 @@#define APU2_GPIO_REG_LED3 AMD_FCH_GPIO_REG_GPIO59_DEVSLP1#define APU2_GPIO_REG_MODESW AMD_FCH_GPIO_REG_GPIO32_GE1#define APU2_GPIO_REG_SIMSWAP AMD_FCH_GPIO_REG_GPIO33_GE2 -#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO59_DEVSLP0 +#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO55_DEVSLP0#define APU2_GPIO_REG_MPCIE3 AMD_FCH_GPIO_REG_GPIO51/* Order in which the GPIO lines are defined in the register list */
include/linux/platform_data/gpio/gpio-amd-fch.h +1 -1
@@ -19,7 +19,7 @@#define AMD_FCH_GPIO_REG_GPIO49 0x40#define AMD_FCH_GPIO_REG_GPIO50 0x41#define AMD_FCH_GPIO_REG_GPIO51 0x42 -#define AMD_FCH_GPIO_REG_GPIO59_DEVSLP0 0x43 +#define AMD_FCH_GPIO_REG_GPIO55_DEVSLP0 0x43#define AMD_FCH_GPIO_REG_GPIO57 0x44#define AMD_FCH_GPIO_REG_GPIO58 0x45#define AMD_FCH_GPIO_REG_GPIO59_DEVSLP1 0x46
Signature · 1 line
2.26.2
Quoted 2 lines · Ed Wildgoose
Schematics show that the GPIO number is 55 (not 59). Trivial typo.
Does it still DEVSLP0? Perhaps you need to drop that part as well.
...
Quoted 21 lines
#define APU2_GPIO_REG_LED3 AMD_FCH_GPIO_REG_GPIO59_DEVSLP1 #define APU2_GPIO_REG_MODESW AMD_FCH_GPIO_REG_GPIO32_GE1 #define APU2_GPIO_REG_SIMSWAP AMD_FCH_GPIO_REG_GPIO33_GE2drivers/platform/x86/pcengines-apuv2.c +1
-1-#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO59_DEVSLP0 +#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO55_DEVSLP0#define APU2_GPIO_REG_MPCIE3 AMD_FCH_GPIO_REG_GPIO51/* Order in which the GPIO lines are defined in the register list */ include/linux/platform_data/gpio/gpio-amd-fch.h +1
-1@@ -19,7 +19,7 @@#define AMD_FCH_GPIO_REG_GPIO49 0x40#define AMD_FCH_GPIO_REG_GPIO50 0x41#define AMD_FCH_GPIO_REG_GPIO51 0x42 -#define AMD_FCH_GPIO_REG_GPIO59_DEVSLP0 0x43 +#define AMD_FCH_GPIO_REG_GPIO55_DEVSLP0 0x43#define AMD_FCH_GPIO_REG_GPIO57 0x44#define AMD_FCH_GPIO_REG_GPIO58 0x45#define AMD_FCH_GPIO_REG_GPIO59_DEVSLP1 0x46
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 5 lines · Andy Shevchenko
Quoted 1 line · Ed Wildgoose
Schematics show that the GPIO number is 55 (not 59). Trivial typo.
Does it still DEVSLP0? Perhaps you need to drop that part as well.
...
In the PCEngines schematic it's labelled as "G55/DEVSLP" (no 0)
(In contrast G59 is labelled "G59/DEVSLP1")
What is the quorum opinion on name?
Thanks
Ed W
Quoted 23 lines
Quoted 22 lines
#define APU2_GPIO_REG_LED3 AMD_FCH_GPIO_REG_GPIO59_DEVSLP1 #define APU2_GPIO_REG_MODESW AMD_FCH_GPIO_REG_GPIO32_GE1 #define APU2_GPIO_REG_SIMSWAP AMD_FCH_GPIO_REG_GPIO33_GE2drivers/platform/x86/pcengines-apuv2.c +1
-1-#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO59_DEVSLP0 +#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO55_DEVSLP0#define APU2_GPIO_REG_MPCIE3 AMD_FCH_GPIO_REG_GPIO51/* Order in which the GPIO lines are defined in the register list */ include/linux/platform_data/gpio/gpio-amd-fch.h +1
-1@@ -19,7 +19,7 @@#define AMD_FCH_GPIO_REG_GPIO49 0x40#define AMD_FCH_GPIO_REG_GPIO50 0x41#define AMD_FCH_GPIO_REG_GPIO51 0x42 -#define AMD_FCH_GPIO_REG_GPIO59_DEVSLP0 0x43 +#define AMD_FCH_GPIO_REG_GPIO55_DEVSLP0 0x43#define AMD_FCH_GPIO_REG_GPIO57 0x44#define AMD_FCH_GPIO_REG_GPIO58 0x45#define AMD_FCH_GPIO_REG_GPIO59_DEVSLP1 0x46
Hi
Could I get a final opinion (or signoff) on this patch please?
The significant typo is the reference to "59", when the GPIO is actually 55
According to the PCEngines schematic the names of two similar GPIOs are G59/DEVSLP1
G55/DEVSLP
The original developer named the second GPIO with a trailing 0, which doesn't seem unreasonable, hence I just corrected the name to:
AMD_FCH_GPIO_REG_GPIO55_DEVSLP0
However another acceptable name could be:
AMD_FCH_GPIO_REG_GPIO55_DEVSLP
If I could ask for some guidance and if necessary I will resubmit this patch? Enrico, do you have an opinion?
However, perhaps it's already acceptable as is?
Kind regards
Ed W
Quoted 44 lines · Ed W
Quoted 5 lines · Andy Shevchenko
Quoted 1 line · Ed Wildgoose
Schematics show that the GPIO number is 55 (not 59). Trivial typo.
Does it still DEVSLP0? Perhaps you need to drop that part as well.
...
In the PCEngines schematic it's labelled as "G55/DEVSLP" (no 0)
(In contrast G59 is labelled "G59/DEVSLP1")
What is the quorum opinion on name?
Thanks
Ed W
Quoted 24 lines
Quoted 23 lines
#define APU2_GPIO_REG_LED3
AMD_FCH_GPIO_REG_GPIO59_DEVSLP1#define APU2_GPIO_REG_MODESWAMD_FCH_GPIO_REG_GPIO32_GE1#define APU2_GPIO_REG_SIMSWAPAMD_FCH_GPIO_REG_GPIO33_GE2drivers/platform/x86/pcengines-apuv2.c +1
-1-#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO59_DEVSLP0 +#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO55_DEVSLP0#define APU2_GPIO_REG_MPCIE3
AMD_FCH_GPIO_REG_GPIO51/* Order in which the GPIO lines are defined in the register list */
include/linux/platform_data/gpio/gpio-amd-fch.h +1
-1@@ -19,7 +19,7 @@ #define AMD_FCH_GPIO_REG_GPIO49 0x40 #define AMD_FCH_GPIO_REG_GPIO50 0x41 #define AMD_FCH_GPIO_REG_GPIO51 0x42 -#define AMD_FCH_GPIO_REG_GPIO59_DEVSLP0 0x43 +#define AMD_FCH_GPIO_REG_GPIO55_DEVSLP0 0x43 #define AMD_FCH_GPIO_REG_GPIO57 0x44 #define AMD_FCH_GPIO_REG_GPIO58 0x45 #define AMD_FCH_GPIO_REG_GPIO59_DEVSLP1 0x46
Quoted 13 lines · Ed W
Hi
Could I get a final opinion (or signoff) on this patch please?
The significant typo is the reference to "59", when the GPIO is actually 55
According to the PCEngines schematic the names of two similar GPIOs are
G59/DEVSLP1 G55/DEVSLPThe original developer named the second GPIO with a trailing 0, which doesn't seem unreasonable, hence I just corrected the name to:
Quoted 8 lines
AMD_FCH_GPIO_REG_GPIO55_DEVSLP0However another acceptable name could be:
AMD_FCH_GPIO_REG_GPIO55_DEVSLPIf I could ask for some guidance and if necessary I will resubmit this patch? Enrico, do you have an opinion?
However, perhaps it's already acceptable as is?
It's being accepted, and will be sent later to Linus.
Quoted 52 lines
Kind regards
Ed W
Quoted 44 lines · Ed W
Quoted 5 lines · Andy Shevchenko
Quoted 1 line · Ed Wildgoose
Schematics show that the GPIO number is 55 (not 59). Trivial typo.
Does it still DEVSLP0? Perhaps you need to drop that part as well.
...
In the PCEngines schematic it's labelled as "G55/DEVSLP" (no 0)
(In contrast G59 is labelled "G59/DEVSLP1")
What is the quorum opinion on name?
Thanks
Ed W
Quoted 24 lines
Quoted 23 lines
#define APU2_GPIO_REG_LED3 AMD_FCH_GPIO_REG_GPIO59_DEVSLP1 #define APU2_GPIO_REG_MODESW AMD_FCH_GPIO_REG_GPIO32_GE1 #define APU2_GPIO_REG_SIMSWAP AMD_FCH_GPIO_REG_GPIO33_GE2drivers/platform/x86/pcengines-apuv2.c +1
-1-#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO59_DEVSLP0 +#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO55_DEVSLP0#define APU2_GPIO_REG_MPCIE3 AMD_FCH_GPIO_REG_GPIO51/* Order in which the GPIO lines are defined in the register list */ include/linux/platform_data/gpio/gpio-amd-fch.h +1
-1@@ -19,7 +19,7 @@#define AMD_FCH_GPIO_REG_GPIO49 0x40#define AMD_FCH_GPIO_REG_GPIO50 0x41#define AMD_FCH_GPIO_REG_GPIO51 0x42 -#define AMD_FCH_GPIO_REG_GPIO59_DEVSLP0 0x43 +#define AMD_FCH_GPIO_REG_GPIO55_DEVSLP0 0x43#define AMD_FCH_GPIO_REG_GPIO57 0x44#define AMD_FCH_GPIO_REG_GPIO58 0x45#define AMD_FCH_GPIO_REG_GPIO59_DEVSLP1 0x46
Signature · 2 lines
With Best Regards, Andy Shevchenko
Enrico Weigelt, metux IT consult
Acked-by Enrico Weigelt--mtx
Quoted 79 lines · Andy Shevchenko
Quoted 13 lines · Ed W
Hi
Could I get a final opinion (or signoff) on this patch please?
The significant typo is the reference to "59", when the GPIO is actually 55
According to the PCEngines schematic the names of two similar GPIOs are
G59/DEVSLP1 G55/DEVSLPThe original developer named the second GPIO with a trailing 0, which doesn't seem unreasonable, hence I just corrected the name to:
Quoted 8 lines
AMD_FCH_GPIO_REG_GPIO55_DEVSLP0However another acceptable name could be:
AMD_FCH_GPIO_REG_GPIO55_DEVSLPIf I could ask for some guidance and if necessary I will resubmit this patch? Enrico, do you have an opinion?
However, perhaps it's already acceptable as is?
It's being accepted, and will be sent later to Linus.
Quoted 52 lines
Kind regards
Ed W
Quoted 44 lines · Ed W
Quoted 5 lines · Andy Shevchenko
Quoted 1 line · Ed Wildgoose
Schematics show that the GPIO number is 55 (not 59). Trivial typo.
Does it still DEVSLP0? Perhaps you need to drop that part as well.
...
In the PCEngines schematic it's labelled as "G55/DEVSLP" (no 0)
(In contrast G59 is labelled "G59/DEVSLP1")
What is the quorum opinion on name?
Thanks
Ed W
Quoted 24 lines
Quoted 23 lines
#define APU2_GPIO_REG_LED3 AMD_FCH_GPIO_REG_GPIO59_DEVSLP1 #define APU2_GPIO_REG_MODESW AMD_FCH_GPIO_REG_GPIO32_GE1 #define APU2_GPIO_REG_SIMSWAP AMD_FCH_GPIO_REG_GPIO33_GE2drivers/platform/x86/pcengines-apuv2.c +1
-1-#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO59_DEVSLP0 +#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO55_DEVSLP0#define APU2_GPIO_REG_MPCIE3 AMD_FCH_GPIO_REG_GPIO51/* Order in which the GPIO lines are defined in the register list */ include/linux/platform_data/gpio/gpio-amd-fch.h +1
-1@@ -19,7 +19,7 @@#define AMD_FCH_GPIO_REG_GPIO49 0x40#define AMD_FCH_GPIO_REG_GPIO50 0x41#define AMD_FCH_GPIO_REG_GPIO51 0x42 -#define AMD_FCH_GPIO_REG_GPIO59_DEVSLP0 0x43 +#define AMD_FCH_GPIO_REG_GPIO55_DEVSLP0 0x43#define AMD_FCH_GPIO_REG_GPIO57 0x44#define AMD_FCH_GPIO_REG_GPIO58 0x45#define AMD_FCH_GPIO_REG_GPIO59_DEVSLP1 0x46
Signature · 8 lines
--- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering [email protected] -- +49-151-27565287