Skip to contentSkip to conversation

migration/multifd: Remove superfluous semicolons

PATCH Applied Philippe Mathieu-Daudé 3 participants 3 messages Sep 21, 2020 – Sep 23, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 migration/multifd: Remove superfluous semicolons

checkpatch.pl report superfluous semicolons since commit ee0f3c09e01, but this one was missed:

scripts/checkpatch.pl d32ca5ad798~..d32ca5ad798
ERROR: superfluous trailing semicolon
#498: FILE: migration/multifd.c:308:
+ ram_counters.transferred += transferred;;
total: 1 errors, 1 warnings, 2073 lines checked

Fixes d32ca5ad798 ("multifd: Split multifd code into its own file")
---
 migration/multifd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
migration/multifd.c +1 -1
index d0441202aae..8aaa2f9ade1 100644
@@ -447,7 +447,7 @@ static int multifd_send_pages(QEMUFile *f)
                 + p->packet_len;
     qemu_file_update_transfer(f, transferred);
     ram_counters.multifd_bytes += transferred;
-    ram_counters.transferred += transferred;;
+    ram_counters.transferred += transferred;
     qemu_mutex_unlock(&p->mutex);
     qemu_sem_post(&p->sem);
 
Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Philippe Mathieu-Daudé <[email protected]> 于2020年9月21日周一 下午12:03写道:

checkpatch.pl report superfluous semicolons since commit ee0f3c09e01, but this one was missed:

Quoted 8 lines

scripts/checkpatch.pl d32ca5ad798~..d32ca5ad798
ERROR: superfluous trailing semicolon
#498: FILE: migration/multifd.c:308:
+ ram_counters.transferred += transferred;;
total: 1 errors, 1 warnings, 2073 lines checked

Fixes d32ca5ad798 ("multifd: Split multifd code into its own file")
Quoted 21 lines
---
 migration/multifd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
migration/multifd.c +1 -2
index d0441202aae..8aaa2f9ade1 100644
@@ -447,7 +447,7 @@ static int multifd_send_pages(QEMUFile *f)
                 + p->packet_len;
     qemu_file_update_transfer(f, transferred);
     ram_counters.multifd_bytes += transferred;
-    ram_counters.transferred += transferred;;
+    ram_counters.transferred += transferred;
     qemu_mutex_unlock(&p->mutex);
     qemu_sem_post(&p->sem);
 
--

2.26.2

#2 lore raw
In reply to Philippe Mathieu-Daudé

Le 21/09/2020 à 06:02, Philippe Mathieu-Daudé a écrit :

Quoted 21 lines

checkpatch.pl report superfluous semicolons since commit ee0f3c09e01, but this one was missed:

scripts/checkpatch.pl d32ca5ad798~..d32ca5ad798
ERROR: superfluous trailing semicolon
#498: FILE: migration/multifd.c:308:
+ ram_counters.transferred += transferred;;
total: 1 errors, 1 warnings, 2073 lines checked

Fixes d32ca5ad798 ("multifd: Split multifd code into its own file")
---
 migration/multifd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
migration/multifd.c +0 -0
index d0441202aae..8aaa2f9ade1 100644

migration/multifd.c static int multifd_send_pages(QEMUFile *f) · line 453

Quoted 8 lines
migration/multifd.c +1 -1
@@ -447,7 +447,7 @@ static int multifd_send_pages(QEMUFile *f)
                 + p->packet_len;
     qemu_file_update_transfer(f, transferred);
     ram_counters.multifd_bytes += transferred;
-    ram_counters.transferred += transferred;;
+    ram_counters.transferred += transferred;
     qemu_mutex_unlock(&p->mutex);
     qemu_sem_post(&p->sem);
 

Applied to my trivial-patches branch.

Thanks,
Laurent