powercap: include header to fix -Wmissing-prototypes
PATCH v2 1/1 powercap: include header to fix -Wmissing-prototypes
Include the linux/idle_inject.h header to fix W=1 build warning:
drivers/powercap/idle_inject.c:152:6: warning: no previous prototype for ‘idle_inject_set_duration’ [-Wmissing-prototypes] drivers/powercap/idle_inject.c:167:6: warning: no previous prototype for ‘idle_inject_get_duration’ [-Wmissing-prototypes] drivers/powercap/idle_inject.c:179:6: warning: no previous prototype for ‘idle_inject_set_latency’ [-Wmissing-prototypes] drivers/powercap/idle_inject.c:195:5: warning: no previous prototype for ‘idle_inject_start’ [-Wmissing-prototypes] drivers/powercap/idle_inject.c:227:6: warning: no previous prototype for ‘idle_inject_stop’ [-Wmissing-prototypes] drivers/powercap/idle_inject.c:299:28: warning: no previous prototype for ‘idle_inject_register’ [-Wmissing-prototypes] drivers/powercap/idle_inject.c:345:6: warning: no previous prototype for ‘idle_inject_unregister’ [-Wmissing-prototypes]
--- drivers/powercap/idle_inject.c | 1 + 1 file changed, 1 insertion(+)
drivers/powercap/idle_inject.c +1 -0
@@ -43,6 +43,7 @@#include <linux/sched.h> #include <linux/slab.h> #include <linux/smpboot.h> +#include <linux/idle_inject.h> #include <uapi/linux/sched/types.h>
Signature · 1 line
2.25.4
Rafael J. Wysocki
maintainerQuoted 11 lines · Herrington
Include the
linux/idle_inject.hheader to fix W=1 build warning:
drivers/powercap/idle_inject.c:152:6: warning: no previous prototype for ‘idle_inject_set_duration’ [-Wmissing-prototypes]drivers/powercap/idle_inject.c:167:6: warning: no previous prototype for ‘idle_inject_get_duration’ [-Wmissing-prototypes]drivers/powercap/idle_inject.c:179:6: warning: no previous prototype for ‘idle_inject_set_latency’ [-Wmissing-prototypes]drivers/powercap/idle_inject.c:195:5: warning: no previous prototype for ‘idle_inject_start’ [-Wmissing-prototypes]drivers/powercap/idle_inject.c:227:6: warning: no previous prototype for ‘idle_inject_stop’ [-Wmissing-prototypes]drivers/powercap/idle_inject.c:299:28: warning: no previous prototype for ‘idle_inject_register’ [-Wmissing-prototypes]drivers/powercap/idle_inject.c:345:6: warning: no previous prototype for ‘idle_inject_unregister’ [-Wmissing-prototypes]
Quoted 3 lines
Signed-off-by Herrington <[email protected]>Signed-off-by Pujin Shi <[email protected]>Signed-off-by Pujin Shi <[email protected]>
First, who is the other person whose S-o-b is present here? For a co-author of the patch, a Co-developed-by tag should be present too. Otherwise, a Reviewed-by tag should be used instead of the S-o-b.
Also, one S-o-b (or R-by) per developer would be sufficient.
Quoted 19 lines
--- drivers/powercap/idle_inject.c | 1 + 1 file changed, 1 insertion(+)drivers/powercap/idle_inject.c +1
-1@@ -43,6 +43,7 @@#include <linux/sched.h> #include <linux/slab.h> #include <linux/smpboot.h> +#include <linux/idle_inject.h> #include <uapi/linux/sched/types.h> --2.25.4