Skip to contentSkip to conversation

drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler

PATCH In review Zbigniew Kempczyński 3 participants 8 messages Sep 21, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler

On !llc platforms when buffer is mapped with WB using GEM_MMAP_OFFSET pagefault handler clears its dirty flag. This has consequences buffer is not flushed on exec before moving to render domain. So make sure we keep dirty flag for buffers mapped to write until it leaves cpu domain.

---
 drivers/gpu/drm/i915/gem/i915_gem_mman.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_mman.c +7 -0
index 3d69e51f3e4d..3f61a5ccbdd5 100644
@@ -239,6 +239,7 @@ static vm_fault_t vm_fault_cpu(struct vm_fault *vmf)
 	struct i915_mmap_offset *mmo = area->vm_private_data;
 	struct drm_i915_gem_object *obj = mmo->obj;
 	resource_size_t iomap;
+	u16 prev_write_domain;
 	int err;
 
 	/* Sanity check that we allow writing into this object */
@@ -246,6 +247,8 @@ static vm_fault_t vm_fault_cpu(struct vm_fault *vmf)
 		     area->vm_flags & VM_WRITE))
 		return VM_FAULT_SIGBUS;
 
+	prev_write_domain = obj->write_domain;
+
 	err = i915_gem_object_pin_pages(obj);
 	if (err)
 		goto out;
@@ -268,6 +271,10 @@ static vm_fault_t vm_fault_cpu(struct vm_fault *vmf)
 
 	i915_gem_object_unpin_pages(obj);
 
+	/* On !llc we need to flush before moving to render domain */
+	if (!obj->cache_coherent && prev_write_domain == I915_GEM_DOMAIN_CPU)
+		obj->cache_dirty = true;
+
 out:
 	return i915_error_to_vmf_fault(err);
 }
Signature · 6 lines
2.26.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler

== Series Details ==

== Series Details ==

Series: drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler
URL : https://patchwork.freedesktop.org/series/81881/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
bd0e70d971fe drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler
-:51: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author ''

total: 0 errors, 1 warnings, 0 checks, 25 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler

In reply to Zbigniew Kempczyński
== Series Details ==

== Series Details ==

Series: drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler
URL : https://patchwork.freedesktop.org/series/81881/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_9025 -> Patchwork_18537
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_18537 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_18537, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_18537:

### IGT changes ###

#### Possible regressions ####

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-icl-u2: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-icl-u2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/fi-icl-u2/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_18537 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_chamelium@hdmi-crc-fast:
- fi-kbl-7500u: [PASS][3] -> [FAIL][4] ([i915#227])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-kbl-7500u/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/fi-kbl-7500u/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-kefka: [PASS][5] -> [DMESG-WARN][6] ([i915#1982]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-bsw-kefka/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/fi-bsw-kefka/igt@[email protected]

* igt@vgem_basic@unload:
- fi-kbl-x1275: [PASS][7] -> [DMESG-WARN][8] ([i915#62] / [i915#92] / [i915#95])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-kbl-x1275/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/fi-kbl-x1275/igt@[email protected]

#### Possible fixes ####

* {igt@core_hotunplug@unbind-rebind}:
- fi-kbl-x1275: [DMESG-WARN][9] ([i915#62] / [i915#92]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-kbl-x1275/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/fi-kbl-x1275/igt@[email protected]

* igt@i915_module_load@reload:
- fi-apl-guc: [DMESG-WARN][11] ([i915#1635] / [i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-apl-guc/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/fi-apl-guc/igt@[email protected]

* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [DMESG-WARN][13] ([i915#62] / [i915#92] / [i915#95]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-kbl-x1275/igt@kms_busy@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/fi-kbl-x1275/igt@kms_busy@[email protected]

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: [DMESG-WARN][15] ([i915#2203]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-kbl-7500u/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/fi-kbl-7500u/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-n3050: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-bsw-n3050/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/fi-bsw-n3050/igt@[email protected]
- fi-icl-u2: [DMESG-WARN][19] ([i915#1982]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-icl-u2/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/fi-icl-u2/igt@[email protected]

* igt@kms_flip@basic-flip-vs-dpms@d-dsi1:
- {fi-tgl-dsi}: [DMESG-WARN][21] ([i915#1982]) -> [PASS][22] +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-tgl-dsi/igt@kms_flip@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/fi-tgl-dsi/igt@kms_flip@[email protected]

* igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2:
- fi-skl-guc: [DMESG-WARN][23] ([i915#2203]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-skl-guc/igt@kms_flip@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/fi-skl-guc/igt@kms_flip@[email protected]

#### Warnings ####

* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][25] ([i915#1982] / [i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][26] ([i915#62] / [i915#92])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-kbl-x1275/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/fi-kbl-x1275/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-kbl-guc: [DMESG-WARN][27] ([i915#2203]) -> [DMESG-FAIL][28] ([i915#2203])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-kbl-guc/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/fi-kbl-guc/igt@[email protected]

* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][29] ([i915#62] / [i915#92]) -> [DMESG-WARN][30] ([i915#62] / [i915#92] / [i915#95]) +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-kbl-x1275/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/fi-kbl-x1275/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-kbl-x1275: [DMESG-WARN][31] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][32] ([i915#62] / [i915#92]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-kbl-x1275/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/fi-kbl-x1275/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#227]: https://gitlab.freedesktop.org/drm/intel/issues/227
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95

Participating hosts (45 -> 39)
------------------------------

Missing (6): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-tgl-y fi-byt-clapper fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_9025 -> Patchwork_18537

CI-20190529: 20190529
CI_DRM_9025: 955d04e2ed0cf4bb4679f594a852cc2eebe8266b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5787: 0ec962017c8131de14e0cb038f7f76b1f17ed637 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18537: bd0e70d971fe176ec7ea809e5cecb0655a0ee086 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

bd0e70d971fe drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18537/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler (rev2)

In reply to Zbigniew Kempczyński
== Series Details ==

== Series Details ==

Series: drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler (rev2)
URL : https://patchwork.freedesktop.org/series/81881/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
3d2651f10f09 drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler
-:51: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author ''

total: 0 errors, 1 warnings, 0 checks, 25 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler (rev2)

In reply to Zbigniew Kempczyński
== Series Details ==

== Series Details ==

Series: drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler (rev2)
URL : https://patchwork.freedesktop.org/series/81881/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9025 -> Patchwork_18538
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/index.html

Known issues
------------

Here are the changes found in Patchwork_18538 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-bsw-kefka/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/fi-bsw-kefka/igt@[email protected]

* igt@vgem_basic@unload:
- fi-kbl-x1275: [PASS][3] -> [DMESG-WARN][4] ([i915#62] / [i915#92])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-kbl-x1275/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/fi-kbl-x1275/igt@[email protected]

#### Possible fixes ####

* {igt@core_hotunplug@unbind-rebind}:
- fi-kbl-x1275: [DMESG-WARN][5] ([i915#62] / [i915#92]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-kbl-x1275/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/fi-kbl-x1275/igt@[email protected]

* igt@i915_module_load@reload:
- fi-apl-guc: [DMESG-WARN][7] ([i915#1635] / [i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-apl-guc/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/fi-apl-guc/igt@[email protected]

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: [DMESG-WARN][9] ([i915#2203]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-kbl-7500u/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/fi-kbl-7500u/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-icl-u2: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-icl-u2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/fi-icl-u2/igt@[email protected]

* igt@kms_flip@basic-flip-vs-dpms@d-dsi1:
- {fi-tgl-dsi}: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-tgl-dsi/igt@kms_flip@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/fi-tgl-dsi/igt@kms_flip@[email protected]

* igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2:
- fi-skl-guc: [DMESG-WARN][15] ([i915#2203]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-skl-guc/igt@kms_flip@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/fi-skl-guc/igt@kms_flip@[email protected]

#### Warnings ####

* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [DMESG-FAIL][17] ([i915#62]) -> [DMESG-FAIL][18] ([i915#62] / [i915#95])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-kbl-x1275/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/fi-kbl-x1275/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-kbl-x1275: [DMESG-WARN][19] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][20] ([i915#62] / [i915#92]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/fi-kbl-x1275/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/fi-kbl-x1275/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379

Participating hosts (45 -> 39)
------------------------------

Missing (6): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-tgl-y fi-byt-clapper fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_9025 -> Patchwork_18538

CI-20190529: 20190529
CI_DRM_9025: 955d04e2ed0cf4bb4679f594a852cc2eebe8266b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5787: 0ec962017c8131de14e0cb038f7f76b1f17ed637 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18538: 3d2651f10f098ace6866668664fb8e5a145eadd1 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

3d2651f10f09 drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler (rev2)

In reply to Zbigniew Kempczyński
== Series Details ==

== Series Details ==

Series: drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler (rev2)
URL : https://patchwork.freedesktop.org/series/81881/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_9025_full -> Patchwork_18538_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_18538_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_18538_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_18538_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_flip@2x-nonexisting-fb-interruptible@ac-vga1-hdmi-a1:
- shard-hsw: NOTRUN -> [INCOMPLETE][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-hsw4/igt@kms_flip@[email protected]

Known issues
------------

Here are the changes found in Patchwork_18538_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_persistence@engines-mixed-process@bcs0:
- shard-skl: [PASS][2] -> [FAIL][3] ([i915#2374])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-skl9/igt@gem_ctx_persistence@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-skl5/igt@gem_ctx_persistence@[email protected]

* igt@gem_ctx_persistence@legacy-engines-mixed@vebox:
- shard-kbl: [PASS][4] -> [DMESG-WARN][5] ([i915#1982])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-kbl3/igt@gem_ctx_persistence@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-kbl4/igt@gem_ctx_persistence@[email protected]

* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-glk: [PASS][6] -> [FAIL][7] ([i915#2389]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-glk2/igt@gem_exec_reloc@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-glk4/igt@gem_exec_reloc@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][8] -> [SKIP][9] ([i915#2190])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-tglb7/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-tglb6/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [PASS][10] -> [FAIL][11] ([i915#96])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-hsw1/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-hsw1/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- shard-skl: [PASS][12] -> [DMESG-WARN][13] ([i915#1982]) +5 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-skl7/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-skl2/igt@[email protected]

* igt@kms_cursor_legacy@pipe-b-torture-bo:
- shard-iclb: [PASS][14] -> [DMESG-WARN][15] ([i915#128])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-iclb4/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-iclb7/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled:
- shard-skl: [PASS][16] -> [FAIL][17] ([i915#177] / [i915#52] / [i915#54])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-skl5/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-skl7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-tglb: [PASS][18] -> [DMESG-WARN][19] ([i915#1982]) +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen.html

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-wc:
- shard-skl: [PASS][20] -> [FAIL][21] ([i915#49]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-skl5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-wc.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-wc.html

* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][22] -> [FAIL][23] ([i915#1188]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-skl2/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-skl6/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-iclb: [PASS][24] -> [INCOMPLETE][25] ([i915#1185] / [i915#250])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-iclb8/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-iclb3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][26] -> [FAIL][27] ([fdo#108145] / [i915#265]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-skl4/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-skl3/igt@[email protected]

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][28] -> [SKIP][29] ([fdo#109441]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-iclb6/igt@kms_psr@psr2_cursor_render.html

#### Possible fixes ####

* igt@gem_eio@suspend:
- shard-iclb: [INCOMPLETE][30] ([i915#2483]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-iclb3/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-iclb1/igt@[email protected]

* igt@gem_mmap_offset@blt-coherency:
- shard-glk: [FAIL][32] ([i915#2328]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-glk5/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-glk1/igt@[email protected]

* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-skl: [TIMEOUT][34] ([i915#1958] / [i915#2424]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-skl8/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-skl3/igt@[email protected]

* igt@i915_selftest@mock@contexts:
- shard-apl: [INCOMPLETE][36] ([i915#1635] / [i915#2278]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-apl2/igt@i915_selftest@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-apl8/igt@i915_selftest@[email protected]

* igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic:
- shard-hsw: [INCOMPLETE][38] ([CI#80]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-hsw8/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-hsw2/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [FAIL][40] ([i915#72]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-glk5/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-glk8/igt@[email protected]

* igt@kms_flip@2x-dpms-vs-vblank-race@ab-vga1-hdmi-a1:
- shard-hsw: [DMESG-WARN][42] ([i915#1982]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-hsw6/igt@kms_flip@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-hsw4/igt@kms_flip@[email protected]

* igt@kms_flip@2x-flip-vs-suspend-interruptible@bc-vga1-hdmi-a1:
- shard-hsw: [INCOMPLETE][44] ([i915#2055]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-hsw8/igt@kms_flip@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-hsw4/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [DMESG-WARN][46] ([i915#180]) -> [PASS][47] +3 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-kbl7/igt@kms_flip@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-kbl6/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:
- shard-skl: [FAIL][48] ([i915#2122]) -> [PASS][49] +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-skl1/igt@kms_flip@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-skl4/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-iclb: [DMESG-WARN][50] ([i915#1982]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-iclb7/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-iclb8/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-fullscreen:
- shard-tglb: [DMESG-WARN][52] ([i915#1982]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-fullscreen.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-fullscreen.html

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][54] ([i915#1188]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-skl10/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-skl10/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [DMESG-WARN][56] ([i915#1982]) -> [PASS][57] +5 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-skl8/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-skl3/igt@[email protected]

* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][58] ([fdo#109441]) -> [PASS][59] +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-iclb7/igt@kms_psr@psr2_sprite_mmap_gtt.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html

* igt@kms_setmode@basic:
- shard-skl: [FAIL][60] ([i915#31]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-skl10/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-skl10/igt@[email protected]
- shard-hsw: [FAIL][62] ([i915#31]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-hsw8/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-hsw1/igt@[email protected]

* igt@kms_vblank@pipe-b-query-busy:
- shard-apl: [DMESG-WARN][64] ([i915#1635] / [i915#1982]) -> [PASS][65] +2 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-apl7/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-apl4/igt@[email protected]

#### Warnings ####

* igt@kms_flip@flip-vs-suspend@a-edp1:
- shard-skl: [INCOMPLETE][66] ([i915#198] / [i915#1982]) -> [DMESG-WARN][67] ([i915#1982])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9025/shard-skl2/igt@kms_flip@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/shard-skl1/igt@kms_flip@[email protected]

[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#177]: https://gitlab.freedesktop.org/drm/intel/issues/177
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2278]: https://gitlab.freedesktop.org/drm/intel/issues/2278
[i915#2328]: https://gitlab.freedesktop.org/drm/intel/issues/2328
[i915#2374]: https://gitlab.freedesktop.org/drm/intel/issues/2374
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2424]: https://gitlab.freedesktop.org/drm/intel/issues/2424
[i915#2483]: https://gitlab.freedesktop.org/drm/intel/issues/2483
[i915#250]: https://gitlab.freedesktop.org/drm/intel/issues/250
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96

Participating hosts (11 -> 11)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_9025 -> Patchwork_18538

CI-20190529: 20190529
CI_DRM_9025: 955d04e2ed0cf4bb4679f594a852cc2eebe8266b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5787: 0ec962017c8131de14e0cb038f7f76b1f17ed637 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18538: 3d2651f10f098ace6866668664fb8e5a145eadd1 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault handler (rev2)

Quoted 29 lines · Patchwork
   Patch Details

   Series:  drm/i915: Ensure bo is dirty when WB-mapped on !llc in pagefault    
            handler (rev2)                                                      
   URL:     https://patchwork.freedesktop.org/series/81881/                     
   State:   failure                                                             
   Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18538/index.html 

       CI Bug Log - changes from CI_DRM_9025_full -> Patchwork_18538_full

Summary

FAILURE

Serious unknown changes coming with Patchwork_18538_full absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_18538_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_18538_full:

Quoted 6 lines

IGT changes

Possible regressions

* igt@kms_flip@2x-nonexisting-fb-interruptible@ac-vga1-hdmi-a1:
* shard-hsw: NOTRUN -> INCOMPLETE +1 similar issue

Unrelated. See below.

Quoted 55 lines

Known issues

Here are the changes found in Patchwork_18538_full that come from known issues:

IGT changes

Issues hit

* igt@gem_ctx_persistence@engines-mixed-process@bcs0:

* shard-skl: PASS -> FAIL (i915#2374)
* igt@gem_ctx_persistence@legacy-engines-mixed@vebox:

* shard-kbl: PASS -> DMESG-WARN (i915#1982)
* igt@gem_exec_reloc@basic-many-active@rcs0:

* shard-glk: PASS -> FAIL (i915#2389) +3 similar issues
* igt@gem_huc_copy@huc-copy:

* shard-tglb: PASS -> SKIP (i915#2190)
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:

* shard-hsw: PASS -> FAIL (i915#96)
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:

* shard-skl: PASS -> DMESG-WARN (i915#1982) +5 similar issues
* igt@kms_cursor_legacy@pipe-b-torture-bo:

* shard-iclb: PASS -> DMESG-WARN (i915#128)
* igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled:

* shard-skl: PASS -> FAIL (i915#177 / i915#52 / i915#54)
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:

* shard-tglb: PASS -> DMESG-WARN (i915#1982) +2 similar issues
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-wc:

* shard-skl: PASS -> FAIL (i915#49) +1 similar issue
* igt@kms_hdr@bpc-switch-suspend:

* shard-skl: PASS -> FAIL (i915#1188) +1 similar issue
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:

* shard-iclb: PASS -> INCOMPLETE (i915#1185 / i915#250)
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:

* shard-skl: PASS -> FAIL (fdo#108145 / i915#265) +1 similar issue
* igt@kms_psr@psr2_cursor_render:

* shard-iclb: PASS -> SKIP (fdo#109441) +1 similar issue

Possible fixes

Quoted 8 lines

* igt@gem_eio@suspend:

* shard-iclb: INCOMPLETE (i915#2483) -> PASS

* igt@gem_mmap_offset@blt-coherency:

* shard-glk: FAIL (i915#2328) -> PASS

Change was related to fix above coherency issue.

--
Zbigniew

Quoted 64 lines

* igt@gem_userptr_blits@sync-unmap-cycles:

* shard-skl: TIMEOUT (i915#1958 / i915#2424) -> PASS
* igt@i915_selftest@mock@contexts:

* shard-apl: INCOMPLETE (i915#1635 / i915#2278) -> PASS
* igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic:

* shard-hsw: INCOMPLETE (CI#80) -> PASS
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:

* shard-glk: FAIL (i915#72) -> PASS
* igt@kms_flip@2x-dpms-vs-vblank-race@ab-vga1-hdmi-a1:

* shard-hsw: DMESG-WARN (i915#1982) -> PASS
* igt@kms_flip@2x-flip-vs-suspend-interruptible@bc-vga1-hdmi-a1:

* shard-hsw: INCOMPLETE (i915#2055) -> PASS
* igt@kms_flip@flip-vs-suspend@c-dp1:

* shard-kbl: DMESG-WARN (i915#180) -> PASS +3 similar issues
* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:

* shard-skl: FAIL (i915#2122) -> PASS +1 similar issue
* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:

* shard-iclb: DMESG-WARN (i915#1982) -> PASS
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-fullscreen:

* shard-tglb: DMESG-WARN (i915#1982) -> PASS
* igt@kms_hdr@bpc-switch-dpms:

* shard-skl: FAIL (i915#1188) -> PASS
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:

* shard-skl: DMESG-WARN (i915#1982) -> PASS +5 similar issues
* igt@kms_psr@psr2_sprite_mmap_gtt:

* shard-iclb: SKIP (fdo#109441) -> PASS +1 similar issue
* igt@kms_setmode@basic:

* shard-skl: FAIL (i915#31) -> PASS

* shard-hsw: FAIL (i915#31) -> PASS

* igt@kms_vblank@pipe-b-query-busy:

* shard-apl: DMESG-WARN (i915#1635 / i915#1982) -> PASS +2 similar issues

Warnings

* igt@kms_flip@flip-vs-suspend@a-edp1:
* shard-skl: INCOMPLETE (i915#198 / i915#1982) -> DMESG-WARN (i915#1982)

Participating hosts (11 -> 11)

No changes in participating hosts

Build changes

* Linux: CI_DRM_9025 -> Patchwork_18538

Quoted 9 lines
   CI-20190529: 20190529
   CI_DRM_9025: 955d04e2ed0cf4bb4679f594a852cc2eebe8266b @
   git://anongit.freedesktop.org/gfx-ci/linux
   IGT_5787: 0ec962017c8131de14e0cb038f7f76b1f17ed637 @
   git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
   Patchwork_18538: 3d2651f10f098ace6866668664fb8e5a145eadd1 @
   git://anongit.freedesktop.org/gfx-ci/linux
   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
   git://anongit.freedesktop.org/piglit

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw
In reply to Zbigniew Kempczyński

Quoting Zbigniew Kempczyński (2020-09-21 04:50:17)

Quoted 5 lines

On !llc platforms when buffer is mapped with WB using GEM_MMAP_OFFSET pagefault handler clears its dirty flag. This has consequences buffer is not flushed on exec before moving to render domain. So make sure we keep dirty flag for buffers mapped to write until it leaves cpu domain.

So the faulthandler is only tangentially associated with cache domains. In that a fresh fault is likely to indicate utilisation of the cpu domain, but it is not definitive; there may either be no fault between domain changes or the fault does not incur any.

So we do not touch the domain during the fault, that is required to be tracked by set-domain around the access. This ensures the fault has no implicit domain changes, waits or locks.

In particular, the path of interest here is relatively new, using the old mmap ioctl, we do not see the fault at all.

The bug you are looking for is in set_domain_ioctl. -Chris
_______________________________________________
Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx