Skip to contentSkip to conversation

add the FPGA Device Feature List (DFL) EMIF support

PATCH New Xu Yilun 3 participants 6 messages Sep 21, 2020 – Sep 22, 2020

Subsystems (4)
lore
Share & tools
lore

Xu Yilun

author maintainer
#0 lore raw

PATCH v3 1/1 add the FPGA Device Feature List (DFL) EMIF support

The driver supports the EMIF controller on Intel Programmable Acceleration Card (PAC). The controller manages the on-board memory of the PCIe card.

Hi Moritz:

I have sent 2 versions of the patch to Krzysztof who maintains the drivers/memory folder. And because this patch depends on the previous fpga patchset "Modularization of DFL private feature drivers" & "add dfl bus support to MODULE_DEVICE_TABLE()", it cannot be applied independently to Krzysztof's branch until next cycle. So he suggests, "please send a v3 of this patch with the fix above and let's apply it via Moritz's tree."

So could you help do that? After it got the acked-by from Krzysztof.

Thanks,
Yilun

Xu Yilun (1):
memory: dfl-emif: add the DFL EMIF private feature driver

 .../ABI/testing/sysfs-bus-dfl-devices-emif         |  25 +++
 drivers/memory/Kconfig                             |   9 +
 drivers/memory/Makefile                            |   2 +
 drivers/memory/dfl-emif.c                          | 207 +++++++++++++++++++++
 4 files changed, 243 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-dfl-devices-emif
 create mode 100644 drivers/memory/dfl-emif.c
Signature · 1 line
2.7.4
author maintainer
#1 lore raw

PATCH v3 1/1 memory: dfl-emif: add the DFL EMIF private feature driver

This driver is for the EMIF private feature implemented under FPGA Device Feature List (DFL) framework. It is used to expose memory interface status information as well as memory clearing control.

The purpose of memory clearing block is to zero out all private memory when FPGA is to be reprogrammed. This gives users a reliable method to prevent potential data leakage.

---
v2: Adjust the position of this driver in Kconfig.
Improves the name of the Kconfig option.
Change the include dfl-bus.h to dfl.h, cause the previous patchset
renames the file.
Some minor fixes and comment improvement.
v3: Adjust the position of the driver in Makefile.

---
 .../ABI/testing/sysfs-bus-dfl-devices-emif         |  25 +++
 drivers/memory/Kconfig                             |   9 +
 drivers/memory/Makefile                            |   2 +
 drivers/memory/dfl-emif.c                          | 207 +++++++++++++++++++++
 4 files changed, 243 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-dfl-devices-emif
 create mode 100644 drivers/memory/dfl-emif.c
Documentation/ABI/testing/sysfs-bus-dfl-devices-emif new file +25 -0
new file mode 100644
index 0000000..56f97dc
@@ -0,0 +1,25 @@
+What:		/sys/bus/dfl/devices/dfl_dev.X/infX_cal_fail
+Date:		Sep 2020
+KernelVersion:	5.10
+Contact:	Xu Yilun <[email protected]>
+Description:	Read-only. It indicates if the calibration failed on this
+		memory interface. "1" for calibration failure, "0" for OK.
+		Format: %u
+
+What:		/sys/bus/dfl/devices/dfl_dev.X/infX_init_done
+Date:		Sep 2020
+KernelVersion:	5.10
+Contact:	Xu Yilun <[email protected]>
+Description:	Read-only. It indicates if the initialization completed on
+		this memory interface. "1" for initialization complete, "0"
+		for not yet.
+		Format: %u
+
+What:		/sys/bus/dfl/devices/dfl_dev.X/infX_clear
+Date:		Sep 2020
+KernelVersion:	5.10
+Contact:	Xu Yilun <[email protected]>
+Description:	Write-only. Writing "1" to this file will zero out all memory
+		data in this memory interface. Writing of other values is
+		invalid.
+		Format: %u
drivers/memory/Kconfig +9 -0
index 00e013b..2495bc4 100644
@@ -137,6 +137,15 @@ config TI_EMIF_SRAM
 	  sequence so this driver provides several relocatable PM functions
 	  for the SoC PM code to use.
 
+config FPGA_DFL_EMIF
+	tristate "FPGA DFL EMIF Driver"
+	depends on FPGA_DFL && HAS_IOMEM
+	help
+	  This driver is for the EMIF private feature implemented under
+	  FPGA Device Feature List (DFL) framework. It is used to expose
+	  memory interface status information as well as memory clearing
+	  control.
+
 config MVEBU_DEVBUS
 	bool "Marvell EBU Device Bus Controller"
 	default y if PLAT_ORION
drivers/memory/Makefile +2 -0
index e71cf7b..bc7663e 100644
@@ -28,6 +28,8 @@ obj-$(CONFIG_STM32_FMC2_EBI)	+= stm32-fmc2-ebi.o
 obj-$(CONFIG_SAMSUNG_MC)	+= samsung/
 obj-$(CONFIG_TEGRA_MC)		+= tegra/
 obj-$(CONFIG_TI_EMIF_SRAM)	+= ti-emif-sram.o
+obj-$(CONFIG_FPGA_DFL_EMIF)	+= dfl-emif.o
+
 ti-emif-sram-objs		:= ti-emif-pm.o ti-emif-sram-pm.o
 
 AFLAGS_ti-emif-sram-pm.o	:=-Wa,-march=armv7-a
drivers/memory/dfl-emif.c new file +207 -0

207 lines not on this page · raw message

Signature · 1 line
2.7.4
maintainer Acked-by on v3 1/1
#2 lore raw

Re: [PATCH v3] memory: dfl-emif: add the DFL EMIF private feature driver

Quoted 17 lines · Xu Yilun

This driver is for the EMIF private feature implemented under FPGA Device Feature List (DFL) framework. It is used to expose memory interface status information as well as memory clearing control.

The purpose of memory clearing block is to zero out all private memory when FPGA is to be reprogrammed. This gives users a reliable method to prevent potential data leakage.

---
v2: Adjust the position of this driver in Kconfig.
Improves the name of the Kconfig option.
Change the include dfl-bus.h to dfl.h, cause the previous patchset
renames the file.
Some minor fixes and comment improvement.
v3: Adjust the position of the driver in Makefile.

Quoted 9 lines
---
 .../ABI/testing/sysfs-bus-dfl-devices-emif         |  25 +++
 drivers/memory/Kconfig                             |   9 +
 drivers/memory/Makefile                            |   2 +
 drivers/memory/dfl-emif.c                          | 207 +++++++++++++++++++++
 4 files changed, 243 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-dfl-devices-emif
 create mode 100644 drivers/memory/dfl-emif.c

Hi Moritz,

Since this depends on dfl patches, I would need a stable tag with them or you can take it directly:

Best regards,
Krzysztof

maintainer
#3 lore raw

Re: [PATCH v3] memory: dfl-emif: add the DFL EMIF private feature driver

Hi Krzysztof,

Quoted 28 lines · Krzysztof Kozlowski
Quoted 17 lines · Xu Yilun

This driver is for the EMIF private feature implemented under FPGA Device Feature List (DFL) framework. It is used to expose memory interface status information as well as memory clearing control.

The purpose of memory clearing block is to zero out all private memory when FPGA is to be reprogrammed. This gives users a reliable method to prevent potential data leakage.

---
v2: Adjust the position of this driver in Kconfig.
Improves the name of the Kconfig option.
Change the include dfl-bus.h to dfl.h, cause the previous patchset
renames the file.
Some minor fixes and comment improvement.
v3: Adjust the position of the driver in Makefile.

Quoted 9 lines
---
 .../ABI/testing/sysfs-bus-dfl-devices-emif         |  25 +++
 drivers/memory/Kconfig                             |   9 +
 drivers/memory/Makefile                            |   2 +
 drivers/memory/dfl-emif.c                          | 207 +++++++++++++++++++++
 4 files changed, 243 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-dfl-devices-emif
 create mode 100644 drivers/memory/dfl-emif.c
Quoted 8 lines

Hi Moritz,

Since this depends on dfl patches, I would need a stable tag with them or you can take it directly:

Best regards,
Krzysztof

The FPGA patches go through Greg's tree. For the time being it's probably easiest if I take the changes through my tree once Greg pulled my tree.

Do you have any feedback to better handle this sort of subsystem spanning changesets for me?

Thanks,
Moritz

#4 lore raw

Re: [PATCH v3] memory: dfl-emif: add the DFL EMIF private feature driver

Quoted 38 lines · Moritz Fischer

Hi Krzysztof,

Quoted 34 lines · Krzysztof Kozlowski
Quoted 17 lines · Xu Yilun

This driver is for the EMIF private feature implemented under FPGA Device Feature List (DFL) framework. It is used to expose memory interface status information as well as memory clearing control.

The purpose of memory clearing block is to zero out all private memory when FPGA is to be reprogrammed. This gives users a reliable method to prevent potential data leakage.

---
v2: Adjust the position of this driver in Kconfig.
Improves the name of the Kconfig option.
Change the include dfl-bus.h to dfl.h, cause the previous patchset
renames the file.
Some minor fixes and comment improvement.
v3: Adjust the position of the driver in Makefile.

Quoted 9 lines
---
 .../ABI/testing/sysfs-bus-dfl-devices-emif         |  25 +++
 drivers/memory/Kconfig                             |   9 +
 drivers/memory/Makefile                            |   2 +
 drivers/memory/dfl-emif.c                          | 207 +++++++++++++++++++++
 4 files changed, 243 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-dfl-devices-emif
 create mode 100644 drivers/memory/dfl-emif.c

Hi Moritz,

Since this depends on dfl patches, I would need a stable tag with them or you can take it directly:

Quoted 6 lines
Quoted 2 lines

Best regards,
Krzysztof

The FPGA patches go through Greg's tree. For the time being it's probably easiest if I take the changes through my tree once Greg pulled my tree.

Yes.

Quoted 3 lines

Do you have any feedback to better handle this sort of subsystem spanning changesets for me?

The easiest through a separate branch. Assuming that such need for sharing patches is known.

If the patches touch generic things, which could be used by other drivers/subsystems, or if it is known that there will be someone depending on them, the easiest is to put them on separate branch which you later merge into your for-next. You send to Greg your for-next. If these patches are needed by someone else, e.g. me, you prepare a tag on them and send a pull request with that tag. I pull it and send these (and only these!) along with other patches. No duplication of commits, only two merges.

Recent example was here:
https://lore.kernel.org/lkml/[email protected]/
where Mark Brown wanted these through his tree, but later work on Samsung ARM depended on them.

Best regards,
Krzysztof

maintainer
#5 lore raw

Re: [PATCH v3] memory: dfl-emif: add the DFL EMIF private feature driver

Hi Krzysztof,

Quoted 64 lines · Krzysztof Kozlowski
Quoted 38 lines · Moritz Fischer

Hi Krzysztof,

Quoted 34 lines · Krzysztof Kozlowski
Quoted 17 lines · Xu Yilun

This driver is for the EMIF private feature implemented under FPGA Device Feature List (DFL) framework. It is used to expose memory interface status information as well as memory clearing control.

The purpose of memory clearing block is to zero out all private memory when FPGA is to be reprogrammed. This gives users a reliable method to prevent potential data leakage.

---
v2: Adjust the position of this driver in Kconfig.
Improves the name of the Kconfig option.
Change the include dfl-bus.h to dfl.h, cause the previous patchset
renames the file.
Some minor fixes and comment improvement.
v3: Adjust the position of the driver in Makefile.

Quoted 9 lines
---
 .../ABI/testing/sysfs-bus-dfl-devices-emif         |  25 +++
 drivers/memory/Kconfig                             |   9 +
 drivers/memory/Makefile                            |   2 +
 drivers/memory/dfl-emif.c                          | 207 +++++++++++++++++++++
 4 files changed, 243 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-dfl-devices-emif
 create mode 100644 drivers/memory/dfl-emif.c

Hi Moritz,

Since this depends on dfl patches, I would need a stable tag with them or you can take it directly:

Quoted 6 lines
Quoted 2 lines

Best regards,
Krzysztof

The FPGA patches go through Greg's tree. For the time being it's probably easiest if I take the changes through my tree once Greg pulled my tree.

Yes.

Quoted 3 lines

Do you have any feedback to better handle this sort of subsystem spanning changesets for me?

The easiest through a separate branch. Assuming that such need for sharing patches is known.

If the patches touch generic things, which could be used by other drivers/subsystems, or if it is known that there will be someone depending on them, the easiest is to put them on separate branch which you later merge into your for-next. You send to Greg your for-next. If these patches are needed by someone else, e.g. me, you prepare a tag on them and send a pull request with that tag. I pull it and send these (and only these!) along with other patches. No duplication of commits, only two merges.

Quoted 7 lines

Recent example was here:
https://lore.kernel.org/lkml/[email protected]/
where Mark Brown wanted these through his tree, but later work on Samsung ARM depended on them.

Best regards,
Krzysztof

Appreciate the explanation, that makes sense. Thanks for taking the time. I'll do this moving forward.

Cheers,
Moritz