Skip to contentSkip to conversation

i2c: ismt: Add support for Intel Emmitsburg PCH

PATCH Applied Andy Shevchenko 3 participants 7 messages Jun 15, 2020 – Sep 21, 2020

Subsystems (2)
I2C subsystem host drivers I2C/smbus ismt driver
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 i2c: ismt: Add support for Intel Emmitsburg PCH

Add PCI ID for the Intel Emmitsburg PCH iSMT SMBus controller.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/i2c/busses/i2c-ismt.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/i2c/busses/i2c-ismt.c +2 -0
index 2f95e25a10f7..cdba77f9ecb1 100644
@@ -77,6 +77,7 @@
 #define PCI_DEVICE_ID_INTEL_S1200_SMT1	0x0c5a
 #define PCI_DEVICE_ID_INTEL_CDF_SMT	0x18ac
 #define PCI_DEVICE_ID_INTEL_DNV_SMT	0x19ac
+#define PCI_DEVICE_ID_INTEL_EBG_SMT	0x1bff
 #define PCI_DEVICE_ID_INTEL_AVOTON_SMT	0x1f15
 
 #define ISMT_DESC_ENTRIES	2	/* number of descriptor entries */

@@ -184,6 +185,7 @@ static const struct pci_device_id ismt_ids[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT1) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CDF_SMT) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMT) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_EBG_SMT) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_AVOTON_SMT) },
 	{ 0, }
 };
Signature · 1 line
2.27.0.rc2
#1 lore raw
Quoted 4 lines · Andy Shevchenko

Add PCI ID for the Intel Emmitsburg PCH iSMT SMBus controller.

Signed-off-by Andy Shevchenko <[email protected]>

---

Seth, Neil?

Quoted 26 lines
 drivers/i2c/busses/i2c-ismt.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/i2c/busses/i2c-ismt.c +2 -0
index 2f95e25a10f7..cdba77f9ecb1 100644
@@ -77,6 +77,7 @@
 #define PCI_DEVICE_ID_INTEL_S1200_SMT1	0x0c5a
 #define PCI_DEVICE_ID_INTEL_CDF_SMT	0x18ac
 #define PCI_DEVICE_ID_INTEL_DNV_SMT	0x19ac
+#define PCI_DEVICE_ID_INTEL_EBG_SMT	0x1bff
 #define PCI_DEVICE_ID_INTEL_AVOTON_SMT	0x1f15
 
 #define ISMT_DESC_ENTRIES	2	/* number of descriptor entries */

@@ -184,6 +185,7 @@ static const struct pci_device_id ismt_ids[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT1) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CDF_SMT) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMT) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_EBG_SMT) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_AVOTON_SMT) },
 	{ 0, }
 };
Signature · 1 line
2.27.0.rc2
author
#2 lore raw
In reply to Andy Shevchenko
Quoted 1 line · Andy Shevchenko

Add PCI ID for the Intel Emmitsburg PCH iSMT SMBus controller.

Seth, Neil, any tag for this?
Wolfram, this is an ID and I don't think silence from maintainers prevent us to add it. What do you think?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw
Quoted 6 lines · Andy Shevchenko
Quoted 1 line · Andy Shevchenko

Add PCI ID for the Intel Emmitsburg PCH iSMT SMBus controller.

Seth, Neil, any tag for this?
Wolfram, this is an ID and I don't think silence from maintainers prevent us to add it. What do you think?

Only as a very last resort. If there are dedicated driver maintainers, the drivers are their authority. If I apply trivial patches on my own, then there may be confusion about what is a trivial patch.

#4 lore raw
In reply to Andy Shevchenko

Hi Andy,

Sorry for the slow response.

Quoted 3 lines

Add PCI ID for the Intel Emmitsburg PCH iSMT SMBus controller.

Signed-off-by Andy Shevchenko <[email protected]>
Signed-off-by Seth Heasley <[email protected]>
Quoted 25 lines
---
 drivers/i2c/busses/i2c-ismt.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/i2c/busses/i2c- renamed from drivers/i2c/busses/i2c-ismt.c +0 -0

ismt.c
index 2f95e25a10f7..cdba77f9ecb1 100644

drivers/i2c/busses/i2c-ismt.c +2 -0
@@ -77,6 +77,7 @@
 #define PCI_DEVICE_ID_INTEL_S1200_SMT1	0x0c5a
 #define PCI_DEVICE_ID_INTEL_CDF_SMT	0x18ac
 #define PCI_DEVICE_ID_INTEL_DNV_SMT	0x19ac
+#define PCI_DEVICE_ID_INTEL_EBG_SMT	0x1bff
 #define PCI_DEVICE_ID_INTEL_AVOTON_SMT	0x1f15
 
 #define ISMT_DESC_ENTRIES	2	/* number of descriptor entries */

@@ -184,6 +185,7 @@ static const struct pci_device_id ismt_ids[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL,
 PCI_DEVICE_ID_INTEL_S1200_SMT1) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CDF_SMT)
 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMT)
 },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_EBG_SMT)
Quoted 5 lines

},
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL,
PCI_DEVICE_ID_INTEL_AVOTON_SMT) },
{ 0, }
};

-Seth

#5 lore raw
Quoted 8 lines · Seth Heasley (Linux)

Hi Andy,

Sorry for the slow response.

Quoted 3 lines

Add PCI ID for the Intel Emmitsburg PCH iSMT SMBus controller.

Signed-off-by Andy Shevchenko <[email protected]>
Signed-off-by Seth Heasley <[email protected]>

Thanks! One favor I am asking: Would you mind using "Reviewed-by" in the future? It is more apropriate and also for easier for my tools to detect when a patch was reviewed.